- 20 Feb, 2018 40 commits
-
-
Mike Dougherty authored
FindElementAtPoint asynchronously returns the DOM element details using postMessage which can be used to communicate with the native app from any document frame. Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I52c6e08f168824f0f458b97965e627d75a93ffa6 Reviewed-on: https://chromium-review.googlesource.com/918404 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537914}
-
Dominick Ng authored
This CL is a minor renaming CL with no functional changes. This prepares for the introduction of a new use for the app layout: app install banners for web and native apps. BUG=811578 Change-Id: Iff4201d160cb93bb2881d24a2f24cadf7fcd94bc Reviewed-on: https://chromium-review.googlesource.com/920125Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#537913}
-
Steven Holte authored
Bug:812729 Change-Id: I113527a6c3c7d6ecc8e71f499b39cd7201e4bb73 Reviewed-on: https://chromium-review.googlesource.com/922687 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#537912}
-
Dirk Pranke authored
We're close enough to turning off MSVC altogether that this doesn't make enough sense any more. R=jbudorick@chromium.org, hans@chromium.org BUG=777642 Change-Id: I64cdde1cbe777abd58fbdb8ee79e71e2b3e4cce7 Reviewed-on: https://chromium-review.googlesource.com/927456Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537911}
-
Fady Samuel authored
With this CL, we no longer kill the renderer when there is a surface invariants violation. Often that state can be recovered from on resize, for example or maybe even on the next frame. Bug: 791154, 672962 Change-Id: I21d0827b54932c636b015c96f3db97a3d2d58dac Reviewed-on: https://chromium-review.googlesource.com/926913Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#537910}
-
Christopher Grant authored
This button now resides in the omnibox. BUG= R=ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icb3882f31e35655156374ac442cce03a13ab73cd Reviewed-on: https://chromium-review.googlesource.com/926767 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#537909}
-
Andrew Grieve authored
Brings the finalize_apk step 19 seconds -> 4 seconds on my machine (for ChromePublic.apk). Also enables v2 signing of apks, which makes them install faster on N+ devices. Bug: 810890 Change-Id: I9fd52ed26c56472bd2894ace6f0516fc386143d6 Reviewed-on: https://chromium-review.googlesource.com/920651Reviewed-by:
-
Allen Bauer authored
Bug: 813253 Change-Id: I11c496289a4e693b78595de76e1398f896643348 Reviewed-on: https://chromium-review.googlesource.com/927449 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#537907}
-
Xianzhu Wang authored
The fields are used for SPv2 only, so disable comparison of them for SPv175. Bug: 813577 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I09f808d7545e49edefdbffcff1bb4385563a47d9 Reviewed-on: https://chromium-review.googlesource.com/926911 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#537906}
-
Alexander Alekseev authored
Chrome OS removes users when profiles are not loaded, and Chrome does not know the exact profile path until it is mounted. So we need to be able to remove entries from ProfileInfoCache based solely on AccountId. This Cl implements removal of cache entries given the AccountId and engages it on Chrome OS. Bug: 808125 Change-Id: I9f8e3a5f1004d119425b92a4bdc3d8011a526dd5 Reviewed-on: https://chromium-review.googlesource.com/905751Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#537905}
-
Scott Chen authored
Bug: 810515 Change-Id: I18891fc67b1ff12017d6a56ac1e0acf8092bdfa5 Reviewed-on: https://chromium-review.googlesource.com/912549 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#537904}
-
Matt Mueller authored
Change-Id: Iaf9671db3799ddc0d305ef317238c1f45ba70809 Reviewed-on: https://chromium-review.googlesource.com/927527Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#537903}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/056e8283..6d2e57db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Idbc16d832d1f63a4f3aab420d4a0437ba2e106f3 Reviewed-on: https://chromium-review.googlesource.com/926766Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537902}
-
Scott Chen authored
This CL gives the sign-in row a more eye-catching banner style, and shrinks to the normal style after 10 impressions. Bug: 800981 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id3b55249d0eea22d6f426faf6ef863c2355f7e92 Reviewed-on: https://chromium-review.googlesource.com/912695 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Ken Rockot authored
Because of some overlap in test coverage, this CL fixes two tangentially related features of the WebRequest API when the Network Service is enabled: - Registered declarative web and net request API rules elicit correct proxy establishment via WebRequestProxyingURLLoader, so both declarative APIs mostly work, modulo some cross-cutting features which affect all WebRequest behavior - onHeadersReceived handlers which modify response headers into a redirect are now handled properly To support the declarative WebRequest changes in particular, all rules registries now have a UI-thread cache. Registries for webviews, which did not have a UI-thread cache before this change, are ephemeral and do not persist in storage. Re-enables a bunch of tests. TBR=benwells@chromium.org Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I60aa27a3a44119f6119377b1f7ccac725b0678c7 Reviewed-on: https://chromium-review.googlesource.com/923432 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537900}
-
https://skia.googlesource.com/skia.git/+log/300cc5b5c1e1..ee78dbe529d9 $ git log 300cc5b5c..ee78dbe52 --date=short --no-merges --format='%ad %ae %s' 2018-02-20 caryclark update path docs online 2018-02-20 caryclark fix Rect doc 2018-02-20 reed hide complex versions of isOval and isRRect 2018-02-20 bsalomon Introduce GrColorType 2018-02-20 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 08d4cf2b3..fa14d14de (3 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ie65c2646afb1dcad8daa0d1674e4ab01de911145 Reviewed-on: https://chromium-review.googlesource.com/927225Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537899}
-
Yaron Friedman authored
Found while tracking references to |onFinishGetGitmap| Seems like Pedro found some dead code earlier but missed this part BUG=651348 Change-Id: Ic93464abc91ae98dbf8eb9a92a641d162838b90e Reviewed-on: https://chromium-review.googlesource.com/921862 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537898}
-
Joe Downing authored
Thi change enables iq stanza logging to make debugging signaling issues in the wild easier. BUG= Change-Id: I14ab58fddcf37b350abe5ab5a1c398e43cb26336 Reviewed-on: https://chromium-review.googlesource.com/927348Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#537897}
-
Albert Chaulk authored
Bug: b/72506886 Test: load browser sample as an overlay Change-Id: I69fd1e69e80f1c624508f77f745327acdb26e19c Reviewed-on: https://chromium-review.googlesource.com/926970Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#537896}
-
Xiangjun Zhang authored
Add a UDP transport that can send/receive UDP packets through Network Service by connecting to a UDPSocket that implements network::mojom::UDPSocket interface. Bug: 734672 Change-Id: Ia2ccf456eea85394e01be919eee645684ba7625a TBR=jam@chromium.org Change-Id: Ia2ccf456eea85394e01be919eee645684ba7625a Reviewed-on: https://chromium-review.googlesource.com/910127 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537895}
-
Ryan Hamilton authored
It's actually unused if you at all the call sites. The two places that priority() is actually called it's explicitly calling down to the base class impl! (And then the unused methods in Handle) Change-Id: I6eb696636ae9346a0110271aeec3e8144d15e606 Reviewed-on: https://chromium-review.googlesource.com/926503Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#537894}
-
Miguel Casas authored
The original CL was reverted due to two gl_unittests_ozone failures: EGLApiTest.DisabledExtensionBitTest EGLApiTest.DisabledExtensionStringTest these two tests also fail on my soraka ToT, so I think they're just flaky. The fix is to check for GetSurfaceFactoryOzone() before using it in HasGLOzone(): http://crrev.com/c/926862/1..3/ui/gl/init/ozone_util.h TBR=reveman@chromium.org, piman@chromium.org, rsesek@chromium.org, dalecurtis@chomium.org since the code they reviewed and LGTM'd hasn't changed. Original CL description ------------------------------------------------ This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer Capabilities to signal support for image_xb30, in parallel to the existing image_xr30. The new flag is used on platforms supporting glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3 or those with the appropriate GL extension. This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to be used where image_xb30 is signalled. With all this, Mac will use image_xr30 <-> BGRX_1010102, and the GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102. Bug: 803975, 776093, 803451, 808172 Change-Id: I8a5a047aabf08f08f6f6fa1d27196e29ddc67120 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/920361Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#537561} Reviewed-on: https://chromium-review.googlesource.com/926862 Cr-Commit-Position: refs/heads/master@{#537893}
-
Varun Khaneja authored
TODOs: - Implement SafeArchiveAnalyzer::AnalyzeRarFile - Implement CheckClientDownloadRequest::OnRarAnalysisFinished - Integrate with third_party/unrar Bug: 750327 Change-Id: I7b4b1e2c35d7c0191928d6dd00846fbf78ef9fa4 Reviewed-on: https://chromium-review.googlesource.com/865936Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#537892}
-
Alexei Svitkine authored
This histogram now always reports 0 with browser-side navigation. BUG=721511 Change-Id: I2315ba15e0f53031609fa933f2e7f0877b1976a2 Reviewed-on: https://chromium-review.googlesource.com/924480Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#537891}
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/6fc8d5201d09..8c27673ed823 $ git log 6fc8d5201..8c27673ed --date=short --no-merges --format='%ad %ae %s' 2018-02-16 mfoltz Remove Mojo error logging in MediaRouteController 2018-02-15 mfoltz Updates the Cast MRP for correct mirroring route descriptions [#2] 2018-02-15 mfoltz [DIAL] Removes in-extension DIAL discovery. 2018-02-02 mfoltz [Dial MRP] Added a config to enable/disable extension side DIAL sink query 2018-02-01 mfoltz [LSC] Replace uses of @code within .js files with Markdown backticks. 2018-02-01 mfoltz [MRP] Use device id as sink id in MRPs 2018-01-31 mfoltz [MR] log last 4 characters of a sink ID 2018-01-30 mfoltz [DIAL MRP] DIAL provider should not return Chromecast Ultra devices for sink queries 2018-01-24 mfoltz Renamed all Weave-specific code to include the word "Weave". 2018-01-11 mfoltz Adds a mirror activity object. 2018-01-02 mfoltz Runs genjsdeps over the Media Router Extension code base. 2017-11-29 mfoltz MediaRemoter: Add handling of media remoting pref value changes. 2017-11-27 mfoltz [Cast Streaming] Add support for media remoting controls from MR dialog. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src Change-Id: I6acdfe820b7e1efd4d0538e96822c470d2f6f7ce TBR=amp Change-Id: I6acdfe820b7e1efd4d0538e96822c470d2f6f7ce Reviewed-on: https://chromium-review.googlesource.com/924613 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#537890}
-
Justin Cohen authored
This reverts commit 6c5d6c38. Reason for revert: Must be rolled back in tandem with https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/573755 Original change's description: > Relands 697d4f8f after fixing upstream change. > > Bug: 808113 > > Original change's description: > >Enables Mailto Handling with Google UI by default. > > > >Bug: 808113 > >Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > >Change-Id: I2b475e6fd474c900ed1984010d15a3e1e31c2af0 > >Reviewed-on: https://chromium-review.googlesource.com/922930 > >Commit-Queue: Daniel Blakemore <danblakemore@google.com> > >Reviewed-by: Peter Lee <pkl@chromium.org> > >Cr-Commit-Position: refs/heads/master@{#537373} > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I3c9821bd95d1ac74fcc4dc4b7c4474ce0b40c5da > Reviewed-on: https://chromium-review.googlesource.com/924635 > Reviewed-by: Peter Lee <pkl@chromium.org> > Commit-Queue: Daniel Blakemore <danblakemore@google.com> > Cr-Commit-Position: refs/heads/master@{#537870} TBR=pkl@chromium.org,danblakemore@google.com Change-Id: I4f5da1bfc9fbaea35999891528d5086fb0bc9605 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808113 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/927501Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537889}
-
John Chen authored
In preparation to update WebView on ChromeDriver Android test bot to current stable version, adjust the test filter for webview shell, so that it is based on the filter for Chrome stable. Change-Id: Ib2143dd6fa46cbda050a53dadfdcbbc7c9eb46f5 Reviewed-on: https://chromium-review.googlesource.com/917161Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537888}
-
Luc Ferron authored
Bug: angleproject:2362 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0cc7aa1b2a0e00009f1184bb1c97e40d809cf032 Reviewed-on: https://chromium-review.googlesource.com/927201Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Luc Ferron <lucferron@chromium.org> Cr-Commit-Position: refs/heads/master@{#537887}
-
John Chen authored
ChromeDownloadDirTest.testDownloadDirectoryOverridesExistingPreferences was flaky due to race condition in deleting temporary directories. Add retries, and ignore the error if temporary directories can't be deleted after retries. This is similar to what we do in ChromeDriver itself (see chromedriver/chrome/scoped_temp_dir_with_retry.cc). Bug: chromedriver:992 Change-Id: I8421b311566dc1e5bef42658ff772dde1a683d30 Reviewed-on: https://chromium-review.googlesource.com/918065Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/029e8ca77884..e703c606f397 $ git log 029e8ca77..e703c606f --date=short --no-merges --format='%ad %ae %s' 2018-02-20 jmadill Add gl::RenderbufferState shared state helper. 2018-02-02 geofflang D3D11: Downsample when copying to emulated 16-bit texture formats. 2018-02-20 jmadill Add empty file to prevent git clean from deleting the tools folder. 2018-02-14 geofflang StateManagerGL: Use dirty bits for VAO bindings. 2018-02-16 cwallez Expand the EGLIOSurfaceClientBufferTests Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ia7745564caccb48cb3543f039c7ff0a49fdd3ac4 Reviewed-on: https://chromium-review.googlesource.com/927204Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537885}
-
Eric Karl authored
This change adds a new GL command (intended for use via the RasterInterface) which copies data from a normal-bit-depth (8888) texture to a low-bit-depth (4444) texture, performing an unpremultiply and a dither in the process. This is a pretty special-case extension designed to address the speicific issues that: - GPU raster output is currently not dithered, leading to banding in some cases - Dithering premultiplied output does not alleviate all banding. - Storing premultiplied ouptut in 4444 textures can lead to artifacts even if dithered. This extension will be used when Chrome rasterizes to 4444 textures on low-end devices. To achieve this behavior, we add a "dither" parameter to the CopyTextureCHROMIUMResourceManager, allowing it to perform a dither while copying. The new extension leverages this existing class. The actual dither code is the same logic used internally in Skia, and has been tested there for performance. The only difference is that in our case we dither alpha as well. Bug: 789153 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibce954f90eb7c461e127c5eb8bcf3ad9799bfe20 Reviewed-on: https://chromium-review.googlesource.com/899664 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
danakj authored
The ResourcePool used to be created for OneCopy mode with a kDefault ResourceTextureHint, rather than kFramebuffer. This was a copy-paste from GpuRasterBufferProvider, which does want to use textures for framebuffer attachment. R=vmpstr@chromium.org Bug: 811432, 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibfba07d0f8834ecdd7160d5e80d8e4d5bb544706 Reviewed-on: https://chromium-review.googlesource.com/926723Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#537883}
-
Kazuhiro Inaba authored
For historical reasons, we modified the ARC framework to let each app to report the cursor position relative to its window. Now, the modification can be removed because we phased out Android-M based ARC. More importantly, the modification *should* be removed, because it is not compatible with third-party Android IMEs, and it caused a minor misplacement in corner cases. Note that we still need to keep the old window-relative mode, since ARC notifications are still thinking themselves to be placed at (0,0), and thus relying on this mode. BUG=b/73097347 TEST=components_unittests ArcImeServiceTest TEST=Manually on PlayStore, Settings, Hangouts (notifications), Dialog in Gallery KK" app, with and without multi-displays. Change-Id: I8cd4581f4ccb5fb331c5686510b225527fea69f5 Reviewed-on: https://chromium-review.googlesource.com/902987Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#537882}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ade6e121416..7707c8a10d46 $ git log 3ade6e121..7707c8a10 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7e6826e847ef51c02c711f54f4d2372b1807a32f Reviewed-on: https://chromium-review.googlesource.com/926912 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537881}
-
Khushal authored
This reverts commit 250fb9b3. Reason for revert: The bug which caused the failure has been fixed. Original change's description: > Disable failing blink_perf.canvas story on 5, 5X, and 5X webview > > TBR=ashleymarie@chromium.org > NOTRY=true > > Bug: 812615 > Change-Id: Ib89c68b30e3b0f33eded7e35572dd71208d60a4d > Reviewed-on: https://chromium-review.googlesource.com/922788 > Reviewed-by: Ashley Enstad <ashleymarie@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537309} TBR=charliea@chromium.org,ashleymarie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 812615 Change-Id: I2cb330d935fdf42d41c00e05637e3dee9e22989f Reviewed-on: https://chromium-review.googlesource.com/927202Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537880}
-
Xiaocheng Hu authored
The SpellCheckHost mojom has some platform-dependent APIs. This patch uses the EnableIf mojo attribute so that we don't need to leave dummy API implementations on unsupported platforms. Bug: 813217 Change-Id: I407ebc6687c404b1583ceeac346a29cb775847ee Reviewed-on: https://chromium-review.googlesource.com/905579 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537879}
-
Changwan Ryu authored
Support library update regressed start up time by 10 ms (crbug.com/782956). Webview uses support library through an indirect dependency chain, such as DropdownAdapter, AutofillKeyboardAccessory, and GMS core library. This can be explained by what we do in ResourceRewriter. ResourceRewriter checks for dependency graphs and call onResourcesLoaded() for all the reachable R's. This is a necessary step to avoid conflicts between library apks and main apk, and webview is doing this on its own. However, resource rewriting takes quite some time, as it creates dependency graphs all the way into support library and GMS core library. Local experiment shows that setting up resources on a separate thread can reduce start up time by 15-50 ms. AwBrowserProcess requires AwResource#getConfigKeySystemUuidMapping() so there is a chance that it can crash if startUpResources() is not finished. When tested, calling startUpResources immediately before AwBrowserProcess seems to work. Bug: b/69005401, 782956 Change-Id: Ie05ffd68063013a251bb5af3618bb78b2576dcbe Reviewed-on: https://chromium-review.googlesource.com/923174Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537878}
-
Malay Keshav authored
The tab recording alert indicator icon no longer has a default color assigned to it in the icon file. Even when touch optimized mode is disabled, the correct color needs to be retrieved from the theme provider. Bug: 813763 Change-Id: I6cf37194aa1498520d973ee4300499ed402b10dc Component: Tab alert icon, recording icon, color Reviewed-on: https://chromium-review.googlesource.com/927110Reviewed-by:
-
Malay Keshav authored
The paint recording scale factor is set to 1 when pixel canvas is disabled. We cannot use the value of PaintContext::device_scale_factor for the recording scale factor in such cases. Bug: 813463 Change-Id: If51bfde2e271ce863cf3971016ee6347cbce592a Component: Tabs, Clipping, Scaling Reviewed-on: https://chromium-review.googlesource.com/927182Reviewed-by:
-
Parastoo Geranmayeh authored
Problem: Sometimes, one section of a form appears in multiple groups over time. This causes field by field situation from second group onward, because we group them all as one section, and would consider the fields which appear later as already filled. This is also an inconsistency, because the browser side fills them, but the renderer side doesn't. Examples: oup.com tradepub.com Solution: Don't fill hidden fields on the browser side. This way, they can get filled in later steps for real. This is also more consistent with a real user's action. As a result of this change, we can no more say if a section is autofilled as a unit. Some fields may be autofilled and some may not. We should consider the fields separately. So, we should take care of: 1.filling/previewing the form. 2.deciding if a credit card number will be filled. Tests added and modified. Note: Previously we would fill the hidden fields (on browser side), because we were not looking at the most updated version of the form, and couldn't trust the given visibility status of a field. This is not the case anymore. This change is based on the new version. Bug: 807780 Change-Id: I297ef33ce5952bab8ff5fce90bf4fc4d6a09731e Reviewed-on: https://chromium-review.googlesource.com/919525 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537875}
-
