GitLab

What FileSystemContext::OpenFileSystem() does is just calling ValidateFileSystemRoot
and CrosMountPointProvider::ValidateFileSystemRoot() does nothing.
Root URI and name of the file system can be acquired with synchronous functions.

BUG=241951
TEST=Can search in Google Drive directory on Files.app

Review URL: https://chromiumcodereview.appspot.com/15814002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202040 0039d316-1c4b-4281-b951-d872f2087c98

The default eliding behavior on views::Label was changed to ELIDE_AT_END in
https://codereview.chromium.org/14654018 which make tooltips display incorrectly
in chromeos.

BUG=none
TEST=manual: trigger a long tooltip (one that cannot fit in one line). For
example, hover over the tab of any page with a long title (try the codereview
link above). Without this change, the tooltip label appears as a single line
elided at the end and has a weird size.

Review URL: https://chromiumcodereview.appspot.com/15772002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202039 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes WeakPtr in the following ways:
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them.
* Removes WeakPtrFactory::DetachFromThread.
* Renames SupportsWeakPtr::DetachFromThread  to DetachFromThreadHack.

Calling code changes to allow this:
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx.

WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use.

BUG=232143, 234964

Review URL: https://chromiumcodereview.appspot.com/14299011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202038 0039d316-1c4b-4281-b951-d872f2087c98

Now LocalFileSystemTestOriginHelper is used only for
Sandbox FileSystems, I'd like to rename this to more
specific, clear name (as the previous name was too vague and
unclear).

BUG=241701,240658
TEST=existing tests
TBR=avi@chromium.org, nhiroki@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/15810004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202037 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202036 0039d316-1c4b-4281-b951-d872f2087c98

While this mode isn't intended to be used in anger, the slow down caused
by reallocating the temp bitmap every frame is very high even for a
development configuration.
Also add a bunch of useful tracing.

BUG=

Review URL: https://chromiumcodereview.appspot.com/15795002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202035 0039d316-1c4b-4281-b951-d872f2087c98

style of tcpdump's -X and -XX options.

R=rch@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15951002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202034 0039d316-1c4b-4281-b951-d872f2087c98

ImportLockDialogView uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead. 
See before/after pics at http://crbug.com/166075#c96
Trigger by making FF default, run chrome.exe --force-first-run

BUG=166075
TEST=Import lock dialog does not have a black border. 
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15772008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202033 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242031

Review URL: https://chromiumcodereview.appspot.com/15789003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202032 0039d316-1c4b-4281-b951-d872f2087c98

Split the individual tests, this was timing out occasionally otherwise on linux_chromeos build bots.

BUG=238662
TEST=WebViewTest.MediaAccessAPIAllow, verified timeout is fixed by running each tests 200 times on trybots, tests now do not flake.

Review URL: https://chromiumcodereview.appspot.com/15741014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15696003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202030 0039d316-1c4b-4281-b951-d872f2087c98

The config dictionary is no longer serialized when passing
it between the web-app and the native messaging host. It is
still serialized for the NPAPI plugin, however, since it's
difficult to return JavaScript objects from a NPAPI plugin.

BUG=232135

Review URL: https://chromiumcodereview.appspot.com/15623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241925
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/15356002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202028 0039d316-1c4b-4281-b951-d872f2087c98

After r200088, NACL_ABI_O_CREAT, NACL_ABI_O_TRUNC, and NACL_ABI_O_EXCL are passed to NaClDescIoDescFromHandleAllocCtor.
But the function does not expect these flags and that causes NaCl to abort.
This CL changes NaClIPCAdapter so that is does not translate the file open flags other than PP_FILEOPENFLAG_READ and PP_FILEOPENFLAG_WRITE.

BUG=241726
TEST=unit_tests --gtest_filter="NaClIPCAdapterTest.*"

Review URL: https://chromiumcodereview.appspot.com/15274002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202027 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson@chromium.org
BUG=228833

Review URL: https://chromiumcodereview.appspot.com/15177003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202026 0039d316-1c4b-4281-b951-d872f2087c98

This persists files to be fetched to the DB so they can be
restored in case Chrome crashes. The origin itself is no
longer saved but it does get added back to
pending_batch_sync_origins anyway when the SyncFS app is
loaded again.

Pre-requisite to deprecating batch_sync_origins from
DriveMetadataStore

BUG=229764
TEST=Existing unit_tests --gtest_filter=DriveFileSyncService*

Review URL: https://chromiumcodereview.appspot.com/15023022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/15983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202023 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nkostylev@chromium.org

BUG=none
TEST=happy heapcheck bots

Review URL: https://codereview.chromium.org/15663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202022 0039d316-1c4b-4281-b951-d872f2087c98

The test for libudev1/libudev0 fails when an sdk has installed
a dependency on libudev1, which will go away on recompile, on
a system with only libudev0.  The dependency created an empty
virtual package that passes the "show" test, but cannot be installed.

BUG=243398
TEST=local

Review URL: https://chromiumcodereview.appspot.com/15911004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202021 0039d316-1c4b-4281-b951-d872f2087c98

chrome.identity is replacing chrome.experimental.identity. The
experimental version will be deleted as soon as some legacy users
switch to chrome.identity.

BUG=124493

Review URL: https://chromiumcodereview.appspot.com/15904006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202020 0039d316-1c4b-4281-b951-d872f2087c98

This change fixes several issues that were causing crashes.
- MediaPlayerHostMsg_DemuxerReady_Params was not initializing the xxx_codec
member variables so audio-only or video-only content would randomly be
flagged as A/V content with a random codec ID.
- ChunkDemuxer::Stop() was not being called which could cause the delegate
to be accessed after it was destroyed.
- MediaSourceDelegate was signalling that it had metadata before the 
ChunkDemuxer was even initialized. This caused the HTMLMediaElement to
signal that the load completed way too early and caused play() to be
called when the delegate wasn't ready.

BUG=233420
TEST=webkitmediasource-play.html LayoutTest reliably runs w/o crashing now.

Review URL: https://chromiumcodereview.appspot.com/15898002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202019 0039d316-1c4b-4281-b951-d872f2087c98

This is regression bug of CSS.
This CL rise the priority of CSS section that hides the search box.

BUG=243281
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/15868002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202018 0039d316-1c4b-4281-b951-d872f2087c98

To pass InstantAutocompleteResult::Type back and forth between the browser and renderer, change the data type to be AutocompleteMatchType::Type instead of an opaque string. 

BUG=239173
TEST=none

Review URL: https://chromiumcodereview.appspot.com/15517007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202017 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15294020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eseidel@chromium.org
BUG=243648

Review URL: https://codereview.chromium.org/15959005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202015 0039d316-1c4b-4281-b951-d872f2087c98

TopSitesTest was renamed to TopSitesImplTest in crrev.com/197127,
hence references to TopSitesTest no longer make sense.

BUG=180467
TEST=none

Review URL: https://chromiumcodereview.appspot.com/15823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202014 0039d316-1c4b-4281-b951-d872f2087c98

This CL drops non-informative StorageType parameter from GlobalUsageCall.
The value should be known by the original caller that makes the callback.

TEST=should not break existing test
TBR=arv@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15695003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202013 0039d316-1c4b-4281-b951-d872f2087c98

R=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/15876004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202012 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes races in case of requested reusing of windows. It might happend, that windows are not yet fully initialized and we tried to reuse them. This bug is fixed by waiting for all windows to be initialized by enqueuing the reusing logic.

TEST=Follow the bug's repro steps.
BUG=238412

Review URL: https://chromiumcodereview.appspot.com/15817002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202011 0039d316-1c4b-4281-b951-d872f2087c98

We were calling asserts withing a subroutines. In that case, asserts breaks the current subroutine but not the test case. This patch wraps calls to subroutines with ASSERT_NO_FATAL_FAILURE, which checks if it failed on any asserts, and if so, then terminates the test case.

TEST=browser_tests
BUG=235334

Review URL: https://chromiumcodereview.appspot.com/15771005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/15745017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202009 0039d316-1c4b-4281-b951-d872f2087c98

When using tile-free renderering, if ActivationStateAsValue() is called
when there is a pending tree it would hit a NULL pointer on tile_manager_.


BUG=

Review URL: https://chromiumcodereview.appspot.com/15743022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202008 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=239337
TEST=unit_tests, manual

Review URL: https://chromiumcodereview.appspot.com/15742018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202007 0039d316-1c4b-4281-b951-d872f2087c98

The "Disconnect your Google Account..." button in the settings page is
supposed to be grayed out when sync setup is in progress, as indicated
by ProfileSyncService::setup_in_progress_. Earlier, we were calling
ProfileSyncService::SetSetupInProgress(false) under all circumstances
from SyncSetupHandler::CloseSyncSetup(), but with r200867, we missed out
on setting the value to false under some conditions. One example of the
flag incorrectly remaining set to true occurs when the user enables
encryption with a custom passphrase and then clears sync data via the
dashboard.

This patch adds a call to ProfileSyncService::SetSetupInProgress(false)
from SyncSetupHandler::CloseSyncSetup() irrespective of why the settings
dialog was closed.

BUG=243078
TEST=Enable custom encryption, do a dashboard clear, and check the settings page

Review URL: https://chromiumcodereview.appspot.com/15742014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202006 0039d316-1c4b-4281-b951-d872f2087c98

The NTP puts the launch of a regular app into a different bucket than the
launch of the special webstore app. This change makes the launcher do something
analogous with the webstore and the chrome app.

Review URL: https://chromiumcodereview.appspot.com/15715003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243035

Review URL: https://chromiumcodereview.appspot.com/15714003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202004 0039d316-1c4b-4281-b951-d872f2087c98

URLFetcherCore is now responsible to write all data stored in |buffer_|.

BUG=126753
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/15711003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202003 0039d316-1c4b-4281-b951-d872f2087c98

At Chrome build-time, the pnacl_component_crx_gen.py script generates a "resource info" JSON file that's placed alongside the translator nexes. We were not actually reading this file so far, but with this CL, we are. The first use is not hard-coding the ld.nexe and llc.nexe tool names in the plugin code. Instead, the tool names are read from the info file. This will allow us, in the future, to move the tool names into the native client directory so we can change them without touching Chrome at all.


BUG=None

Review URL: https://chromiumcodereview.appspot.com/15697019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202002 0039d316-1c4b-4281-b951-d872f2087c98

Currently this checkbox does nothing. The next CL will add code to request
pairing if it was checked.

BUG=156182

Review URL: https://chromiumcodereview.appspot.com/15685008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202001 0039d316-1c4b-4281-b951-d872f2087c98

Implements proper bubble non-client frame view hit testing.
Use NonClientFrameView::GetHTComponentForFrame hit testing.
(this is similar to the implementation of CustomFrameView)
Remove the |can_drag_| flag, use WidgetDelegate::CanResize().

BUG=166075
TEST=New dialog style windows resize, drag, and generally allow mouse interaction as expected.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15667004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202000 0039d316-1c4b-4281-b951-d872f2087c98