- 02 Oct, 2018 40 commits
-
-
Chris Lu authored
Every file has been moved to AppBarViewControllerPresenting. Safe to delete AppBarPresenting now. Bug: 874471 Change-Id: I5c1edc13f1b9a8288c99fcb7b6e13f4ef7e70066 Reviewed-on: https://chromium-review.googlesource.com/1251762Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#595824}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/895ce82cabc8..73d117f64ebb git log 895ce82cabc8..73d117f64ebb --date=short --no-merges --format='%ad %ae %s' 2018-10-02 brandtr@webrtc.org Split WebRTC-UseShortVP8TL3Pattern field trial in two. 2018-10-02 philipp.hancke@googlemail.com getStats: add relayProtocol 2018-10-02 aleloi@webrtc.org Reduce digital adaptive AGC2 gain in some situations. Created with: gclient setdep -r src/third_party/webrtc@73d117f64ebb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd5ada35335256725d83210eb85a0032af7ff85f Reviewed-on: https://chromium-review.googlesource.com/1256236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595823}
-
chrome://dinoEdward Jung authored
New content to the offline page will mean it's currently possible to scroll down the page and inadverently activate the offline dino game. This change ensures the game canvas is mostly in the viewport before allow the game to start. Bug: 873343 Change-Id: I04d874f71480b3aac20a24373466626e3372f246 Reviewed-on: https://chromium-review.googlesource.com/1240339Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#595822}
-
Rakina Zata Amni authored
Previously custom element default style is passed to the constructor, adding a CSSStyleSheet parameter to multiple parts of code. This change removes that and instead sets the default style after the definition has been built, in CustomElementRegistry::DefineInternal Bug: 824684 Change-Id: Ic544561830cced77e946ae43491e6ee989511117 Reviewed-on: https://chromium-review.googlesource.com/1256263Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595821}
-
Daniel Bratell authored
Both some Win32 headers and OpenSSL/BoringSSL defines some constant macros like X509_NAME. To avoid that clash we have a wrapper for <wincrypt.h>, crypto/wincrypt_shim.h Use that one in chrome/chrome_cleaner/os/system_util.h too since that header might be used close to OpenSSL code. Change-Id: I678b5aa1658e8436eed4b431e6c2950ce7acfb3b Reviewed-on: https://chromium-review.googlesource.com/1255825Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595820}
-
Yi Su authored
If the device's size class has changed from RegularXRegular to another or reversely, the find bar should switch between regular mode and compact mode accordingly. Hide and then reshow the findbar in BVC.traitCollectionDidChange if the size class changed. Bug: 883672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38872c3fd0911e0e99ffae87f51f90c0cf9082fb Reviewed-on: https://chromium-review.googlesource.com/1256690 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Camille Lamy authored
This reverts commit e186dbf7. Reason for revert: Introduced flakyness in virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html. See https://crbug.com/891155 Original change's description: > Convert middleClickAutoscroll.js to use gpu benchmarking > > This cl converts middleClickAutoscroll.js and the middle click autoscroll > layout tests that are using it to use gpu benchmarking. > > Bug: 875945 > Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6 > Reviewed-on: https://chromium-review.googlesource.com/1251901 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595596} TBR=nzolghadr@chromium.org,sahel@chromium.org Change-Id: I108620182b4466997df7734f01718e102628fcf6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875945 Reviewed-on: https://chromium-review.googlesource.com/1256923Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595818}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c1070ec18e9..e928488baf66 Created with: gclient setdep -r src-internal@e928488baf66 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic0e355a7049e874b7e2f90acdc8eb02ac1fbf76b Reviewed-on: https://chromium-review.googlesource.com/1256235Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595817}
-
Boris Sazonov authored
Reland of https://crrev.com/c/1245786 that was reverted by https://crrev.com/c/1255456 due to a build failure. This CL replaces Chrome-specific tinting view classes with their AppCompat equivalents: TintedImageView -> AppCompatImageView and TintedImageButton -> AppCompatImageButton. 1. Entries in XML layouts have fully qualified names because some layouts are inflated outside AppCompatActivity, so AppCompat magic doesn't work for them. 2. AppCompatImageView doesn't have setTint, so ImageViewCompat.setImageTintList is used instead. 3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint', so these are replaced, too. TBR=tedchoc@chromium.org Bug: 727723 Change-Id: Iedc6337e2f58c60de2d19cd3ac1787ec7ae7b16e Reviewed-on: https://chromium-review.googlesource.com/1256783Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595816}
-
Boaz Sender authored
This change matches the behavior of Edge, Firefox and the spec: https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3 Bug: 612424 Change-Id: Ib085301f732b259f2789d50b92aff9e12dcf4ae7 Reviewed-on: https://chromium-review.googlesource.com/1254724Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#595815}
-
stkhapugin@chromium.org authored
Adds support for showing shortcuts in the popup view controller when no suggestions are shown. Since the actual shortcuts are not implemented yet, a placeholder is displayed. Bug: 886897 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie9afb4933b42b846d5177c1024feebf9241afdee Reviewed-on: https://chromium-review.googlesource.com/1233706 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#595814}
-
Hans Wennborg authored
../../components/zucchini/disassembler.h:100:3: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted] ReferenceGroup() = default; ^ ../../components/zucchini/disassembler.h:144:23: note: default constructor of 'ReferenceGroup' is implicitly deleted because field 'traits_' has no default constructor ReferenceTypeTraits traits_; ^ Bug: 890307 Change-Id: Ic7ec04e175f4fb3cc9a32e6a43115485f671b72f Reviewed-on: https://chromium-review.googlesource.com/1256805Reviewed-by:Greg Thompson <grt@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595813}
-
Yi Su authored
Remove some redundant parameters of FindBarControllerIOS::addFindBarViewToParentView:usingToolbarView:selectText:animated. Bug: 879136 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I47dbefdfbadcd160f3466a39ea6b75d90c2e8c78 Reviewed-on: https://chromium-review.googlesource.com/1254722 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595812}
-
Jochen Eisinger authored
R=tangltom@chromium.org, msarda@chromium.org BUG=890925 Change-Id: Ibbcd8c86e6398d2d5abbe55536297195f8b00afc Reviewed-on: https://chromium-review.googlesource.com/1254148 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595811}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I47a07d4b3a518c1bf109483b80e8951b9fa93aa7 Reviewed-on: https://chromium-review.googlesource.com/1251626 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595810}
-
Anders Carlsson authored
This reverts commit f990835b. Reason for revert: Breaks H264 profile negotiation in some cases. Original change's description: > WebRTC: Migrate completely to new video codec factories API > > This CL is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/788410 > > This CL makes the Chromium HW video factories implement the new > interfaces directly. It also adds SW codecs, simulcast, and SW fallback > codecs manually, instead of relying on WebRTC to do this. This will > give Chromium more flexibility in the future, and will allow us to > simplify the WebRTC code, since it's only Chromium that uses some of > these features. > > Bug: webrtc:7925 > Change-Id: Ib66ec75827363dc9e0985c35a6de936ca8f3a523 > Reviewed-on: https://chromium-review.googlesource.com/1100463 > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Anders Carlsson <andersc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580144} TBR=haraken@chromium.org,emircan@chromium.org,hiroh@chromium.org,andersc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:7925 Change-Id: I4b9c7ef3c386d310156611898ecbd552df8c1520 Reviewed-on: https://chromium-review.googlesource.com/1255636 Commit-Queue: Anders Carlsson <andersc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595809}
-
Corentin Wallez authored
This reverts commit 1c700bea. Reason for revert: Causes flakiness on the WebGL2 video tests on Mac. See crbug.com/891249 Original change's description: > [media] Reland: Fix video to canvas GPU-CPU race. > > VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED > must be retained until all reads have been completed. Such frames are > produced when software frames are uploaded to GpuMemoryBuffers. The > VideoResourceUpdater handles this, but PaintCanvasVideoRenderer > implemented only sync tokens. > > As a result, WebGL reads of software-decoded frames can tear when the > storage is reused for later frames. > > This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential > VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to > the VideoFrame until it completes. This ensures that the memory is not > reused until after the reads complete in the GPU process. > > TBR=pfeldman@chromium.org > > Bug: 819914 > Change-Id: Id181a476b78e2799bdbff149c9655427ae552743 > Reviewed-on: https://chromium-review.googlesource.com/1252962 > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595676} TBR=pfeldman@chromium.org,tedchoc@chromium.org,sandersd@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I5a1c66dc55ef5d4a5980704ef97dadea7ab41051 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819914 Reviewed-on: https://chromium-review.googlesource.com/1256372Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595808}
-
Mythri Alle authored
V8 compile options related to producing code caches (kProduceParserCache, kProduceCache, kProduceFullCodeCache) are no longer supported and would be deprecated. This cl fixes chrome to not use those options. V8 provides an explicit API (CreateCodeCache) to generate code caches. Change-Id: I8039c6e4ef84133af5b1e406f10fbd5b166acdb4 Reviewed-on: https://chromium-review.googlesource.com/1254147 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#595807}
-
Sam Zackrisson authored
echo_control_mobile() and echo_cancellation() interfaces are replaced with AudioProcessing::Config. Some configuration is now hardcoded defaults in APM, and hence should not (can not) be configured in these processors. Statistics are now accessed through AudioProcessing::GetStatistics. A UMA metric disappears. Bug: webrtc:9535 Change-Id: Ia23d58cf1a1315605beef3ec72e080844bb94e5d Reviewed-on: https://chromium-review.googlesource.com/1243123Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595806}
-
Camille Lamy authored
This reverts commit 05ee0393. Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina. See https://crbug.com/891230 Original change's description: > remove SK_SUPPORT_LEGACY_SVG_ARC_TO > > Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd > Reviewed-on: https://chromium-review.googlesource.com/1254341 > Commit-Queue: Mike Reed <reed@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595627} TBR=fmalita@chromium.org,reed@chromium.org Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891230 Reviewed-on: https://chromium-review.googlesource.com/1256825Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/121ad83c50b6..1cae4d538d01 git log 121ad83c50b6..1cae4d538d01 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 taylori@google.com Merge "trace_processor: Parse SysStats trace events and add to counters table" Created with: gclient setdep -r src/third_party/perfetto@1cae4d538d01 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibdb778a6f1fa576719b7e6d1b351cc510c43a085 Reviewed-on: https://chromium-review.googlesource.com/1256234Reviewed-by:
-
Antonio Gomes authored
Fixes crash when focusing textfield with pointer click Bug: 878692 Change-Id: Ifb66115e42bdd06c572f784dff673309a2562598 Reviewed-on: https://chromium-review.googlesource.com/1193870Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Cr-Commit-Position: refs/heads/master@{#595803}
-
Rayan Kanso authored
Make sure that only the fetch that is being processed has a notification. This CL also fixes a few bugs encountered: - MarkRegistrationForDeletion was deleting prefixes of the registration - Scheduler errors were not propagating the error to the Delegate, which was keeping abandoned fetch notifications on screen. This was fixed by adding a data manager observer which communicates these errors to the delegate. Change-Id: Ie4abada89c3ba0c98a7e7219ba3aebeb0f8e640d Reviewed-on: https://chromium-review.googlesource.com/1249075Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595802}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe79649..810f3db BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5cf7dfe1e1a84a8eb4cad57bd2d6a6138e006aaf Reviewed-on: https://chromium-review.googlesource.com/1254749 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595801}
-
Greg Kraynov authored
Bug: 865411 Change-Id: I068554583da9190c6d2e84c510f4d76d1bf4d742 Reviewed-on: https://chromium-review.googlesource.com/1245715 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595800}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ec8e0059. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25749 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2136a3b1976296cfd8256679c80c256d3d2f388f Reviewed-on: https://chromium-review.googlesource.com/1256625 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595799}
-
Michael Lippautz authored
Avoid calling the string version of 'gc()'. Bug: 889396 Change-Id: I752b7726d11c748c441cc119d015f21a45529305 Reviewed-on: https://chromium-review.googlesource.com/1254204 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
A Olsen authored
Weeklytime package has no dependencies of its own, and few things depend on it, so it is relatively easy to move out of src/chrome/browser and into src/chromeos. This is useful as part of bug 446937 - moving CrosSettings out of chrome/browser - since CrosSettings depends on this class for the DeviceOffHoursPolicyController. Bug: 446937 Change-Id: I9866f341a15f67b452b57cc219b5ca88cd18cfdb Reviewed-on: https://chromium-review.googlesource.com/1254661 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#595797}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee216640ddcc..895ce82cabc8 git log ee216640ddcc..895ce82cabc8 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 kwiberg@webrtc.org VAD/DTX tests: Don't let the ACM create audio encoders 2018-10-02 sprang@webrtc.org Split TemporalLayers and TemporalLayers checker, clean up header. Created with: gclient setdep -r src/third_party/webrtc@895ce82cabc8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7c6021dfa8dbf1f2e740c101f44043c659af404 Reviewed-on: https://chromium-review.googlesource.com/1256230Reviewed-by:
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-request/pull/789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae Reviewed-on: https://chromium-review.googlesource.com/1253942Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595795}
-
Camillo Bruni authored
Initial version shows predictably 29 network errors: - 28x times https://abs.twimg.com/k/en-gb/13.hls.js.en-gb.43b6de858df39857f6b2.js - 1x https://twitter.com/manifest.json Bug: 878390 Change-Id: Ifa4dd5dae68f1450d47d22241f094a6e454593cd Reviewed-on: https://chromium-review.googlesource.com/1219003 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#595794}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/daa3b5e9795b..9c1070ec18e9 Created with: gclient setdep -r src-internal@9c1070ec18e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I427060c5916b114c96a073aacc6a369728b0f42b Reviewed-on: https://chromium-review.googlesource.com/1256232Reviewed-by:
-
Kent Tamura authored
- Consolidate 'origin' and 'queueMicrotask' - Move 'customElements' to the top section - Move requestAnimationFrame() and cancelAnimationFrame() to their own section - Move requestIdleCCallback() and cacelIdleCallback() to their own section - Update comments This CL has no behavior changes. Change-Id: I4472c1582933a53703510ab33d35f4f1a0824541 Reviewed-on: https://chromium-review.googlesource.com/1256391Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#595792}
-
Noel Gordon authored
Teach the <file-safe-media> element more about the loaded state of its child <webview>: make the <webview> send webview-loaded/cleared events to its parent <file-safe-media>, and have the parent set that state in the 'loaded' attribute of the child <webview>. Add an html scroll test: wait for the <webview> to load its content by waiting for the 'loaded' attribute. Then call window.scrollBy() on the <webview> and verify that the <webview> was scrolled. Minor: files_safe_media_webview_content.js: use document.querySelector to get the #content element to silence a presubmit warning. Test: browser_tests --gtest_filter="QuickView*openQuickViewScrollHtml" Bug: 891150 Change-Id: I7bc10a47ff4e50a16ece910174959596615e6fd7 Reviewed-on: https://chromium-review.googlesource.com/1256399 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#595791}
-
Jose Dapena Paz authored
On using keyboard with Wayland, we get performance timing asserts. It is caused by inconsistency in how we generate the timestamps from the native events. This replicates the reasoning of Windows EventTimeFromMSG, as the problem is the same. For platform independent events we use TimeTicks::Now, but for native events we use a different time origin. So let's use for keyboard also EventTimeForNow(). Bug: 891205 Change-Id: Iaf1c2e106ea39c7ea3fc6da5c5ab647109f87c7a Reviewed-on: https://chromium-review.googlesource.com/1256569Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 887201 Change-Id: Ife32574b7014616f13b5ac3ede174c6a72c7bf4e Reviewed-on: https://chromium-review.googlesource.com/1253921Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595789}
-
Oleg Maximenko authored
Passing desired_size to ImageDecoder::Create() means that caller have checked that the size is possible by calling ImageDecoder::GetSupportedDecodeSizes(). Otherwise some issues may arise even for the formats that don't support decode-to-scale. On the other hand the only supported format (JPEG) isn't very popular for the icons. Better to simplify the code. Change-Id: I24e173ee0540bb5d7adc055ffaa8285bef8f90de Reviewed-on: https://chromium-review.googlesource.com/1253901Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595788}
-
Marc Treib authored
AutofillWalletDataTypeController is used (pre-USS) for both AUTOFILL_WALLET_DATA and AUTOFILL_WALLET_METADATA. When Sync is stopped, it calls PersonalDataManager::ClearAllServerData. Since there are two instances of the controller, that happens twice (which is unnecessary but doesn't hurt). However, when AUTOFILL_WALLET_DATA is on USS, then the remaining ClearAllServerData call (for the metadata controller) still happens, which brings Sync into a bad state since the data is now gone, but the progress marker is still there (see bug 885211). This CL changes AutofillWalletDataTypeController to only call ClearAllServerData for AUTOFILL_WALLET_DATA (i.e. it won't be called anymore if Wallet is on USS). Instead, AUTOFILL_WALLET_DATA gets special-cased in ModelAssociationManager to clear even in the STOP_SYNC case. This achieves the same "clear data on stopping sync, but *not* on browser shutdown", but without requiring a special side channel to the SyncService. One consequence is that with AUTOFILL_WALLET_DATA on USS, the clearing now happens asynchronously (because it goes through the DB), which requires some test changes. Bug: 889941 Change-Id: I54c36050c81fa862acfc0052f355ff1645a8b292 Reviewed-on: https://chromium-review.googlesource.com/1251041 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#595787}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f61afaa6ec3..121ad83c50b6 git log 7f61afaa6ec3..121ad83c50b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 hjd@google.com Add libfuzzer to buildtools gitignore Created with: gclient setdep -r src/third_party/perfetto@121ad83c50b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If22e3137e25ca856e41afdc3e1666ba504fe412d Reviewed-on: https://chromium-review.googlesource.com/1256231Reviewed-by:
-
Camillo Bruni authored
Several login pages do no longer work by simply settings the value of the email and password inputs. Using EnterText single KeyboardEvents are dispatched to the currently selected input thus simulating more closely real input. Bug: 878390 Change-Id: I86ba8edbac681d6739acaaebe74ed4e6b1034096 Reviewed-on: https://chromium-review.googlesource.com/1254962 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
