GitLab

The combination of 'branding=Chromium' and 'enable_widevine=1' causes
'widevinecdm' to be a 'shared_library' build of the CDM stub.
Additionally combined with 'mac_strip_release=1', this triggers
'strip_save_dsym', which fails, because it doesn't support
'product_dir'.

This fix does to 'widevinecdm' what has already been done to
'clearkeycdm': Split the target into 'widevinecdm_binary' which builds
and strips the stub binary, and 'widevinecdm' which just copies the
binary.

This CL relands https://codereview.chromium.org/2117343005/ with the
following change:

The new 'widevinecdm_binary' target is now defined conditionally for the
case when it is really needed, to fix the ninja error "multiple rules
generate WidevineCdm/_platform_specific/win_x86/widevinecdm.dll".

BUG=622282

TEST='build/gyp_chromium -Gconfig=Release -Dbranding=Chromium -Denable_widevine=1 -Dmac_strip_release=1 && ninja -C out/Release widevinecdm' is successful

Review-Url: https://codereview.chromium.org/2149233003
Cr-Commit-Position: refs/heads/master@{#405635}

Need for unit testing regarding http://crrev.com/2136723002

Review-Url: https://codereview.chromium.org/2151693006
Cr-Commit-Position: refs/heads/master@{#405634}

--remote-debugging-port flag is lost when guest sessions are started on
chromeos.

BUG=None

Review-Url: https://codereview.chromium.org/2141303003
Cr-Commit-Position: refs/heads/master@{#405633}

Keep the SystemModalContainerEventHandler added, and check the modality in the event handler, instead of adding/removing the event handler.

Ensures that pointer/touch events on Arc windows are not registered when a system modal is open.

BUG=624168
TEST=PointerTest.IgnorePointerEventDuringModal,TouchTest.IgnoreTouchEventDuringModal

Review-Url: https://codereview.chromium.org/2127263002
Cr-Commit-Position: refs/heads/master@{#405632}

Modified chrome.extensions.getViews() to support filtering by tabId

BUG=72418

Review-Url: https://codereview.chromium.org/2105033003
Cr-Commit-Position: refs/heads/master@{#405631}

TEST=intersection-observer/display-none.html
BUG=621693
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2149033003
Cr-Commit-Position: refs/heads/master@{#405630}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4c68d129..a0ba5b34

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2148123003
Cr-Commit-Position: refs/heads/master@{#405629}

This patch makes changes as per discussion at
https://github.com/slightlyoff/ServiceWorker/issues/916

Namely,
* The waiting worker gets promoted to active once there are no
controllees and the incumbent worker has no in-flight events
(fetch/sync/push/message etc).
* skipWaiting bypasses the no controllees requirement, but we
still wait until there are no in-flight events.
* As usual, incoming fetch/sync/push events always go to the
active worker.

BUG=616331

Review-Url: https://codereview.chromium.org/2119143002
Cr-Commit-Position: refs/heads/master@{#405628}

This separates out the default values of configs for the various target types into well-named global variables that can be referred to in different places.

This allows us to move the set_defaults calls for various templates to the places where those templates are defined rather than putting them all in BUILDCONFIG. An example of this is the test() target defaults, where the actual template is declared in a .gni file but the defaults have to be global.

Review-Url: https://codereview.chromium.org/2150753002
Cr-Commit-Position: refs/heads/master@{#405627}

This consolidates the mechanism for running unit tests with and
without root layer scrolling enabled.  The same mechanism can be
used to parameterize anything in WebSettings.

BUG=490942
R=skobes@chromium.org

Review-Url: https://codereview.chromium.org/2154493002
Cr-Commit-Position: refs/heads/master@{#405626}

and debug protocol commands. It's intended for developer debugging only.

Examples:

    WebInspector.sendOverProtocol('Emulation.setDeviceMetricsOverride', { ... });
    WebInspector.sendOverProtocol('Emulation.clearDeviceMetricsOverride');

    WebInspector.sendOverProtocol('Page.captureScreenshot')
        .then((err, result) => console.log(result));

Review-Url: https://codereview.chromium.org/2149833002
Cr-Commit-Position: refs/heads/master@{#405625}

This CL first check if we can undo the recent closure in java by using
TabModelImpl.

If nothing we can do with undo snackbar logic, then use
recently_closed_tabs_bridge in native code to retrive data from
tab_restore_service.

BUG=602559
https://bugs.chromium.org/p/chromium/issues/detail?id=602559#c7

Review-Url: https://codereview.chromium.org/2088443003
Cr-Commit-Position: refs/heads/master@{#405624}

This renames the PixelTestDelegatingOutputSurface to drop the "Pixel",
it's cleaner.

And the caller creates the Display and its OutputSurface, etc. So it
has control over the types and can use a PixelTestOutputSurface or a
FakeOutputSurface for non-pixel unit tests.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2144393003
Cr-Commit-Position: refs/heads/master@{#405623}

Some layout tests are flaky on WebKit Leak bot due to m_document introduced to
CanvasAsyncBlobCreator in https://codereview.chromium.org/2143353002.

TBR=haraken@chromium.org
BUG=628308

Review-Url: https://codereview.chromium.org/2149233004
Cr-Commit-Position: refs/heads/master@{#405622}

Allow the bots to call iossim -w as a standalone call.

BUG=

Review-Url: https://codereview.chromium.org/2147793004
Cr-Commit-Position: refs/heads/master@{#405621}

BUG=621139

This is in preparation for https://codereview.chromium.org/2118853002/,
which will also move PaintTabBackgroundUsingFillId() into namespace.
This CL is moving everything it depends on out of Tab.

Review-Url: https://codereview.chromium.org/2150013002
Cr-Commit-Position: refs/heads/master@{#405620}

BUG=627539
R=mlamouri@chromium.org,zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2146383002
Cr-Commit-Position: refs/heads/master@{#405619}

Previously this was force to a source set because it was too large for official Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows builds so it can be a static library now.

BUG=627637

Review-Url: https://codereview.chromium.org/2145253003
Cr-Commit-Position: refs/heads/master@{#405618}

https://chromium.googlesource.com/skia.git/+log/4c7e117b696b..494c2b6fa125

$ git log 4c7e117b6..494c2b6fa --date=short --no-merges --format='%ad %ae %s'
2016-07-14 herb Fix a bug in the Clamp in X direction tiling. The code mixed up which end of the span was cut and preserved in the sequence of span breaks.
2016-07-14 robertphillips Remove GrWrapTextureInBitmap call in SkGpuDevice::drawSpriteWithFilter
2016-07-14 fmalita Build Expat on all platforms

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2153433003
Cr-Commit-Position: refs/heads/master@{#405617}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4d408bfe9dec..93f7631816bc

$ git log 4d408bfe9..93f763181 --date=short --no-merges --format='%ad %ae %s'

BUG=472699

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2149073004
Cr-Commit-Position: refs/heads/master@{#405616}

Now behind a Feature and also will not show if the number of impressions is higher than some value passed by Variations params.

BUG=626442
TEST=AutofillManagerTest

Review-Url: https://codereview.chromium.org/2146823003
Cr-Commit-Position: refs/heads/master@{#405615}

Cr-Commit-Position: refs/heads/master@{#405614}

This patch saves about 5% time during prepare tiles by eliminating
unnecessary refcount churn when copying prioritized tiles around in
the raster tile priority queues.

R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2150473003
Cr-Commit-Position: refs/heads/master@{#405613}

Default favicon now has the same color as the close button. This CL
also makes sure that the favicon's color gets updated when the theme
changes. CloseButtonColor has been refactored.

BUG=621015, 625821

Review-Url: https://codereview.chromium.org/2126043002
Cr-Commit-Position: refs/heads/master@{#405612}

We currently assume that the occlusion calculated for contributing
surface (the second last element of the stack in occlusion tracker) is
always the occlusion by its target. This is not true.

BUG=501135
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2147283002
Cr-Commit-Position: refs/heads/master@{#405611}

This issue was caused during a recent refactoring.  This CL adds the
initialization code for Trackpad mode back.

BUG=628034

Review-Url: https://codereview.chromium.org/2146303002
Cr-Commit-Position: refs/heads/master@{#405610}

DCHECK can be tripped when there is a chain of openers or when the
opener has been cleared. The subsequent comparison against file:
fails, and we may make a browser navigation where one could have
been avoided, but it is still correct.

Since it is still correct, we can simplify the check, perhaps
forking in more cases that we used to, but that doesn't matter.

BUG=622509
R=creis@chromium.org

Review-Url: https://codereview.chromium.org/2153573002
Cr-Commit-Position: refs/heads/master@{#405609}

Out-of-flow items should not be frozen. This would have problematic
effects when they have flex-grow/flex-shrink set because freezing
them would subtract them from our flex-grow/shrink total without
having been added.

This also adds some DCHECKs.

R=eae@chromium.org,dgrogan@chromium.org
BUG=628072

Review-Url: https://codereview.chromium.org/2146603007
Cr-Commit-Position: refs/heads/master@{#405608}

* Adds hooks in DownloadManagerService for calling GetAllDownloads()
  and sending the information back to Java.  This creates a
  List of DownloadItems that contain the basic information needed
  for the UI.

* Adds a basic RecyclerView to display the files in the user's
  download history.

* Adds a DownloadHistoryAdapter that is used to track information
  about the download history.  This *should* be reusable among
  multiple RecyclerViews in case the user opens up multi-window
  mode.

- This currently doesn't monitor any changes to the history and is
  used solely for getting a skeleton working.

BUG=616324

Review-Url: https://codereview.chromium.org/2143303002
Cr-Commit-Position: refs/heads/master@{#405607}

kOzoneTestSingleOverlaySupport was originally added to test a single
overlay plane when using Ozone.

The code evolved and now passing that parameter enable overlays (not
only a single overlay).

This CL removes the command line flag and uses kEnableHardwareOverlays
instead to enable overlays on Ozone.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2122303003
Cr-Commit-Position: refs/heads/master@{#405606}

follow-on to https://codereview.chromium.org/2126973004

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API. (See linked crbug for details.)
No new layout API methods were required in this CL.

There are no functional changes.

BUG=499321

Review-Url: https://codereview.chromium.org/2151883004
Cr-Commit-Position: refs/heads/master@{#405605}

- Add a placeholder for CUPS printers subpage
- Move the google cloud printing page to the Cloud Printers subpage.

See the mock: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/flow#%2F101_Printing.png%3Fz=width

BUG=626752, 625364
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2110653003
Cr-Commit-Position: refs/heads/master@{#405604}

The close (X) button now sets the kDefaultBrowserLastDeclined pref.

BUG=627615

Review-Url: https://codereview.chromium.org/2148523002
Cr-Commit-Position: refs/heads/master@{#405603}

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against that library.
This CL fixes the shared library build with GYP.

TBR=erg

Review-Url: https://codereview.chromium.org/2146363002
Cr-Commit-Position: refs/heads/master@{#405602}

No longer try to set overlay message and no longer send
"Inspecotr.enable" message to the targets of JS inspector type.

BUG=624494

Review-Url: https://codereview.chromium.org/2122113004
Cr-Commit-Position: refs/heads/master@{#405601}

This command-line switch was added for testing on an experimental
'backlog' heuristic for measuring encoder utilization in:
https://codereview.chromium.org/2108373002/

From lab testing, the new heuristic works better and more stable than
original deadline heuristic. This CL removes the command-line switch
and makes the new heuristic default.

BUG=chrome-os-partner:55236,chrome-os-partner:54806

Review-Url: https://codereview.chromium.org/2149843002
Cr-Commit-Position: refs/heads/master@{#405600}

Patch generation and various utilities (disasm) now use memory mapped file
instead of copying into a string buffer. This saves the equivalent of the size of
both |old_file| and |new_file| in memory when generating the patch
(~300Mb with chrome.7z).

BUG=

Review-Url: https://codereview.chromium.org/2143973004
Cr-Commit-Position: refs/heads/master@{#405599}

BUG=612802

Review-Url: https://codereview.chromium.org/2151023004
Cr-Commit-Position: refs/heads/master@{#405598}

(1) Remove redundant checks for bundled vs. component-updated Flash:
    This distinction is handled at registration time by the DCI.
(2) Update PathService after calling register. These two events are
    already racy, and it's more convenient to have the registration
    finished by the time the component updater notifies that the
    component has been updated.
(3) No need to explicitly pick up the bundled version of Flash for non-
    Linux: the component updater will manage registration of bundled
    Flash the same way it does component-updated Flash.

BUG=624067
TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1

Committed: https://crrev.com/ae2a704ab712680c8b53a86e77eba78d0e591106
Review-Url: https://codereview.chromium.org/2130803003
Cr-Original-Commit-Position: refs/heads/master@{#405148}
Cr-Commit-Position: refs/heads/master@{#405597}

BUG=621542

Review-Url: https://codereview.chromium.org/2145103003
Cr-Commit-Position: refs/heads/master@{#405596}