GitLab

Checking the selectors here gives error messages when a
developer has a typo instead of just failing to match anything.

Canonicalizing the selectors improves compatibility with the upcoming
Blink watchSelectors API, which will send back generated selector
strings instead of exactly what the user set.

I also added support in our testing infrastructure to assert that a thrown exception's message matches a regular expression.

BUG=172011

Review URL: https://chromiumcodereview.appspot.com/23478003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220487 0039d316-1c4b-4281-b951-d872f2087c98

Make sure to compute generated_background_page value in all cases.

BUG=276519

Review URL: https://chromiumcodereview.appspot.com/23535002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220486 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dharcourt@chromium.org

BUG=281815
TEST=interactive_ui_tests

Review URL: https://codereview.chromium.org/23638004

Patch from Lambros Lambrou <lambroslambrou@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220485 0039d316-1c4b-4281-b951-d872f2087c98

Apps Developer Tools will close when the user close the dialog.

Here's a screenshot of the dialog.
http://i.imgur.com/aO03CqB.png

BUG=267679

Review URL: https://chromiumcodereview.appspot.com/23460005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220484 0039d316-1c4b-4281-b951-d872f2087c98

DXVAVideoDecodeAccelerator::PreSandboxInitialization function. 

This is because these functions fail on Windows 8.1 in the gpu sandbox causing us to
fallback to s/w video decode for H.264 videos.

BUG=281752
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/23726005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:280383

Review URL: https://chromiumcodereview.appspot.com/23608003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220482 0039d316-1c4b-4281-b951-d872f2087c98

Moves the ones that do not involve renaming.

BUG=248353
R=jamescook@chromium.org,xiyuan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23534023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220481 0039d316-1c4b-4281-b951-d872f2087c98

This is a mechanical change. No semantics changed.

BUG=280416
TEST=none
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23710012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220480 0039d316-1c4b-4281-b951-d872f2087c98

This allows creation of a transform and its inverse that would be used
to counter-animate some child layer.

BUG=270857

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220124

R=vollick@chromium.org, wittman@chromium.org

Review URL: https://codereview.chromium.org/22861008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220479 0039d316-1c4b-4281-b951-d872f2087c98

Life is short and we've only got so much horizontal whitespace to work with.

This also helps pave the way for introducing Android demuxer client interfaces for media/ code.

BUG=263652
TBR=palmer

Review URL: https://chromiumcodereview.appspot.com/23787002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220478 0039d316-1c4b-4281-b951-d872f2087c98

Have ui::Layer subclass cc::LayerClient and register itself as the
client of the cc::Layer it is using. This allows the names for the
layers appear in debugging output.

BUG=280662
TEST=Built version of chrome that dumps debug information about layers
     and confirmed the missing layer names are now present.

Review URL: https://chromiumcodereview.appspot.com/23701005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220477 0039d316-1c4b-4281-b951-d872f2087c98

-change session timeout to base::TimeDelta
-change command timeout to 10m
-refactor and simplify wait for events
-also, fix some assertions on windows with unzipping
BUG=none
R=frankf@chromium.org

Review URL: https://codereview.chromium.org/23542005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220476 0039d316-1c4b-4281-b951-d872f2087c98

This will be useful for writing tests for the file task stuff
in chrome/browser/chromeos/extension/file_manager/file_tasks.cc.

BUG=269929
TEST=none
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23503008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220475 0039d316-1c4b-4281-b951-d872f2087c98

This wasn't correctly setting it to 1.

TBR=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23766005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23514018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220473 0039d316-1c4b-4281-b951-d872f2087c98

> Added basic browser test for window.print() from Chrome apps.
> 
> This just tests the success of the call to window.print(). It does not
> test whether the call leads to a print preview window and ultimately to
> a printout. It will be extended over time to provide additional coverage
> of the print functionality.
> 
> BUG=NONE
> 
> Review URL: https://chromiumcodereview.appspot.com/23054002

TBR=dharcourt@chromium.org

Review URL: https://codereview.chromium.org/23597011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220472 0039d316-1c4b-4281-b951-d872f2087c98

Created a default URLFetcherFactory to fix the flaky tests.

BUG=280247
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23440010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025
R=eroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19757011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220470 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 219657 "Roll Clang r186332:r188423."
> 
> BUG=266815
> 
> > Roll Clang r186332:r188423.
> > 
> > BUG=none
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23172018
> 
> TBR=hans@chromium.org
> 
> Review URL: https://codereview.chromium.org/23801002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/23559013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220469 0039d316-1c4b-4281-b951-d872f2087c98

This just tests the success of the call to window.print(). It does not
test whether the call leads to a print preview window and ultimately to
a printout. It will be extended over time to provide additional coverage
of the print functionality.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/23054002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=266815

> Roll Clang r186332:r188423.
> 
> BUG=none
> 
> Review URL: https://chromiumcodereview.appspot.com/23172018

TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/23801002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220466 0039d316-1c4b-4281-b951-d872f2087c98

Add a NetworkActivationHandler for handling cellular activation calls to Shill.

BUG=188753
TEST=tested Verizon LTE (on link) and Verizon 3g (on Lumpy) activation

Review URL: https://chromiumcodereview.appspot.com/22611005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220463 0039d316-1c4b-4281-b951-d872f2087c98

This patch prevents LTHI from background ticking
animations if there is no active tree to
animate since animating with no active tree will
often result in segfaults.

BUG=280706

Review URL: https://chromiumcodereview.appspot.com/23593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220462 0039d316-1c4b-4281-b951-d872f2087c98

If metro viewer instance was connected before crash then we won't show crash dialog.

BUG=273185
R=cpu,ananta
TBR=sky
TESTS:Please see comment#2 in bug description and check if you see restart dialog when crashed from metro mode.

Review URL: https://chromiumcodereview.appspot.com/23405002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220459 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156928:156936&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23559011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220458 0039d316-1c4b-4281-b951-d872f2087c98

This isn't necessary in the browser since if there are 2 requests for 
the same translation we don't care which one wins, 
(i.e. which one gets the temp file and does the translation and which one 
blocks to wait) but the unit tests do care because they try to hit particular
corner cases. This is why they were flaky. So just always sequence the temp
file creation, which will have minimal cost in practice.
Also re-enable the disabled tests.
R=jvoung@chromium.org
BUG=272492

Review URL: https://chromiumcodereview.appspot.com/23737002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220457 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/14025/steps/cc_unittests/logs/stdio#failure7

> cc: Block commit on activate by setting a flag on LayerTreeHost.
> 
> Currently the ThreadProxy recursively asks all layers in the tree if
> they should block the commit. This is problematic as when you remove
> a layer from a the tree, it may want to block the commit to get back
> resources from its active-tree impl-layer.
> 
> Instead, have layers call SetNextCommitWaitsForActivation() when they
> want the next commit to block on activate. This way we only block
> commits that matter, not every commit when there's a texture layer
> present. And we can allow a layer to block the commit when it is
> leaving the tree.
> 
> Tests:
> TextureLayerNoMailboxIsActivatedDuringCommit
> TextureLayerMailboxIsActivatedDuringCommit
> DelegatedFrameIsActivatedDuringCommit
> 
> R=enne, piman
> BUG=277953
> 
> Review URL: https://chromiumcodereview.appspot.com/23530003

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/23702010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220455 0039d316-1c4b-4281-b951-d872f2087c98

Crash data seems to indicate AutocompletePopupWidget is getting
destroyed when we Init() it. This seems wrong, so I'm adding a CHECK
to helkp isolate why.

BUG=275794
TEST=none
R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23490017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220451 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org
BUG=150084,281527,281541, 281582

Review URL: https://chromiumcodereview.appspot.com/23548003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220450 0039d316-1c4b-4281-b951-d872f2087c98

On windows, web page replay server fails to do cleanup such as restoring dns settings if it gets terminated.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23455009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220448 0039d316-1c4b-4281-b951-d872f2087c98

To open the gallery, dowloads dir is needed, but the code was wrong.
This fixes it by using VolumeManager.
This is also the preparation to switch rootsList to volume info list.

BUG=268817
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23599004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272715
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/23601005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220444 0039d316-1c4b-4281-b951-d872f2087c98

** Will need to be updated/rebased when https://codereview.chromium.org/22883011/ lands 
BUG=273827

Review URL: https://chromiumcodereview.appspot.com/23465003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=274658

Review URL: https://chromiumcodereview.appspot.com/23771002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220441 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220440 0039d316-1c4b-4281-b951-d872f2087c98

1705: Land a test change that should have been part of r1704.
1706: ninja/mac: Allow more than one ld process at a time, based on RAM.
1707: ninja&make/mac: Convert .strings files to UTF-16LE, not just UTF-16.

BUG=280718
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/23790003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220439 0039d316-1c4b-4281-b951-d872f2087c98

These objects will soon be added to PasswordForm, which needs to be persisted
by the PasswordStore.

BUG=240559

Review URL: https://chromiumcodereview.appspot.com/23033010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276334
TEST=Manual, see bug.

Review URL: https://chromiumcodereview.appspot.com/23311008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220435 0039d316-1c4b-4281-b951-d872f2087c98

We need to switch to googlestorage first.

This change reverts r220393 and r220374.

TBR=ilevy@chromium.org
BUG=276076

Review URL: https://codereview.chromium.org/23647005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220434 0039d316-1c4b-4281-b951-d872f2087c98