- 30 Jul, 2018 40 commits
-
-
Boris Sazonov authored
This CL changes the way an account is bundled into an intent that opens the settings page for this account: instead of bundling just the name of the account, the whole account object is bundled now. This is necessary because Settings app expects the whole account object in the bundle. Bug: 863370 Change-Id: I95a5ae901183c3cdd96bffd38906cb767a3afef3 Reviewed-on: https://chromium-review.googlesource.com/1152924Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579003}
-
Yoshifumi Inoue authored
This patch changes |SetSelectionToDragCaret()| to take |SelectionInDOMTree| instead of |VisibleSelection&| since it uses |SelectionInDOMTree| and output parameter isn't used in caller for improving code health. This is 1/3 of series of patches: 1. This patch 2. http://crrev.com/c/1153070 3. http://crrev.com/c/1153071 Bug: 657237 Change-Id: If01c9f465cbf5e5a940d1e9c30af8080a5496527 Reviewed-on: https://chromium-review.googlesource.com/1153069Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579002}
-
Arthur Sonzogni authored
The test http/tests/misc/adopt-iframe-src-attr-after-remove.html as always been a bit flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Fadopt-iframe-src-attr-after-remove.html&testType=webkit_layout_tests The reason is that navigations triggered by a script before the onload handler don't generate back/forward entries. See third_party/blink/public/web/web_history_commit_type.h Sometimes, this test was fast enough so that no history entry was created. Then history.back() failed and it ended with a timeout. This is the same for: http/tests/misc/resource-timing-iframe-restored-from-history.html Bug: 862580, 831155 Change-Id: I3b8243c5f43c5043de8e23acfbe561a648c0f115 Reviewed-on: https://chromium-review.googlesource.com/1133170Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#579001}
-
Yoshifumi Inoue authored
This patch changes call site of |ChildrenChanged()| in |ContanerNode:: RemoveChild()| out side of |SlotAssignmentRecalcForbiddenScope| to allow |ChildrenChanged()| to use flat tree. Background: |HTMLElement::ChildrenChanged()| adjust directionality of element, e.g. "dir" attirbute, <bdi>, <bdo>, etc, by traversing flat tree. Bug: 867355 Change-Id: I8e1211f1a43afc27ba0e582030f2f2e8a6a74731 Reviewed-on: https://chromium-review.googlesource.com/1152754Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579000}
-
Kunihiko Sakamoto authored
gen-certurl's -sct option is deprecated in https://github.com/WICG/webpackage/pull/259. Bug: 803774 Change-Id: I4fbc575366aba978b262418d2cf415121e840099 Reviewed-on: https://chromium-review.googlesource.com/1154745 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#578999}
-
Arthur Sonzogni authored
The navigation may be triggered before the load event. When it happens, the history entry must replace the current one instead of being appended to it. Then history.go(-1) fails in the next document. This CL make the navigation to happen after the load event. Bug: 862580, 831155 Change-Id: I4a48d50f5899e3fd65c74d9a89ab836ae94ba7be Reviewed-on: https://chromium-review.googlesource.com/1133261Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6d158c31. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22102 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I3c69eb5c7a1e4e374d7fb1f8e9e24752e0ccc487 Reviewed-on: https://chromium-review.googlesource.com/1154635 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578997}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id948a518e7cc6c96d9b1070b6daa0314ee8495f7 Reviewed-on: https://chromium-review.googlesource.com/1154637 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578996}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/823c88d37b4d..da846e65f8a2 git log 823c88d37b4d..da846e65f8a2 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5b3b5cc126a7..e452382a61a1 (1 commits) Created with: gclient setdep -r src/third_party/skia@da846e65f8a2 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ibf7591d0bb0a44c76aac8e4b6ca0a93e66d63d9a Reviewed-on: https://chromium-review.googlesource.com/1154636Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578995}
-
Arthur Sonzogni authored
The layout test: object-src-inject.html is flaky. Sometimes, this line is printed: ``` CONSOLE MESSAGE: Blink Test Plugin: initializing ``` It is fired from BlinkTestInstance::Init(...); It is racing with the end of the layout test. This CL disables console error dump to avoid this issue. Bug: 862959, 831155 Change-Id: I912e71b9ff8b7b5ccd7a4716f111f2017493e37a Reviewed-on: https://chromium-review.googlesource.com/1135003Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578994}
-
Rune Lillesveen authored
We assert that we find the same text node before creating the element as we find when attaching the first letter LayoutText. We used to attach the ::first-letter pseudo element before finding the LayoutText from which we get the first letter text. We did crash in a clusterfuzz test because FirstLetterTextLayoutObject() was confused by a combination of a grid, button, anonymous wrappers and continuations. Instead of trying to fix all bugs in FirstLetterTextLayoutObject(), find the LayoutText before attaching the ::first-letter to make sure we are consistent instead of chasing clusterfuzz issues. Reported the incorrectness for button, grid, and ::first-letter in 868380. Bug: 859285, 868380 Change-Id: I335a32b466ab31858fb05ea5f650cf12ab674040 Reviewed-on: https://chromium-review.googlesource.com/1152982Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#578993}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5279da5c..69747f20 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I045fb789a9dc0d0d01bef44b6aaf3d4dd426bdef Reviewed-on: https://chromium-review.googlesource.com/1154632Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578992}
-
Kent Tamura authored
The third test and the forth test are very slow. Split out the latter to another file. Bug: https://github.com/web-platform-tests/wpt/issues/11187 Change-Id: I3af14e712b6b06603140666f08005fb18d6a0541 Reviewed-on: https://chromium-review.googlesource.com/1148163Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#578991}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5b3b5cc126a7..e452382a61a1 git log 5b3b5cc126a7..e452382a61a1 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 fjhenigman@chromium.org Vulkan: convert/align vertex data from buffers Created with: gclient setdep -r src/third_party/angle@e452382a61a1 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I4afd33599e0750b7943531f2d7081fdcd496d31d Reviewed-on: https://chromium-review.googlesource.com/1154633Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578990}
-
kristipark authored
This is a reland of c7c6a230 The iframe was sometimes emitting a DOMContentLoaded event before the src was modified. Original change's description: > [NTP] Add ability to add/delete/reset custom links from the New Tab Page > > Added functionality for adding/removing links and restoring the Most > Visited tiles. If the URL is not valid, the link will not be added. The > blacklist button now opens the edit dialog (editing links is currently > not functional and will be added in a later CL). > > Also added hover/pressed/focus styling to the input fields and the > buttons. > > Design Doc: go/chrome-ntp-custom-links > > Video: https://screencast.googleplex.com/cast/NTQyNDU2OTc1ODI1MzA1NnwwMjFkODAwYi1kMg > > Bug: 851293 > Change-Id: Ic92e46ba93a4abcb375467a1d047cbb573f231ba > Reviewed-on: https://chromium-review.googlesource.com/1149458 > Commit-Queue: Kristi Park <kristipark@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578404} TBR=bauerb@chromium.org Bug: 851293 Change-Id: Ibc4e29d1b5a9cedbd6151e0e02d14c6ae8eb9bd0 Reviewed-on: https://chromium-review.googlesource.com/1153314 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578989}
-
Matt Falkenhagen authored
Easier to maintain than explicit function calls. Bug: 866353 Change-Id: I91b535aca35ded19b7dd92fa1c78b49d38e78376 Reviewed-on: https://chromium-review.googlesource.com/1151085Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578988}
-
Kuo-Hsin Yang authored
Setting oom_score_adj directly is faster and doesn't have to involve debugd when ARC++ is disabled. Bug: 868249 Change-Id: Ifeda6cd1d393c85f373928aafadd4ec3d3941a92 Reviewed-on: https://chromium-review.googlesource.com/1152751Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578987}
-
Ramin Halavati authored
Preferences defined in: 'ash/public/cpp/ash_pref_names.h' 'ash/public/cpp/shelf_prefs.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: If62781c31693db1b8b755ce46bd75f2c6eceda5a Reviewed-on: https://chromium-review.googlesource.com/1141567 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578986}
-
Gang Wu authored
Specifics: +596,579 bytes normalized apk size +3 zip entries file count +29,136 bytes main lib size +386,948 bytes main dex size InstallSize: +209,631 bytes APK size +1,772,900.92 bytes Estimated installed size InstallBreakdown (+1,773,525.92 bytes): +1,570 bytes Non-compiled Android resources size +29,136 bytes Native code size +161 bytes Package metadata size +1,728,134.92 bytes Java code size +14,524 bytes Compiled Android resources size Dex: +1,935 entries fields +2,676 entries methods +656 entries types +1,339 entries strings Change-Id: I73032882a03bf9fa3000068ba5d80e55f0208f88 Reviewed-on: https://chromium-review.googlesource.com/1154206 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#578985}
-
Alan Cutter authored
This CL refactors HostedAppOriginText to be a child view of HostedAppButtonContainer. This reduces the amount of copy paste code required for BrowserNonClientFrameViews to include hosted app titlebar controls. There are no behavioural changes in this patch. This is in preparation to add HostedAppButtonContainer to OpaqueBrowserFrameView as part of crbug.com/854479. ChromeOS: Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350571&signed_aid=YOEpL6GXAWvEz_Z3y_oEGQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350572&signed_aid=OPqcFEyjoPZPeTeV_gOCVw==&inline=1 ChromeOS Mash: Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350573&signed_aid=XZV7AbxDTBXdKws05j49uw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350574&signed_aid=afuv2dBuAZOzE5KMlE5x-A==&inline=1 Windows 10: Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350575&signed_aid=foMVbIlc5-EyYC_3xWeLIw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350576&signed_aid=-lTiU3fJfkAr_3c_z2Tu3g==&inline=1 Bug: 854479 Change-Id: I275af3c8079a895d23dec1d56230648ca1784aae Reviewed-on: https://chromium-review.googlesource.com/1152718 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#578984}
-
Giovanni Ortuño Urquidi authored
WebApplicationInfo is not moveable so wwhen calling std::move() on it, we make a copy. To avoid this, wrap WebApplicationInfo in a unique_ptr. Bug: 864904 Change-Id: I3568101b8ee209786b18127e515b694729aa2ed2 Reviewed-on: https://chromium-review.googlesource.com/1154733Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#578983}
-
Alexey Baskakov authored
Bug: 860581 Change-Id: Ice0a693c6a8a4a247d9cd191967e0f88af2d4bf4 Reviewed-on: https://chromium-review.googlesource.com/1154735Reviewed-by:
-
Keiichi Watanabe authored
This patch makes Chrome work before/after https://crrev.com/c/1134934 (for chromiumos-overlay), https://crrev.com/c/1136336 (for v3.14) and http://crrev.com/c/1134929 (for v4.4) are merged, which change ChromeOS-specific controls' IDs to avoid cofliction with upstream. By calling QUERY_CTRL for new IDs, Chrome can detect whether the CLs are already merged at run-time. If they are not merged yet, Chrome will use old control IDs instead. This patch is needed because we cannot land the kernel change at the same time as new Chrome build. After new ChromeOS build contains these CLs, this patch should be reverted. Bug: 819930 Test: Play VP8/VP9 video on veyron_jerry w/o CL:1134934 and CL:1136336 Test: Play VP8/VP9 video on veyron_jerry w/ CL:1134934 and CL:1136336 Test: Play VP8/VP9 video on kevin w/o CL:1134934 and CL:1134929 Test: Play VP8/VP9 video on kevin w/ CL:1134934 and CL:1134929 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I293464d85c4ca28fd3413b89e77e242c0a7648c0 Reviewed-on: https://chromium-review.googlesource.com/1134933 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#578981}
-
Koji Ishii authored
This patch uses UniteIfNotZero, which incorporates rects if either width *or* height is not zero, to compute LinesBoundingBox for LayoutInline and LayoutText. Using regular Unite, which incorporates rects if width *and* height are not zero, ignores zero-width rects such as empty inline or <br>. The name and logic are ported from LayoutRect to NGPhysicalOffsetRect. This patch fixes two tests, but also require ~300 text rebaselines because heights of such LayoutInline, LayoutText, and their subclasses (such as <br>) are changed. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6488c074dedad71ae5f46fb366ee4a2b9d3cdca5 Reviewed-on: https://chromium-review.googlesource.com/1154240Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578980}
-
Darren Shen authored
In a previous patch, we removed shadows for both docked and floating keyboard so that IME can draw them. Unfortunately, this means that KeyboardController no longer knows which area of the keyboard is the shadow and which is the actual UI, which breaks things like overscrolling. A fix would be to make IME indicate what the actual occluded bounds are through setOccludedBounds. Unfortunately, setOccludedBounds has several problems (e.g. what happens when occluded bounds and visual bounds go out of sync, e.g. when the screen is rotating). This requires some additional thought. So in the meantime, we just draw shadows only for docked mode. This will at least unblock the new UI while we find a permanent solution. Bug: 867775 Change-Id: Iebd8f5edfeac5643fe837b672bf65dab5bfcdb4d Reviewed-on: https://chromium-review.googlesource.com/1152328 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#578979}
-
Kenichi Ishibashi authored
Looks like this test doesn't exist. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I858e13708663f143b56e390af91702d2d3b71492 Reviewed-on: https://chromium-review.googlesource.com/1154610Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578978}
-
Kenichi Ishibashi authored
Update tests for ServiceWorkerControlleeRequestHandler to have better coverage with S13nServiceWorker enabled/disabled. Bug: 860361 Change-Id: Ie4b915fd2aea96afc9880c759d4bcdb82d320892 Reviewed-on: https://chromium-review.googlesource.com/1151070 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Nicholas Verne authored
If Crostini is disabled by policy, IsCrostiniEnabled will now return false. Bug: None Change-Id: I4eb93223c7b3f65280e171f04895a8942186af51 Reviewed-on: https://chromium-review.googlesource.com/1152641Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578976}
-
Timothy Loh authored
This CL adds some tests for the linux package install flow in the File Manager. It also fixes a bug in the CrostiniManager where package progress observers were not correctly removed, as discovered by these tests. Bug: 868221 Change-Id: I2b6adf2530ff43a0b22fe2b552bb877f98fd61c7 Reviewed-on: https://chromium-review.googlesource.com/1152643Reviewed-by:
-
Han Leon authored
This CL is the 1st step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: - Remove the typemapping of blink.mojom.FetchAPIResponse. The mojom struct blink.mojom.FetchAPIResponse describes a Response in terms of the concept from the Fetch spec, currently it's defined under blink/public/platform/modules/fetch/ and is used only by Cache Storage API implementation (by both Browser and Renderer code), as this struct meets the 2 conditions below, it should be fine to go into blink/public/mojom/: - it is expected to be used by both Browser and Renderer code. - it is expected to be passed over Mojo between Browser and Renderer (Blink). But, currently for Chromium Mojo binding variant it is typemapped to content::ServiceWorkerResponse being used in content/browser/cache_storage/, this blocks it being moved to blink/public/mojom/. So we need to remove this typemapping first, this removal also helps reduce 1 user of content::ServiceWorkerResponse. 2nd step: Now we can just move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/, which makes the next steps possible. 3rd step: - Use blink.mojom.FetchAPIResponse to represent the response a service worker provides to FetchEvent#respondWith. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse in content/common/service_worker/service_worker_fetch_response_callback.mojom. Thus we can reduce another 1 user of content::ServiceWorkerResponse. More importantly, this makes it possible for us to move service_worker_fetch_response_callback.mojom into blink/public/mojom/service_worker/ in future. 4th step: - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: Ibae19bcac50688360426ef8b736a3841ca59ff39 Reviewed-on: https://chromium-review.googlesource.com/1134731Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Joel Hockey authored
Change-Id: I496c4bd6f0c6cf87dee2a8af7e473160098fa082 Reviewed-on: https://chromium-review.googlesource.com/1154616Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#578973}
-
Tetsui Ohkubo authored
Some feature pod buttons have same action for both the icon and the label. In such case, the label button should not be included in keybaord focus chain. TEST=manual BUG=none Change-Id: I1e2c87c5bfdc18ce4ca233807e94053313e9830d Reviewed-on: https://chromium-review.googlesource.com/1152716Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#578972}
-
Makoto Shimazu authored
This CL adds MimeSniffingThrottle which can intercept the response in ThrottlingURLLoader. Typically mime sniffing happens in network::URLLoader and MimeSniffingThrottle is skipped in this case. If a request goes to a service worker or other interceptors, the MimeSniffngThrottle intercepts the response when a set of the mime type and the url is eligible to sniff the mime type. Sniffable mime types are defined in net::ShouldSniffMimeType(). When a mime type for performance sensitive components like "text/html", "text/javascript",or "text/css" is provided, it doesn't sniff. Bug: 858975 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib6e5b29867494fc0c0876952b4fec2a141288b36 Reviewed-on: https://chromium-review.googlesource.com/1141744Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I89871b65dbe2f2b5202a079f4c4e54c637cf672f Reviewed-on: https://chromium-review.googlesource.com/1154688Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578970}
-
Jiajia Qin authored
Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib373b6797b780c0294fef471fae7bb7a9deac39a Reviewed-on: https://chromium-review.googlesource.com/1149711Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#578969}
-
Tetsui Ohkubo authored
This CL adds dedicated tooltip strings to feature pod buttons in UnifiedSystemTray. As a feature pod button has two click targets, we have two tooltip strings per each. These strings are approved by UX: http://shortn/_HCw1PLpXw1 TEST=manual BUG=none Change-Id: I76a527d5bbdbe06a8365607e1aa304af50b03c37 Reviewed-on: https://chromium-review.googlesource.com/1152747Reviewed-by:
-
Yuki Awano authored
Bug: None Test: None Change-Id: Ie1241763c6984de48ebaa9d99807489a3e31616e Reviewed-on: https://chromium-review.googlesource.com/1149425 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578967}
-
Makoto Shimazu authored
The service worker has a simple fetch handler which returns a response fetched from the service worker. Bug: 853085 Change-Id: I605a495da3657017e0c43cef63499a523b225f69 Reviewed-on: https://chromium-review.googlesource.com/1152757Reviewed-by:
-
Alan Cutter authored
This CL forces Windows 7 to use the OpaqueBrowserFrameView (instead of GlassBrowserFrameView) for hosted app windows. This is in preparation to consistently support extra hosted app controls in the title bar before we have implemented support for Aero glass titlebars. This change is hidden behind the DesktopPWAWindowing flag. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350562&signed_aid=YMSTIPY7Xl2vwJUHiVXzPw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=350563&signed_aid=XwsCSHyIFeGdrm_6R_PkVQ==&inline=1 Bug: 854479 Change-Id: I3232648004ff7b32657afa127fe76924aa4f2950 Reviewed-on: https://chromium-review.googlesource.com/1152722Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578965}
-
Kenichi Ishibashi authored
These tests are timing out only on msan bots. Move these entries to MSANExpectations so that we can make sure these tests pass on linux bots. Bug: 866965, 856601 Change-Id: I48d15a00a508c989865ebba2fa88987ddcd46c80 Reviewed-on: https://chromium-review.googlesource.com/1154609Reviewed-by:
-
