- 22 Aug, 2018 22 commits
-
-
Kyle Horimoto authored
This CL adds: (1) Four .png files (two icons in both 1x and 2x sizes). (2) Three .svg files. Bug: 870111, 824568 Change-Id: I39f2a24f128a63ee081629eaa755b9fbea1ef4db Reviewed-on: https://chromium-review.googlesource.com/1184332Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#584950}
-
David Black authored
Ideally we would not have an empty query, but we should still handle that case for now to avoid an ugly UI state. See bug for additional details. Bug: b:112908989 Change-Id: I450c7624221646d3edd440ae355f92a8516a0930 Reviewed-on: https://chromium-review.googlesource.com/1184101 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584949}
-
Ryan Hansberry authored
Before Smart Lock or Better Together Suite can be enabled, the user is prompted to confirm their password. The auth token that is generated by the process is then passed along to MultiDeviceSetupService. For other features which don't require authentication, simply call out to MultiDeviceSetupService with no auth token. This CL always requires Better Together Suite enabling to be an authenticated request. However, that's really only necessary in the case that the Smart Lock user pref is enabled. A follow-up CL will remove this unnecessary authentication requirement; see crbug.com/876377. Bug: 870122 Change-Id: I95056000a3dccf27c4d62329d7f04a737f1e1c4a Reviewed-on: https://chromium-review.googlesource.com/1184025 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#584948}
-
Devlin Cronin authored
Break up extension API bundle generation into two targets separate gn templates: generated_json_strings and function_registration. This simplifies the flow of control within the template, as well as the number of bespoke arguments that the template needs to be invoked with. With this, each of the json_schema_api generating actions are now separate. Bug: 864576 Change-Id: I126e2f746137b89ac879e35252a16667f2f4367d Reviewed-on: https://chromium-review.googlesource.com/1170427Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584947}
-
Yi Gu authored
Previously we have to force compositing the animated target for worklet animations. Given that the target with worklet animations has been composited automatically after crrev.com/c/930128, there is no need to keep the force composition in the test. Change-Id: I5effd169844e0c08a3578b35ccacf886965fce37 Reviewed-on: https://chromium-review.googlesource.com/1167988Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584946}
-
Ken MacKay authored
Bug: internal b/112780630 Test: on device Change-Id: I5b9b3a603214e65d3f59ede534858fe11cd6a8ae Reviewed-on: https://chromium-review.googlesource.com/1184208Reviewed-by:
-
Kevin Marshall authored
Adds support for Reload()ing a chromium::web::Frame. * Browser test added to verify the resulting navigation event and network request. * Minor cleanup in context_impl_browsertest.cc Bug: 852145 Change-Id: Ie7893b49e0872bb4b1a4c57b972d9c5f75a2ee34 Reviewed-on: https://chromium-review.googlesource.com/1180519Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584944}
-
Ryan Hansberry authored
Only move forward with the SetFeatureEnabled() and SetHostDevice() methods if a valid AuthToken is provided. Bug: 870122 Change-Id: I5367490cc28a51ee38161d23ca900b52f9793afc Reviewed-on: https://chromium-review.googlesource.com/1178567 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584943}
-
wutao authored
Settings' window is not registered with MultiUserWindowManager, so it is not handled automatically in multiple users case. This patch registers it to MultiUserWindowManager and handle the shelf icon change. Bug: 872380 Test: manual. Change-Id: I9d451a27099da77c1c36560c608040684018eeb8 Reviewed-on: https://chromium-review.googlesource.com/1184037 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584942}
-
Eugene But authored
This DCHECK will help to diagnose possible URL spoofing bugs in Slim Navigation feature. _documentURL is used as proxy for legacy navigation manager URL, which is generally reliable and almost always match last committed URL. Bug: 1182320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib3773ac80e85ca8d08680d319b0441f44a22cb72 Reviewed-on: https://chromium-review.googlesource.com/1184158Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584941}
-
erikchen authored
Previously, compare_build_artifacts.py only compared certain executables in the output directories. This CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1180706 makes deterministic builder use .isolate files to compare both data files and the appropriate executables. With this change, we've discovered that the data files included in this CL are also not deterministic. Bug: 870731, 330263 Change-Id: Ia02c3f99d35ab690f5a709c0adb987d2820201b5 Reviewed-on: https://chromium-review.googlesource.com/1183999Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584940}
-
erikchen authored
If files are specified by a .isolate and missing, this should be handled like any other error in compare_build_artifacts. It should not throw an exception. Bug: 870731 Change-Id: If29a180539ffa148d5788ac2ecd626205e2eb090 Reviewed-on: https://chromium-review.googlesource.com/1183998Reviewed-by:
-
Mao Huang authored
Original CL: - https://chromiumcodereview.appspot.com/9212025 Support use of third party time function for about:profiler This uses TCMalloc to provide a time function, allowing us to see how much memory was allocated on a single thread during the running of a task. The alternate time function is put in place only when a specific environment variable is detected during TCMalloc startup. This change currently is activated only in Windows/Linux, as it is based on changes TCMalloc (not used on Mac). We also create an infrastructure for using any alternate timer, to replace the "wall clock time," on a per-thread basis, in the about:profiler infrastructure. That interface may be used on other platforms, including scenarios where we have a per-thread-CPU-time function to replace the wall-clock timer. In all cases, when this alternate timer is activated, we lose the ability to calculated queueing time. Queueing time is based on a time snapshot taken on a second thread, and hence is not comparable to the alternate timer (when the alternate timer is engaged). r=rtenneti BUG=103321 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122180 BUG=724399,b:70905156 Change-Id: If2edfa25da30dc05c9ec7f8abf47017d8fce9464 Reviewed-on: https://chromium-review.googlesource.com/1130788Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#584938}
-
Thoren Paulson authored
We used to tear down CastWebContentsActivity when we stop because the user left. This is needed because sometimes we can leave the activity without tearing down, leaving the receiver running without the user seeing it. Bug: internal b/112775688 Test: cast_shell_junit_tests Change-Id: If234a52facb9ea310b8899db0a9bda1a67439cd5 Reviewed-on: https://chromium-review.googlesource.com/1184044 Commit-Queue: Thoren Paulson <thoren@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584937}
-
Daniel Erat authored
Now that ChromeFeaturesServiceProvider lives in //chrome/browser/chromeos/dbus, it no longer needs a Delegate interface. Bug: 843392 Change-Id: Ia4b4a737e8cde0b517f6975994238dc8f03fec1a Reviewed-on: https://chromium-review.googlesource.com/1184168Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584936}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Idac6a13a32465359102228499e05238da53a5e97 Reviewed-on: https://chromium-review.googlesource.com/1111468 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584935}
-
Anand K. Mistry authored
BUG=845393 Change-Id: I5c2f1cb68810596ade3c780658fddfcde2d9578b Reviewed-on: https://chromium-review.googlesource.com/1182915Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#584934}
-
Sky Malice authored
Bug: 876449 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib42fb716d79f95370f060af0a43fca7cb3288900 Reviewed-on: https://chromium-review.googlesource.com/1184141Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584933}
-
Hans Wennborg authored
It contains 'tail' in addition to the contents of gnuwin-7, to be able to run some tests that were updated in r339475. NOTRY=true Bug: 876139 Change-Id: I447d79591b01de309b258a54a37cb5603599201b Reviewed-on: https://chromium-review.googlesource.com/1183909 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Daniel Erat authored
Now that VmApplicationsServiceProvider lives in //chrome/browser/chromeos/dbus, it no longer needs a Delegate interface. Bug: 843392 Change-Id: I1c9a0cf0a251d12bf3a0c33a58b0d6e177859618 Reviewed-on: https://chromium-review.googlesource.com/1184142Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584931}
-
Alexander Alekseev authored
This CL splits CreateOobeUIDataSource into several smaller functions. Bug: 864686 Change-Id: I6843595bf66a9584778fa5ebbff8167a0ce605d2 Reviewed-on: https://chromium-review.googlesource.com/1182608 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Sky Malice authored
This reverts commit d184f073. Reason for revert: Speculative revert to fix net_unittests BUG: 876563 Original change's description: > Add NetLog events for cookie blocking by NetworkDelegate > > Cookies setting and getting can be blocked by a NetworkDelegate. > This CL adds NetLog events so they can aid in the investigation of cookies bugs. > > Bug: 875849 > Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7 > Reviewed-on: https://chromium-review.googlesource.com/1181244 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584809} TBR=mmenke@chromium.org,xunjieli@chromium.org Change-Id: Ifbfcf98ec819cda47cb04e4c87e6274db0e93579 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875849 Reviewed-on: https://chromium-review.googlesource.com/1184274Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584929}
-
- 21 Aug, 2018 18 commits
-
-
Tom Anderson authored
BUG=876451 R=pkasting Change-Id: I2be8079b64ef0f05fbb740dc99562f44a1734fab Reviewed-on: https://chromium-review.googlesource.com/1184045 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584928}
-
Sam McNally authored
Bug: 172187 Change-Id: I0e42fe87ed76a44bff4c2a34065255e9440870a2 Reviewed-on: https://chromium-review.googlesource.com/1180822Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#584927}
-
Adam Langley authored
(Webauthn will need to parse an extension out of the token attestation certificate.) Change-Id: I24c3bc63bd190e6bfc4faeb02b8acf7fd0883b74 Reviewed-on: https://chromium-review.googlesource.com/1179231Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#584926}
-
Cole Winstanley authored
This reverts commit 1ffe88a7. Reason for revert: Causing ChromeDriver waterfall issues Original change's description: > [ChromeDriver] Add replay end-to-end tests to run_all_tests.py > > This change adds the end-to-end tests for the client replay component > of ChromeDriver to the ChromeDriver waterfall by incorporating them > into the existing run_all_tests.py. This will extend the waterfall > coverage to include the ChromeDriver log-replay component. > > Bug: chromedriver:2501 > Change-Id: I6e35675d2598a2a33c67340e0ee73e05201c3439 > Reviewed-on: https://chromium-review.googlesource.com/1174894 > Commit-Queue: Cole Winstanley <cwinstanley@google.com> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584518} TBR=crouleau@chromium.org,johnchen@chromium.org,cwinstanley@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:2501 Change-Id: I6f0eec4d77b0608a38b9ccc4efcacd1b948c8c46 Reviewed-on: https://chromium-review.googlesource.com/1183827Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#584925}
-
Bailey Forrest authored
Bug: internal b/112773799 Test: cast_bluetooth_unittests Change-Id: I988345b574ddbc9ba8f7afc821aac90f56779985 Reviewed-on: https://chromium-review.googlesource.com/1182301Reviewed-by:
-
Mike Wasserman authored
Bug: 722496 Change-Id: I797582085ebaf0c3f63b0eb4ec60d605342c5129 Reviewed-on: https://chromium-review.googlesource.com/1183584Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584923}
-
David Black authored
Per change in product spec, we should no longer anchor to the top of the screen when in tablet mode. We should always anchor to the bottom. Bug: b:112849003 Change-Id: If2ec374fc4ea26377edb2251be5ae445db736c80 Reviewed-on: https://chromium-review.googlesource.com/1182442 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Roberto Carrillo authored
R=tandrii No-Try: True Bug: 872448 Change-Id: Ia12df35141be3e9073167f24bd70fdf02568c66e Reviewed-on: https://chromium-review.googlesource.com/1184249 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584921}
-
Tommy C. Li authored
Without this CL, video streaming from chrome:// does not work. Now it will work for URLs that use the WebUIDataSourceImpl source. This also extends URLDataSource class in general, so other source subclasses may report content size if they wish. <video> only supports unknown length content with http/https. For these other sources, the resources are assumed to be fully buffered. Bug: 866703 Change-Id: I826b2fa1a732c6f99f37b5df3603658a5b5b8165 Reviewed-on: https://chromium-review.googlesource.com/1173497 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#584920}
-
Yuki Awano authored
- Initially ExoShellSurface has both focus and active state. But when user clicks something on Android window, ExoSurface becomes focused. We need to use ExoShellSurface to get the widget. This CL changes it to use active window instead of focused one. click maximize button. Confirm that Chrome doesn't crash. Bug: 867199 Test: Enable S2S and open Play Store app. Focus on the search box and Change-Id: I74e363e2ee91986966a97a12f7cdb5399721f6cf Reviewed-on: https://chromium-review.googlesource.com/1183046Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#584919}
-
Li Lin authored
Bug: b:110107505 Change-Id: Ie642268b7bab2abd867bae2d5e1ad85b29459aa2 Reviewed-on: https://chromium-review.googlesource.com/1182667Reviewed-by:
-
Eric Karl authored
Currently DisplayScheduler reports damage to SurfaceManager in any case where a damaged surface ID damages the display. While these cases will trigger a draw when visible, they don't necessarily trigger a draw in any defined timeframe. This can lead to issues. Consider: 1) Display 1 is not visible, embeds surface A. 2) Surface A sends CF 1, we don't immediately ack as we will wait for Display 1 to draw. 3) Display 2 becomes visible, embeds surface A with a new surface ID. 4) Display 2 will never update, as no new frames will be produced for surface A as the renderer is continually waiting on the ack for CF 1. By having DisplayScheduler report no damage if invisible, we always ack frames in a timely manner. This may allow a renderer to produce some extra frames when its display is invisible, but this should be limited as the renderer itself receives visibility notifications and won't get additional BeginFrames once visibility is fully processed. Bug: 875895 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I272de950d8e4d4c819c445dc8162ac360afb80a1 Reviewed-on: https://chromium-review.googlesource.com/1182862Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584917}
-
David Black authored
This involved: - Limiting conversation starter count to 3. - Shuffling and selecting conversation starters to reach 3. - Refreshing conversation starter cache for new UI sessions. - Center aligning conversation starters (but keeping suggestion chips for interaction responses start aligned). Bug: b:111694337 Change-Id: I1b5b94fabcd0a37ce3a3400a670db4224fc6a667 Reviewed-on: https://chromium-review.googlesource.com/1182863 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Kenneth Russell authored
external/wpt/web-animations/interfaces/Animatable/animate.html http/tests/worklet/webexposed/ global-interface-listing-paint-worklet.html These are the remaining test failures seen on this bot when running with --use-gpu-in-tests. Unfortunately there doesn't seem to be a way to specialize these for this device. Bug: 875172 Change-Id: I050b131b2702987f2e5803ac6e75ea6dfae35b2b Reviewed-on: https://chromium-review.googlesource.com/1183979Reviewed-by:John Budorick <jbudorick@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584915}
-
Kenneth Russell authored
Observed flaky after starting testing on the passthrough command decoder on this configuration. Tbr: geofflang@chromium.org Bug: 872302 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I44700af5fa229f10037435c226f870e306736730 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1184178Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584914}
-
Ryan Hansberry authored
A new people_page/lock_screen_password_prompt_dialog is created that implements lock screen specific logic that previously resided in password_prompt_dialog. Bug: 870122 Change-Id: If1fb68e6b7fd84f91850a169342ab04fb8a75404 Reviewed-on: https://chromium-review.googlesource.com/1179377 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
James Cook authored
We need to distinguish between MultiProcessMash, SingleProcessMash and both (aka IsUsingWindowService). * Power - ML and settings UI * Exo * WebRTC desktop capture * Tabs extension API * Tab dragging * TestBrowserDialog The remaining ones are in browser frame code. Bug: 874468 Change-Id: Iac58a63b518966e781a25a090b58a24b8d2ace95 Reviewed-on: https://chromium-review.googlesource.com/1183790Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584912}
-
Philip Rogers authored
This reverts commit e06da142. Reason for revert: Was not the root cause of test failures. Original change's description: > Revert "Fix background painting on scrolling contents layer with foregrounds" > > This reverts commit 7834ee21. > > Reason for revert: Suspected as causing failing tests in 874162 > > Original change's description: > > Fix background painting on scrolling contents layer with foregrounds > > > > This patch removes a negative z-index children check from > > PaintLayer::GetBackgroundPaintLocation. This lets backgrounds paint in > > the scrolling contents layer in the presence of negative z-index > > children, fixing the painting of background-attachment: local. This > > patch also removes a DCHECK that was hit when a foreground layer and > > kBackgroundPaintInScrollingContents coexisted. This DCHECK[1] could be > > hit for root layers without the functional change in this patch. As the > > test in this patch shows, kBackgroundPaintInScrollingContents and > > foreground layers work together, so this patch makes non-root-layers use > > both, and removes the DCHECK. > > > > What are foreground layers? A foreground layer is created if a stacked > > PaintLayer has composited negative z-index children that should wedge > > between the layer's background and the layer's contents. The foreground > > layer will have the normal-flow contents in this case. See the comment > > above foreground_layer_ in composited_layer_mapping.h. > > > > [1] DCHECK originally added in: https://crrev.com/9a2cdc8d96d. Reading > > the comments, I think the DCHECK was intended to ensure the background > > would not be painted into the foreground layer. > > > > Bug: 861948 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I7409cbe9ac61fed444856df342d0707d6babab09 > > Reviewed-on: https://chromium-review.googlesource.com/1173532 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Commit-Queue: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584802} > > TBR=pdr@chromium.org,chrishtr@chromium.org > > Change-Id: Ifd22a963dbd5ce288dfb31ab1e8ac41ebe63062d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 861948 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1184109 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584895} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: I569313a9d5e1dd0b79e541cc3e3ae8816c4c3e05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861948 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1184181Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584911}
-
