GitLab

Screenshot in bug.

R=dpapad@chromium.org

Bug: 788776
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic4c6123ebdf42e29ec2b2eeeff52c4c3bc00f81a
Reviewed-on: https://chromium-review.googlesource.com/795352
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520233}

Bug: 789215
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b2ab2c062490c21d2b72e2518ff93f8f2f7a801
Reviewed-on: https://chromium-review.googlesource.com/795353
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520232}

When media remoting is forced back to mirroring due to high frame drop
rate or too slow pacing, the existing logic disables media remoting for
the whole life time of RendererController. This CL re-enables remoting
if the media element stops and later re-starts being the dominant
visible content in the tab.

Bug: 789007
Change-Id: I85a7f7921b16fa20d3a1aeda8c509367a0184df8
Reviewed-on: https://chromium-review.googlesource.com/792634
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520231}

This will give us more flexibility in the future on how we process feature names when training. No model with hashed features are in production yet, so this change is safe. The proto on the google3 side will also be updated with this change.

Bug: 786472
Change-Id: I89a9b364533279da9d696a85beeb9794e5ca3d43
Reviewed-on: https://chromium-review.googlesource.com/794855Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520230}

Instead of duplicating the "\0" vs "; " separator logic in
SeparatorForKey(), just call SpdyHeaderBlock::AppendValueOrAddHeader()
directly.  In addition to reducing code duplication, this has the added
advantage that the existing part of the header does not have to be
copied on each append, because SpdyHeaderBlock instead keeps a list of
fragments, which it only assembles on read, thus saving on memory usage
(memory is never freed in the underlying UnsafeArena memory store).

HeaderCoalescer: :AddHeader() that SpdyHeaderBlock already has in
Change-Id: Iab96e2779e3e654765065ca4dbc566306658365a
Reviewed-on: https://chromium-review.googlesource.com/796593Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520229}

The call to ref_at_point was allocating the extra reference
for transferring ref ownership as requested by the method.

Change-Id: I76ed65d75cc136fff7dbaf9c61fad3e3a59f2c47
Reviewed-on: https://chromium-review.googlesource.com/794138Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#520228}

Bug: 776538
Change-Id: I265f3329477f695e437fcb0e41beb8bfc914d0b9
Reviewed-on: https://chromium-review.googlesource.com/796592Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520227}

Bug: 789534
Change-Id: Ice59510e006bcb8b8a70bbac862d52f0e6a3a40e
Reviewed-on: https://chromium-review.googlesource.com/797213Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520226}

Currently, we issue the warning log when webview is created, it is
hard to tell which webview's autofill is disabled, changed to log the
warning when autofill is triggered.

Bug: 
Change-Id: I4fa480db7f8d825f29b980b44c80add732c35407
Reviewed-on: https://chromium-review.googlesource.com/794528Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520225}

Previously we associated the 'composite' property with the Keyframe,
including the default 'replace' value. However the spec differentiates
between the KeyframeEffectReadOnly composite property and additional
keyframe-specific composite properties. This CL updates the code to
properly track these two concepts. Keyframe now has an optional
keyframe-specific composite operation, and the final composite operation
is determined when creating the property-specific keyframes.

Unfortunately due to the way the code is structured this change was
non-trivial. Major changes:

  * KeyframeEffectReadOnly and InertEffect now store a
    KeyframeEffectModelBase rather than an EffectModel, due to the
    need to store and retrieve the 'composite' value.
  * The KeyframeEffectModelBase on KeyframeEffectReadOnly is now
    non-nullable. Previously a null model indicated that a
    KeyframeEffectReadOnly had no keyframes; this is now tracked
    explicitly in the model.

Bug: 785526
Change-Id: I9b4967bf11c010bbd1f61f2d5ced1159fc0dd0c4
Reviewed-on: https://chromium-review.googlesource.com/786292
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520224}

Bug: 780946
Change-Id: If4459c5ce35591b8e3e2a29f5dc856700a464ac7
Reviewed-on: https://chromium-review.googlesource.com/795150
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520223}

This reverts commit d4214b50.

Reason for revert: Possibly causing WebGL failures and other assertion failures.

BUG=789621

Original change's description:
> Don't delete the invalid service id.
> 
> It was possible to put thing in a bad state by calling glBind* with an
> invalid client id (which binds the invalid service id) and then calling
> glDelete* with an invalid client id (which deletes the invald service
> id).
> 
> BUG=785753
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I4628f964e9d14a1d87bc12b1cde3f056acb8314e
> Reviewed-on: https://chromium-review.googlesource.com/791011
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519752}

TBR=geofflang@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 785753
Change-Id: If2343ecb8fd12c8bfc400bffa455de91f0caf8bb
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/797570Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520222}

Fixed. Once and for all.

I SAID FIXED!

Bug: 789473
Change-Id: I5f41023febd34c5e51ddbed9d668c505dedaed3f
Reviewed-on: https://chromium-review.googlesource.com/797612
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520221}

There may be other [audio] permission prompts in the future. This one
should clearly indicate its meaning and match the histogram description.

The histogram name was just added so this should not affect data.

Bug: 779669,788013
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I147a9d214572fac76219125730224ab028a367ef
Reviewed-on: https://chromium-review.googlesource.com/792593Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520220}

This cl transitions to/from showing the dev controls (developer mode)
over time, rather than snapping in/out of view.

Bug: 787220
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b7e8176a284b77a68eced3b346031986340ff72
Reviewed-on: https://chromium-review.googlesource.com/792537Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520219}

This CL add a widget and a root view for Sidebar behind a flag. This is an initial implementation which has only basic feature of sidebar. The detailed behavior will be implemented in succeeding patches.

Design doc: go/cros-sidebar
Mock: go/cros-sidebar-mock (Early State)

Bug: 726250
Change-Id: I3ac1239f8509136eafff16b659e0040e36f702b9
Reviewed-on: https://chromium-review.googlesource.com/748983
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520218}

TBR=amineer@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4c8df544762310bd8e4628b032d7a7c823da2ac7
Reviewed-on: https://chromium-review.googlesource.com/797474Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520217}

BUG=717091

Change-Id: Ie5f53cabef12dd0f8cd4ac368789bb19f381d10c
Reviewed-on: https://chromium-review.googlesource.com/795930Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520216}

When clicking into an iframe, it was the case the the previously focused
element remained focused in the document. This would cause issues for
the frame, for example the iframe element would not be the
document.activeElement if the previous activeElement was anything but
document.body.

BUG=755023

Change-Id: Ibab12e91520e2b9dee5db9eeb0c6c1c61e847928
Reviewed-on: https://chromium-review.googlesource.com/721684Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520215}

BUG=789537
R=sky@chromium.org

Change-Id: I938ca44ab2f5ad87600dba98de257425d30d2f5f
Reviewed-on: https://chromium-review.googlesource.com/796415Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520214}

CSSWG resolved back in January 2017 about how percentage rows
in a grid container with indefinite height work, to make them symmetric
to what happens for columns. Which has been ratified in the last
F2F meeting at TPAC 2017.
All this has been discussed in the following issue:
https://github.com/w3c/csswg-drafts/issues/1921

No browser is doing that right now, so it'd be nice to gather some data
about the usage of this before changing the implementation.
For that reason this patch adds a new use counter to check
when this change will have impact on real websites.

Change-Id: I61b82957d2bfe53912fd3e53a6bd41a6491a67be
Reviewed-on: https://chromium-review.googlesource.com/796855Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#520213}

|unclippedLocation| is the location of the node if it were not
clipped by any of its ancestors. This is now used by ChromeVox
to determine navigation by line, rather than the clipped
location.

This change reverts bf576717, submitted in
https://chromium-review.googlesource.com/c/chromium/src/+/777541,
which disabled clipping until the fix could be added.

Bug: 788810
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50d4df7364c32384ccfb06a04b226afce67eb091
Reviewed-on: https://chromium-review.googlesource.com/794511Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie D <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520212}

We wouldn't invalidate as needed if the 'transform-box' property changed
its value.

Bug: 595829
Change-Id: Ibcaa9e94b54b99724f2d3e1ca5dedd868d85b776
Reviewed-on: https://chromium-review.googlesource.com/796213Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#520211}

Bug: 789612
Change-Id: Ic81a3a20bb6bbbec72d49e76163a781752aa1605
Reviewed-on: https://chromium-review.googlesource.com/797532
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520210}

Following bot results are included.
2294 2296 2297 2305 2307 2310 2311 2314 2317

3 lines were removed by consecutive passes since 2282.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Change-Id: Ib2b5692acfc316320d6ab236cd46caefd109860d
Reviewed-on: https://chromium-review.googlesource.com/797551
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520209}

Also implements adding and removing of devices after initialization.

Bug: 695937
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I70ff4085242720f135da3d3cd51dd99dcbd7492c
Reviewed-on: https://chromium-review.googlesource.com/789652
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520208}

base/memory/shared_memory_posix.cc was especially confusing because on
iOS it was removed and then re-added to the sources list.

Change-Id: I689911144a6116e1129b2ecb5e9b90db791a7e8f
Reviewed-on: https://chromium-review.googlesource.com/794450Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520207}

This was caused by accessing an uninitalized reader.

Bug: 
Change-Id: I99c9f01dff53262ad825bdea353857fc7e78e4fd
Reviewed-on: https://chromium-review.googlesource.com/797310
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520206}

Introduced recently by https://chromium-review.googlesource.com/756711
  "Wrap X11 headers in ui/gfx/x/x11.h"

Build error 1:
  media/gpu/vaapi/vaapi_tfp_picture.cc:
    error use of undeclared identifier 'RootWindow'; did you mean 'XRootWindow'?
      x_pixmap_ = XCreatePixmap(x_display_, RootWindow(x_display_, screen),

Build error 2:
  In file included from ../../media/gpu/vaapi_video_decode_accelerator_unittest.cc:14:
  error: expected unqualified-id
    /usr/include/X11/X.h:115:30: note: expanded from macro 'None'

Bug: 782184
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1b1ecf39baee160e1778e5cdd596426a63e4e054
Reviewed-on: https://chromium-review.googlesource.com/788111Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520205}

BUG=788275

Change-Id: Ied2077ce95dd3a0eb1d97ebf5f063c1da4975025
Reviewed-on: https://chromium-review.googlesource.com/792633
Commit-Queue: James Zern <jzern@google.com>
Reviewed-by: James Zern <jzern@google.com>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520204}

Bug: 787743, 785711, 782134
Change-Id: I77fe9a7192697ebe82734231ae709c2094b57b62
Reviewed-on: https://chromium-review.googlesource.com/791813
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520203}

This CL removes -rootViewController in geolocation in an alert that says
"Get a better Google experience in Chrome based on your location".
Using -rootViewController breaks when presenting the BVC since it is
no longer the rootViewController.

While we would like to remove TopPresentedViewController() as well as
rootViewController, this alert is a special case where the alert
can be presented above any window. In the future, this may be replaced
by the OverlayService.

Bug: 785316
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I26832f3aeaf9eefdbb9a8296e05ac5676438cc1b
Reviewed-on: https://chromium-review.googlesource.com/791503
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520202}

*sigh*. On some devices running Android O, a window animation that fades
between a stale frame and the current frame run when the activity is
shown. This leads to 2D UI being shown when entering VR, which is bad.
To avoid this, we cancel our animation that keeps the activity hidden
only after the Window animation has completed.

Bug: 774755
Change-Id: Idbb08bc9d72ff862d1eafc5c0fb952b287a942dd
Reviewed-on: https://chromium-review.googlesource.com/797294Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520201}

Prior to this change visible passwords were bound to a specific row in
the list of passwords. This led to bugs when the list changed, e.g. when
adding or deleting a password, or changing the list of passwords with a
search filter.

This change fixes this by grouping the password and the UiEntry into a
newly introduced typedef.

Bug: 786312, 771126
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I25751d6a20b315290f2c52cc76946f85c413405f
Reviewed-on: https://chromium-review.googlesource.com/779179Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520200}

https://chromium.googlesource.com/catapult.git/+log/c5bfbbc86903..81d3bd9213f4

$ git log c5bfbbc86..81d3bd921 --date=short --no-merges --format='%ad %ae %s'
2017-11-28 benjhayden Fix "View Options" dropdown in trace viewer.
2017-11-28 rmcilroy [Metrics] Avoid collecting sub-group events in RuntimeStatsMetric.

Created with:
  roll-dep src/third_party/catapult
BUG=786988


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iec704d0f260deb823313dd427b4d2bfb14c034b7
Reviewed-on: https://chromium-review.googlesource.com/797472
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520199}

There's no additional functionality for DocumentResourceClient. Just use the
base class.

Bug: 789198
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ied4815fbba70bb6b7e4e856d654c9d2d6035e446
Reviewed-on: https://chromium-review.googlesource.com/792000
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520198}

If the user tries to view or copy passwords in Chrome on Android, the
settings page asks them to reauthenticate. The explanation on the
reauthentication screen is currently confusing, telling the user that
they need to reauthenticate to "continue setting up [their] phone".

This CL changes that message to mirror better the user's original
intention, mentioning copying or viewing as appropriate.

The change has no test. While the instrumentation tests are able to trigger the
reauthentication screen, there seems to be no way to read UI elements on that,
because it is being rendered by Android and not by Chrome.

Bug: 788749
Change-Id: I06c25c837606aa427cb5cb6db39e8e3fbeb5aa07
Reviewed-on: https://chromium-review.googlesource.com/796630
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520197}

Currently all RenderFrameImpls call RegisterRenderFrame on the
RenderView, and additionally, out-of-process iframe RFIs call it on the
RenderWidgets that they own.

This is incorrect for local child frames of OOPIFs, because they need
to register with the OOPIF's RenderWidget also.

This patch corrects and simplifies RenderFrameImpl widget registration,
making all of them register with their associated widgets after their
WebFrame is created, and unregister just before their WebFrame is
destroyed.

Bug: 770622
Change-Id: I51be01147d3a810bf6e6c0214150b3714ea1c181
Reviewed-on: https://chromium-review.googlesource.com/791071
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520196}

Adds a discussion about the need for client-side checks, and
corrects the description of parameters to match the current
code.

Change-Id: I6687c4c6ce12296ccb2ebfebe98e46a75afb8d64
Reviewed-on: https://chromium-review.googlesource.com/797372Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520195}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c1a3627c..c03152cb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I2cd61e1976d94a667fa15f68f5bb441af468fd33
Reviewed-on: https://chromium-review.googlesource.com/796934Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520194}