- 03 Jan, 2019 33 commits
-
-
dstockwell authored
Bug: 902646 Change-Id: I397bc8d7043ce3a911bfdd5139381f4cae7599bf Reviewed-on: https://chromium-review.googlesource.com/c/1393123 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#619571}
-
dstockwell authored
This will allow the ink component to be unloaded and will prevent any of its globals from intefering with the PDF viewer. Covered by existing tests in annotations_feature_enabled.js Bug: 902646 Change-Id: Ie45067d95df2d91441516714b04e6e5f4f3e459d Reviewed-on: https://chromium-review.googlesource.com/c/1392702Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a70cce175222..479562cc0b31 Created with: gclient setdep -r src-internal@479562cc0b31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6590331a1e22dda7f16f7413766da3bd133d6539 Reviewed-on: https://chromium-review.googlesource.com/c/1394223Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619569}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/392ae31831b7..46a3ae6dffc6 git log 392ae31831b7..46a3ae6dffc6 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 cepheus@frii.com Update copyright years. 2019-01-03 cepheus@frii.com Include the new spv.d file when fixing line endings on Windows. Created with: gclient setdep -r src/third_party/spirv-headers/src@46a3ae6dffc6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I467e0560e7edbad2ef8fc1cc2894133d3d788e84 Reviewed-on: https://chromium-review.googlesource.com/c/1394224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619568}
-
Dan Beam authored
This CL was generated with: $ eslint --fix chrome/browser/resources $ git cl format --js Note: there are some annoying edge cases that mess up formatting. Specifically: if (blah) // trailing comment <do something> is transformed by eslint --fix into: if (blah) // trailing comment { <do something> } and all other types of things start to get funky. TBR=aee@chromium.org Bug: 916782 Change-Id: I03b591da917d5315616bf5e31566733771dc168c Reviewed-on: https://chromium-review.googlesource.com/c/1393944Reviewed-by:Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619567}
-
edchin authored
This CL simply removes unused/dead code from snapshots. Change-Id: I23d7eebea71d1db42057b5b06750d76fc2081bd0 Reviewed-on: https://chromium-review.googlesource.com/c/1392265Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619566}
-
edchin authored
The default snapshot image is a simply a 2x2 white pixel image. This image is unnecessarily passed around and unnecessarily complicates code. This CL removes use of a default snapshot image, and updates the API contract to use nil as the sentinel value for failed retrieval or generation. Bug: 918032 Change-Id: Ie7d8312cad6d05912474c6205c1bbb4ec9d242e0 Reviewed-on: https://chromium-review.googlesource.com/c/1392264Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
edchin authored
Snapshot coalescing is dead code. It is only enabled when the user enters the tab switcher. A lot of code around entering the tab switcher has changed since this coalescing code was first written. It is no longer the case that multiple snapshots are taken during the transition. Additionally, snapshots are now asynchronous and do not block the UI. This CL removes the dead snapshot coalescing code. Bug: 918032 Change-Id: I766e6b8546c785d9ba25e36c329504cdce7208e4 Reviewed-on: https://chromium-review.googlesource.com/c/1392261Reviewed-by:
-
edchin authored
This CL improves snapshots with the following changes: 1) Snapshots are taken earlier when entering the tab switcher. Snapshots are now taken at the earlier TouchDown event rather than the later TouchUpInside event. This is where the tab grid cells are prepared, so the snapshot is needed at this time. 2) Snapshots are now taken when entering the tab switcher while the page is still loading. Metrics show that 30% of tab switcher entries are while the page is still loading. Previously, we disabled snapshotting while the page is still loading so as to prevent stale snapshots. That means 30% of tab switcher transition animations resulted in a blank snapshot. This CL enables snapshotting in these cases. The page will continue to load even while the tab switcher is shown and will successfully update the snapshot in the tab switcher. 3) Snapshots are no longer removed from the cache when a page begins to load. This supports #2 above. However, snapshots are now removed from the cache when snapshot attempts fail. This ensures that a stale snapshot isn't kept around to retrieve. 4) Histogram metrics at tab switcher entry are updated to capture two dimensions: a) whether the page was loading or not at that time, and b) whether the snapshot was successful. 5) Histogram metrics are added to understand whether stale snapshots are successfully updated at page load. Stale snapshots are defined as snapshots of a previous page, when a new page is loading. Bug: 918032 Change-Id: Ibb1cd267ca37cbd066e047742300967c57ce7962 Reviewed-on: https://chromium-review.googlesource.com/c/1391713 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5dee56f39c42..d238bb67a52a git log 5dee56f39c42..d238bb67a52a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jiawei.shao@intel.com Support using a layer of a texture as a color attachment on OpenGL Created with: gclient setdep -r src/third_party/dawn@d238bb67a52a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2565ffe5f18802812210c0917933f0af7a4dfbde Reviewed-on: https://chromium-review.googlesource.com/c/1393925Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/534e18423b9c..1d110aee1f7a git log 534e18423b9c..1d110aee1f7a --date=short --no-merges --format='%ad %ae %s' 2019-01-02 pprabhu@chromium.org chromeos_config: Stop running HWTests from link-paladin 2019-01-02 jclinton@chromium.org Add Emacs elisp to automate finding compile command Created with: gclient setdep -r src/third_party/chromite@1d110aee1f7a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic18546f18838ed172632ad7db4530ba408708814 Reviewed-on: https://chromium-review.googlesource.com/c/1393924Reviewed-by:
-
Chris Lu authored
Adds class that defines public //ios/web API for FindInPageManager. Bug: 894651 Change-Id: Ie1f750e6ea8953bcbb169bc4c957a6946b217d8f Reviewed-on: https://chromium-review.googlesource.com/c/1387696 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#619560}
-
Lukasz Anforowicz authored
This gives extension authors a way to test whether their extension is ready to be removed from the allowlist. Bug: 846346 Change-Id: Ide112dab32076ac2a554115b7ca815a23385050c Reviewed-on: https://chromium-review.googlesource.com/c/1368783 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619559}
-
Istiaque Ahmed authored
Bug: None Change-Id: I8b5c88b97f0214298264d57212e5aa3b18a31d2d Reviewed-on: https://chromium-review.googlesource.com/c/1387984Reviewed-by:
-
Daniel Ng authored
Modified Crostini registry to store exec data of apps and updated AppSearchProvider to add exec to the searchable words field. Updated the appropriate test files to also test for this new case. Bug: 849936 CQ-DEPEND=CL:1381311 Change-Id: Ice016099aa10a42dabb788c7ae4f05e35b036477 Reviewed-on: https://chromium-review.googlesource.com/c/1382658 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619557}
-
Wez authored
Update the run_all_tests.cc for Blink's heap tests to derive from base::TestSuite and override Initialize/Shutdown to provide the expected environment for the heap tests. Bug: 918724 Change-Id: I3c9bab5e07b828e04473ad61d0dc380f60d34c60 Reviewed-on: https://chromium-review.googlesource.com/c/1393893Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619556}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbd8fc1f9fa4..a70cce175222 Created with: gclient setdep -r src-internal@a70cce175222 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id71543b5f469a205da6aca3dca7010188fc08c60 Reviewed-on: https://chromium-review.googlesource.com/c/1393357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4618b86e9e4b..392ae31831b7 git log 4618b86e9e4b..392ae31831b7 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 johnkslang@users.noreply.github.com Merge pull request #87 from rtbo/dlang Created with: gclient setdep -r src/third_party/spirv-headers/src@392ae31831b7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia712ff4d3bccbe1bfec57a7c68dce03e7b7ced7e Reviewed-on: https://chromium-review.googlesource.com/c/1393926Reviewed-by:
-
Dan Beam authored
This CL was generated with: $ eslint --fix ui/webui $ git cl format --js Note: there are some annoying edge cases that mess up formatting. Specifically: if (blah) // trailing comment <do something> is transformed by eslint --fix into: if (blah) // trailing comment { <do something> } and all other types of things start to get funky. R=aee@chromium.org BUG=916782 NOPRESUBMIT=true # for __lookupGetter__ in cr.js Change-Id: I2698d8c17ee06dac0688aa55d783f7978f587663 Reviewed-on: https://chromium-review.googlesource.com/c/1393626 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#619553}
-
khmel@chromium.org authored
We are 2+ years using shelf pins supported by sync. Now we can drop import from prefs code. As a side effect this fixes several DCHECKs. This also makes pin positions for default apps and apps, pinned by policy deterministic and not-dependent from installation order. TEST=Locally + unit_tests. Logic of unit tests is not changed. BUG=918203 BUG=907221 Change-Id: I11d1cd7f1f0192719b48adfd3fa9e56c9dc1429b Reviewed-on: https://chromium-review.googlesource.com/c/1392280 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619552}
-
Peter Kotwicz authored
This CL changes the names of methods which search for a WebAPK which matches a given URL to make it clearer what the return value is if there are several matching WebAPKs. Changed method names in WebApkValidator: queryWebApkPackage() -> queryFirstWebApkPackage() queryWebApkResolveInfo() -> queryFirstWebApkResolveInfo() findWebApkPackage() -> findFirstWebApkPackage() findWebApkResolveInfo() -> findFirstWebApkResolveInfo() BUG=None Change-Id: I2a1bb3042f93fb6f465cd069f672bfca57acb7f9 Reviewed-on: https://chromium-review.googlesource.com/c/1390320 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619551}
-
Daniel Rubery authored
The crash in http://crbug/915037 appears to have been fixed, so this CHECK is ready to be removed. Bug: 915037 Change-Id: I1b09c308287e3ef6d411b60378f08f334c8396e3 Reviewed-on: https://chromium-review.googlesource.com/c/1393884 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619550}
-
Aidan Wolter authored
Bug: None Test: None Change-Id: Ib9daa3f4e144c3c7b62d7d472cb631f2e6db41a5 Reviewed-on: https://chromium-review.googlesource.com/c/1393892Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#619549}
-
Xiaocheng Hu authored
When NextLinePosition() reaches block boundaries, it uses NextLeafWithSameEditability() to search forward in DOM tree to look for an appropriate starting node in the next block. The function performs editability adjustment by itself that, and uses the editability of the starting node, which is the last node in the last block, which is incorrect as shown in the new test case. This patch fixes the problem by specifying the correct editability. Bug: 906148 Change-Id: I0d62212209a900ec26ba5b3bfbc6d1873dba02d7 Reviewed-on: https://chromium-review.googlesource.com/c/1392257 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#619548}
-
Wez authored
User input is now received via the Scenic session, so remove the legacy InputConnection path for those events. Bug: 900428 Change-Id: Ifcbb04c52cf517fe8f472854d5736625ff1a87d5 Reviewed-on: https://chromium-review.googlesource.com/c/1393705Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619547}
-
chuanl authored
This is guarded by the CCTModuleCustomHeader Finch feature. Bug: 882404 Change-Id: I2a7675b95d2135b602f89b26a5d9220677d9079a Reviewed-on: https://chromium-review.googlesource.com/c/1386428Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#619546}
-
Toni Barzic authored
SigninExtensionsDeviceCloudPolicyBrowserTests were opening a browser window in Sign-in profile and running the test code in that context. In general, browser windows should not be used in sign-in profile, so we should not rely on this behavior in tests. The test code is moved to the test extensions background page, and run on runtime.onInstalled event (which should be dispatched on each extension install event - note that running the tests in event listener is not strictly necessary, but it gives better indication of the reason the background page is loaded). Given that in sign-in profile, background hosts are not allowed for non-policy installed extensions, the test is updated to set up policy to force install the test extension (which is packed into a CRX, which is added to test data dir). Furthermore, the test extension is transformed to an app, and whitelisted using whitelisted-extension-id switch. This makes ScopedSigninScreenPolicyProviderDisabler unnecessary. PreinstalledSigninExtensionsDeviceCloudPolicyBrowserTest is dropped, and the component policy caching is tested by running sign-in extension device policy tests in two parts: * first, PRE_ManagedStorage test downloads the component policy from the tests server and runs the test extension (matches the logic in replaced InstallAndRunInWindow test) * the second, ManagedStorage test verifies that the downloaded policy is cached and usable after restart by throttling the component policy download request. BUG=916859 Change-Id: Ia0748c2914649ea439664d748aca0bd5461a397f Reviewed-on: https://chromium-review.googlesource.com/c/1379702Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#619545}
-
Chris Harrelson authored
This is because change of stacking may result in a change of the size or position of a composited layer. Bug: 916896 Change-Id: I44d42efc84df892c9e6cbf04f9dcb9ee34a803d9 Reviewed-on: https://chromium-review.googlesource.com/c/1392363Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619544}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bba675db3eb4..c63ddb2a3f9a git log bba675db3eb4..c63ddb2a3f9a --date=short --no-merges --format='%ad %ae %s' 2019-01-02 amithi@webrtc.org Negotiating Simulcast in the initial offer/answer - Part1. Created with: gclient setdep -r src/third_party/webrtc@c63ddb2a3f9a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I78fd30bb16b9eefb7d01b08f6fea768211d8459a Reviewed-on: https://chromium-review.googlesource.com/c/1393415Reviewed-by:
-
Danan S authored
This reverts commit e775e110. Reason for revert: This is inconsistently crashing demo mode when Android apps are launched on certain devices. Original change's description: > Added UMA metric to count unique apps launched during Demo Mode. > > Bug: 904564 > Change-Id: I653438bf5244bc98bcb742d9d986b4ea2bd4b40a > Reviewed-on: https://chromium-review.googlesource.com/c/1334563 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609961} TBR=oshima@chromium.org,michaelpg@chromium.org,bcwhite@chromium.org,danan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 917156 Change-Id: I7e8d88541ad5f74fda720425c05816f48e4ba4a8 Reviewed-on: https://chromium-review.googlesource.com/c/1387953Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619542}
-
James Hollyer authored
This change adds a list of notifications that are currently displayed and checks that list for duplicates before displaying a new notification. Bug: 789362 Change-Id: I1f8025dbb237da35b088de5bd6f21e80a1bbec52 Reviewed-on: https://chromium-review.googlesource.com/c/1373436 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619541}
-
liberato@chromium.org authored
Since it turns out to be much easier to record results for a regressor than a classifier, add support for it to ExtraTrees. Change-Id: I0734c81bafd87e06c23df8f74b7a0c4c80d616e6 Reviewed-on: https://chromium-review.googlesource.com/c/1391327 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#619540}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bdda5e4967f2..534e18423b9c git log bdda5e4967f2..534e18423b9c --date=short --no-merges --format='%ad %ae %s' 2019-01-02 dburger@chromium.org Removal of out of date active_waterfall comments in chromeos_config.py Created with: gclient setdep -r src/third_party/chromite@534e18423b9c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib70c0bba183eb56232f4e9d4cf66af5185280593 Reviewed-on: https://chromium-review.googlesource.com/c/1393355Reviewed-by:
-
- 02 Jan, 2019 7 commits
-
-
John Lee authored
Change-Id: I6ceea7e847bd9b141426e7f491f447e739c64437 Reviewed-on: https://chromium-review.googlesource.com/c/1389395 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#619538}
-
Jinsuk Kim authored
This CL partially reverts the change made in https://crrev.com/c/1381352 which was a mistake. The main menu should appear if ephemeral tab is in peeked mode, while should be disabled in the other available mode(maxmized). This CL fixes it. Bug: 916931 Change-Id: Ie80bdd606be065685689e7f45ae0792b6253cdb7 Reviewed-on: https://chromium-review.googlesource.com/c/1392688Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#619537}
-
Ted Choc authored
Update the suggestion visibility call to handle multiple focus/lost focus cycles by always calling the finish animations method after any url focus event. BUG=902243 Change-Id: I413b772436faaa30c19106799ba27c638b6986e9 Reviewed-on: https://chromium-review.googlesource.com/c/1393375Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bbdeee914aeb..48bbc53ea4d0 git log bbdeee914aeb..48bbc53ea4d0 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 bryan.bernhart@intel.com ES31: Fix for reading back initialized SSBO buffers in D3D11 2019-01-02 syoussefi@chromium.org Suppress flaky Linux/Intel/OpenGL test. Created with: gclient setdep -r src/third_party/angle@48bbc53ea4d0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ib4f6846d4ee3b65da1681f8d06641b1eb756533f Reviewed-on: https://chromium-review.googlesource.com/c/1393356Reviewed-by:
-
Aidan Wolter authored
Bug: None Test: ./tools/fuchsia/local-sdk.py <fuchsia> x64 Change-Id: I9b73e6cf179b739345ea0d48c5e597de44eef8f1 Reviewed-on: https://chromium-review.googlesource.com/c/1393743Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
Peter Boström authored
This change makes flood fill the default ink-drop style. Square InkDrops are currently bugs in the browser that are kind-of hidden by InkDrop masks. It makes use of the same path that FocusRing uses for masks to make sure that the InkDrop and FocusRing are in sync by default. These mismatch bugs keep popping up, especially on Mac, as testers verify new parts of the UI. Follow-up changes will be to reduce the number of classes that override CreateInkDrop methods and make sure that they explicitly request a SquareInkDrop when they want it. Bug: chromium:888204, chromium:907833, chromium:915284 Change-Id: I681b93d6f5bdfe7f78421ebc8f2fbd522fb6eee4 Reviewed-on: https://chromium-review.googlesource.com/c/1367186 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619533}
-
Dan Beam authored
Previously, there were things like: --some-color: #010203; --some-color-opacity-X: rgba(1, 2, 3, X); Which is a bit inflexible and leads to a bit of redundancy. Instead, let's use this syntax, which allows minting an arbitrary number of colors with var() + rgba() syntax: --some-color-rgb: 1, 2, 3; --some-color: rgb(var(--some-color)); /* later ... */ color: rgba(var(--some-color-rgb), X /* any opacity */); Bug: 883049 Change-Id: If730a1123294e43f2ea04b433c6c5a46933cc08e Reviewed-on: https://chromium-review.googlesource.com/c/1393442Reviewed-by:
-
