GitLab

SharedMemoryMapping::Unmap() call passes a mapping size to the munmap() or a
similar system call on some platforms. The actual size of a mapping is stored
in the SharedMemoryMapping::mapped_size_ but the SharedMemoryMapping::size_
which contains the logical size of the mapping has been mistakenly used instead.

This bug is not severe though because the mapped_size_/size_ mismatch exists
only on Windows and Windows system call for unmapping doesn't accept the size.

Change-Id: Id25c3dce6f0e2ea78d885e76e936572d4e5d2d52
Reviewed-on: https://chromium-review.googlesource.com/1241054Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593695}

https://chromium.googlesource.com/catapult.git/+log/e06567b30fdd..64f2ed4bb2f1


git log e06567b30fdd..64f2ed4bb2f1 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 jbudorick@chromium.org Revert "Use vpython and remove vendored pymock."


Created with:
  gclient setdep -r src/third_party/catapult@64f2ed4bb2f1

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:878777,chromium:777865
TBR=sullivan@chromium.org

Change-Id: Ia7a75c175d7efa7f628faabf583f193998b4bb60
Reviewed-on: https://chromium-review.googlesource.com/1240835Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593694}

Most user reports are for driver version 8.970.100.9001.

However, there is one report on AMD r7 M360 (0x6900) with driver 24.20.11016.4,
which is from May 2018.

Limit the scope of applying this workaround, so we can backport to Beta without
changing code path for most users, although in theory we don't need direct
composition on non Intel GPUs on Windows.

BUG=800950
TEST=manual
R=sunnyps@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib2e224c2c316cf84a96ca252a3a7aa9828979fd0
Reviewed-on: https://chromium-review.googlesource.com/1241273
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593693}

Sessions restoration should not trigger web state observer callbacks.
Also updated the tests to wait for web state observer callbacks
from the last page load.

Bug: 877671
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0ae13d40e106dc7ad344518c31258db7ab110b0e
Reviewed-on: https://chromium-review.googlesource.com/1238378Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593692}

Currently the ExtensionAPITest.ActiveTab fails with the RuntimeHostPermissions
feature since it assumes that the active tab access grant is revoked when the
page is navigated. However, with the runtime host permissions feature enabled,
the active tab grant is only revoked when the page navigates to a different
origin. Fix the test and also test the behavior with RuntimeHostPermissions
enabled.

This is in preparation of enabling RuntimeHostPermissions for field trial
testing.

BUG=888158

Change-Id: I46c2c1f92d273eff80395642d0fe2733528cdf70
Reviewed-on: https://chromium-review.googlesource.com/1239210
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593691}

Currently, RenderFrameImpl returns
kWebNavigationPolicyHandledByClientForInitialHistory policy,
which instructs FrameLoader to just mark itself as loading.

This patch makes it explicit from the client side. The end goal
is to delegate all commit decisions to the client.

Bug: 855189
Change-Id: Ided8227efe4f1e99335141f5710fc1d47072a903
Reviewed-on: https://chromium-review.googlesource.com/1235323
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593690}

Bug: 867488
Change-Id: Ied05d87e4d1a104f4a6012d465fcf20fd85c3bcf
Reviewed-on: https://chromium-review.googlesource.com/1225935
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593689}

https://pdfium.googlesource.com/pdfium.git/+log/97f4483de007..fed6e124109f


git log 97f4483de007..fed6e124109f --date=short --no-merges --format='%ad %ae %s'
2018-09-24 tsepez@chromium.org Give CFX_GraphStateData a work-over.


Created with:
  gclient setdep -r src/third_party/pdfium@fed6e124109f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I94f02a794f82dc2b704250677e840fd58450830a
Reviewed-on: https://chromium-review.googlesource.com/1240833Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593688}

      +697,754 bytes normalized apk size
            +3 zip entries file count
       +53,964 bytes main lib size
      +442,364 bytes main dex size
      +259,086 bytes APK size
 +2,046,236.56 bytes Estimated installed size
InstallBreakdown (+2,048,104.56 bytes):
        +3,696 bytes unwind_cfi (dev and canary only) size
        +1,458 bytes Non-compiled Android resources size
       +53,964 bytes Native code size
          +179 bytes Package metadata size
 +1,974,131.56 bytes Java code size
       +14,676 bytes Compiled Android resources size
        +2,186 entries fields
        +3,020 entries methods
          +728 entries types
        +1,507 entries strings

Specifics: 
InstallSize: 
Dex: 
Change-Id: I50076aa2405ed276cfba7978aa1173a9f9036995
Reviewed-on: https://chromium-review.googlesource.com/1240744Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593687}

For the cases where we store that vector on the stack, we can
easily give it an inline capacity and gain some performance.

There is one function that can take either a stack-based or
LayoutResult-based positioned floats vector; I made that a template
so it can accept either one.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2afb67e03862f062864dd4d36c740b5c578041aa
Reviewed-on: https://chromium-review.googlesource.com/1226159Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593686}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3e22586a..1afc0dd4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib819bb6e35ae941add9acfd33751e7b6e41e4af4
Reviewed-on: https://chromium-review.googlesource.com/1240869Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593685}

Where appropriate, replaced `var`s with `let`s, `function`s with lambdas, closure function with braces, and construction functions with classes.

Change-Id: I45dcf2e7aa840242cf2b25cd73cf8a81bfe5b3da
Reviewed-on: https://chromium-review.googlesource.com/1239352
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593684}

Just check before showing the tooltip.

Bug: 857258
Change-Id: Ie9b6768d89ac65ff21bbf729c7fc84a467a98790
Reviewed-on: https://chromium-review.googlesource.com/1240209Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593683}

Bug: 888613

Change-Id: If7bb4952eb3a19d4d32afec18dc037e66d4c55b4
Reviewed-on: https://chromium-review.googlesource.com/1239363Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593682}

The text insertion caret in web contents can have a positive height but
zero width. Ensure the a11y highlight is still visible in this case.

This regressed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1152373

due to the change to AccessibilityHighlightController::IsCaretVisible.

Bug: 882762
Test: added to ash_unittests
Change-Id: I2743cb234b49eb5c0d71ba5bf1d25e3869c2492f
Reviewed-on: https://chromium-review.googlesource.com/1241215Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593681}

Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1230694.

Change-Id: I5043132eb238ce968d451df28f5939d0de9129e3
Reviewed-on: https://chromium-review.googlesource.com/1240974
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593680}

NTP will not invert the color back to white when we set invert color
scheme on system setting. This can not only make the default background
color change according to the system setting but also  avoid weird color
on both themes and custom backgrounds. Notice that, only windows has the
invert color setting.

Screencast:
https://screencast.googleplex.com/cast/NjI0ODU4OTI2NTIwNzI5NnxhYzdiNWI3YS04NQ

Bug: 802186
Change-Id: Icd64f1350b8014d15107c565785b612ae9febe2e
Reviewed-on: https://chromium-review.googlesource.com/1241156Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593679}

Bug: 832676
Change-Id: I4664d3052a0131ab591b166c1a725f042b55b6b0
Reviewed-on: https://chromium-review.googlesource.com/1240513
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593678}

Avoid the crash when handing stop interaction without an active assistant
manager. The root cause of this issue is still unknown.

Bug: 882952
Test: locally build and run
Change-Id: Ic7b9fc0f013ba926917a2b266235e887c169418b
Reviewed-on: https://chromium-review.googlesource.com/1240856Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593677}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/background/background_mode_manager_mac.mm.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=avi@chromium.org

Bug: 874080
Change-Id: Ic807c6eb4e22dc7ebdd34e2240e1fe6484e44174
Reviewed-on: https://chromium-review.googlesource.com/1191232Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593676}

https://skia.googlesource.com/skia.git/+log/4fb073ac7328..9461dcf1306a


git log 4fb073ac7328..9461dcf1306a --date=short --no-merges --format='%ad %ae %s'
2018-09-24 michaelludwig@google.com Revert "Implement an explicit binary search-based analytic gradient colorizer"
2018-09-24 fmalita@chromium.org [skottie] Initial property setters
2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b9dc92669da2..82ea7fbce65f (1 commits)
2018-09-24 fmalita@chromium.org UBSAN: Divide-by-zero in SkRRect::setRectXY
2018-09-24 halcanary@google.com SkPDF: simplify SkPDFDevice::drawPaint.
2018-09-24 jvanverth@google.com Make sure ReflexHash grid count is reasonable
2018-09-24 michaelludwig@google.com Implement an explicit binary search-based analytic gradient colorizer


Created with:
  gclient setdep -r src/third_party/skia@9461dcf1306a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254,chromium:888233,chromium:796479,chromium:729727,chromium:696603,chromium:543625,chromium:414254
TBR=bsalomon@chromium.org

Change-Id: I5c06466571c0dbc74c36d61f4a9c7a6552f75eee
Reviewed-on: https://chromium-review.googlesource.com/1240836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593675}

This is the last CL to remove SkColorSpaceXform call sites from
third_party/blink. This change also does some refactoring in
ImageBitmap unit tests, etc.

TBR=fserb@chromium.org

Bug: 774520
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8279f1687ef096ae9aa2179c74d5d6cf2364ce9b
Reviewed-on: https://chromium-review.googlesource.com/1237140Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593674}

 - Errors are handled as part of _htmlPreview.
 - image/svg is already handled as an image as part of PreviewFactory.createPreview.
 - Text types are already handled as source as part of PreviewFactory.createPreview (and with better defaults like auto-formatting).

The only branch in which case this was still hit is Other resource type with non-encoded content, but it's best not to use that as heuristic since backend might encode text content as well and vice versa, so it's better not to show any preview in that case at all. Note that user can still check raw Response tab if they wish.

Change-Id: Icb76f2d54641a73aeef62d3e1c98c731ee894ab5
Reviewed-on: https://chromium-review.googlesource.com/1216303Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com>
Cr-Commit-Position: refs/heads/master@{#593673}

This migrates content::PepperNetworkMonitorHost from
NetworkChangeNotifier to NetworkConnectionTracker, which works with the
network service enabled.

Bug: 887046
Change-Id: I6fcd03fa664689cc6bcc16ff80b86fdba75d695d
Reviewed-on: https://chromium-review.googlesource.com/1236560
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593672}

Refactoring of the internal input events blocker in
TabletModeController.

The input events should only be blocked if 1) we're currently in tablet
mode or 2) we're currently in laptop mode but the lid is flipped over,
i.e., we are in laptop mode because of an attached external mouse.

Bug: 887042
Change-Id: I8be03c684265d79ccc3499362a7154eb44c4dec0
Reviewed-on: https://chromium-review.googlesource.com/1237407
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593671}

- Screen reader will read the app name when the chip is focused.
- Navigate chips using tab.
- Toggle app to install / not install with space or enter key.
- Screen reader will read the title of recommend-apps and app-dowloading
screens.

Bug: 885219
Change-Id: I5ad9f79b33ae8a55fe4f5240692261e346461a22
Reviewed-on: https://chromium-review.googlesource.com/1234237Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593670}

Bug: 838910
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id40fa8876356c3ecdac81999f1701bb0ef420393
Reviewed-on: https://chromium-review.googlesource.com/1234842Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593669}

Changes visibility of JavaPoet in android deps to
allow for code generation support in annotation processors.

Change-Id: Ic84705a85504fd8e3e541cb0a2be524df2164ef0
Reviewed-on: https://chromium-review.googlesource.com/1239360Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#593668}

This change Clang formats ARC's power bridge.

Bug: None
Test: Compile.
Change-Id: I9658ce6c8405b3ec1b21986c162aa836fc09b774
Reviewed-on: https://chromium-review.googlesource.com/1239694Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593667}

This patch aligns the checkboxes to the first text line and adds a
separator between the geo/accept languages and the rest of the list.

Bug: 887678
Change-Id: Icf0f20a2f550541cd940d134b752d0d5deee6f11
Reviewed-on: https://chromium-review.googlesource.com/1237178Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593666}

Currently the policy uses a image element's naturalWidth/naturalHeight
as the image's size, but this is incorrect for cases:
  1. intrinsicSize attribute overrides naturalWidth/naturalHeight;
  2. srcset w descriptor sizes will determine
     naturalWidth/naturalHeight;

So, instead, we should be using the actual size of the Image object.

Bug: 888578
Change-Id: I2abc9854ffd8c0d942651085d510885a82884ad8
Reviewed-on: https://chromium-review.googlesource.com/1240497Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593665}

This comment should have been removed with code review 1211963
because the bug fixed there was precisely the change of color
depending on popup state.

Bug: 879935
Change-Id: Ie4dd596a96050759d45bd542a75ab06e066c3797
Reviewed-on: https://chromium-review.googlesource.com/1240203Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593664}

A FrameCoordinationUnit is never removed from a ProcessCoordinationUnit
through this mojo method. What happens instead is that when a frame is
deleted, the corresponding FrameCoordinationUnitImpl is destroyed. In
its destructor, the FrameCoordinationUnitImpl remove itself from its
parent ProcessCoordinationUnitImpl without going through mojo.

Bug: 885293
Change-Id: Ief70ddd0b979ca97fe822a9405899cf3bdfc8aba
Reviewed-on: https://chromium-review.googlesource.com/1234896Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593663}

Cleanup TrayBubbleView's MouseWatcher comments.
Remove a TimeDelta that was being used incorrectly.
(controls the callback delay, not a mouse sampling rate)

Remove no-op delegate function overrides (default is no-op).
Remove a call to the no-op BubbleDialogDelegateView::OnGestureEvent.

Bug: None
Test: No tray bubble (volume/brightness) auto-close regressions.
Change-Id: I1bf3775b22a147f2d42557ff4a71dba153c5bb6c
Reviewed-on: https://chromium-review.googlesource.com/1241195Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593662}

Bug: 853824
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6e52260c7966a59434176c20867a11b5505a1cde
Reviewed-on: https://chromium-review.googlesource.com/1240740Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593661}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8bdc1b8a0433..aaf2cc09c687


git log 8bdc1b8a0433..aaf2cc09c687 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 sergiyb@chromium.org Implement --no-autocc flag for Gerrit


Created with:
  gclient setdep -r src/third_party/depot_tools@aaf2cc09c687

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:878303
TBR=agable@chromium.org

Change-Id: Iab04c0d298d064f57c569aadd622ea5a338637be
Reviewed-on: https://chromium-review.googlesource.com/1240834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593660}

For incognito window's the in-memory DB is seeded (read only) by the DB
of the original profile. This is achieved via raw pointer to the seed
DB and the invariant that the incognito profile is always outlived by
its ancestor profile. Unfortunately, this overlooked that the ancestor
profile may destroy the DB and make a new one when asked to clear the
DB history. This caused the seed pointer to be invalid.

This CL changes the VideoDecodePerfHistory to never destroy the DB.
The DB is now a const unique_ptr, passed in during construction.

This CL also changes how clearing history works. Before, we used the
Destroy() API of the underlying ProtoDatabase to delete all entries.
This left the DB broken until re-initialized, which presents a risk
whenever that DB is seeding an incognito profile. Going forward,
clearing the DB is achieved by querying for all the keys and then
removing them. This removes the need for re-initialization and allows
the seeded in-memory DB to carry on safely unaware.

Test: Updated unit tests. Also manual e2e testing.
Bug: 881059
Change-Id: I014d76d9e04b16574fd7eea08775b1388740dd8d
Reviewed-on: https://chromium-review.googlesource.com/1220392Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593659}

Rename the minimum/target SDK version and manifest package name
variables in the WebView manifest to be consistent with the ones in the
Chrome manifest. Use the old names as a default value so as not to break
downstream until this is updated.

Change-Id: If55711db4540fc164ddd0f6bddcf30abd3da99a5
Reviewed-on: https://chromium-review.googlesource.com/1241014Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593658}

This will execute the uninstall operation via the UI and the callback
will be invoked upon completion.

BUG=chromium:849438
TEST=tast run vm.CrostiniFiles

Change-Id: I854b0563cea082a325c3c52a00e2c357cb62a295
Reviewed-on: https://chromium-review.googlesource.com/1237387
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593657}

LayerTreeHostTestWillBeginImplFrameHasDidFinishImplFrame has been
reported as flaky on and off for a while now.

TBR=lijeffrey@chromium.org

Bug: chromium:842038, chromium:845381
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie71c4716777812d6ebec67833d98da340962b699
Reviewed-on: https://chromium-review.googlesource.com/1241193Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593656}