GitLab

This CL changes the Template Expressions from using
a ${ to identify the start of an expression, to using
$i18n{.  The intention is to reduce (eliminate) false
positives when searching for expressions that need
replacement.  This CL also prepares for the replacement
work to be done in a background thread and used on a
broader set of files.

BUG=506009

Committed: https://crrev.com/5aa7fd5f14e49c65ebba87e4248424d622b92930
Cr-Commit-Position: refs/heads/master@{#371537}

Review URL: https://codereview.chromium.org/1585923011

Cr-Commit-Position: refs/heads/master@{#372239}

https://chromium.googlesource.com/chromium/src/+/ba696d0d2

BUG=240845
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1642263003 .

Cr-Commit-Position: refs/heads/master@{#372238}

https://chromium.googlesource.com/chromium/src/+/510e13d15

BUG=569643
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1649953002 .

Cr-Commit-Position: refs/heads/master@{#372237}

- Added RemoteChannelMain and RemoteChannelImpl to serialize and transmit
  inter-proxy messages between the main and impl components of the
  compositor using protobufs.
- Added RemoteChannelHost to be used by the cc embedder as the API for
  interacting with the impl components of the remote compositor.
- Added tests to verify the initialization and shutdown sequence for the
  remote compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1513643010

Cr-Commit-Position: refs/heads/master@{#372236}

BUG=529938

Review URL: https://codereview.chromium.org/1643523006

Cr-Commit-Position: refs/heads/master@{#372235}

This is currently necessary as windows may supply values not in the
enum list. Without extensible a validation error is generated, so that
you can't type ':' among others.

BUG=582279
TEST=none
R=yzshen@chromium.org
TBR=yzshen@chromium.org

Review URL: https://codereview.chromium.org/1644633007

Cr-Commit-Position: refs/heads/master@{#372234}

BUG=582274,582277
TBR=glider@chromium.org,lfg@chromium.org

Review URL: https://codereview.chromium.org/1649943002

Cr-Commit-Position: refs/heads/master@{#372233}

BUG=514815, 581951

Review URL: https://codereview.chromium.org/1641323002

Cr-Commit-Position: refs/heads/master@{#372232}

Still detect the situation when the app is creating WebView from two
processes sharing the same data dir, but do not throw a RuntimeError,
only print a warning.

BUG=558377,582146

Review URL: https://codereview.chromium.org/1641383002

Cr-Commit-Position: refs/heads/master@{#372231}

- VS2013 doesn't support constexpr
- windows.h defines helpful things like min and max macros
- Use HANDLE instead of HFILE

BUG=none

Review URL: https://codereview.chromium.org/1646823004

Cr-Commit-Position: refs/heads/master@{#372230}

Revert of GN: Use special toolchain for nacl64.exe, force is_component_build off (patchset #2 id:20001 of https://codereview.chromium.org/1580723006/ )

Reason for revert:
We are seeing errors on Win x64 fre/chk GN build bots and this is the most likely cause.  Reverting.

Original issue's description:
> GN: Use special toolchain for nacl64.exe, force is_component_build off
>
> The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
> compatible with component-style builds.  Build nacl64.exe in a special
> variant of the x64 toolchain, wherein is_component_build is always false.
>
> BUG=512869
> R=bradnelson@chromium.org, dpranke@chromium.org
>
> Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
> Cr-Commit-Position: refs/heads/master@{#372217}

TBR=bradnelson@chromium.org,dpranke@chromium.org,mcgrathr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512869

Review URL: https://codereview.chromium.org/1643803006

Cr-Commit-Position: refs/heads/master@{#372229}

This CL adds CombinedDesktopMediaList class and its associated unit tests. It intends to support chrome tab capture for JavaScript API chooseDesktopMedia().

Design document is in
https://docs.google.com/document/d/1zZOiayDzVkuIQ3twEdiE6S-LTXz9fWOGKjbMIsLTcAk/edit#heading=h.cetuprbl19fv

BUG=557222

Review URL: https://codereview.chromium.org/1622733002

Cr-Commit-Position: refs/heads/master@{#372228}

On VS2015:

d:\src\cr3\src\tools\battor_agent\battor_sample_converter_unittest.cc(28): error C2397: conversion from 'double' to 'int16_t' requires a narrowing conversion

R=brucedawson@chromium.org, charliea@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1648123002

Cr-Commit-Position: refs/heads/master@{#372227}

This CL adds valgrind config in mb_config.pyl for valgrind bots
on chromium.memory.fyi

R=dpranke@chromium.org
BUG=572694

Review URL: https://codereview.chromium.org/1648803002

Cr-Commit-Position: refs/heads/master@{#372226}

artOffset`.

Just only recognize with `percentage` when return value on
`startOffset` that is normalize value between 0 and 1.
Because occur to the problem on `SVGTextLayoutEngine::begin-
TextPathLayout`.

So check whether percentage or not, If no percentage, don't
recognize to normalize value.

BUG=576702

Review URL: https://codereview.chromium.org/1580293008

Cr-Commit-Position: refs/heads/master@{#372225}

BUG=266276

Review URL: https://codereview.chromium.org/1577723002

Cr-Commit-Position: refs/heads/master@{#372224}

--site-per-process flag.

Also resolved the flakiness as a side product.

BUG=373155,568710

Review URL: https://codereview.chromium.org/1585003002

Cr-Commit-Position: refs/heads/master@{#372223}

This supports communication via Google api to get an auth
code for GMS Core client and pass it to ARC instance. There
are two types of getting the auth code. Firstly, we try to
get it silently and secondary, in case when an additional
input is required from the user WebView dialog is shown.
Changed logic of starting ARC instance. Now its start is
controlled by ArcAuthService after communication with
Google auth servers.

BUG=571146
TEST=Provide additional unit_tests.
TEST=logcat shows that auth code is passed to ARC instance.
     Both modes are tested: silent and WebView based (can
     be forced by re-imaging)

Review URL: https://codereview.chromium.org/1618193003

Cr-Commit-Position: refs/heads/master@{#372222}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be0306ff..0e000221

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1641133006

Cr-Commit-Position: refs/heads/master@{#372221}

Selection gaps have been disabled in M47 stable for some time now.

BUG=471908

Review URL: https://codereview.chromium.org/1642223002

Cr-Commit-Position: refs/heads/master@{#372220}

If (due to an unexpected failure) one of the find() calls in
audio_video_metadata_extractor_unittest.cc fails (returns end()) then
dereferencing it triggers undefined behavior. This makes the results of
the test undefined. In most cases the test failure will still be caught
but there are no guarantees.

This change adds a helper function to simplify using find() in a way
that is safe even in the face of unexpected failures.

This was discovered while investigating crbug.com/581768.

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/1643633005

Cr-Commit-Position: refs/heads/master@{#372219}

This test started failing on the Site Isolation FYI bots after
https://codereview.chromium.org/1645923002/.  This CL disables it
there until we can fix it.  The test is a no-op on other bots
without the --site-per-process flag.

BUG=582251
TEST=Site Isolation FYI bots go green.

Review URL: https://codereview.chromium.org/1646083002

Cr-Commit-Position: refs/heads/master@{#372218}

The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
compatible with component-style builds.  Build nacl64.exe in a special
variant of the x64 toolchain, wherein is_component_build is always false.

BUG=512869
R=bradnelson@chromium.org, dpranke@chromium.org

Review URL: https://codereview.chromium.org/1580723006

Cr-Commit-Position: refs/heads/master@{#372217}

BUG=582257

Review URL: https://codereview.chromium.org/1648813002

Cr-Commit-Position: refs/heads/master@{#372216}

BUG=582130

Review URL: https://codereview.chromium.org/1646893002

Cr-Commit-Position: refs/heads/master@{#372215}

BUG=571458

Review URL: https://codereview.chromium.org/1645103002

Cr-Commit-Position: refs/heads/master@{#372214}

I thought this was happening before, but upon further inspection, it
looks like whatever I did wasn't working. This way of building the
battor_agent seems to be.

Given that the battor_agent will be used by Telemetry, it makes sense
to build this on the waterfall.

BUG=571458

Review URL: https://codereview.chromium.org/1640883003

Cr-Commit-Position: refs/heads/master@{#372213}

Previously naked pointers AssemblyProgram and EncodedProgram are used over the
place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}().
In this CL we use scoped_ptr to manage the life cycles of these objects.

- Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced calls
  with e.g., program.reset(nullptr); if the manual deallocation is a peak
  memory optimization.
- Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc files.
- Extracted DetectExecutableType() and ParseDetectedExecutable() from
  disassembly.* to new files program_detector*c, since Disassembly is really an
  implementation that caller's don't care about.

Review URL: https://codereview.chromium.org/1629703002

Cr-Commit-Position: refs/heads/master@{#372212}

Crash reports associated with the --isolate-extensions trial show
that a RenderWidgetHostViewChildFrame can receive mouse events even
after Destroy has been called on it, resulting in a null pointer
dereference since the RenderWidgetHost pointer has been cleared.

This CL checks the pointer for null and discards the event if the
RWHVCF is currently awaiting deletion.

BUG=571092
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1641553007

Cr-Commit-Position: refs/heads/master@{#372211}

font_warmup_win.cc depends on Blink code but is linked into content/common. This file is not needed outside of child processes, so it can go in content/child and avoid the blink-in-browser usage.

Removes the linux conditional on libjingle_webrtc and make it apply whenever webrtc is being used. This code is called by socket_host.cc whenever webrtc is enabled. This is necessary for a future patch that removes Blink's linking into content/browser. Blink is currently bringing in webrtc which is why the code links today.

BUG=582206

Review URL: https://codereview.chromium.org/1642213002

Cr-Commit-Position: refs/heads/master@{#372210}

https://boringssl.googlesource.com/boringssl/+log/6c22f542f42eccb0de7f43edf27aa1255c7be7e2..2cdf398773edb5e6fa6ccb4088553c245f048062

BUG=none

Review URL: https://codereview.chromium.org/1647953004

Cr-Commit-Position: refs/heads/master@{#372209}

https://chromium.googlesource.com/skia.git/+log/317a45e87988..817c72ad40bf

$ git log 317a45e87..817c72ad4 --date=short --no-merges --format='%ad %ae %s'
2016-01-28 djsollen Fix broken Android framework builds GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641173003
2016-01-28 fmalita SaveFlags begone!
2016-01-28 benjaminwagner Fix typo on trooper page.
2016-01-28 benjaminwagner Work around exasperating Google3 Android build error.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1642243002

Cr-Commit-Position: refs/heads/master@{#372208}

This is a re-land of https://codereview.chromium.org/1541393003/

This patch is another effort to make Character::isCJKIdeographOrSymbol
faster.

The previous CL[1] made it faster by ~90% for codepoints below U+2020,
but codepoints abvoe U+2020 were not as fast. This CL makes all
codepoints faster, as fast as ICU functions.

      Before  After Improve ICU
All    2569 => 292    88%   298
ASCII    68 =>  68     0%   160
Han    2958 => 263    91%   344
Hira    258 =>  11    95%    14
Arabic   37 =>  32    13%    44
* # of code points and iterations vary by rows.

The previous CL[1] clarified that binary search is not as fast as ICU
functions such as uscript_getScript(). This patch changes to use
UTrie2, which is the data structure ICU property functions use.

In addition in this patch:
* U+2763 and U+2764 are added as requested by drott@.
* Character::isUprightInMixedVertical() was switched to UTrie2 too.
* Character::isCJKIdeograph() was removed because it is no longer used.

[1] https://codereview.chromium.org/1545073002

BUG=571943

Review URL: https://codereview.chromium.org/1645893002

Cr-Commit-Position: refs/heads/master@{#372207}

This is in preparation for switching these bots to the Chromium recipe.

The only thing of note is that the angle_deqp_gles3_tests will not be
run on the Linux Release dEQP (NVIDIA) bot yet, to match their current
configuration.

BUG=542370
TBR=dpranke@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1642293002

Cr-Commit-Position: refs/heads/master@{#372206}

In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent key will be passed through directly to the system. In particular, the key needs to be a ChromeVox command. For example, Search+Shift+Esc followed by any number of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking since the passed through key is the last ChromeVox command.

This cl also makes all key events involving Search captured.

TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox tries to move to the next link.
Press Search+Shift+Esc; then Search+L. Verify screen locks.
Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass through activates. Press Search+L and see that screen locks.

Review URL: https://codereview.chromium.org/1636243002

Cr-Commit-Position: refs/heads/master@{#372205}

Now ChromotingClient creates WebrtcConnectionToHost or
IceConnectionToHost depending on protocol_config.

BUG=547158

Review URL: https://codereview.chromium.org/1649513002

Cr-Commit-Position: refs/heads/master@{#372204}

Since the tool wasn't using the "spelling" location, replacements would
be emitted using source locations into an unnamed input buffer. As a
result, the emitted replacements would never apply since the file name
would never match.

However, it ends up still being included in the symbol dump for the
rebase tool. Since these identifiers aren't being renamed, just skip
processing anything inside a macro.

BUG=581902

Review URL: https://codereview.chromium.org/1641703003

Cr-Commit-Position: refs/heads/master@{#372203}

This CL removes support for the "subresource" rel of HTMLLinkElement, as it is not useful, proprietary, and buggy.

I2DnR: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Y_2eFRh9BOs/gULYapoRBwAJ

BUG=581840

Review URL: https://codereview.chromium.org/1647813003

Cr-Commit-Position: refs/heads/master@{#372202}

Resubmit of http://crrev.com/1518223002 now that we have a fix in for
http://crbug.com/569643.

Work still pending per http://crbug.com/569211 to use correct rects for certain
items.

BUG=529938
TBR=christr

Review URL: https://codereview.chromium.org/1648023002

Cr-Commit-Position: refs/heads/master@{#372201}

During reattach, InspectorEmulationAgent tries to access
mainFrameImpl() too early, which happens to break during
remote -> local main frame transition.

Similar thing happens when we cleanup during local -> remote transition.

Somehow, we also enable emulation for remote frames sometimes (or just
not disbale it, so it keeps going). Added null-check for now and TODO.

BUG=579065,579474,578968,543896

Review URL: https://codereview.chromium.org/1622633003

Cr-Commit-Position: refs/heads/master@{#372200}