- 05 Mar, 2019 40 commits
-
-
Adam Rice authored
Move ReadableStream to ReadableStreamWrapper. Make ReadableStream be an interface which can have multiple implementations. Make ReadableStreamWrapper implement the ReadableStream interface, and be delegated to by the ReadableStream static methods. Deprecate ReadableStreamOperations as it won't work with the new implementation. BUG=902633 Change-Id: Idcc8ae62e787e5696698f13229d19c91ca7a7e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494394Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#637651}
-
Mohamed Amir Yosef authored
Before this CL: StatmentToForms() used to return false in case of DB error or Decryption failure. This doesn't allow upper layers from acting differently in each case. After this CL: StatmentToForms() return one of three outcomes: SUCCESS, DB_ERROR, ENCRYPTION_SERVICE_FAILURE This allow later patches to use of the outcome and do cleanup of passwords don't are not decryptable. Bug: 935996 Change-Id: I2e27285feef76030895ab4476bc9f3cde2e53e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499353 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637650}
-
Stephane Zermatten authored
Before this change, the client waited for a hardcoded duration for scripts to become available and then entered a generic error state. After this change, the timeout and action can configured by the backend. When that timeout is reached, the client executes a specific script, controls what the client does. This change also subtly modifies the time after which the client stops waiting for autostart scripts: it now stops either once it's found a script to autostart or when it's found runnable scripts to propose, instead of waiting for a script to be started. This unifies operations and avoid the unlikely but confusing case where there client would autostart a script after having proposed scripts to run. For background, see go/autobot-a2m74ux-client-errors Bug: b/125245527 Change-Id: I0bc757293ca324544f1b3d35275168ee6545c340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497073 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637649}
-
Juan Antonio Navarro Perez authored
Some external module dependencies, notably numpy and pandas, are required by some command line perf tools to work properly. And these are normally satisfied by the vpython environment. However vpython is not always available, e.g. on ChromeOs, so we provide a mechanism to safely dismiss the respective import errors and skip tests that cannot be run due to the lack of these modules. Doing in this in preparation for the migration of soundwave out of catapult/experimental and into tools/perf; since that includes many other tests that also depend on these external modules. TBR=achuith@chromium.org Bug: 922030 Bug: 921762 Change-Id: I162e8e232484a5f9c8f919426ad86c6d0ad2e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494887Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#637648}
-
David Jean authored
Bug: 886583 Change-Id: I28e56d75def275ec05b5425be85282d1f11fffe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480458 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#637647}
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: I963b34fe4bf1dac600e7859608c8090bbb05396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499539Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637646}
-
Stephane Zermatten authored
This change adds a blue line around transparent areas and adds a fade animation when the transparent area appears or disappears. Screenshot: https://screenshot.googleplex.com/kAH8AHKk2du.png Animation: https://drive.google.com/open?id=1E_X48t1Kl-z2JAJpWyVtuCP8tmzcrnEz Bug: b/125245127 Change-Id: I95ba459c6420620b64225c9043e00ce2dcfd25d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497138 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#637645}
-
Tsuyoshi Horo authored
Bug: 937583 Change-Id: I07ae09c08dd3277176444a63cefe3d68db004b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496408Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Previously, a single flag (#enable-layered-api and "LayeredAPI") is used to enable/disable all built-in modules as well as Layered API Infra + Import Maps. To enable/disable individual modules separately, and to rename "Layered APIs" to "built-in modules" in externally visible places, this CL renames the existing flag and introduces new flags: - #enable-built-in-module-all / BuiltInModuleAll that enables all built-in modules (renamed from #enable-layered-api / LayeredAPI). - #enable-built-in-module-kv-storage / BuiltInModuleKvStorage that enables kv-storage only (new flag). - #enable-built-in-module-infra / BuiltInModuleInfra that enables built-in module infra + import maps (new flag), which is implied if any of built-in modules are enabled. This CL replaces RuntimeEnabledFeatures::LayeredAPIEnabled() with RuntimeEnabledFeatures::BuiltInModuleInfraEnabled(). So far all built-in modules are enabled if BuiltInModuleInfra is enabled. Subsequent CL [1] will introduce control over individual built-in modules using BuiltInModuleKvStorage and BuiltInModuleAll flags. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1497468 Bug: 829084, 938069 Change-Id: I2486c9e8b0c5ea96056a60e645a171d642c218fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497616Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL removes a check that an entity that gets deleted exists. It turns out it gets deleted before notifying so this check always fail, producing useless results. As a result we compute is_converted_from_server for DELETE changes differently, based on the storage key. The metric does not get renamed as it only lives on Canary / Dev so far and is not used in production. Bug: 904390 Change-Id: Iac3e5c42377d480671efce57ec225fea1cc8f625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496859 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#637642}
-
Takashi Toyoshima authored
Changes from the original patchset: - variation header support for iOS Chrome - additional variation header support for Chromecast - additional variation header support for StoragePartition Original descriptions: > Now ResourceRequest has multiple special header entries that are aimed > for escaping from CORS checks for internal uses. This patch introduces > cors_exempt_headers to handle this kind of entries in an unified way. > > Also this patch removes {Get|Set}ClientDataHeader interfaces from > WebURLRequest because these should not be used in Blink. > Bug: 870173 > Change-Id: I5ae5a4a58df30e54064da5b7ab74abb69c9e42a7 > Reviewed-on: https://chromium-review.googlesource.com/c/1445178 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630268} Bug: 931190, 870173 Change-Id: I0220918d3aa18787d2ed1ef8029f8c568d8afb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485560Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#637641}
-
Takuto Ikuta authored
device_management_backend.pb.h is 1.5MB. Removing such header include reduces compile time of some files. e.g. compile time of obj/chrome/browser/browser/chrome_content_browser_client.o is improved from 30.2s to 29.7s. Bug: 242216 Change-Id: If05857d45165756b6e86330f332280ad20ee3458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502318 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637640}
-
Ivan Sandrk authored
Locked fullscreen is supposed to be a secure mode where the user cannot do anything outside of the current browser window, but ARC apps can currently draw on top of it. To fix this, we disable ARC when entering the mode, and we re-enable it upon exiting the mode. This is a follow-up CL to crrev.com/c/1363202 ([ARC] Decouple ARC data removal from disabling ARC inside of ArcSessionManager) More details can be found on the design doc go/disabling-arc-locked-fullscreen Bug: 888611 Change-Id: I295902b2dfb6889457ef468c15bb7becdec1c746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488927Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#637639}
-
Takashi Toyoshima authored
In OnLifecycleStateChanged(), ShowConsoleMessageIfNeeded() is called and it chosen the top request from |pending_requests_| to show a console message if the request is stacked in the queue for a long time. This code expects the entry in |pending_requests_| is always alive even in the |pending_request_map_|, but it's wrong. If the request is canceled, it remains only in |pending_requests_| and DCHECK fires. This patch changes ShowConsoleMessageIfNeeded() to choose a request only when it is still alive in |oending_request_map_|. Bug: 936937 Change-Id: Ic0ea774f62719a3b36e78c49f24da3d5f6ce8365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498971Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 67245b48. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" 5a7d4abb "IndexedDB: Fix WPT bindings-inject-key to clean up Object.prototype" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4f526f712ea0170f85f4b85e3dd67b2c8af1cd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502712Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637637}
-
Kent Tamura authored
They are helpful to: - Restrict the usage of 'progress-bar' only to <progress>, and - Unexpose 'inner-spin-button', 'meter', 'push-button', 'progress-bar', and 'square-button' Bug: 892586 Change-Id: I6bd198345390fb6a3075d555906e427a68579cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502333 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637636}
-
Mohamed Amir Yosef authored
Some wrong DCHECKs have gone undiscovered for sometime due of the lack of unit tests of the case when the password store sync fails. This CL adds some simple unit testing that tests that during initial merge, if the store fails to add a login or to read all logins, an error is returned without crashing. Bug: 936823 Change-Id: Iefd2759b3a73c702c2e9bc4e95c96a43e1ed945c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499543 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/instrumentation with the macros of Allocator. After some analyzes, it was concluded that for the case of FrameResourceCoordinator, RendererResourceCoordinator, WebMemoryAllocatorDump, and WebProcessMemoryDump classes, they make sense to use USING_FAST_MALLOC because it has been supported factory functions which return std::unique_ptr<ImageEncoder>. Bug: 919389 Change-Id: I45269ef45893c461481d26258873b206e4d5c70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502317Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637634}
-
Lowell Manners authored
TBR=droger@chromium.org Bug: 933109 Change-Id: I64b2587470112cddf86c6f9b8f126f8cdfc8cc25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495546 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637633}
-
Yuki Shiino authored
Replaces CallbackFunctionTreatedAsScriptValue (obsolete) in AnimationWorkletGlobalScope with IDL callback function type. Change-Id: I97f0cbce17af91051c2b9fc40e7a374800700aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496406Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c8eff1c1e1b8..b47470daa737 git log c8eff1c1e1b8..b47470daa737 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 jiawei.shao@intel.com Return an error ComputePassEncoder when error occurs in BeginComputePass 2019-03-05 jiawei.shao@intel.com Fix crashes when using error textures in copy commands Created with: gclient setdep -r src/third_party/dawn@b47470daa737 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:937628 TBR=cwallez@chromium.org Change-Id: Ic563a8dc8c7c0c633442618fb607ea30e0570e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637631}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/525c349dbfeb..2905eac7889d git log 525c349dbfeb..2905eac7889d --date=short --no-merges --format='%ad %ae %s' 2019-03-05 gbiv@google.com Add LLVM ToT builders Created with: gclient setdep -r src/third_party/chromite@2905eac7889d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Id3a43ecfbfc45aa8958739347e7b63467b449fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502673Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb2adbb3f4d2..f87f16a7d161 Created with: gclient setdep -r src-internal@f87f16a7d161 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I60475d5834712e186d06e9acfcacdd0716c17e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502674Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637629}
-
Tina Wang authored
When user click "Send To My Device" option, a new entry will be added to the STTSModel. Bug: 927959 Change-Id: I18d5abc753f0ed6589c758a4543f34b28ef25040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1454216 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637628}
-
Miyoung Shin authored
Change short/int to uint16_t in third_party/blink/renderer/core/html/parser & make_html_entity_table.py - short/int -> uint16_t considering the total number of HTMLEntityTableEntry - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I4e6f06ae1b2d8091ec0b71764914855c082ef86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502252Reviewed-by:
-
Miyoung Shin authored
- short/int -> int16_t in order to make the consistency of border-spacing type. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I78c4ab12cbe20aef57084df872537e7a718bb468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502016Reviewed-by:
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/heap with the macros of Allocator. After some analyzes, it was concluded that for the case of ImageEncoder class, it makes sense to use USING_FAST_MALLOC because it has been supported factory functions which return std::unique_ptr<ImageEncoder>. In ImageEncoderUtils class, it makes sense to use STATIC_ONLY because it only has static functions. Bug: 919389 Change-Id: I892e459c7c21300128f9b6ee320afa8a3633e5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502316Reviewed-by:
-
Matt Falkenhagen authored
This is a step toward removing EmbeddedWorkerRegistry, which should no longer be needed since mojofication. Bug: 931084 Change-Id: I53b6bc29d92427b2e36e48f585c309b0308cfc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502337Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637624}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa2881937a07..fb2adbb3f4d2 Created with: gclient setdep -r src-internal@fb2adbb3f4d2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I169d28b11562c28231a4359d0fe0cf47a71d3d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502672Reviewed-by:
-
tanvir.rizvi authored
Use testharness for copy-paste-ruby-text.html and remove expected text. Bug: 679977 Change-Id: I257da179cd3cdbf9e41ec1fd99a8ca6fe5726e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498805Reviewed-by:
-
Alan Cutter authored
Without this CL the upload_screenshots.py script fails to run with: $ python tools/translation/upload_screenshots.py Traceback (most recent call last): File "tools/translation/upload_screenshots.py", line 212, in <module> main() File "tools/translation/upload_screenshots.py", line 155, in main TRANSLATION_EXPECTATIONS_PATH)) File "tools/translation/upload_screenshots.py", line 108, in find_screenshots repo_root, list_grds_in_repository(repo_root), translation_expectations) File "$HOME/repos/chromium/src/tools/translation/helper/translation_helper.py", line 101, in get_translatable_grds (translation_expectations_path, '\n - '.join(errors))) Exception: $HOME/repos/chromium/src/tools/gritsettings/translation_expectations.pyl needs to be updated. Please fix these issues: - chrome/android/features/media_router/java/strings/android_chrome_media_router_strings.grd appears to be translatable (because it contains <file> or <message> elements), but is not listed in the translation expectations. - chrome/android/features/media_router/strings/android_chrome_media_router_strings.grd is listed in the translation expectations, but this grd file does not exist. Change-Id: I6cd2daf6091881df16ac0b169bc5eec591a0b9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502339 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by: -
Takashi Toyoshima authored
Current code expects OnComplete should not be called while handling redirects. But if an underlayout URLLoader request fails for some reasons, it results in OnComplete with an error status, e.g. net::ERR_FAILED. Also this fixes following tests for OutOfBlinkCors. - ExtensionWebRequestApiTest.WebRequestSubresourceRedirectsWithExtraHeaders - ExtensionWebRequestApiTest.WebRequestRedirectsWithExtraHeaders Bug: 934571 Change-Id: I0817c51b66e4cb81e1740ceedb64795c1dba25cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482282Reviewed-by:
-
Ramin Halavati authored
Incognito menu's color is modified to primary text color to ensure contrast with menu background. Bug: 896235 Change-Id: I96c31f2326bb249c5e5af9a42dd8944481eef281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482451 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#637619}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c46e9b49. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" 5a7d4abb "IndexedDB: Fix WPT bindings-inject-key to clean up Object.prototype" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc kojii@chromium.org: external/wpt/css/css-text/line-break meade@chromium.org: external/wpt/web-animations msisov@igalia.com: external/wpt/webvtt rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request skobes@chromium.org: external/wpt/css/css-scroll-anchoring yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3fc26ef8e8f00f1d7d29d71cb7597845c975e445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501758Reviewed-by:
-
Giovanni Ortuño Urquidi authored
BookmarkApps can only be ENABLED or inexistent, so it doesn't make sense to query all extensions; querying ENABLED should be enough. Bug: 916381 Change-Id: I232514d79a5a4413a6e400280b4e1eaec0f3da8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502314 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#637617}
-
Maggie Cai authored
Currently a custom search box is used, however the ctrl+F is not working, updated to use the default search box (with UI permission) and move the sort box. BUG=931969,835712 Change-Id: Ibabc3a3dbfa67f6d38b481126f0983a20dd3aa9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491156 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#637616}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/edefc3380260..aa2881937a07 Created with: gclient setdep -r src-internal@aa2881937a07 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I90de7af49f60fd53d65c3d3ba7c9793eb4ba8c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502514Reviewed-by:
-
Malay Keshav authored
Fix comments that were missed in the original patch. TBR=enne Bug: 903486 Change-Id: I28132b25e95141cf56663300a46e92299c9df8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502352Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#637614}
-
Guido Urdaneta authored
Header file initially in public/platform so that it can still be accessed by dependents in content. Once dependents are migrated to blink, it will be moved to renderer/platform. Bug: 704136 Change-Id: If66f57d7239fe585a77d07a098ad20dd51d8e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499553Reviewed-by:
-
Dmitriy Lyamkin authored
There is a wrong MIME-type for ".png" files on internal pages. It sets 'text/html' for them. So we have some broken images like this: chrome://downloads/1x/incognito_marker.png Change-Id: I61f241c87fac50d8fbb65876536c7d0ef06358d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496979Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#637612}
-
