- 22 Oct, 2020 40 commits
-
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I41890da092bb22dfca7c9bc92a1af0365407c16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490548 Commit-Queue: Joon Ahn <joonbug@chromium.org> Auto-Submit: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#819875}
-
Justin Cohen authored
Bug: 1140474 Change-Id: I53d57e95867a29bd682bbc1e726d2327ab047195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491544Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819874}
-
Azeem Arshad authored
This CL fixes mobile-data network summary row not showing arrow button when tethering is enabled but has no active tether connections. Clicking the row in this case, however, does indeed navigate to the subpage to allow user to scan and show tethering information. Fixed this with a more correct check for arrow button visibility. Fixed: 1141238 Change-Id: I7eec6495562942ed068e5c826c2ba258fe027962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491103Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#819873}
-
Matt Jones authored
This patch replaces usages of the layout LayoutUpdateHost that only use the requestUpdate method to instead depend on a Runnable. Bug: 1070281 Change-Id: I4af2b265cd5d3e3121afb8134729ed7a79ac09cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490237Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819872}
-
Hidehiko Abe authored
Then, migrate EvdevCodeToNativeCode and NativeCodeToEvdevCode into the new functions. Bug: 1135034 Test: Built locally. Change-Id: Ibfa0ff101649e1087f547147ca53201067b6ae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461166Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#819871}
-
Sharon Yang authored
Add conversion so when action requests tied to node IDs are received from the Fuchsia side, the correct node ID is used. Test: AXTreeConverterTest.ConvertToAxNodeId Bug: 1135323 Change-Id: I3c4587cf581f115ddbfc5d8ed27b87f131ccc449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453890Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#819870}
-
Mariia Shvedchenko authored
If the page_language has no entries (e.g., if it's the empty string), return all patterns. Bug: 1141012 Change-Id: I9809a2c034df47b13a9c5c21ac62f47b5fea8b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489997 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#819869}
-
Aga Wronska authored
Observes cros settings on login screen and in session to prevent users from using the device if policy was disabled. Makes sure that the policy is handled correctly when users' allowlist is evaluated. Bug: 1138199 Change-Id: Ie0ce1a597e25867bf3d1bcb69b73faaf8866759b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448059Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#819868}
-
Koji Ishii authored
|NGBlockLayoutAlgorithm| has two branches, one when |lines_until_clamp_| becomes |<= 0| by the layout, and another when it is |== 0|. To make sure we run all these logic, this patch: * Updates |lines_until_clamp_| by the number of reused lines. * Limits reusing only up to 1, so that conditions above go normal layout codepath. Bug: 1140951 Change-Id: I15fe81b4957fe70d23bb88aae700642297bb1550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491561Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819867}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010220700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/-UBwQixuGMTrCC6fT6wDK3ak5Gkt558wUizuOD2eaKoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ia7fd7de353ed584810d50523579dac4e3d713812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492061Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819866}
-
Robert Ogden authored
This crash is caused by the callback being run after the original SRP has been navigated away from, causing the metrics collector to be null. This CL adds a check to skip the callback if the url isn't in the set of predicted urls, and also adds an additional guard to check that the metrics collector is not null. Bug: 1141319,1136174 Change-Id: Ia8a8542cf5c6833abdd1e88d5c2317966ebf4cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490211 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819865}
-
Bruce Dawson authored
Now that the main thread's stack size is set independently from the default stack size of the process (by using a fiber) it is possible to increase the main thread's stack size without significantly impacting address space usage. By setting it to 4 MiB we can make it roughly consistent with the 8 MiB stack of 64-bit Chrome (based on the assumption that half-sized pointers should give us half-dized stack frames). This change, therefore, is basically a continuation of the change landed in crrev.com/c/1682227 to fix bug 977387, and it was enabled by the work to load the stack reservation of non-main threads (bug 981238). The net result of all of these changes is that the main thread has a much larger stack size, while total space used by stacks is lower than before (due to the process-default stack size being 0.5 MiB). Bug: 977387, 981238 Change-Id: Ia09b7b7c44d1e51dd6fe3cd1e549bd71c1a98b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490667Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#819864}
-
Vasilii Sukhanov authored
Change-Id: I3bb9c70cc809f763334202f95b93a70edbf2ce05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489651 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819863}
-
Hitoshi Yoshida authored
This CL is actually a revert of https://crrev.com/c/2298053 Currently, WorkItemLoadingScript and WorkItemNonLoadingScript refers a TestRunnerBindings to know which RenderFrame they work with. However, if we swap RenderFrameHost over processes on navigations, the references of the bound TestRunnerBindings become wrong. This CL removes the tight bindings again, and let work items know the frames dynamically. This CL also introduces an assumption again that the frames are the main window's one. Bug: 1136383, 1132180 Change-Id: If5257ed3be881ad806e9a65d610779581412a960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469419Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819862}
-
Alex Turner authored
Many users of ProfileManager::Create{,Multi}ProfileAsync use a callback constructed with base::Bind. That method is deprecated and should be replaced with the more explicit base::BindRepeating. base::BindOnce cannot be used as the callback may be called multiple times. This resolves all remaining users of base::Bind/Callback in chrome/test/ other than a single file, so the legacy presubmit exception is made more specific. Bug: 1140573 Change-Id: Ie90b385051e42ef95442d7e40175b7250dbbfc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488041Reviewed-by:Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819861}
-
Peter Kotwicz authored
This CL makes fetch_all_androidx.py pass in a path relative to the current working directory instead of a path relative to the chromium src for fetch_all.py's --android-deps-dir argument. BUG=1064277 Change-Id: I01ad71331f33c7c0925f005dfe7eaac4a5b1be74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491523Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819860}
-
Patrick Brosset authored
The new component structure in devtools makes this test fail, so I'm disabling it temporarily to land the frontend. Bug: 1137438 Change-Id: I285d7069c5746a7c9dbb91f5e9e142af5c015206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491984Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819859}
-
Katie Dillon authored
A few places in the scheduling code take a queue as an argument to recording metrics but don't actually use the queue for anything. This CL removes those references. This CL is also a pre-requiste for crrev.com/c/2453591 which refactors MainThreadTaskQueue to not extend TaskQueue. Removing these unecessary references makes that refactor simpler. Change-Id: Ie98e19e44be2e5d156981a775c757f97766d0c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486214 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819858}
-
Andrew Grieve authored
Caspian's caught more, so used that one. Bug: None Change-Id: I2c559ceb7ade128111166eea6756531a6e6896b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490358Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819857}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4492cf287a23..377d9b3b2b65 2020-10-22 janscheffler@chromium.org [WebVitals] Add new WebVitals lane 2020-10-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-22 aerotwist@chromium.org TypeScriptify StylePropertyTreeElement.js 2020-10-22 pfaffe@chromium.org Reland "Implement support for the JavaScript formatter API" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1127915,chromium:1137509,chromium:1137754 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2c4f618fedd0cb2dc38ab3f4e974ca808085476f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819856}
-
Rob Buis authored
This implements special drawing of largeop <mo> element in display style as described in step 3. of [1]. A new algorithm is introduced for that purpose and in particular only used for <mo> elements that are made of a single glyph. Existing painting logic for stretchy radical symbol is reused and adapted to work with largeop operators. [1] https://mathml-refresh.github.io/mathml-core/#layout-of-operators Bug: 6606 Change-Id: Icca70f4bf464417809970fecc101e5aa7f149621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414298 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
-
Rune Lillesveen authored
For properties which takes tree-scoped names, use a flag in css_properties.json5 that says so and invoke an ApplyProperty which takes a ScopedCSSValue. For all other properties call ApplyProperty with a CSSValue. Bug: 336876 Change-Id: Id1b4da29660e15f2149d36145bb3894fba7f369a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490001Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819854}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae7f748fc467..7b6f13473709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmentovai@google.com,beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: mmentovai@google.com,beverloo@google.com Change-Id: Ifea41f400c11d70f68ea131264a172be4e2323ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491966Reviewed-by:
-
David Bokan authored
Injected input should force generate a frame before being dispatched so that we ensure the compositor is aware of any touch event handlers and other side effects that may have occurred prior to the input. This was previously done for other modalities in this file in https://crrev.com/c/2437695 but not for mouse emulating touch. This causes the inspector-protocol/input/emulateTouchFromMouseEvent.js test to start failing when input is routed through the compositor. Bug: 915926 Change-Id: I135ecbcd8e69d3dad5ee3ff4bf3bd4de14e7a296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488543Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819852}
-
Olivier Li authored
Bug: 1135215 Change-Id: Ice1f4b65b3ff3e1bdbbdbbd3215f53a4a27f472d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485588 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#819851}
-
Owen Min authored
For extension request, the report only contains request, browser and profile path. It also includes user info on CrOS. Also change the existing with_profile=false flag to ReportType::kBrowserVersion. It's used by real time version report. The extension request only report will be marked specifically in the request proto. Bug: 1137964 Change-Id: Ife07a5e95131b42335c762e25cf40d24c4274b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490942Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819850}
-
Dave Tapuska authored
Appears CastMessage class is no longer used. Remove it. BUG=993189 Change-Id: I048a396ecadef03731680722302604a6a7e7e351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490273Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //base. Bug: 1113033 Change-Id: Ic88522e24b0836394a67a13369d75840c125c82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481290 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL adds the pressing animation to |Learn more| button in the incognito interstitial of the web sign-in flow. Bug: 1140903 Change-Id: I4181166b228d01aeb6c9d2a8f2495c847e3ed5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490100 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819847}
-
Ian Struiksma authored
This is a reland of 4e484a8f Disabled flaky test separately (crrev.com/c/2490849) so no change from original CL. Original change's description: > Give test hooks to allow autofill test to keep popup open > > On some test bots, mac dock or external values cause the browser to > make minor resizings of the frame. These are extraneous to our tests > so we would like to ignore those during tests. > > This CL provides a test hook by adding test access methods to > ChromeAutofillClient to make the autofill popup more > resistant to hiding from frame resizes, and then has AutofillUiTest > access that hook when running Interactive UI tests. > > This re-enables autofill interactive tests on mac bots. > > > Bug: 967588 > Change-Id: Id9e25988f0cf64f0aa0631a48d48eb982b116c34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473802 > Commit-Queue: Ian Struiksma <ianstruiksma@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818550} Bug: 967588 Change-Id: I605a05e69636e5dbbf7e240c882bf1406b1a3eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490868Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#819846}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Icda023abc2c5105c1796913cde5b94aaca7a4438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480627 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819845}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I944746422982223a5580db531c7bb3e6e94434fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492060Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c5f7774fc2a..f3ec9833e881 2020-10-22 jvanverth@google.com Fix storage class issues for push constant variables. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I1a76ecd737355f01fb8c4b028d5f8c0c29bbb319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491685Reviewed-by:
-
Ben Wagner authored
It is possible that a memory dump will be requested before the blink font manager is set. This can result in attempting to create a fallback font manager and ignoring the real one which may be set later. Avoid this situation by ensuring that the memory dump request does not implicitly cause a global FontCache to be created just to dump that it is empty. Bug: chromium:1140954 Cq-Include-Trybots: luci.chromium.try:win_chromium_dbg_ng Change-Id: If29d830c66f85552663384898fbf3d29fb6d67e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490503 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#819842}
-
Jan Wilken Dörrie authored
This change implements notifying the PasswordAutofillAgent about automated text changes to confirmation password fields if the user manually modifies a previously generated password. Bug: 1140499 Change-Id: Ia52e71819c608ee9aa9a574a4afbc7858c02ed23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489916Reviewed-by:
-
Fredrik Söderqvist authored
Introduces a new child-content-management class for use by LayoutSVGRoot and LayoutSVGContainer. Moves shared child management code from SVGLayoutSupport to it, namely: LayoutChildren(), HitTestChildren(), ComputeHasNonIsolatedBlendingDescendants() and ComputeContainerBoundingBoxes() Besides allowing nicer code-sharing (and thus depopulating SVGLayoutSupport) it also allows better handling of derived, and other, state relating to the collection of children. Change-Id: I009a9bcde670fa6f994a9195b08f2f58683b5370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489643Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#819840}
-
Brian Ho authored
SkiaRenderer uses the |are_contents_opaque| property to selectively enable alpha blending [1]. Without it, underlays will be entirely occluded by the "transparent" quad. This CL sets the |are_contents_opaque| property for quads replaced by underlays. Since this will be needed on all platforms that will use SkiaRenderer (e.g. ChromeOS and Cast), this CL moves the relevant logic up from DCLayerOverlayProcessor [2] into RenderPassInternal directly. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/skia_renderer.cc;l=1209;drc=1bcf9a08d9f39a91a37d025bb78c7877cfc525aa [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/dc_layer_overlay.cc;l=754;drc=36971a950ef4b6d8fe1a4e90382cca6eb2dfda37 Bug: 1114290 Change-Id: Ib7b8b389492457a6bbeb2fb913bd1706e04511ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354465 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819839}
-
Alex Turner authored
This is a reland of ed0b0d99 The UkmWorkerBrowserTests should now always have the identifiability study enabled, which was the cause of the previous failures. Original change's description: > Emit a UKM event on client connection to a ServiceWorker > > Whenever an execution context (whether a window or worker) becomes a > client of a service worker, the renderer will now inform the respective > ServiceWorkerContainerHost of the client's ukm::SourceId once it is > execution ready. This id will be passed to SWIdentifiabilityMetrics, a > new SWContextCoreObserver. This observer will them emit a UKM event > (Worker.ClientConnected) in order to associate the ServiceWorker's > ukm::SourceId with the client's. DedicatedWorkers' ukm::SourceIds are > not included as they exactly match that of their parent execution > context. > > This association is required both for attributing entropy consumption of > workers to sites, but will also help to gain insight into the cross- > connectivity between first-party contexts via shared and service > workers. Design doc (internal-only): > https://docs.google.com/document/d/1mx4-zI53cskB8j75Mis2q3rVrO8uHeJpwGuT8psbURA/edit?usp=sharing > > Bug: 1085645, 1134193 > Change-Id: I7d1728ebe15d162b980dd2e552622e4c4f91edc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321059 > Commit-Queue: Alex Turner <alexmt@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818555} Bug: 1085645 Bug: 1134193 Change-Id: I958c842277a91266b4f3f74a37ddfb1db67265b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485589Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819838}
-
Denis Kuznetsov authored
Discover app was replaced by Showoff app (crbug.com/1042109) without being launched. The only relevant part of Discover code is the PIN setup dialog during OOBE/First login UI that is kept for now. Fixed: 1110625 Bug: 1104120 Change-Id: I4df4edbbb0768996264c70735133ce63e9cc1912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487640Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Throttle isn't safe browsing related and doesn't needed to be guarded by a safebrowsing flag check. Change-Id: Ie59c7a9c87141b378cecc5ba4befdb97d21a2ca2 Bug: 1141329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490168Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#819836}
-
