- 10 Nov, 2017 40 commits
-
-
Gauthier Ambard authored
This CL makes sure that the AppState unit tests can run with ContentSuggestions enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0773b29330f1a0b139b0f25a707e9d58c1f87cd8 Reviewed-on: https://chromium-review.googlesource.com/758838 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515520}
-
Ricky Liang authored
The buffer vector may contain null buffers in case of error. BUG=None Change-Id: If13de598df06a69833921b6b2608cc6adb35904a Reviewed-on: https://chromium-review.googlesource.com/763189Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515519}
-
Elodie Banel authored
This value was assumed received on the histogram side but not sent, resulting in an empty histogram. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I58b4e97eca73f987db6380485d34ffe594329e1e Reviewed-on: https://chromium-review.googlesource.com/758855Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#515518}
-
Olivier Robin authored
This is the same logic as the getFormIdentifier. This fixes filling the CC form in nordstrom.com Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic1ee55a4c9a0ea92e0826579db0e0dca9473541d Reviewed-on: https://chromium-review.googlesource.com/751241 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515517}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f83c79a6db05..2671b653f331 $ git log f83c79a6d..2671b653f --date=short --no-merges --format='%ad %ae %s' 2017-11-09 dtu [pinpoint] AsDict() results_values fixes. 2017-11-08 nednguyen Reland "Fix reinit after failure"" 2017-11-07 crouleau Don't use grouping_keys for cache and traffic. 2017-11-08 dtu [pinpoint] Separate exception comparisons for each Quest. 2017-11-08 nednguyen Disable TestBrowserOperationDoNotLeakTempFiles.testBrowserNotLeakingTempFiles 2017-11-08 dtu [pinpoint] Compress Job.state. 2017-11-08 perezju [Telemetry] Log Telemetry's memory usage after collecting all results 2017-11-07 sadrul Reland "viz: Fix collecting rendering stats with viz." 2017-11-08 benjhayden Save memory with __slots__ in python Histogram library. 2017-11-06 benjhayden Fix default bin boundaries in python Histogram. 2017-11-07 benjhayden Fix a bug with results.html deep-linking sortDescending. 2017-11-03 sergiyb Add VPython checks to Catapult presubmit 2017-11-02 benjhayden Syntax updates for Polymer 2.0. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I612caf7be5d43f0caed353b8da3d33b7b416327c Reviewed-on: https://chromium-review.googlesource.com/762528 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515516}
-
Daniel Bratell authored
There are two NSString* const NSAccessibilitySelectedTextMarkerRangeAttribute = @"AXSelectedTextMarkerRange"; and in jumbo builds they will end up in the same translation unit and trigger compilation errors. This patch moves one of them to where its used which will prevent the clash and let the compilation proceed. Bug: 746953 Change-Id: Iaf440412f7780141f8d22f648dfef59358ef610c Reviewed-on: https://chromium-review.googlesource.com/758845Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#515515}
-
Martijn Croonen authored
Bug: 778047 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib879c1e7dfd9f664ed733dcc51a1f80e24fdc806 Reviewed-on: https://chromium-review.googlesource.com/751664Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515514}
-
Hitoshi Yoshida authored
In the original way, origin trial features are installed in V8PerContextData::ConstructorForTypeSlowCase on each context. However, if V8 objects are created from snapshot, those features were not installed. This CL make them installed again even when Blink uses the snapshot. Bug: None Change-Id: Iebf387afab27c2de2ec9c7f74312914269a43ece Reviewed-on: https://chromium-review.googlesource.com/762970Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#515513}
-
Mirko Bonadei authored
WebRTC unprefixed LOG macros will be deprecated on 10/11/2017. In order to remove backwards compatible macros from webrtc_overrides libjingle_xmpp needs to switch to RTC_ prefixed LOG macros. Bug: webrtc:8452 Change-Id: I8c8dbf36e0208e22f7f20c17a8b041ef3429f273 Reviewed-on: https://chromium-review.googlesource.com/762317Reviewed-by:
Henrik Andreasson <henrika@webrtc.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#515512}
-
Vaclav Brozek authored
This adds a straightforward fuzzer for components/password_manager/core/browser/import/password_csv_reader.* and also some seeed corpus and dictionary. Bug: 783111 Change-Id: Ic5193d4baa1c730db185059997c1a9fad1b2eef5 Reviewed-on: https://chromium-review.googlesource.com/758773Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515511}
-
Shuhei Takahashi authored
BUG=chromium:783535 TEST=None Change-Id: Ib9c41ae593ebe5f04832bb1c92d6fd16baf69558 Reviewed-on: https://chromium-review.googlesource.com/762727Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#515510}
-
Darren Shen authored
A stray LOG was accidentally left in the code. Change-Id: I39ba40d5459b1061579785c1ed11f28e8a381069 Reviewed-on: https://chromium-review.googlesource.com/762832 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515509}
-
Mikhail Pozdnyakov authored
This patch moves source sensors fetching logic to the newly created private PlatformSensorFusion::Factory class. 1) PlatformSensorFusion stops exposing a constructor which does not initialize it fully. 2) PlatformSensorFusion does not need to check it state internally as source sensors are initialized at construction time. Rationals: Change-Id: I24416e770d60c1d7f0c8ac2cc8cc1758038bca49 Reviewed-on: https://chromium-review.googlesource.com/760420 Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#515508}
-
Marti Wong authored
Fix the issue that when bookmarks exceeds screen height, the auto adjusted inset of tableView will cause the bookmarks to be shown under the navigation bar at the first appearance. An egtest is added to make sure this issue won't happen again. Bug: 772383 Change-Id: Id3f9b33b3b882d3b8a680d7ef8f9053565161541 Reviewed-on: https://chromium-review.googlesource.com/754661Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL is a precursor to converting the callers of sync_ui_util::ConstructAboutInfo() to supply the information of the signed-in user via the Identity Service. Analysis of this caller shows that it's actually dead code. Bug: 783144 Change-Id: Ia7060fe0e0af6ec54858bab800f8481281871cab Reviewed-on: https://chromium-review.googlesource.com/758586Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515506}
-
Colin Blundell authored
sync_ui_util::ConstructAboutInformation() currently only initializes the username field if SyncService::signin() is non-null. In an upcoming refactoring to change this function to use the Identity Service instead, it will no longer be possible for the client to differentiate the situation where SyncService::signin() is null from the situation where the user simply isn't signed in. To avoid coupling a behavioral change with a refactoring, this CL first explicitly makes the behavioral change to initialize the username field in all cases, setting it to the empty string if SyncService::signin() is null. The only user-visible effect that this will have is that if there are any situations wher SyncService::signin() is null in production, the user will see the username field being empty in chrome://sync-internals rather than having a value of "Uninitialized." Bug: 783144 Change-Id: Ie090a2635549072f86d15b86fb98891396abdb08 Reviewed-on: https://chromium-review.googlesource.com/758685Reviewed-by:
-
Shubhie Panicker authored
Bug: 764104 Change-Id: I45cd6ae2d0d4911e0f156e53333080c7e2bf53ba Reviewed-on: https://chromium-review.googlesource.com/762118 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#515504}
-
Yoshifumi Inoue authored
This patch gets rid of null |LocalFrame| checks from |SelectionModifier| since it is always non-null |LocalFrame| initialized from |LocalFrame&| to simplify source code for improving code health. Change-Id: I183aa2eb588d0f3d67c4255acc68f4b05f2771bf Reviewed-on: https://chromium-review.googlesource.com/762831Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515503}
-
Alexandr Ilin authored
The predictors::kSpeculativePreconnectFeature is explicitly disabled in net::Predictor browser tests because the LoadingPredictor if enabled intercepts all prefetch and preconnect coming from a renderer. WarmupManagerTest.testPreconnect() was expecting two connections to be opened but it's not the case for the LoadingPredictor, it opens only one connection. Bug: 699080 Change-Id: I73537c3a59818793e41c5741762fe675a4efa97f Reviewed-on: https://chromium-review.googlesource.com/754837Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515502}
-
Yutaka Hirano authored
They now pass. Bug: 441781 Change-Id: I98dad704808c2ed810ff9d03e0e49200b8e90209 Reviewed-on: https://chromium-review.googlesource.com/762930Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515501}
-
Wei-Yin Chen (陳威尹) authored
There are lots of occurrences of canUseGooglePlayServices() and canUseFirstPartyGooglePlayServices() using application context and silent error handler. These are refactored to static functions. Bug: 782496 Change-Id: Ifd554cb3ce62784db333f97f6a1bcb4a98999d28 Reviewed-on: https://chromium-review.googlesource.com/760697 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
Hooks tend to have implicit dependencies //.vpython covers or should cover all of them, so run all hooks via vpython Also add missing catapult's dependencies to .vpython. Bug: 781430 Change-Id: I5ec7a760f44bcb806c654ad8da303f78d3dbee3f Reviewed-on: https://chromium-review.googlesource.com/762037 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#515499}
-
Dan Elphick authored
Add a new GetRegistrationTask to be used by BackgroundFetchDataManager when the persistent storage flag is enabled. Adds the origin to the proto stored in the database and check it matches when retrieving a registration, otherwise trigger a storage error. Make BackgroundFetchDataManagerTest parameterized by persistence, which turns on the command line flag. Now all tests run (and pass) with or without persistence although the Cleanup test doesn't test much yet since there's no way yet to interact with a non-active fetch. Bug: 757760 Change-Id: I3aa29e17f9112f282f5672366e52522e549f32d0 Reviewed-on: https://chromium-review.googlesource.com/758762Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515498}
-
Renee Wright authored
Here is the diff of the generated files https://gist.github.com/rjwright/61829820d0cbb6d304eebc345a29ab76/revisions Bug: 779927 Change-Id: Ia13f9a0c6f788fc7b7030f1248a8ecd44ec6ba7b Reviewed-on: https://chromium-review.googlesource.com/760018 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7af1dc56fc10..0ffcc877a624 $ git log 7af1dc56f..0ffcc877a --date=short --no-merges --format='%ad %ae %s' 2017-11-09 nodir [gclient hooks] add .bat to vpython on windows Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I4186dae198699abdb543b860c8db91eb3d9baa6b Reviewed-on: https://chromium-review.googlesource.com/762947Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515496}
-
Rakina Zata Amni authored
Currently, EventTarget cannot be constructed or be subclassed (in JavaScript). The spec for EventTarget was updated to allow constructing and subclassing EventTarget. A new class, EventTargetImpl, is created as the user-constructable version of EventTarget. Even though the name is EventTargetImpl, it will be exposed as EventTarget to JavaScript. We are using a hacky approach by making EventTarget::Create return an instance of EventTargetImpl, which means an instance of EventTargetImpl will be returned when the EventTarget object is constructed in JavaScript. Spec: https://dom.spec.whatwg.org/#dom-eventtarget-eventtarget Design doc: https://docs.google.com/a/google.com/document/d/1TXMAkLeaNpbbETeqTyJZ57YnmqzgchyhFsANVZ2Ow3Y/edit?usp=sharing Bug: 740576 Change-Id: Ia0569ee99c4d856120c387ca6aceed5fbe1491b5 Reviewed-on: https://chromium-review.googlesource.com/754248Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
When multiple getUserMedia and stop() requests are active concurrently, getUserMedia() sometimes fails with TrackStartError. The reason is that the underlying video capture subsystem does not keep a count of how many sources have opened a video device. It can happen that a stop request stops video capture while a getUserMedia() request is being processed, with the result being that the video device is closed before getUserMedia() starts the new video track, resulting in an error. One solution to this problem is to make sure that stop requests and getUserMedia() requests cannot run concurrently, which is the approach followed by this CL. This CL basically moves handling of MediaStramTrack.stop() from MediaStreamCenter to UserMediaClient, and puts stop() requests in the same queue used for getUserMedia() and applyConstraints() requests. Bug: 778039 Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5 Reviewed-on: https://chromium-review.googlesource.com/751981Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515494}
-
Takashi Toyoshima authored
Since the feature was launched, let me remove the code for field trial. Bug: 683027 Change-Id: I2f09e1484c4b8e88f636e25a0a79847f6458ac35 Reviewed-on: https://chromium-review.googlesource.com/760140 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515493}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/309fa59a2992..c7056ca0027e $ git log 309fa59a2..c7056ca00 --date=short --no-merges --format='%ad %ae %s' 2017-11-09 npm Remove a couple of unused methods in CXFA_FFWidget Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I924626b6cd3c20eede9a2ffe7294b8713ad52cd8 Reviewed-on: https://chromium-review.googlesource.com/762770 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515492}
-
Darren Shen authored
We currently don't support relative URLs. This patch uses ScriptState to resolve relative URLs. Note that the CSSURLImageValue.url needs to return the original (relative) url given by the constructor. Since CSSImageValue already stores the relative url for serialization, we only need to expose it to CSSURLImageValue. Bug: 783031 Change-Id: I12b7ae8e98306e4debd6d3b1a9fd1ef1eca9752e Reviewed-on: https://chromium-review.googlesource.com/760057 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
This implements link rel=modulepreload without submodules fetch, behind the Experimental Web Platform feature flag. LinkLoader fetches module script using Modulator::FetchSingle, so it populates the module map but does not fetch descendant modules. Unlike the preload fetches by link rel=preload, this doesn't set FetchParameters::SetLinkPreload flag, so it works like a regular script fetch. HTMLPreloadScanner fetches module scripts in a similar way to speculative preload of <script type=module>, i.e. just fetch a ScriptResource and not populate the module map. Spec PR: https://github.com/whatwg/html/pull/2383 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ynkrM70KDD4 Bug: 740886 Change-Id: I5f4420e305f4962b3fbe3f703ce95a5a43e4f7a9 Reviewed-on: https://chromium-review.googlesource.com/662697 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#515490}
-
Yoshifumi Inoue authored
This patch changes |NextBoundary()| to utilize |EmitsSmallXForTextSecurity| |TextIteratorBehavior| to handle -webkit-text-security CSS property in |TextIterator| to reduce source code for improving code health. This patch is similar to the patch[1]. http://crrev.com/c/760218: Utilize EmitsSmallXForTextSecurity TextIteratorBehavior in PreviousBoundary() Bug: 778507 Change-Id: Ia62bcec825be863ff15a9075eeb22f2a6a9ee981 Reviewed-on: https://chromium-review.googlesource.com/760063 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yves Arrouye authored
Set a CrOS setting from cloud's device settings' forced re-enrollment. Add an enrollment policy observer which observes the setting and uploads an enterprise enrollment certificate when identification is needed. This certificate will be used by the server to obtain the device's enrollment ID for automatic forced re-enrollment. Bug: 778535 Test: unit_tests Change-Id: I7e95148e8101c27faa3dc1d21eb44971c79ee3c6 Reviewed-on: https://chromium-review.googlesource.com/758116 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#515488}
-
Tatsuhisa Yamaguchi authored
Zip Archiver is a new component extension that handles zipping and unzipping. After this change, Files app. will use Zip Archiver for unzipping zip files. It will also allow to unzip a zip file in the Google Drive volume or other non-local places. Bug: 783200 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3851c8c801d58a7573632e664b4fc2fca92acb83 Reviewed-on: https://chromium-review.googlesource.com/758696Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515487}
-
Daniel Cheng authored
Change-Id: I40fc2ff294e2f8c66380d49f0d350e7eba3c7bc5 Reviewed-on: https://chromium-review.googlesource.com/762949Reviewed-by:
-
Rakina Zata Amni authored
The spec for node filtering steps was recently updated, adding active flags to avoid recursive invocations. This change added the active flag property and the active flag checks in the node filtering steps. Spec: https://dom.spec.whatwg.org/#concept-traversal-active Bug: 753271 Change-Id: I7cdd57f86401bd6ea9a8012f28b47afa8a60a65b Reviewed-on: https://chromium-review.googlesource.com/760238 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Sriram authored
Bug: 782141 Change-Id: I243c94935989866778fa75169070326364ddfe38 Reviewed-on: https://chromium-review.googlesource.com/760438 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515484}
-
Yoshifumi Inoue authored
This patch changes |PreviousBoundary()| to utilize |EmitsSmallXForTextSecurity| |TextIteratorBehavior| to handle -webkit-text-security CSS property in |SimplifiedBackwardTextIterator| to reduce source code for improving code health. This patch is similar to the patch[1]. [1] http://crrev.com/c/760063: Utilize EmitsSmallXForTextSecurity TextIteratorBehavior in NextBoundary() Bug: 778507 Change-Id: I4612c7916498ee2604062ac50eb79803f93172e9 Reviewed-on: https://chromium-review.googlesource.com/760218 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
yoshiki iguchi authored
This change is prevent a notification from hiding during the user is entering a text. This CL works with: - ag/3166118 - ag/3174823 Bug: b/68156269 Change-Id: I1107e1141acebe62e8f381020534b007fa0cbaf5 Reviewed-on: https://chromium-review.googlesource.com/754252Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#515482}
-
John Abd-El-Malek authored
This is a followup to r514556 per comments in https://chromium-review.googlesource.com/c/chromium/tools/build/+/758799/. Bug: Change-Id: If42ea0e4bd43f10a5a44f7ce16dd4c721c9f3603 Reviewed-on: https://chromium-review.googlesource.com/761976 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515481}
-
