- 08 Oct, 2019 40 commits
-
-
Nina Satragno authored
When multiple virtual authenticators are in scope and a MakeCredential request is received, a credential is created on every authenticator due to the way we dispatch requests. Since this reflects the real behaviour (although in reality it's a very unlikely scenario), I don't think it's a bug. This created a non-deterministic failure where the ID of a created credential would not match the expected value on layout tests since the credential returned on an empty allowCredentials request would be the one created on a second authenticator. Fix this by cleaning up virtual authenticators created on individual tests so they do not interfere with each other. Bug: 1010863 Change-Id: Ibe2a987a3bb7a094008ab0c426f09065fc9bb59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847852 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703817}
-
zhaoyangli authored
Changed headers and moved some function calls to ChromeEarlGrey calls. Will create EG2 test target along with autofill automation framework migration in following CLs. Bug: 987646 Change-Id: I127aada72669c20bb01d87c711644e89a9326886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815582Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#703816}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7efb1a6dbcff..5899485b9a87 git log 7efb1a6dbcff..5899485b9a87 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 herb@google.com Add tests for SkZip first, data, and consting copy ctor 2019-10-08 brianosman@google.com Remove SkCurve and SkColorCurve 2019-10-08 egdaniel@google.com Also blacklist path_text benches on vulkan pixel3a. 2019-10-08 robertphillips@google.com Black list failing test(s) on internal bot 2019-10-08 fs@opera.com Fix mapping the morphology filter's radius when the CTM is a mirror op Created with: gclient setdep -r src/third_party/skia@5899485b9a87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:595244 Change-Id: I82736a6fa64218d7e8abd740215cdd7e49ba8e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703815}
-
Xiaocheng Hu authored
After turning on CORS for '-webkit-mask-image' (crrev.com/c/1838592), the most visited iframe can no longer perform the cross origin fetch for "chrome-search://local-ntp/images/close_3_mask.png" from its own origin "chrome-search://most-visited/". To prevent this, this patch changes the mask image to be served from the same origin "chrome-search://most-visited/". Since the image is used only by NTP, this patch also moves the image files from ui/resources/ to chrome/browser/resources/. Bug: 786507 Change-Id: I3b44489040c036cf24d8539517cc363d2b510c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841506 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#703814}
-
Mandy Chen authored
The localization parser currently logs the error stack and error message when running without the --autofix flag. Since the stack includes the error message, this CL takes out the call to log the error message to avoid duplicate error messages. Bug: 941561 Change-Id: If8c5f05148be6e2eb666eb17cefe649715006209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820088Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703813}
-
Lei Zhang authored
Move iOS strings from ui/strings/ui_strings.grd to ios/chrome/app/strings/ios_strings.grd. Change-Id: I1e8c443bd3dc3631e77d06cbc4cfc9eb286aeb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839373Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703812}
-
Yulun Wu authored
Bug: 1011933 Change-Id: Ia485a0263f891e303fe6906bb608d7ce6e2a67cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846035Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703811}
-
Albert J. Wong authored
This paves the road for deleting the RenderWidgetHost for RenderViewHosts that do not have an in-process top-level frame by removing unnecessary accesses to the underlying RenderWidgetHost. Bug: 545684 Change-Id: I78b7d93c9f17f767a10ec28a098a99d098bcc60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846087 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703810}
-
Nate Fischer authored
No change to logic. This moves WebView's Safe Browsing java code into a subfolder, and links the OWNERS file against //aw/browser/safe_browsing/OWNERS (which has the same ownership as the Java files do currently). This adds a temporary adapter version of AwSafeBrowsingConfigHelper, in order to keep the downstream targets building. Bug: 934597 Test: ninja -C out/Default system_webview_google_apk Change-Id: I81c1ca498a7d6c2d76256b46e734f2cbf8d95b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845882Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703809}
-
Jimmy Gong authored
- Update the empty state of the printer settings landing page. Bug: 1010716 Test: End to End manual, browser tests Change-Id: I69e84035acd0f859f9f707a2550dee16ec9daa9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845993Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#703808}
-
Miguel Casas authored
This CL adds the simplest MailboxVideoFrameConverterTest that basically initializes a MailboxVideoFrameConverter and lets it fall out of scope. Later CLs will add more testing. Test: media_unittests --gtest_filter=MailboxVideoFrameConverterTest* Bug: 998279 Change-Id: I74ecb0b02b00cd5d301819e1e8466dc89f0144d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830108Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#703807}
-
John Budorick authored
This reverts commit ed8151f9. Reason for revert: suspected cause of increased CQ false rejection rate, https://bugs.chromium.org/p/chromium/issues/detail?id=1011915 Original change's description: > Change default retries for components unittests to 0 > > Bug: 993428 > Change-Id: Id21490633dfb7ae92f73b0bdc9b2f81191f00ccb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801021 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Ilia Samsonov <isamsonov@google.com> > Cr-Commit-Position: refs/heads/master@{#700857} TBR=thakis@chromium.org,erikchen@chromium.org,isamsonov@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993428 Change-Id: Ie9c97d3e250eb5789d7095dd145b66afddf4363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846805Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703806}
-
Gavin Williams authored
Three places where this was changed: - When opening the Language settings from the notification tray. - When opening the Language settings from the accessibility virtual keyboard. - When opening the Language settings from ARC++. Bug: 1008353 Change-Id: I247380aed63004b61c397726498541485076add7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836551Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
As part of upcoming changes to cellular representation in OOBE, we will no longer be providing the option to attempt cellular activation, so unactivated cellular networks will no longer be able to be chosen. However, omitting cellular networks entirely could confuse users who expect a cellular entry to be on the list. Thus, instead of removing it entirely, we show a "Not available" message beneath the network name. Note that this property is not actually used yet at this time; it will be applied to network_select_login.html at a later time when the rest of the cellular OOBE changes are complete. Bug: 1011574 Change-Id: I157bae86270ff82a432b66d93f6f6bc4d4737d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842222 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Koji Ishii authored
When there are no script segments (i.e., all the text is in single script) and in vertical flow, we create a single segment and split it at the font-orientation boundaries. This patch fixes to create the single segment from the first text item, not from the first item. If it is created from the first item and the first item is not a text item, we may give incorrect script and/or font-orientation to HarfBuzz. Bug: 10061548 Change-Id: I5ea87920f8cbc76cdc13fe25611f7a7a34284813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847697Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703803}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ad5811accae..1458d572f950 git log 1ad5811accae..1458d572f950 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 tandrii@google.com recipe_module git: remove non-LUCI mode. Created with: gclient setdep -r src/third_party/depot_tools@1458d572f950 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012148 Change-Id: I653f2a4dad0c45b7878f829d7554a7968c50a912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846765Reviewed-by:
-
Xinghui Lu authored
Pros: Good memory locality, low overhead especially for smaller maps. Cons: Inserts and removals are O(n). But since the keys are profiles, there shouldn't be too many insert and remove operations. Bug: 995926 Change-Id: I2b26d5ebeba3c12732c3ad71a772afaa0262cf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845577Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703801}
-
Lei Zhang authored
Clearly indicate pointer ownership. Fix nits along the way. Change-Id: I721a6c543197f18effe5b050885b7a9a8f3f524b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843394Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703800}
-
Piotr Bialecki authored
Tested via dry-running the update_bucket.py (`python update_bucket.py -n -v --force-generate-latest`), manually creating a file with the contents of latest.html that are printed out by the script and uploading the new file to the bucket & testing the redirection. Change-Id: I9ab9297d6f850db5aa7273efabdb6e464b72e629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845665 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#703799}
-
Donn Denman authored
Fixes the scrolling of the base page during the expansion of the panel. There were several problems: 1) The SelectionPopupController was not returning the x,y value when the selection handles are shown. 2) The Overlay panel was mixing dps and pixels in the offsetting calculation. 3) The Contextual Search panel didn't know about the layout adjustment. Now the selection should end up centered when the panel is expanded. BUG=1012274,1011021 Change-Id: I16d69b8b2b4e14d9b3207d0f42ab0a8eb869b230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845790 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703798}
-
Caleb Raitto authored
Change-Id: I18861df1cb95a2e8a5756c8a00da4f3ff57da098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846016Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#703797}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2d888f8eb5dbca2d3cc4fbc9e644126f02a01932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846764Reviewed-by:
-
Marc Treib authored
Turns out these still require some extra cleanup on the server. This is a partial revert of crrev.com/c/1821520 and crrev.com/c/1824261. Bug: 965503 Change-Id: I97b7a6f7282351f2b8905483ac0c0a618a4fcc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847290Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703795}
-
Roger Tawa authored
Bug: 1012270 Change-Id: Ic35c3a7c331d353db8a938e11ea78d5ca38f6f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847792Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#703794}
-
Nicolás Peña Moreno authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: Iaed9dbf26f7668c758416558b82e80c015080725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837656 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#703793}
-
Lan Wei authored
In this test, we want to test that testdriver Action API supports key and mouse action interactions. Clicking with "Ctrl" key pressed on Mac causes a context menu open, which fails itself and prevents a subsequent test from running. We can use other keys such as "Shift" or "Alt", which do not open any context menu. Change-Id: Id9b48440306eeddbd97114bc1ac0f4c9c3c012fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845994 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703792}
-
Henrique Nakashima authored
Bug: 995916 Change-Id: I780da4d5689a58a3002321aae8687db96ca859c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830011 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#703791}
-
Nick Diego Yamane authored
In X11, TouchEvent destructor must clear native event id mapping, created at construction time for TOUCH_{RELEASE,CANCELLED} events. It was doing that using native event (i.e: XEvent) info, which is undesired [1]. This CL address it by abstracting away the pointer_details.id => native tracking id from TouchEvent implementation, into X11-specific TouchFactory. So when a new touch id is created (at TouchEvent's ctor for native events) a new entry is added into TouchFactory table and removed in the destructor of the corresponding RELEASE/CANCELLED. Additionally, a cleanup is done, removing unneeded flag and methods as it is a X11-only logic and it was possible to simplify its implementation. [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 965991 Change-Id: I36c568d0ef627c6d2e900e47bfecd08345a3cc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816779 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#703790}
-
Ben Pastene authored
🙄 Bug: 1005370 Change-Id: I4e73a9871572595520a908f347034cd8287c601b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845798 Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by: -
Robert Ogden authored
Bug: 1011457 Change-Id: I39016ea24cd296b3ed0ed95a2556e7941fdb9390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845937Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#703788}
-
Misha Efimov authored
This avoids immediate dereferencing when local scoped_refptr() goes out of scope. Change-Id: Ibf7bc85ca23cd36d8c1e527edb2a70e9d081e8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846351 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Misha Efimov <mef@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703787}
-
Friedrich Horschig authored
This CL ensures that blank usernames display a translated version instead of an empty string. Bug: 1011836 Change-Id: Ic473e5adc59375c638c04b60ca81e0934891aec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847303 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#703786}
-
Kush Sinha authored
Initially observed in Chrome OS Account Manager's account addition screen, chrome://chrome-signin does not declare its encoding as UTF-8, leading to non-ASCII localized text to be displayed incorrectly. Fix this by declaring the encoding as UTF-8 in the HTML WebUI page. Bug: 1012269 Change-Id: Idc598157489355f9999e60f0e45f65de07c8f582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847307Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#703785}
-
Christian Dullweber authored
The current approach is very brittle and requires a sentinel value. Change to a simple vector. Also fixes a bug where DialogClientView would crash when used with only an extra_view and no buttons. Change-Id: I63a7ca82138f76b96169cf1777a7aa564f2a9890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847218 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#703784}
-
Gavin Williams authored
This reverts commit 0ac392fe. Reason for revert: Settings search bar loses focus on search cancel. crbug/1011752 Original change's description: > Prevent settings search icon from flashing when a search is cleared > > Bug: 1001056 > Change-Id: I326b21b3e25e472fa15dc9bd9d9c97feb688ad4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815542 > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Commit-Queue: Gavin Williams <gavinwill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699457} TBR=stevenjb@chromium.org,zentaro@chromium.org,baileyberro@chromium.org,gavinwill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1001056 Change-Id: I1bcad3ef2b08fdb130d289a9c9619337078570c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847796Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#703783}
-
Kenneth MacKay authored
This reverts commit 9413e636. Reason for revert: cast_media_unittest failures Original change's description: > [Chromecast] Statically link CMA backend when possible > > Merge-With: eureka-internal/321778 > > Bug: internal b/127963522 > Bug: internal b/141138924 > Change-Id: I08813895e48ea3e983258e3e0d316b8acda740b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842677 > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Commit-Queue: Kenneth MacKay <kmackay@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703747} TBR=spang@chromium.org,halliwell@chromium.org,kmackay@chromium.org Change-Id: I5ab4f1257615e5d89ab815d880252544dec0767c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: internal b/127963522, internal b/141138924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846806Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#703782}
-
Daniel Libby authored
In the Edge fuzzer runs, we're seeing crashes in sequence_manager_fuzzer via ThreadManager::PostDelayedTask. The root cause appears to be the fact that a cross-thread post can execute on one thread while the thread where the target ThreadManager lives is executing a shutdown task. The TestTaskQueue pointer that is held by ThreadManager::PostDelayedTask can be deleted when the TaskQueueWithVoters is erased from the task_queues_ vector. Keeping a scoped_refptr on the stack allows safe use of the TestTaskQueue pointer for the duration of the function, and the task runner infrastructure gracefully handles posting to a TaskQueue that has gone away. That change alone fixes the fuzzer crash, but there's still a race - since only GetTaskQueueFor is protected by the lock (same lock is acquired before erasing the vector entry), it's possible for the TaskQueueWithVoters to be destroyed along with its queue before we take the extra reference when assigning the stack scoped_refptr. To fix this, I've converted TaskQueueWithVoters to a thread-safe refcounted type and GetTaskQueueFor now returns a scoped_refptr<TaskQueueWithVoters> instead of a raw pointer. Bug: 977527 Change-Id: I9f49531bd7d8c76bae36a65ed150c32714039d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835216Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703781}
-
Nick Diego Yamane authored
As part of X11 PlatformEvent migration effort, this CL eliminates native_event() usage from KeyEvent::IsRepeated method, which is only called at object initialization, this eliminating one more native event usage after event object construction. This corresponds to item 1.5 of PlatformEvent migration doc: https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 965991 Change-Id: Ib5ad9f7da00e1d26b86616033eee343676e5a494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816777Reviewed-by:
-
Dominic Battre authored
By default, the NetworkService bootstraps a leaking SystemDnsConfigChangeNotifier singleton object in NetworkChangeNotifier::NetworkChangeNotifier(). This SystemDnsConfigChangeNotifier observes the DNS configuration (via FilePathWatchers on /etc/resolv.conf and /etc/hosts on POSIX and via ObjectWatchers on the registry on Windows). These watchers outlive the BrowserTaskEnvironment of the RenderViewHostTestHarness, including it's message queues. If the trybots experience network changes (e.g. due to expiring DHCP leases or other problems), it is possible that the watchers post messages to a message queue that has been destroyed already, see crbug.com/1011275#c3. This CL introduces a MockChangeNotifier which does not observe network changes. This is probably fine for RenderViewHostTestHarness tests but we should evaluate whether the network service needs to bootstrap a leaking SystemDnsConfigChangeNotifier or whether that can be scoped to the lifetime of the NetworkService. Bug: 1011275 Change-Id: I50359d5c3e8631a3e03a5f2bee4e94bb7f45c53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847215 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#703779}
-
Fredrik Söderquist authored
Tests a new begin/end being added by a syncbase, and the corresponding 'end' event being fired. Bug: 998526 Change-Id: Ie40f196d4ef2c5fb6b65fced80890a965415cace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840692 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#703778}
-
