- 23 Dec, 2020 40 commits
-
-
Gil Dekel authored
As explained in crbug.com/1161556, hardware mirroring is rarely used, and when it is, it often results in unfavorable outcomes. This CL introduces a disabled-by-default flag to control hardware mirroring as the first step towards permanently disabling it. Bug: 1161556, b:176092209, b:127878082, b:173159439 Test: display_unittest && ozone_unittest Change-Id: I02b356626d077c15f4c90f6b44d95d66214ad671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601397 Commit-Queue: Gil Dekel <gildekel@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#839184}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3c9279ae878962c1694187947f7c1d3a14967356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602362Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839183}
-
David Tseng authored
R=akihiroota@chromium.org, josiahk@chromium.org Fixed: 1161524 Test: existing browser_tests --gtest_filter=ChromeVox*.*Select* Change-Id: I5c6e72b78bdcd7db829e67e712d8b7ce965b4de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602113Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839182}
-
Sam Maier authored
Change-Id: I746c6af582fa88d74cf8c6cb4c6e6ecdbed62b95 Bug: 1159984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595259Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#839181}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33bf309c1d45..a4fb42ac92cc 2020-12-23 jiawei.shao@intel.com Enable two dawn_end2end_tests on Win/Intel/Vulkan after bot upgrades If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4066587f0c933f95fa2d2196e53be70c4bc900af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602497Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839180}
-
David Bokan authored
Both overrides of GetKeyboardConfig only ever call this method once and the chrome/ version already runs it with std::move. Bug: 1152268 Change-Id: I23861fd1945f62654bb0692492f61e73e94ab0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601517Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839179}
-
David Bokan authored
This class keeps a list of callbacks to invoke on page load but clears the list after invocation so they can only ever be invoked once. Bug: 1152268 Change-Id: I97e43b14be743ef6798ce7281b6003e6d34c99cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601228Reviewed-by:
-
Xiaoqian Dai authored
Bug: None Change-Id: I174f12dbaecc64e83f8fabbe53a481549dc79a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600052Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#839177}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33c64a447368..20fad3206488 2020-12-23 brianosman@google.com SkSL: Hide most integral types from runtime effects 2020-12-23 brianosman@google.com SkSL: Remove many unused sampler types 2020-12-23 brianosman@google.com SkSL: Hide non-square (half) matrices from runtime effects 2020-12-23 fmalita@chromium.org Add rsx_blob_shader GM 2020-12-23 reed@google.com Use bitmap.asImage() 2020-12-23 reed@google.com Work on hiding filter-quality 2020-12-23 brianosman@google.com SkSL: Remove all $gsamplerFoo types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I2876283ee04bfb56f43f91e8c396e98177ea3623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600581Reviewed-by:
-
Cattalyya Nuengsigkapian authored
This is a reland of http://crrev.com/c/2581684, which was reverted by http://crrev.com/c/2601580 due to flakiness of the test NoWindowInActiveDesk. The issue is that CompleteCycling() activates a window in another desk, so deskSwitchAnimation takes a screenshot and sometimes fail if the test ends before it is taken. TBR=afakhry@chromium.org Original CL description: - Add a tab slider and update windows shown in Alt-Tab so that "Current desk" mode only display windows in the active desk, while "All desks" display all windows. - Handle special cases: As before, entering Alt-Tab with less than two windows aren't allowed. However, if users switch from the all-desks mode to the current-desk mode resulting in zero or one window, it should show "no recent items" or show a window consecutively. - Hide behind Bento flag and make sure to overwrite kLimitAltTabToActiveDesk in case of conflict, so the old flag works. - Disable remapping Alt+LeftClick to a right click when using Alt-Tab. - Ash unittests for switching between modes and special cases. Bug: 1142726 Test: A manual test (a video in crbug) and unit tests `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.*` Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581684Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#838709} Change-Id: I52c67cbb878fc33dac5ee0d8b59cc4310eb08f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601480 Cr-Commit-Position: refs/heads/master@{#839175}
-
Daniel Libby authored
After crrev.com/c/2586450 removed NGPaintFragment and templates, this class is much easier to reuse in upcoming changes for selection recording for non-NG text, replaced, and SVG text. Remove dependencies on NGInlineCursor, force the caller to provide the selection rect, and factor out the early out checks so callers can compute the rect only when necessary. Bug: 1065049 Change-Id: If4bcc660c5e5b288fec0e0432d377d4d6289a878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598097Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#839174}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/815ee4029d9e..6005f1179a65 2020-12-23 fmayer@google.com Simplify GetPerfettoBinaryPath. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie6db04b050576657a5f417b119ef7a04e8bab48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600931Reviewed-by:
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. A previous CL added an accessor to net::HttpBasicState as well as one to net::HttpStream. This change continues the plumbing by adding a field to net::HttpResponseInfo to store the alias list in the HttpCache and the code to net::HttpNetworkTransaction and net::HttpCache::Transaction to save the aliases to this field. We moreover add the code to network::URLLoader to set the field `dns_aliases` in network::mojom::URLResponseHead. Relevant tests: net:net_unittests out/Default/net_unittests --gtest_filter=*Dns*Alias* services/network:tests out/Default/services_unittests --gtest_filter=*Dns*Alias* Bug: 1151047 Change-Id: I9adebfcc5fa811ece4d55e70f3d624d495ca6d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569956Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#839172}
-
Sam Maier authored
Bug: 1029038 Change-Id: I84568516fea23cf21bc91afb79bb90096d8a5963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595721 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
-
manukh authored
Split AC was added in CL crrev.com/c/2424985 . It allows e.g. the input 'a c' to match the text 'a [b ]c[ d]' When generating the text selections from word matches, it removes empty matches and merges adjacent matches. E.g. the input 'a b' produces the selections 'a b[ c]' instead of 'a| |b[ c]'. This is desirable usually, but not desirable for the last selection which is used to determine the cursor position; merging or filtering the last selection incorrectly alters the cursor. This CL makes sure to preserve the last selection and, therefore, the correct cursor. E.g. the input 'a c' produces selections 'a [b ]c|' instead of 'a [b ]c'. Bug: 1062446 Change-Id: Icfb13321d86454a8a2fbc89289fefda53287b770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601046 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#839170}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61cbb8911dcc..815ee4029d9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2f421f3f0e7503143bc20b058f6b5189199d1297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602111Reviewed-by:
-
Tom Anderson authored
After [1], Chrome and ANGLE use separate X11 connections, so in order for Chrome to receive exposure events, it must select for them its own connection. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2492177 Change-Id: If01cd9d106bf900a5c7a56768602b34dc50b1a23 Bug: 1158170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602441 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#839168}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608724675-36d361379e6ecc2792aff1f82c923e32f70d38c4.profdata to chrome-mac-master-1608746256-3ed2cb6bb1e0224e9725c01d978e3ae9cf598e54.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic9519823505646d1c7cd055ec7ba781cef58194c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602496Reviewed-by:
-
Alan Screen authored
The Linux sandbox causes created files to be automatically deleted once they are closed. This means that creating a file without leaving an open file handle is useless afterwards for any subsequent calls expecting it to exist with results of previous work. Change ParsePpdCapabilities() to open a stream for a temporary file and keep that open for the duration of the file operations, instead of doing multiple open/close operations against a common filename. This is necessary for supporting sandboxing of the print backend in a utility process. Bug: 809738 Change-Id: Id16dc686873decad7be980ce4621747b4233184a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597143Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#839166}
-
Frank Liberato authored
WeakLearningSessionImpl::PredictDistribution accessed the session, without first checking if its weak ptr was valid. This CL adds that wp check. Bug: 1159663 Change-Id: I2c26fd8cb22cd2c78d39267e58e8b79217cee1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602258Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#839165}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608724675-48ba6591ad34bc4b599f70e6d7e6561723f787a8.profdata to chrome-linux-master-1608746256-194231b3dc387c7a03e0631c0ae6df5b6e567b63.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id4e4946b70d99e7323975c1fd1be9696e6541d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600584Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1160106 Change-Id: I51ec6cf9c745f48e389feda26515ceaded5a5e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597792 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Auto-Submit: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d75fb83845d1..0162f9bf2635 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: chanli@google.com,mohsen@google.com Change-Id: I81e9e0bc8df06e5405bedc4d45681e976776fbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602436Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839162}
-
Mason Freed authored
There should be no behavior change from this CL. Change-Id: I009e877e711ef85deb4a2391412a598757d20999 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601717 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#839161}
-
yjliu authored
Two steps are used to track if a surface intersects damage from under it. 1) When the surface (assume A) accumulates damage in AccumulateDamageFromRenderSurface(), if the surface doesn't intersect any damage, it would be appended to the vector |surfaces_with_no_damage_under|. 2) When surface A's render target (assume B) computes damage from left-over rects in ComputeSurfaceDamage(), A (and all other surfaces rendering to B) will be removed from the vector |surfaces_with_no_damage_under|. For example, suppose, nodes below all represent render surfaces. A / \ B C /\ /\ G H J K B,C renders to A; G,H renders to B; J,K renders to C. The draw order is K, J, C, H, G, B, A. During damage tracking, G and H, for instance, will be added to the vector when they each AccumulateDamageFromRenderSurface(), and then when their parent B ComputeSurfaceDamage(), both G and H will be removed from the vector. This means the vector's use pattern is similar to a stack: a surface's children will first be appended to the vector, and then the surface itself will be inserted into the vector after all its children are removed. Based on such an idea, in this CL, ComputeSurfaceDamage() no longer iterates through all elements in the vector, but rather, stops at the first element that's not current surface's children. Bug: N/A Change-Id: I22a022530f6869a5dd3b07f900da2c3e1ede2079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582843 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:weiliangc <weiliangc@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839160}
-
Hui Yingst authored
|top_toolbar_height_in_viewport_coords_| and |background_color_| are common attributes for both OutOfProcessInstance and PdfViewWebPlugin. This CL moves them to PdfViewPluginBase, and provides accessors and mutators for them. Bug: 1140629 Change-Id: I1df7ea3d8e89e5d3ab3ff00ba5bfe40170ac2c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599704 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#839159}
-
Yue Zhang authored
This CL adds the skeleton of chrome cart service which will later be used to read, write and maintain data of chrome cart module. This CL also adds a singleton CartServiceFactory to acquire CartService. Bug: 1157892 Change-Id: Ia4bde1bc514cf83fe445f8c8be24b093b05fb0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597813 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#839158}
-
Jamie Madill authored
https://chromium.googlesource.com/vulkan-deps/+log/b08eace32e9c..d0adb7e24551 $ git log b08eace32..d0adb7e24 --date=short --no-merges --format='%ad %ae %s' 2020-12-21 jmadill Rolling 8 dependencies Created with: roll-dep src/third_party/vulkan-deps Bug: chromium:1153258 Bug: angleproject:5390 Change-Id: I95ce78ca1f44fa03c2f4220badf97815b07a072a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595260Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#839157}
-
Jamie Madill authored
This removes the checked-in copy of Vulkan-Headers from Chrome. We replace it with the mirror of the official Vulkan-Headers in the "vulkan-deps" meta-repo. Updates several source files and scripts to use the canonical version. Bug: 1158425 Change-Id: I8dc2ac618dd8cb68938cb13cb72e169cca0c20a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600196 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#839156}
-
Ghazale Hosseinabadi authored
This CL replaces the clear button with an edit button, and introduces a read-only mode for the shortcut input. That way, when the user navigates over the field in read-only mode, it reads out the current shortcut. Tbr: cpu@chromium.org Bug: 1031007 Change-Id: I7881288a6c141b8ca2717bafb9ccb50e12ea7642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575346 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839155}
-
Zhenyao Mo authored
BUG=1069262 TEST=bots R=kbr@chromium.org Change-Id: I0e7250c49204c051512abbd43478a13f157f0cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602224 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#839154}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8986f3ce67ec..61cbb8911dcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I578187606261f88243e0eb9f3b709dfc53dc0362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602110Reviewed-by:
-
Roman Sorokin authored
Update screen was renamed in http://crrev.com/c/2230462 in M85. If device updates from <85 to >=85 version - pending update screen (from local state) is not recognized. This makes Chromebooks start from the welcome screen again. Chromebases, Chromeboxes and Chromebits might actually suffer from the white screen on M85 and M86. Users can't bypass the screen and have to recover devices. This CL handle this rename gracefully. Fixed: 1160383 Change-Id: I1bc529791ef3072ce397cb85640416117ac85a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600910Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839152}
-
Stephen McGruer authored
This is a manual copy of an automated import, with the tools/ changed backed out due to bug 1161210. Using wpt-import in Chromium 18a0e912. With Chromium commits locally applied on WPT: fda9a53d "Replace 'dummy' with 'sample' for inclusive language" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm bokan@chromium.org: external/wpt/scroll-to-text-fragment domenic@chromium.org, hiroshige@chromium.org: external/wpt/import-maps finnur@chromium.org, peter@chromium.org, rayankans@chromium.org: external/wpt/contacts foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools garykac@chromium.org, joedow@chromium.org: external/wpt/keyboard-lock jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mkwst@chromium.org: external/wpt/cookies external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mlamouri@chromium.org: external/wpt/mediasession npm@chromium.org: external/wpt/event-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true Bug: 1161210 No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ie906ab1bc036ea00b82032b377823dda97134bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601738 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839151}
-
Ahmed Fakhry authored
Since we can't have more than one recording at a time, we should disabled the video recording toggle button when the capture mode session starts while recording is in progress. BUG=1160343 TEST=Manually, added a new test. Change-Id: Ib6b169c584b1fdf84926995a94fa07000be66c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601856Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#839150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65b4827f1679..33c64a447368 2020-12-23 brianosman@google.com SkSL: Remove "null" as a type and literal value. 2020-12-23 brianosman@google.com Remove use of uint from particle random system 2020-12-23 bsalomon@google.com Remove public getter for GrSurfaceDrawContext on SkSCanvas. 2020-12-23 reed@google.com Bitmap.asImage() 2020-12-23 brianosman@google.com SkSL: Remove $gvec and $gfloatN types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Iaef13c9350bca3d8ece02c8de0346f7d8c4edff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602067Reviewed-by:
-
Mason Freed authored
This is a reland of dbfed21f --> Patchset 2 contains the fix, just a missing initializer on an int in the test. Original change's description: > Fix several crashes when nested slots are removed from a ShadowRoot > > There were some crashes caused by nested slots (e.g. > <slot><slot>Content</slot></slot>) being removed from the tree. > These crashes were triggered by [1], which removed Shadow DOM v0, but > my theory is that due to the old V0 shadow root code, more calls were > being made to SlotAssignment::RecalcAssignment(). Now that the V0 code > is gone, it has exposed some missing code. > > Three issues are being fixed here: > 1. In Node::CheckSlotChange(), while removing the inner nested slot, > the parent_slot will have already been removed from the tree, so we > only need to call DidSlotChange if not. This used to be a DCHECK. > 2. In TreeOrderedMap::Get(), while removing a key that previously had > more than one element, we may walk the tree and find that none of > the pre-existing elements are present. I.e. we're in a RemoveScope. > In this case, the key should be removed from the map. > 3. In SlotAssignment::DidRemoveSlotInternal(), given #2 above, we can > just early-out if the slot isn't present in the map. > > I added a test for the crash conditions (variations on removing nested > named and unnamed slots), plus I added a test for the TreeOrderedMap > class, since there was none previously. The last test in the set > documents the new Get() behavior. I also tried to improve some of the > comments along the way. Finally, this CL rolls back a mitigation [2] > previously landed for this crash. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 > > Bug: 1159328, 1159727 > Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838974} Bug: 1159328 Bug: 1159727 Change-Id: I0025c0f00d6b3876de8f40a60fdc34f726ddc85c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601051 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839148}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie537aafacdd96fed47b0464c404df597a54aa5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602063Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8986f3ce67ec..61cbb8911dcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iee57e37b1c631564bfea628fa126478496279820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602223Reviewed-by:
-
Sujie Zhu authored
Clean up nicknameManagementEnabled flag and remove the legacy elements and CSS config. Local build test video after clean up(googlers only): https://drive.google.com/file/d/1uYmVuIjlThiGl-TTeGvPrZWvDtkBJwKJ/view?usp=sharing&resourcekey=0-hMW3nVLEyQ7fbLzV5RHwqg Bug: 1082013 Change-Id: Ie5ba1372cf510decb17a113c67ed5aee11eeb755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600180 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#839145}
-
