Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 24 Aug, 2018 37 commits
  3. 23 Aug, 2018 3 commits
    • Eric Karl's avatar
      Android OOP-D: Tear down display when going invisible · 7c6485d8
      Eric Karl authored 
      When Android goes invisible in OOP-D, it wasn't tearing down the
display, which can lead to GL issues as we continue to use GL
after the window (used to create the GL surface) is destroyed.

In order to tear down the display for Viz, we need to invalidate
our root frame sink ID. This change refactors things so that we
always invalidate the root frame sink ID on going invisible, and
re-register it on becoming visible. This allows both viz/non-viz
to share the same logic.

As registering/unregistering isn't doing much in non-viz case,
this doesn't add significant overhead there.

Bug: 863049
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1589e402185fd9e2cdb007d3d8cd739f303ad48a
Reviewed-on: https://chromium-review.googlesource.com/1184376Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585664}
      7c6485d8
    • Tom Anderson's avatar
      GTK4: Fix crash when drawing certain frame buttons · 7004b5ed
      Tom Anderson authored 
      BUG=876586
R=sky

Change-Id: Iac4f45a4aec1a905b75332ed7b365d1a2fce1d87
Reviewed-on: https://chromium-review.googlesource.com/1187223
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585663}
      7004b5ed
    • Paul Miller's avatar
      Rename android_webview::GetChannel · f7542b65
      Paul Miller authored 
      Commit 0c0fc42d moved
AwVariationsServiceClient's "channel == unknown ? stable : channel"
logic into a new android_webview::GetChannel. But this is confusing
because the new GetChannel retains the variations-specific comment, and
the name "android_webview::GetChannel" might sound like all of WebView
should be using this sanitized channel, when UMA still needs the
un-sanitized channel.

Move the variations-specific comment back into AwVariationsServiceClient
and rename GetChannel to GetChannelOrStable.

BUG=758290

Change-Id: I4590aa22b73424e14e47444c3fdf3abc151bf441
Reviewed-on: https://chromium-review.googlesource.com/1187271Reviewed-by: default avatarBo <boliu@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585662}
      f7542b65