GitLab

Also disables the hash tests which seem to be flaking on the bots.
I was not able to reproduce this flake locally under valgrind.

BUG=492882, 496466
TEST=all pipeline tests pass under valgrind.

Review URL: https://codereview.chromium.org/1152803003

Cr-Commit-Position: refs/heads/master@{#333181}

Update chrome.settingsPrivate to support CrOS-only settings. These needed special handling since they are managed by the CrOSSettings rather than by one of the PrefService objects.

I also added a few such settings as used by the users page, to the prefs whitelist, and removed some dead code from the apitest.

BUG=496308

Review URL: https://codereview.chromium.org/1163593005

Cr-Commit-Position: refs/heads/master@{#333180}

Adds a test that validates that TemplateUrlService returns
URLs with correct parameters.

BUG=None

Review URL: https://codereview.chromium.org/1156423006

Cr-Commit-Position: refs/heads/master@{#333179}

This reverts commit e5196986 with fixes in media/cast/sender/h264_vt_encoder_unittest.cc

TBR=dalecurtis@chromium.org,watk@chromium.org,bbudge@chromium.org
BUG=126070,332204
TEST=Updated unittests.

Review URL: https://codereview.chromium.org/1143223007

Cr-Commit-Position: refs/heads/master@{#333178}

BUG=493856

Review URL: https://codereview.chromium.org/1162203004

Cr-Commit-Position: refs/heads/master@{#333177}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b500ffa..726cf90

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1154023003

Cr-Commit-Position: refs/heads/master@{#333176}

A minor tweak to disable retrieving a Data Reduction Proxy configuration
from the config service if the feature is not enabled by the user, but
the config service is enabled.

Review URL: https://codereview.chromium.org/1166803004

Cr-Commit-Position: refs/heads/master@{#333175}

BUG=

Review URL: https://codereview.chromium.org/1148303007

Cr-Commit-Position: refs/heads/master@{#333174}

with the same origin (HostPortPair) and value (ServerNetworkStats).

This change reduces the number of times SetServerNetworkStats tries
to persist HttpServerProperties to disk (currently 17% of persist calls
are due to SetServerNetworkStats).

BUG=451256
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1158823005

Cr-Commit-Position: refs/heads/master@{#333173}

This pulls in the following Native Client changes:

1da5d86: (sbc@chromium.org) Fix for gyp build of nacl_bootstrap with target_arch=mips
f404a83: (scottmg@chromium.org) Reland of 'vs2015: avoid redefining UINT8_MAX et al, some warning fixes'
3b1b3cf: (rickyz@chromium.org) Add SIGHUP and SIGTERM handlers in NaCl.
12ab4282: (sergiyb@chromium.org) Added CQ config to the nacl repo
ae55d9f: (bradnelson@chromium.org) Don't run asan toolchain build through runtest.py
23b1555: (jvoung@chromium.org) Update revision for PNaCl
bcaef62: (mseaborn@chromium.org) SelLdrLauncher: Allow using a subset of SetupCommand(): Make some methods public

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/e255676bce441a5a54072548cd1cf1ed8eaaecad..bcaef620a70f2e84e3660bd9098c4af811528f47

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1159693005

Cr-Commit-Position: refs/heads/master@{#333172}

Else the compiler can create SSE4.1 instructions for the SSE3 files, but we
only check for SSE3 when running that code.  So the code might crash with
"unknown instruction" when running on a processor that has SSE3 but not SSE4.

This matches what the gyp build does.

Depends on https://codereview.chromium.org/1161853008/

BUG=496512

Review URL: https://codereview.chromium.org/1160253011

Cr-Commit-Position: refs/heads/master@{#333171}

net: add gvt2.com as an HSTS, Google domain.
Cr-Commit-Position: refs/heads/master@{#333170}

called with the same origin (HostPortPair) more than once and if we
didn't change anything in  broken_alternative_services_ (in other words
the return value of IsAlternativeServiceBroken hasn't changed).

This change reduces the number of times ConfirmAlternativeService tries to
persist HttpServerProperties to disk (currently ~17% of persist calls
are due to ConfirmAlternativeService).

BUG=451256
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1142413004

Cr-Commit-Position: refs/heads/master@{#333169}

Delete old references when new form data is being parsed.

BUG=495102

Review URL: https://codereview.chromium.org/1161793006

Cr-Commit-Position: refs/heads/master@{#333168}

Revert of cc: Fix size_t to int truncations in layers/ output/ playback/ quads/ (patchset #12 id:260001 of https://codereview.chromium.org/1158433010/)

Reason for revert:
Broke windows build. http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/2919

Original issue's description:
> cc: Fix size_t to int truncations in layers/ output/ playback/ quads/
>
> This patch fixes size_t to int truncations in layers/, output/,
> playback/, and quads/ directories in cc/.
>
> R=danakj
> BUG=167187
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/0d5963315aa03e6ebb20351f13d3d517ca14d816
> Cr-Commit-Position: refs/heads/master@{#333153}

TBR=danakj@chromium.org,mkwst@chromium.org,jschuh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=167187

Review URL: https://codereview.chromium.org/1155553006

Cr-Commit-Position: refs/heads/master@{#333167}

- This CL updates the Permission Bubble Manager to autorespond for browser tests.
  The test tells the Permission Bubble Manager which response is desired, and the
  Permission Bubble Manager will execute that response immediately after Show().

- This CL applies the new responder to parameterized PushMessagingBrowsertests.

BUG=438758

Review URL: https://codereview.chromium.org/1154943008

Cr-Commit-Position: refs/heads/master@{#333166}

Split the behaviors into functions instead of a gigantic main().

R=dpranke@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/1170633002

Cr-Commit-Position: refs/heads/master@{#333165}

BUG=495560,495808

Review URL: https://codereview.chromium.org/1152013007

Cr-Commit-Position: refs/heads/master@{#333164}

- also rename class to SimpleMediaTaskRunner

BUG= internal b/18865809

Review URL: https://codereview.chromium.org/1161163003

Cr-Commit-Position: refs/heads/master@{#333163}

This CL generate Javadoc as a part of cronet_package.

BUG=428935

Review URL: https://codereview.chromium.org/1148263004

Cr-Commit-Position: refs/heads/master@{#333162}

It was removed from the class name but not the IPC names.

Review URL: https://codereview.chromium.org/1161853007

Cr-Commit-Position: refs/heads/master@{#333161}

This patch uses CheckedNumeric for size calculations that can overflow
in resources.

R=danakj, jschuh
BUG=495867
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1154393003

Cr-Commit-Position: refs/heads/master@{#333160}

The availability of this extension is already limited to desktop core
profile as the only reason we need to support it is IOSurfaces on
MacOSX.

This provides 2x performance improvement of copy operations when using
IOSurface backed GpuMemoryBuffers.

BUG=486922

Review URL: https://codereview.chromium.org/1149233005

Cr-Commit-Position: refs/heads/master@{#333159}

The only libvpx change rolling in:
https://chromium.googlesource.com/chromium/deps/libvpx/+/a43631169b4200f2000c8cfa82404ce507e31486

BUG=491209
TBR=tomfinegan

Review URL: https://codereview.chromium.org/1157433012

Cr-Commit-Position: refs/heads/master@{#333158}

R=thakis@chromium.org
BUG=none

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1169653002

Cr-Commit-Position: refs/heads/master@{#333157}

BUG=434113
R=oshima@chromium.org
TBR=jwd@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/1146303008

Cr-Commit-Position: refs/heads/master@{#333156}

This patch has some substantive changes that are not just code deletion, mainly around syncing/merging behavior.

BUG=493856
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/1143253012

Cr-Commit-Position: refs/heads/master@{#333155}

This makes it possible for a client to initialize a texture using
partial updates without causing the texture level to be implicitly
cleared at the time of the first partial update.

BUG=460288
TEST=gl_tests, gpu_unittests

Review URL: https://codereview.chromium.org/1154053002

Cr-Commit-Position: refs/heads/master@{#333154}

This patch fixes size_t to int truncations in layers/, output/,
playback/, and quads/ directories in cc/.

R=danakj
BUG=167187
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1158433010

Cr-Commit-Position: refs/heads/master@{#333153}

This is to make glRenderbufferStorageMultisample related tests working.

BUG=429053
TEST=gpu_unittests, newly added multisampled-renderbuffer-initialization.html
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1165553003

Cr-Commit-Position: refs/heads/master@{#333152}

This will allow consolidating many current "link-time" implementations
into virtual methods in our ContentClient classes, which should both
provide increased clarity and eliminate frequent internal build breaks
due to lag between a new public feature and matching internal CLs.

See discussion on https://codereview.chromium.org/1168643004/.

R=halliwell@chromium.org,lcwu@chromium.org,byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1153173006

Cr-Commit-Position: refs/heads/master@{#333151}

On other platforms, the OS IME system generates composition events for
combining characters like accents, but on Android it's the
responsibility of the textbox implementation to do so for physical
keyboards.  This patch adds support for that.

This differs from the previous accent implementation
https://codereview.chromium.org/759033002 in that it uses IME
compositions.  This is more similar to desktop platforms from the point
of view of Blink/Javascript (I've verified compositionUpdate events are
sent on Mac instead of keycodes), and it avoids complications arising from
artificial backspace characters.

To simplify the if/else blocks, this patch also changes to update
mEditable on ACTION_DOWN instead of up, which also better maps to when
Blink makes the change.

BUG=230921

Review URL: https://codereview.chromium.org/1162863007

Cr-Commit-Position: refs/heads/master@{#333150}

Android test annotation is missing in the only one test in this file.
This CL fixes it.

BUG=NONE

Review URL: https://codereview.chromium.org/1165513006

Cr-Commit-Position: refs/heads/master@{#333149}

Unexpected SwapBuffersComplete's can arrive for two common reasons:
1) DidSwapBuffersComplete is getting called before DidSwapBuffers.
2) A swap ack from the previous OutputSurface arrives.

This extra debug info will allow us to determine which case
we are in.

BUG=495650
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1153283009

Cr-Commit-Position: refs/heads/master@{#333148}

called with the same origin (HostPortPair) and nothing was deleted.

This change reduces the number of times ClearAlternativeService tries to
persist HttpServerProperties to disk (currently ~11% of persist calls
are due to ClearAlternativeService).

BUG=451256
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1156513004

Cr-Commit-Position: refs/heads/master@{#333147}

the same origin (HostPortPair) and value (supports_spdy).

This change reduces the number of times SetSupportsSpdy tries to persist
HttpServerProperties to disk (currently ~5% of persist calls are due to
SetSupportsSpdy).

BUG=451256
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1159853005

Cr-Commit-Position: refs/heads/master@{#333146}

net: add gvt3.com as an HSTS, Google domain.
Cr-Commit-Position: refs/heads/master@{#333145}

This is the first step in a refactoring of the declarativeContent API
implementation. The goal is to facilitate profile state matching by
providing abstractions for conditions and condition state tracking
and evaluation.

This CL consists of steps 1 and 2 described in the associated bug:
by-hand instantiation of DeclarativeRule as DeclarativeContentRule to
decouple changes from the web request declarative API implementation,
and encapsulation of CSS selector condition tracking logic. No
functional change is intended.

BUG=492946

Review URL: https://codereview.chromium.org/1159733004

Cr-Commit-Position: refs/heads/master@{#333144}

BUG=497344
TBR=bruening@chromium.org

Review URL: https://codereview.chromium.org/1157813004

Cr-Commit-Position: refs/heads/master@{#333143}

https://chromium.googlesource.com/angle/angle.git/+log/10eb591..dd2eb50

BUG=491209
BUG=477306
TEST=bots
TBR=geofflang

Review URL: https://codereview.chromium.org/1149213007

Cr-Commit-Position: refs/heads/master@{#333142}