GitLab

Implementation of the MediaSession specification will happen behind
the runtime flag 'MediaSession'.

Add a virtual testsuite for running tests with MediaSession flag. This
way we don't have to have the flag enabled when running LayoutTests in
general, only when running MediaSession tests.

Intent to implement:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/dLWDxYgxzQ8/vXt0ntWFNBwJ

BUG=497735

Review URL: https://codereview.chromium.org/1206283002

git-svn-id: svn://svn.chromium.org/blink/trunk@198049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Another regression from baseLayoutStyle implementation where operator==
is not affected by the loading/loaded state of web fonts. To get a re-
layout and re-rendering when a web font loading state changes, we need to
check for the loading state. In this case, there was a missing check for
::first-line pseudo style.

Also, moved the code which marks for re-layout with accompanying FIXME
into LayoutObject.

BUG=501564,504864
TEST=fast/text/ellipsis-platform-font-change.html

Review URL: https://codereview.chromium.org/1209253006

git-svn-id: svn://svn.chromium.org/blink/trunk@198048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is following the specification change:
https://github.com/w3c/permissions/issues/31

BUG=502275

Review URL: https://codereview.chromium.org/1194963002

git-svn-id: svn://svn.chromium.org/blink/trunk@198047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was only used for a broken preferred widths "optimization"
that was removed in https://codereview.chromium.org/1184563002.

Review URL: https://codereview.chromium.org/1216573006

git-svn-id: svn://svn.chromium.org/blink/trunk@198046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This affects the output for the -webkit-columns shorthand:
"-webkit-columns: 10px;" -> '10px auto'
Update tests to reflect this.

BUG=471917

Review URL: https://codereview.chromium.org/1215503009

git-svn-id: svn://svn.chromium.org/blink/trunk@198045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/1217073002 removed [ NeedsManualRebaseline ]
for these tests, however, these still fail on default (non-virtual) path.
Note that since these don't seem to fail to ASAN/MSAN bots, these are likely
racy flakes actually.

BUG=502308
TBR=adamk,japhet
NOTRY=true

Review URL: https://codereview.chromium.org/1214533003

git-svn-id: svn://svn.chromium.org/blink/trunk@198044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I believe the setObjectGroupId is unnecessary.

- Regarding [SetWrapperReferenceTo], it shouldn't be necessary because [SetWrapperReferenceTo] doesn't create any object group id.

- Regarding [SetWrapperReferenceFrom], setObjectGroupId is called only when the C++ reachable function returns null (e.g., NodeList::owner() returns null). In this case, it shouldn't be necessary to create an object id for the NodeList.

BUG=

Review URL: https://codereview.chromium.org/1214903006

git-svn-id: svn://svn.chromium.org/blink/trunk@198043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=495801
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1215813003

git-svn-id: svn://svn.chromium.org/blink/trunk@198042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes |findPlainText()| with |Range| parameter by replacing call
sites with |findPlainText()| with two |Position| parameters to avoid
constructing redundant |Range| object for Oilpan GC friendly.

BUGS=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1214293002

git-svn-id: svn://svn.chromium.org/blink/trunk@198041 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sof

Review URL: https://codereview.chromium.org/1217833006

git-svn-id: svn://svn.chromium.org/blink/trunk@198040 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems compilers are not always smart enough to ignore checkHeader().
This CL replaces checkHeader() with ASSERT(checkHeader()) to make
it more explicit that it is nop in production code.

BUG=420515

Review URL: https://codereview.chromium.org/1211243006

git-svn-id: svn://svn.chromium.org/blink/trunk@198039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Rename node_reachable_function to set_wrapper_reference_from.

- Drop support for [SetWrapperReferenceTo=(...)] that takes more than one argument.
There is no use case at the moment.

- No change in the generated code.

BUG=

Review URL: https://codereview.chromium.org/1215093002

git-svn-id: svn://svn.chromium.org/blink/trunk@198038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes "insertHTML" execCommand on TEXTAREA not to crash when
inserted HTML containing text.

The root cause of issue 504886 is calling |plainText()| with null |Range| object
in |ReplacementFragment| constructor. This null |Range| object is comes from
|VisibleSelection::selectionFromContentsOfNode()| with HTML fragment without
text content, e.g. "<b></b>", "<span>", and so on, which returns empty
seleciton.


BUG=504886
TEST=LayoutTests/editing/inserting/insert-html-to-textarea-crash.html

Review URL: https://codereview.chromium.org/1219723004

git-svn-id: svn://svn.chromium.org/blink/trunk@198037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@37981c1f8a21482e9b14603a2f27f9bbcf4a1276
imported web-platform-tests@b90da6aee4c27c41cba6aa4d3e041f3893a3c614

* No changes to W3CImportExpectations this time.
* 64 new abs-pos tests added to Writing Modes, 21 of them fail.
* abs-pos in vertical flow has its own bug 505151, changed bug number.

BUG=492664, 505151

Review URL: https://codereview.chromium.org/1212773004

git-svn-id: svn://svn.chromium.org/blink/trunk@198036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504739

Review URL: https://codereview.chromium.org/1212253002

git-svn-id: svn://svn.chromium.org/blink/trunk@198035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was trying to form a Vector<RefPtr<String>>, which doesn't work.

BUG=500638

Review URL: https://codereview.chromium.org/1221743002

git-svn-id: svn://svn.chromium.org/blink/trunk@198034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is style-only change and no functional change.

Review URL: https://codereview.chromium.org/1220703002

git-svn-id: svn://svn.chromium.org/blink/trunk@198032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=496259

Review URL: https://codereview.chromium.org/1203853003

git-svn-id: svn://svn.chromium.org/blink/trunk@198031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's known to be very slow, and we've related layout-forcing changes in flight.

BUG=505670,427743,485428

Review URL: https://codereview.chromium.org/1214163003

git-svn-id: svn://svn.chromium.org/blink/trunk@198030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1217893004

git-svn-id: svn://svn.chromium.org/blink/trunk@198029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=chromium:502437
R=adamk

Review URL: https://codereview.chromium.org/1214113005

git-svn-id: svn://svn.chromium.org/blink/trunk@198028 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=505518

Review URL: https://codereview.chromium.org/1219733002

git-svn-id: svn://svn.chromium.org/blink/trunk@198027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8 enabled the --harmony-arrays flag by default in
https://chromium.googlesource.com/v8/v8/+/325fbd0,
adding many methods to Array and the various TypedArrays.

The intent to ship was posted to v8-users:
https://groups.google.com/forum/#!msg/v8-users/WIdC-t1zmKQ/lXpufXhNj3UJ

This patch adds the appropriate expectations for the aforementioned
methods, as well as several bits that changed while these tests
were disabled:

  - Added CanvasRenderingContext2D#filter (runtime enabled)
  - Added MediaDevices#getUserMedia (runtime enabled)
  - Added PerformanceResourceTiming#workerStart
  - Removed ServiceWorker#terminate

From my review of the commit log, all four of the above changes were
intentional and appropriate.

BUG=502308

Review URL: https://codereview.chromium.org/1217073002

git-svn-id: svn://svn.chromium.org/blink/trunk@198026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove bg threads and responsiveness bar from timeline overview.

Review URL: https://codereview.chromium.org/1213143003

git-svn-id: svn://svn.chromium.org/blink/trunk@198025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is part of a series of patches to update the client side API of what was
formerly known as navigator.connect to follow the new spec based on
navigator.services and a new ServicePort type.

This patch removes the old client side API from blink, and removes now
redundant code from the layout tests.

[1/3] https://codereview.chromium.org/1191393003 Blink side changes
[2/3] https://codereview.chromium.org/1192713004 Content side changes
[3/3] https://codereview.chromium.org/1198653004 This patch

BUG=426458

Review URL: https://codereview.chromium.org/1198653004

git-svn-id: svn://svn.chromium.org/blink/trunk@198024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for adding the DOMSharedArrayBuffer object, which needs
to be able to share allocated array memory between multiple WTF::ArrayBuffers.

BUG=497295
R=jochen@chromium.org,haraken@chromium.org

Review URL: https://codereview.chromium.org/1186863005

git-svn-id: svn://svn.chromium.org/blink/trunk@198023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

redirect happens

BUG=500554

Review URL: https://codereview.chromium.org/1175113009

git-svn-id: svn://svn.chromium.org/blink/trunk@198022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In cases where smooth scrolling is enabled, this test was previously
flaky. Disabling smooth scrolling should fix the issue.

BUG=

Review URL: https://codereview.chromium.org/1220783002

git-svn-id: svn://svn.chromium.org/blink/trunk@198021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

That bug is obsolete.

BUG=133097

Review URL: https://codereview.chromium.org/1212353003

git-svn-id: svn://svn.chromium.org/blink/trunk@198019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504687

Review URL: https://codereview.chromium.org/1216523005

git-svn-id: svn://svn.chromium.org/blink/trunk@198018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The old flexbox implementation did that. This still used to work halfheartedly
by accident until the fix for bug 498770, though, because we used to mark
out-of-flow positioned children in updateBlockChildDirtyBitsBeforeLayout(). But
it never worked for anything other than direct children. Added one test for the
recent regression (out-of-flow child) and one test that has probably never
passed, until now (out-of-flow grandchild).

We need to be inside layout() when setting the height of an object, or we won't
be able to detect any changes and thus fail to relayout positioned descendants
that may be affected.

BUG=504239
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1213843002

git-svn-id: svn://svn.chromium.org/blink/trunk@198017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=198006

BUG=505411
TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/1214193005.

git-svn-id: svn://svn.chromium.org/blink/trunk@198016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With DocumentLoader now being on the heap, keep a strong
back reference to the loader.

R=haraken
BUG=393516

Review URL: https://codereview.chromium.org/1220713004

git-svn-id: svn://svn.chromium.org/blink/trunk@198015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=caseq@chromium.org
BUG=505411
NOTRY=true

Review URL: https://codereview.chromium.org/1220513003

git-svn-id: svn://svn.chromium.org/blink/trunk@198014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch refactors BoxClipper to be a little cleaner. There should be
no change in behavior.

Changes:
1) BoxClipper::pushedClip has been removed as it was deadcode.

2) LayoutBox& is now const.

3) LayoutPoint m_accumulatedOffset has been removed since it was only
needed in the constructor.

4) bool m_pushedClip has been removed in favor of checking whether the
clip type is not uninitialized.

5) roundedRects heap allocation has been moved inside the
displayItemConstructionIsDisabled check.

This has been pulled out of https://codereview.chromium.org/1193433004.

BUG=484943

Review URL: https://codereview.chromium.org/1212293003

git-svn-id: svn://svn.chromium.org/blink/trunk@198013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=392046,331583
TBR=thakis@chromium.org,scottmg@chromium.org

Review URL: https://codereview.chromium.org/1210073008

git-svn-id: svn://svn.chromium.org/blink/trunk@198012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=198005

BUG=382491
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1211323005.

git-svn-id: svn://svn.chromium.org/blink/trunk@198011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Obviously, an empty text is a valid text for a stylesheet. No need to
throw.

BUG=505358
R=pfeldman

Review URL: https://codereview.chromium.org/1212643005

git-svn-id: svn://svn.chromium.org/blink/trunk@198010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=198001

BUG=505411
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1213143004.

git-svn-id: svn://svn.chromium.org/blink/trunk@198009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Report accurate Overscroll on handleWheel. Currently 
invalid ScrollResult is returned on overscroll.

compositor changes @
https://codereview.chromium.org/1203693003/

Bug=442859

Review URL: https://codereview.chromium.org/1195803003

git-svn-id: svn://svn.chromium.org/blink/trunk@198007 bbb929c8-8fbe-4397-9dbb-9b2b20218538