GitLab

Review URL: https://codereview.chromium.org/551183003

git-svn-id: svn://svn.chromium.org/blink/trunk@181613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add FontFaceDescriptors IDL dictionary (patchset #4 id:60001 of https://codereview.chromium.org/481453003/)

Reason for revert:
Broke build

http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19956

Original issue's description:
> Add FontFaceDescriptors IDL dictionary
> 
> To follow the spec[1]. This is the first place to use IDL dictionary
> execept for testing, so this CL also includes build related changes.
> Existing tests(e.g. fast/css/fontface-constructor-error.html) should
> cover this change.
> 
> [1] http://dev.w3.org/csswg/css-font-loading/#fontface-interface
> 
> BUG=403150
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181610

TBR=haraken@chromium.org,ksakamoto@chromium.org,bashi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403150

Review URL: https://codereview.chromium.org/551873004

git-svn-id: svn://svn.chromium.org/blink/trunk@181612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=321462
NOTRY=true

Review URL: https://codereview.chromium.org/553993004

git-svn-id: svn://svn.chromium.org/blink/trunk@181611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To follow the spec[1]. This is the first place to use IDL dictionary
execept for testing, so this CL also includes build related changes.
Existing tests(e.g. fast/css/fontface-constructor-error.html) should
cover this change.

[1] http://dev.w3.org/csswg/css-font-loading/#fontface-interface

BUG=403150

Review URL: https://codereview.chromium.org/481453003

git-svn-id: svn://svn.chromium.org/blink/trunk@181610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As the tests in KeyframeEffectModelTest are unit tests, it doesn't make
sense for them to use the parser to construct timing functions when
they can be constructed directly.

Review URL: https://codereview.chromium.org/552123003

git-svn-id: svn://svn.chromium.org/blink/trunk@181609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See: http://dev.w3.org/fxtf/web-animations/#dfn-zero-time

Review URL: https://codereview.chromium.org/551253002

git-svn-id: svn://svn.chromium.org/blink/trunk@181608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Go back to old underline position and thickness logic (patchset #2 id:20001 of https://codereview.chromium.org/550163003/)

Reason for revert:
Many tests failed on WinXP because of different underline position.

Original issue's description:
> Go back to old underline position and thickness logic
> 
> In r174431 from May this year we changed the underline position and
> thickness logic to respect the underline data specified in the font.
> While this improved rendering for certain fonts and scripts it did cause
> a regression for others. This change reverts to the old behavior while
> we figure out how to handle fonts with inaccurate or undesirable
> metrics.
> 
> BUG=408075
> R=scottmg@chromium.org, cpu@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181591

TBR=scottmg@chromium.org,cpu@chromium.org,eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408075

Review URL: https://codereview.chromium.org/557653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method setProperty(CSSPropertyID, CSSPropertyID identifier, bool important = false) is not used anywhere in the code, so removing it.

Review URL: https://codereview.chromium.org/547333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit f98363c805c098bf6f5b69c90ea7e5ae120a32a3.

NOTRY=true
TBR=arv@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/555033002

git-svn-id: svn://svn.chromium.org/blink/trunk@181605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add DictionaryHelper::getWithUndefinedOrNullCheck() to fix a bug that
newly added tests found. When IDL dictionary member is undefined or null,
the member should be treated as 'not present' and default values should
be used when specified. Since DictionaryHelper::get() converts
null/undefined into a valid value, we can't use DictionaryHelper::get()
in IDL dictionary implementation directly.

BUG=321462

Review URL: https://codereview.chromium.org/554893004

git-svn-id: svn://svn.chromium.org/blink/trunk@181604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently standard JS errors thrown by private scripts are treated
as real errors of the private scripts and crash the renderer.
However, we need to special-case a stackoverflow error because
user's script can create code that causes a stackoverflow error
in private scripts.

BUG=412143
TEST=fast/dom/private_script_unittest.html

Review URL: https://codereview.chromium.org/553983007

git-svn-id: svn://svn.chromium.org/blink/trunk@181603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=367689

Review URL: https://codereview.chromium.org/552673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=arv@chromium.org
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/549413002

git-svn-id: svn://svn.chromium.org/blink/trunk@181601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Needed in order to pair up constructor and destructor calls. Should be
generally useful for debugging.

BUG=393331,407976

Review URL: https://codereview.chromium.org/556703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

My last change to it made it not work if there were no failures
for a tree because failures[tree] would be undefined. Make it
less brittle, add tests for this code and while here add an
explanatory message that this page means there are no failures.

BUG=407496
NOTRY=true
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/530613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use |type() == InputTypeNames:foo| instead.
These predicates are inconsistent and confusing.

BUG=
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/557613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This isn't an ideal solution, but it hides the failure category labels when there are
no failure cards. Also adding a bit of styling in the meantime.

NOTRY=true
TBR=ojan@chromium.org

Review URL: https://codereview.chromium.org/555493005

git-svn-id: svn://svn.chromium.org/blink/trunk@181597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: blink_heap_unittests: asan check failed. HeapObjectHeader::finalize zap a wrong memory for object without VTable

1. In the HeapObjectHeader::finalize, we zap the primary vTable entry, but we have not checked if the object has vTable.

R=ager@chromium.org, oilpan-reviews@chromium.org
BUG=411204

Review URL: https://codereview.chromium.org/547903002

git-svn-id: svn://svn.chromium.org/blink/trunk@181596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181591

BUG=408075
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/555683002

git-svn-id: svn://svn.chromium.org/blink/trunk@181595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Another change needed for https://codereview.chromium.org/502293003/

I believe this also fixes a bug I introduced where builderList
was not updated when failures change :(

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/541123002

git-svn-id: svn://svn.chromium.org/blink/trunk@181594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid duplicate array traversals, and clarify what the code is trying to do.

Review URL: https://codereview.chromium.org/538293002

git-svn-id: svn://svn.chromium.org/blink/trunk@181593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replaced by AnimationPlayer.playState

BUG=396366

Review URL: https://codereview.chromium.org/552933002

git-svn-id: svn://svn.chromium.org/blink/trunk@181592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r174431 from May this year we changed the underline position and
thickness logic to respect the underline data specified in the font.
While this improved rendering for certain fonts and scripts it did cause
a regression for others. This change reverts to the old behavior while
we figure out how to handle fonts with inaccurate or undesirable
metrics.

BUG=408075
R=scottmg@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/550163003

git-svn-id: svn://svn.chromium.org/blink/trunk@181591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The scroll bar width should only be added if the width of the grid item is
not fixed.

This test coverage has been inspired from the webkit patch for flexboxes at
https://bugs.webkit.org/attachment.cgi?id=182187&action=diff 

BUG=395788

Review URL: https://codereview.chromium.org/532203002

git-svn-id: svn://svn.chromium.org/blink/trunk@181590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Set value of autofilled property to false in the following cases:
  - Cancel search via cancel button in <search> element.
  - Delete autofilled selected <select> option.

This patch also
  - Merged test case for editing text in autofilled textarea.

R=tkent@chromium.org
BUG=395627

Review URL: https://codereview.chromium.org/537393002

git-svn-id: svn://svn.chromium.org/blink/trunk@181589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to buggy code added in http://src.chromium.org/viewvc/blink?view=rev&rev=181407 .

This code path is only used in layout tests.

TBR=eae@chromium.org
R=bungeman@chromium.org
BUG=394902

Review URL: https://codereview.chromium.org/551063002

git-svn-id: svn://svn.chromium.org/blink/trunk@181587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Three globals were missing and causing tests to fail.

TBR=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/542953003

git-svn-id: svn://svn.chromium.org/blink/trunk@181586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/554833003

git-svn-id: svn://svn.chromium.org/blink/trunk@181585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Noticed here https://codereview.chromium.org/538333002/ .
Something's wrong between gn/gyp because this doesn't happen
in gyp, but remove these consts anyway as they're unnecessary.

R=thakis@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/551863004

git-svn-id: svn://svn.chromium.org/blink/trunk@181584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

GN visibility currently allows either string or list types, but this is causing
some problems for some templates. I'm going to require it to be lists, so am
changing all callers before pushing the new binary.

Review URL: https://codereview.chromium.org/550333003

git-svn-id: svn://svn.chromium.org/blink/trunk@181583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/550133002

git-svn-id: svn://svn.chromium.org/blink/trunk@181582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This might be left from historical versions. Remove.

Review URL: https://codereview.chromium.org/550363003

git-svn-id: svn://svn.chromium.org/blink/trunk@181580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Section 5.1.5 of the specs clearly states that the resolved value
for grid-template-{columns|rows} must include every listed track, whether
explicitly or implicitly created. We were only listing the explicit grid
tracks.

Review URL: https://codereview.chromium.org/548263002

git-svn-id: svn://svn.chromium.org/blink/trunk@181579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181567

BUG=405422
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/555503003

git-svn-id: svn://svn.chromium.org/blink/trunk@181576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderSVGResourceClipper needs a couple bits of state to determine
whether mask or path clipping was used. (The clipper doesn't maintain
this state because it can be applied to multiple renderers.) This patch
converts the ClipperContext class into a simple enum which is now
scoped to RenderSVGResourceClipper.

No new tests as there is no change in behavior.

Review URL: https://codereview.chromium.org/547723003

git-svn-id: svn://svn.chromium.org/blink/trunk@181575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In some situations, the channel count mode is updated just before the
audio rendering starts. During audio processing, the channel count
mode is used to set the number of channels for processing.  However,
for AudioBasicProcessor's, the number of kernels has not yet been
updated to the correct number of channels, so the incorrect number of
channels is accessed.

We delay the setting of the channel count mode until the pre or post
rendering phase of the audio thread where it is safe to change things
since the audio graph is not being pulled.

BUG=407489

Review URL: https://codereview.chromium.org/543073004

git-svn-id: svn://svn.chromium.org/blink/trunk@181573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Extract common part of invalidateTreeIfNeeded() of
RenderLayerModelObject and RenderSVGModelObject.

This is preparation of letting setShouldDoFullPaintInvalidation() work
for RenderText (to avoid invalidatePaintForWholeRenderer from
DocumentMarkerController).

No functional change.

BUG=394133

Review URL: https://codereview.chromium.org/535633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, add isResourceLoadInProgress() for use in content shell, to determine
when to complete tests.

Exposing this information will allow content shell to better
evaluate when to end tests, hopefully eventually leading
blink being able to define load completion strictly as
the completion of the load event.

BUG=

Review URL: https://codereview.chromium.org/514603004

git-svn-id: svn://svn.chromium.org/blink/trunk@181570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This interface temporarily subclasses WebFrameClient to ease the transition, and will be implemented by content::RenderFrameProxy. Add postMessageEvent(), to be properly plumbed in a followup patch.

This is step 1 of 3 on crubg.com/411066

BUG=411066

Review URL: https://codereview.chromium.org/539413002

git-svn-id: svn://svn.chromium.org/blink/trunk@181569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yurys@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/547413003

git-svn-id: svn://svn.chromium.org/blink/trunk@181568 bbb929c8-8fbe-4397-9dbb-9b2b20218538