- 01 Oct, 2020 40 commits
-
-
Austin Eng authored
This reverts commit 71c10e67. Reason for revert: Breaking Dawn's CQ. This CL likely needs to update webgpu_blink_web_tests as well. Original change's description: > Change blink_web_tests and blink_python_tests test types. > > This CL changes the GN blink_web_tests and blink_python_tests > targets to use a new script_test() GN template. > > A script_test is a kind of test target that implements the > [test executable API](//docs/testing/test_executable_api.md) > via a Python script (rather than being an executable target). > > :blink_web_tests, :blink_python_tests are examples of this type > of test; other targets will be switched over in future CLs as well. > > Most importantly, using script_test() will ensure that > the $root_build_dir/bin/run_$target_name test wrappers are > generated with all of the appropriate arguments, simplifying the > invocation of the test both for devs and for the bots. > > Bug: 816629 > Change-Id: Ib4bfd2342d762db24cdef75b64ed5dd7fbf3c10e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380936 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#812523} TBR=dpranke@google.com,robertma@chromium.org,rmhasan@google.com Change-Id: I16c0d8bfaebbeabbeee7dd98a0f4bb083403444f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442872Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#812694}
-
Morten Stenshorne authored
When performing column layout, we need to tell the builder that it's to generate a column box, as this determines the behavior when finishing fragmentation; see IsFragmentainerBoxType() check in FinalizeForFragmentation() in NGBlockLayoutAlgorithm). The other entry points to column layout already take care of this, but it was missing for the initial column balancing pass. Bug: 829028 Change-Id: I60914b7adead19e4efa441d05733d4bd819dafd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440527 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812693}
-
Shakti Sahu authored
This CL adds : 1 - Mediator unit tests for the video player. Bug: 1117157 Change-Id: I27e000e63e6e528f7480caa0b26932fd89d5300e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430688 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#812692}
-
Anders Hartvoll Ruud authored
Otherwise, for a selector such as ':is(:host(.a), .b) .c', the tree- boundary crossing flag will be set when processing :host(.a), and then incorrectly carry over to subsequent list items (i.e. .b). Bug: 568705 Change-Id: I2a8eb5735c0fc44242d7c0e089b85814e6080b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435190 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812691}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /native_client_sdk/src/doc to source.chromium.org equivalent. This CL was uploaded by git cl split. Change-Id: Iaa8ac8df6920e9ccfcf4a04ee09c4c36d32e6581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392709Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#812690}
-
Adam Langley authored
This Mojo pipe disconnects once the WebSocket handshake has completed, but we want to carry on and use the WebSocket. So, instead, switch to watching the pipe that carries frame information once the handshake callback is complete. BUG=1002262 Change-Id: I4586dd12cbf2051e3ee9bc461d239dcdd6a3fde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441299 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#812689}
-
Christian Biesinger authored
Given top: 0; bottom: 0; width: auto; aspect-ratio: 1/1;, we should compute the width from the height. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: I2ea7a791f827dc42ca07e0aaa1238584bfc47a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442368 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#812688}
-
edchin authored
An NTP is normally created for a new empty window. However, this is not necessary when dragging and dropping a tab into a new window. Bug: 1132293 Change-Id: I720979235fdb447a5270f81a4b0c8451343ce773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438941 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812687}
-
arthursonzogni authored
This makes network reports and ReportingObserver's report similar. Bug: 1090273 Change-Id: I0fce6f0a25153e6f32feaeaf713d44ab081c1a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436533Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812686}
-
David Bienvenu authored
This stat will be used by the team working on the WebUI tab strip to determine how much of a real world problem failure of touch drag of tabs in the tab strip is. Failure is detected by ::DoDragDrop blocking for more than one second and only calling QueryContinueDrag once. Bug: 1126230 Change-Id: I75b9d3a95912b8ef2ec049fcd32ed4700e4ca51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437485 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812685}
-
Guido Urdaneta authored
This CL ensures that if an ideal or max frame rate is requested via constraints in getUserMedia(), the requested rate will be enforced using frame-rate adjustment, if necessary. Even if the requested rate equals the reported native frame rate being used by the device. In practice, it has been reported that actual frame rates sometimes exceed the rate reported by the device, so this ensures that explicitly requested rates are produced in practice. Prior to this CL, if the requested rate matched the rate reported by the device, no attempts to adjust the frame rate were made. Fixed: 1133796 Change-Id: If0699f97292b3bccc69205f861f059660355cc11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440758 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#812684}
-
Yao Xiao authored
The raw sim-hash values are needed by the server to calculate the sorting-lsh cutting points and/or blocklist. We should always log it regardless of the final result after applying the blocklist or (the upcoming) sorting-lsh. Removed the NotifyFlocUpdated method, as we no longer need to notify floc update event (which could be useful for the header. we can add it back later if we want the header). Bug: 1062736 Change-Id: I50bba6a1f1945c7b1c57dfc01724c8375da89d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438483 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812683}
-
Colin Blundell authored
When the intent launching code determines that a tab should be closed (e.g., because the initial navigation resulted in the launch of an intent), it posts a task to the embedder to asynchronously close the tab. We are seeing crashes in WebLayer indicating that in the interim the tab is being closed for another reason. TabImpl does not guard against its destroy() method being called multiple times, and the crash results due to members being invoked and then nulled out in that method. This CL adds a targeted fix for this flow, changing //weblayer's InterceptNavigationDelegateClientImpl to short-circuit out of its closeTab() method if it has already been destroyed. I avoided changing TabImpl#destroy() to guard against multiple invocations as in general we would regard any such flows as errors that should be detected and fixed (like this one). I investigated making a test for this case but so far have been unable to program a flow where I can cause a tab opened via an intent launch to be destroyed in the interim between the navigation starting and the intent launching code destroying the tab. It is worth pointing out that I still don't know what use case would result in this flow in production, so this is a speculative fix. Nonetheless, it is a good change to make in any case. Bug: 1132983 Change-Id: I2b3c5a1598f6f13887f70bff90d822afbbd3f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442626Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#812682}
-
Kyle Horimoto authored
This CL continue the effort starting from [1], which converted to using SharedRemote for Bluetooth operations. This fixes potential deadlock issues when accessing WebRTC on different threads. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2440981 Bug: 1130069 Change-Id: I1debebdf4b8144f134b0ab4b27fc835fbf8236b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441489 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#812681}
-
Piotr Tworek authored
This was exposed when building code against libstdc++ instead of bundled libcxx. The code uses memchr function, but fails to include string.h declaring it. My guess is libcxx somehow pulls this indirectly for us. Bug: 957519 Change-Id: If9b1253bf0c78a2784a74839dc11291de2490113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440617Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#812680}
-
Titouan Rigoudy authored
This change is not strictly necessary to clean up the address space computation logic currently spread around third_party/blink/renderer, but it offended my sensibilities that we would represent an IP address as a string :) Bug: chromium:1124358, chromium:955213 Change-Id: Ica9957042d5cf222a9e0a053714f4ad7ed7c3cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421891Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812679}
-
Adam Lesinski authored
Fuchsia is transitioning from UTC time being tracked in the kernel, to userspace UTC clock handles. This preserves the existing behavior that each chromium process has access to the global UTC clock. Bug: 1133580, fuchsia:61060 Change-Id: I8ff3d3033a47814dac1a1dd5946ca1fe872ead13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440983 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Adam Lesinski <adamlesinski@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#812678}
-
Alex Rudenko authored
This CL proposes refactoring Init/DoInit methods by moving the overlay and frontend parameters to the constructor to avoid confusion about at what time they are set on a tool. Also, it removes DoInit/Init methods and moves the ScreenshotTool's init to the constructor as well. Change-Id: I246c1383c66f6977c0b69fd82938a6c7baa192e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428926Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812677}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601531335-6ddc6aeaa45d1043385555e19eae524fbb6fe60e.profdata to chrome-mac-master-1601553580-dedfc7e09ce8d42299369759d9da080930ec4031.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1c23a70af0d44682123b0a5ecec10da83a4c58a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812676}
-
Mohsen Izadi authored
When two WebCoalescedInputEvent's are coalesced, the latency info of the old event is assigned to the newer event. However, in all cases, the newer event thrown away after coalescing. So, there is no point in setting its latency info and we can simplify the code by removing this assignment and making the newer event a const reference. Bug: 1079116 Change-Id: Ia340920b74cf8dcf2d3de319b9a8a255f31fb076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437481Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812675}
-
David Bokan authored
This test wants to check scrolling over a scrollbar but was scrolling over the scroll corner instead. The scroll corner is considered part of the scroller when scrolling from the main thread but not when scrolling from the compositor thread. This CL move the point to be over the scrollbar so that the test has consistent behavior on main and compositor threads. We also move it to fast/scrolling so it gets test coverage on both threads. Some cleanup has broken rename detection in Gerrit. See Base->PS1 for rename and above change. PS1->PS2 makes the test more readable. Bug: 915926,1090860 Change-Id: I25afd7c214505d38c08e456496d5bfa5a47ee74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442353Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812674}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_yLwB4ZAKfO - Diagnostics App (after) http://shortn/_u5OBuBN0Bm Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I688332b4ee48867be5b20e9ee0834914f0f6e0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440927Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#812673}
-
Alice Wang authored
This CL improves the sign-in error retry flow by adding a sign-in state check before signing in and keep WebSigninBridge when there is a sign-in error. Bug: 1133704 Change-Id: Id4c1bba4f5af997ccfeb43972ba622eb5268d823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440582Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812672}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I88ce6b1968db26a9a65690bf10a472af2e863f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812671}
-
Peter Kasting authored
Bug: 772945 Change-Id: I392d3bde5479806c1f9e03151dd25a8f394c7dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441129 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#812670}
-
Alice Wang authored
TBR=mcarlen@chromium.org Bug: 1134118 Change-Id: Icd716e4e698fc46a720ad769503bd79f036861a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442018Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812669}
-
kylechar authored
There have been multiple user reports about green flashes when navigating to or away from video with SkiaRenderer. ImageContextImpl doesn't hold any sort of reference to legacy GL textures while it's using them and was relying on the client holding the a reference. However, if a renderer is destroyed, and therefore all of it's references released, before the display compositor draws something else the video texture can be deleted while Skia is still using it to draw. This resulted in solid green, solid black or just missing quads in place of the video. Hold onto a reference to TexturePassthrough to prevent the texutre from being deleted early in this case. Bug: 1118166 Change-Id: Id35120b7c2cf5c11d0bb8d26812b2794e851a8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441951Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812668}
-
Ian Kilpatrick authored
This patch tracks the bounds of any inflow children (no floats, or out-of-flow positioned objects). This is only done for scrollable containers. This is used to correctly determine the layout-overflow of a fragment. Bug: 1066616 Change-Id: I334176cdf61f6eda92573e169719dbf7a2f62995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432225Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812667}
-
Michael Hablich authored
This is a roll-back to 8.7.220. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I079691a99c37d77015884f99ee701fbbea767214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442017Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#812666}
-
Christian Biesinger authored
These are new tests added by mozilla, testing https://github.com/w3c/csswg-drafts/issues/5550 R=futhark@chromium.org Bug: 1133835 Change-Id: Ifa3127600540d783f59c8ffe31fccb27d41de4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442376 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812665}
-
harrisonsean authored
The scheduled callback is no longer called if there is no update. Both scheduled and oneoff callbacks not used if there is an error. Bug: 1078782, 1133907 Change-Id: Ib88f35db3f0dc8243b7a6a5e150bda10e6799552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440631Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#812664}
-
Reda Tawfik authored
This CL sorts the credentials in AllPasswordsBottomSheet alphabetically according to second-level domain name. Bug: 1133326, 1104132 Change-Id: I31bd63c51a0e842a3a8f92470a30f56342886471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440889Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#812663}
-
Sadrul Habib Chowdhury authored
Use atomic memcpy to read/write the smoothness data, and report the UKM data. BUG=1115139 Change-Id: I7bf40d0be0ad45e094c0f8910188edf48004ab92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422421 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#812662}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95949e4c8ae8..0d0e5bfe429c 2020-10-01 wolfi@chromium.org Fix tabs shown on reload 2020-10-01 sigurds@chromium.org Improve Settings types for checkboxes 2020-10-01 tvanderlippe@chromium.org Typecheck elements/MarkerDecorator.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie11991058fa74022fd7ae98e8c64e9ceb2ddaa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812661}
-
Antonio Gomes authored
This CL implements the tabs.removeCSS extension API, that removes from a page CSS which was previously injected by a call to tabs.insertCSS(), similarly to Firefox' [1]. [1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/removeCSS The main difference between this implementation and the one in Firefox is that in Chrome's an extension can only remove its own CSS, not CSS injected by other extensions. This CL is based on the original work of https://crrev.com/c/918606 by Manish Jethani <m.jethani@eyeo.com>. BUG=608854 Change-Id: Ib448dbbe1f56b9c2db692794ce4fd210437f60a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250506 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812660}
-
Tanmoy Mollik authored
For Sync Setup Incomplete error and auth error sync engine may not be initialized. And for unrecoverable error sync engine may shut down. This cl adds a separate flow for these two errors. Bug: 1131992 Change-Id: I979d7731142ba935add868dde9026def2b95dad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440579 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812659}
-
Esmael El-Moslimany authored
Bug: 1110069 Change-Id: I9d8cce94e913ba4915c4903a5bdc9e6fa0f1cdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441448 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812658}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/492d4a85a2f0..2fde3fac998c 2020-10-01 hjd@google.com Merge "ui: Don't go via trackState for trackState.id" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If2ebff5a82f567254fb4b367005aaecb0317c313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812657}
-
henrika authored
As discussed: landing behind a flag so we can learn more by testing it on more Windows laptops. Will eventually be launched using an experiment. This round is mainly for local testing purposes and to add UMA so we can track how many devices that support raw audio capture. NOTRY=true Tbr: beccahughes Bug: 1133643 Change-Id: Iae1a5ad45fb8ca7db192e0d3ea779e3803d372d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440055Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812656}
-
Viktor Semeniuk authored
This change adds test case coverage for the scenario when the Passwords screen is shown from the Breach Dialog. Bug: 1129871 Change-Id: I10148da8a6356a918f7d468eac7014977c3f3594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437815 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#812655}
-