- 06 Jun, 2018 40 commits
-
-
Allen Vicencio authored
This adds the metrics for the number of mounts a user has in Native SMB File Share Bug: 757625 Change-Id: Iec6e33523c56dbfb094f15758241ec7f2fabe8f7 Reviewed-on: https://chromium-review.googlesource.com/1080089 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#564797}
-
Tatsuhisa Yamaguchi authored
This is a reland of 181414e9 The original change was reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1085067 > ==20322==ERROR: LeakSanitizer: detected memory leaks > Direct leak of 496 byte(s) in 1 object(s) allocated from: > #0 0x69b3d2 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 > #1 0x65a6dca in ash::TopShortcutsView::TopShortcutsView(ash::UnifiedSystemTrayController*) ash/system/unified/top_shortcuts_view.cc:130:43 Original change's description: > Resize sign out button when it's too long. > > Limits the size of the sign-out / sign-out-all button to keep other > buttons and minimum spacing in the parent view. This is needed because > the translated text resource can be very long. Also adding description > for such text resources to keep them shorter in the next revision. > > Bug: 847100 > Change-Id: I8fc79b0b0d3eb661553323a2d9f094f02320fa0a > Reviewed-on: https://chromium-review.googlesource.com/1080364 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564016} Bug: 847100 Change-Id: Ic2641bf8d61d837c56072988033f68f31f3d5da8 Reviewed-on: https://chromium-review.googlesource.com/1085327Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564796}
-
Yutaka Hirano authored
This CL makes OnAuthRequired work with WebSocket when the network service is enabled. Design Doc: https://docs.google.com/document/d/1L85aXX-m5NaV-g223lH7kKB2HPg6kMi1cjrDVeEptE8/edit Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7587ea7937f3e283096a10a70d5d18b1a67d2650 Reviewed-on: https://chromium-review.googlesource.com/1009266Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#564795}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/87da90a..844791e git log 87da90a..844791e --date=short --no-merges --format='%ad %ae %s' 2018-06-06 pwang@chromium.org chromeos_config: remove arc-gts from infoVMTest Created with: gclient setdep -r src/third_party/chromite@844791e The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I21d113592e0f28a427901a3c1c1df379865270aa Reviewed-on: https://chromium-review.googlesource.com/1088250Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564794}
-
Xianzhu Wang authored
This reverts commit 85b96ea9. Reason for revert: crbug.com/849968 Original change's description: > [PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform > > In Pre-SPv175 we forced subtree paint invalidation on non-composited > transform change. SPv175 no longer does that, causing > NonScalingStrokeTransform not updated on ancestor transform change. > > We also had a non-obvious bug that LayoutSVGShape::StrokeBoundingBox > didn't get updated on ancestor transform change. > > Now always explicitly update non-scaling-stroke data during layout. > > Bug: 849080 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ia61eb94f43e53a71a80e1102e4d605e4331f44b1 > Reviewed-on: https://chromium-review.googlesource.com/1086715 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#564584} TBR=wangxianzhu@chromium.org,fs@opera.com Change-Id: Ifbdd23b74dc45b5c8bc66c3d64bff580d5306f78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849080, 849968 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1087332Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564793}
-
François Beaufort authored
This makes sure Picture-in-Picture window controls are hidden when window is shown. Bug: 726619 Change-Id: I195df27741440c2f00ae0e50bdcd8abe59367f42 Reviewed-on: https://chromium-review.googlesource.com/1084094Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#564792}
-
Sidney San Martín authored
This fixes the window button position for MD refresh. Bug: 841348 Change-Id: Ib313a773a6a220cb8e3e39c944325e4a105ec7ad Reviewed-on: https://chromium-review.googlesource.com/1081053 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#564791}
-
Sasha Morrissey authored
Make setupAndWaitUntilReady take optional arguments for default entries to set up in the file manager. This is required for tests that need a different set of entries to the default. Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c505ff3be8c8b85167bfbfe300714f728dba19a Reviewed-on: https://chromium-review.googlesource.com/1088330 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#564790}
-
Nigel Tao authored
This neither adds nor deletes declarations. It reorders them to lessen the diff on a subsequent commit (which automatically generates file_manager_private.js by running tools/json_schema_compiler/compiler.py on file_manager_private.idl). Two declarations (EntryAction, installWebstoreItem) don't have any corresponding entry in the file_manager_private.idl file. Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6dcc4a8f4f51182f7e33509decebe72b221f3ea6 Reviewed-on: https://chromium-review.googlesource.com/1082185Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#564789}
-
Sam McNally authored
Currently, FileManagerBrowserTestBase::SetUpCommandLine(), after setting command line args for guest mode, calls its base class, eventually calling ExtensionBrowsertest::SetUpCommandLine(), which overwrites kLoginUser with its test user. This results in guest mode running with an underlying profile with an associated email address, causing DriveIntegrationService to be enabled for the underlying profile. Change FileManagerBrowserTestBase::SetUpCommandLine() to disable the base class's setting of user account flags so the guest mode tests more accurately replicate the production environment. Fix the chrome.fileManagerPrivate.startCopy() implementation to check free disk on a blocking sequence instead of the IO thread. Without an enabled DriveIntegrationService for guest mode, this code path is now covered by tests. Fix createNewFolder tests to not expect a google drive entry in guest mode now that it isn't mounted in guest mode. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I953290b120a2a6b4f24214a12516efded442b75c Reviewed-on: https://chromium-review.googlesource.com/1086888 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564788}
-
rbpotter authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I09abc82ecd2ab71850a70c65a9a2decfcc011fe3 Bug: 849476 Reviewed-on: https://chromium-review.googlesource.com/1086236Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#564787}
-
Luciano Pacheco authored
An |Error| instance already has the |stack| attribute so the exception doesn't need to be raised, which makes the code cleaner and faster. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I148bb213f58b1c7ea352d862b9c666da35ba2b48 Reviewed-on: https://chromium-review.googlesource.com/1086562 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Nicholas Verne authored
Eliminates Termina, Concierge in all user-facing strings. These are internal code names. BUG=849900 Change-Id: I47d627c01aafefde001ce4e76cd405caa66ff1cf Reviewed-on: https://chromium-review.googlesource.com/1084423Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564785}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7602689. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19097 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding TBR=foolip No-Export: true Change-Id: I77c326860e72242a964bff3b1e592fc5d5d55d9f Reviewed-on: https://chromium-review.googlesource.com/1087763 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564784}
-
Shakti Sahu authored
When a download is removed (e.g. via download home), we should remove if we are showing an infobar for this download. Fixing this bug in this CL. Bug: 849407 Change-Id: I512d0a3e946b9c349badfaad9f304985678fd603 Reviewed-on: https://chromium-review.googlesource.com/1086286Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564783}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/784bb7f..87da90a git log 784bb7f..87da90a --date=short --no-merges --format='%ad %ae %s' 2018-06-06 dgarrett@chromium.org Revert "config_stages: Fix a missed path that can change per branch." 2018-06-06 dgarrett@google.com config_stages: Fix a missed path that can change per branch. 2018-06-06 dgarrett@google.com chromeos_config: Remove symlinks to new config files locations. Created with: gclient setdep -r src/third_party/chromite@87da90a The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:848020,chromium:848020,chromium:848020 TBR=chrome-os-gardeners@chromium.org Change-Id: Ib07fa234212c937752540d95695c1ce12f57f5cc Reviewed-on: https://chromium-review.googlesource.com/1088246Reviewed-by:
-
Sadrul Habib Chowdhury authored
Use gfx::PresentationFeedback instead of plumbing timestamp, interval, and flag separately to the following places: . mojom.CompositorFrameSinkClient . cc::LayerTreeHostImplClient . The various PresentationCallbacks in ash, cc, exo, viz. Also add a mojom type (and struct-traits) for gfx::PresentationFeedback. TBR=reveman@ for trivial ash/components and components/exo changes. BUG=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I893833710ab6e8d336176d43342df2b4efe62856 Reviewed-on: https://chromium-review.googlesource.com/1075859 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#564781}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b990770..e89dcf7 git log b990770..e89dcf7 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 sergeyberezin@google.com Roll mac_toolchain to 796d2b92c Created with: gclient setdep -r src/third_party/depot_tools@e89dcf7 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:849728,chromium:846485 TBR=agable@chromium.org Change-Id: Ibda12f0347c61cf3bee4d660e73e907ac1560fcd Reviewed-on: https://chromium-review.googlesource.com/1087615Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564780}
-
Darren Shen authored
Currently, KeyboardController::GetInstance returns null if the keyboard is disabled. This patch changes it so that |GetInstance| always returns a valid KeyboardController. However, existing code determines whether the keyboard is enabled by checking whether KeyboardController is null or not. With this patch, KeyboardController will never be null. So we have to replace the null checks with calls to KeyboardController::enabled(). In some cases, calls to KeyboardController::enabled() can be omitted, but we leave that to a future patch for easier review. Bug: 731537 Change-Id: Ica487e69bae0a589d79c726f131611f0bf934672 Reviewed-on: https://chromium-review.googlesource.com/1032230 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I603cb0d05a8492f8a98f1eaf17acfbb84c3977ee Reviewed-on: https://chromium-review.googlesource.com/1087936Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#564778}
-
Kurt Horimoto authored
Tests that fail because there is no share button: ActivityServiceControllerTestCase.testActivityServiceControllerPrintAfterRedirectionToUnprintablePage ActivityServiceControllerTestCase.testActivityServiceControllerCantPrintUnprintablePages ActivityServiceControllerTestCase.testOpenActivityServiceControllerAndCopy JavaScriptDialogTestCase.testShowJavaScriptAfterShareMenu PrintControllerTestCase.testPrintNormalPage PrintControllerTestCase.testPrintPDF ToolbarTestCase.testCopyPasteURL Other failures: TabSwitcherTransitionTestCase.testLeaveSwitcherByOpeningNewNormalTab Bug: 849492 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I519dda50b0a055bba937aa9685bcfdeb6bf319e1 Reviewed-on: https://chromium-review.googlesource.com/1088239 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#564777}
-
Xianzhu Wang authored
The case is extended from crbug.com/849382. Some elements may display by scaling down from huge geometries with a tiny scale. When the scale changes (e.g. from 1e-6 from 2e-6), the rasterized result will significantly change which should not be ignored. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I31928d95f8d864de83a75af02fd3cfe95ef8e8fa Reviewed-on: https://chromium-review.googlesource.com/1087812 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564776}
-
Gang Wu authored
This CL adds persistence for content data, and unittest for it. Bug:831633 Change-Id: I944d9812133192e24306699bd696b5de8c2e411f Reviewed-on: https://chromium-review.googlesource.com/1080274 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564775}
-
Mihai Sardarescu authored
This CL adds the skeleton for the unified consent service. The role of this service is to manage the preferences for unified consent. The initial implementation adds the pref that monitors whether the user has consented for URL-keyed anonymized data collection. It also resets this preference to false when the user signs out of Chrome. Design document: http://go/project-unity-dd (internal only). Bug: 823809, 814973 Change-Id: If902eee16843b8df73b543c151e7155d966441a7 Reviewed-on: https://chromium-review.googlesource.com/1074658 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#564774}
-
Stuart Langley authored
Bug: 715355 Change-Id: I9a43ae333d0844924d08034a9c01cd4d47af357b Reviewed-on: https://chromium-review.googlesource.com/1087194Reviewed-by:
-
Justin Cohen authored
NOTRY=true Bug: 843236 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If67f7873e39cdb7aaa88c55a32d6630b1a431335 Reviewed-on: https://chromium-review.googlesource.com/1087935 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
This is a temparory fix so that EncryptedMediaTest.PolicyCheck doesn't fail on Google Chrome build when using Widevine CDM. A more proper fix will be landed later. Bug: 849846 Change-Id: Iaa92f1b547489c825cf5fc095f9a0fc37ac660d2 Reviewed-on: https://chromium-review.googlesource.com/1087819 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#564771}
-
Matt Falkenhagen authored
It was registering a service worker for each test case, and had a lot of test cases. This changes the file to register a single service worker at the beginning, and unregister it at the end. Bug: 847787 Change-Id: Ic2536824a3c57e86bb5e042287e9e62e6222ad9a Reviewed-on: https://chromium-review.googlesource.com/1087188Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564770}
-
Allen Vicencio authored
This adds the metrics for the number of entries found when performing a ReadDirectory in Native SMB File Share. Bug: 757625 Change-Id: Iebafa900a76cc27c8aa2a878a9ac69318a7992c3 Reviewed-on: https://chromium-review.googlesource.com/1079891 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#564769}
-
Kyle Horimoto authored
SecureChannelService holds one instance of SecureChannelImpl and brokers all API calls to that instance. Bug: 824568, 752273 Change-Id: Iaa3c0cde59fca0382682d3bf34b6458b75712b15 Reviewed-on: https://chromium-review.googlesource.com/1079643 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Christopher Lam authored
This CL fixes an issue where the First Run Dialog didn't show up with the switch enabled because the user was not considered new, which skips the First Run UI. Bug: 849551 Change-Id: Ibef80187dada0a2b99f932bf8f1256b1bf6034c2 Reviewed-on: https://chromium-review.googlesource.com/1086684Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#564767}
-
liberato@chromium.org authored
Previously, WMPI checked the video rotation and didn't enable overlays if it was nonzero. During the switch to AndroidOverlay, this is now the decoder's job. This CL tells MCVD to do that. Bug: 847338 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic76c91db1dd37e7e4160e5e7a17e2951b000884b Reviewed-on: https://chromium-review.googlesource.com/1085691Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#564766}
-
Sadrul Habib Chowdhury authored
Use the presentation-time for measuring the tab-switching times, both for the browser process, and the renderer process (when the renderer needs to submit new content because of the switch, if its content had been evicted while it was in the background). This removes the usage of ui::LatencyInfo for measuring the tab-switching time, and TAB_SHOW_COMPONENT is no longer needed. So TAB_SHOW_COMPONENT is removed, and IPCs are updated to not carry a ui::LatencyInfo anymore. BUG=849182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie6d695ebc2ffaed321e061b965615cee8564430d Reviewed-on: https://chromium-review.googlesource.com/1083862 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Weidong Guo authored
Changes: 1. Define "page break" item as an indicator to create a new page in app launcher. 2. Add function to add "page break" item in item list and sync it to backend. 3. Add function to remove redundant "page break" items. See details at go/applist-gap BUG=843709 Change-Id: I23efb2d833e93683be873a0aff92fe15938075fa Reviewed-on: https://chromium-review.googlesource.com/1079453Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564764}
-
Noel Gordon authored
Adding a file to a path's basic file entry set is common in these test fixtures: common enough to warrant a helper routine. Also don't bother sorting the row entries: remoteCall.waitForFiles does that. Bug: 847172 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I529015eb9a5aa7fda59d9e33babee752875db5ab Reviewed-on: https://chromium-review.googlesource.com/1087189Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564763}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3857fbf..7d43296 git log 3857fbf..7d43296 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7ba3f42..d197803 (1 commits) Created with: gclient setdep -r src/third_party/skia@7d43296 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I94622dc4310a670462bb64b6b29717d75951c149 Reviewed-on: https://chromium-review.googlesource.com/1087614Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564762}
-
Carlos Knippschild authored
The publish code from OfflinePageModelTaskified was deleting the instance of OfflinePageArchiver right after requesting the publishing of pages instead of waiting until they were done. This CL addresses that by changing both the internal and external implementation of the publish methods to use pending_archivers_ to store that instance until the action callback is received. This bug was also partially hidden away because test code was not post-tasking the callback but calling it directly instead. So that has also been changed to more closely mimic the runtime code. Nonetheless the runtime code has alse been made more resistant to the cases where the non-post-task callback happens. Bug: 847630 Change-Id: I1df933ed43a54fa4dccf342fcd7da46403d1a0ea Reviewed-on: https://chromium-review.googlesource.com/1077656Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#564761}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/99a065d..36d4a47 git log 99a065d..36d4a47 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dtu@chromium.org [pinpoint] Add testapp to the global TestCase. Created with: gclient setdep -r src/third_party/catapult@36d4a47 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I74719af3b3395369900c131d3a1e77707ba801eb Reviewed-on: https://chromium-review.googlesource.com/1087636Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564760}
-
Tetsui Ohkubo authored
This CL adds UnifiedSystemTrayTestApi, which implements mojom::SystemTrayTestApi for UnifiedSystemTray. TEST=browser_tests --enable-features=SystemTrayUnified BUG=847104 Change-Id: I278ec8d381aa9f7c13121088a892419dc627b655 Reviewed-on: https://chromium-review.googlesource.com/1086674 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
This class is based on the chromeos::tether::BleScanner class, but it has several key distinctions: (1) It must support scanning for devices which belong to multiple accounts, so it supports having more than one "local device". The function used to direct BleScanner to start or stop scanning is SetScanFilters(). (2) It only has a single listener, so I've changed the Obsever pattern to a Delegate pattern. (3) Since SecureChannelService cannot be temporarily disabled, there is no longer a need for the asynchronous shutdown flow, so the OnDiscoverySessionStateChanged() callback is no longer needed. (4) The artificial limit of 2 devices has been removed. In SecureChannel, it should be possible to scan for as many nearby devices as the client requests. Bug: 824568, 752273 Change-Id: Idaf6b65a6465d41e7979a81d8024b162a32b9b49 Reviewed-on: https://chromium-review.googlesource.com/1084319 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
