- 18 Sep, 2019 40 commits
-
-
Gyuyoung Kim authored
This CL converts BindingSet to ReceiverSet in CompositingModeReporterImpl. According to the change, |bindings| is changed to |receivers| and BindingRequest() is changed to BindReceiver() as well. Bug: 955171 Change-Id: I69d2a4f05101ac1c92a844fe5c5946099a4c6205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803939 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#697453}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Icb6f6c47421173cf943070c45bdbf485bd990c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809965 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#697452}
-
Matt Reynolds authored
Previously, GamepadMonitor would only remove itself as a gamepad consumer if it was active (GamepadStartPolling called with no corresponding GamepadStopPolling), and would leak if it was inactive. This CL ensures GamepadMonitor is always removed if it was ever added as a gamepad consumer. BUG=998128 Change-Id: If4f1ac4d1f3b6889acffeb584c2c6dc04b310e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804836Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#697451}
-
Kelvin Jiang authored
This CL changes DNR actions such that a list of actions is returned when DNR rules are matched, and each action has a unique extension ID. This is necessary for remove header rules and the action feedback API to determine exactly which extensions removed which headers from a request. Bug: 973211, 991420 Change-Id: Ie77a9a51a3c6761da414f8bc3a0f8747068f3717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758806 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697450}
-
Jeevan Shikaram authored
This CL fixes the errors that stopped the main page from being shown when an app was uninstalled. dom-switch now detaches it's child when the app-permission-view is not being displayed. Bug: 1001710 Change-Id: Iefb2e19a3a1aa70d69bbafa9c5b347a030f8fa0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799650 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#697449}
-
Steven Bennetts authored
Shill stores the Ethernet EAP properties in a separate service entry. This separation creates unnecessary and awkward complexity for the UI and serves little purpose at the UI layer. Previously we merged the dictionaries in the JS layer. This change does the merge in the mojo model layer, populating the managed EAP properties for the Ethernet network when they exist. This is done regardless of whether they are actually applied. This CL also adds EthernetEAP properties to chrome://network for debugging purposes. Bug: 853953 For comment only changes to cros_network_config.mojom: TBR=dcheng@chromium.org Change-Id: I7c47c7f33c9df1515b1f8674b4e6178747fcd35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783880Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697448}
-
khmel@chromium.org authored
At this moment it is not possible to configure custom set of systrace events to capture and all predefined categories are always used. It's not possible to easily change how much data is being captured. This CL allows to pass customs set of events or categories for systrace. TEST=Unit test, chrome//tracing does not break. systrace could be customized (with other CLs). BUG=b:/140939504 Change-Id: Icd590027f64fda251dc0f3dc7fb9632ebae5248f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801914 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ExternalService and ExternalConnector to new Mojo types. It also updates RegisterServiceInstance and Clone from connector.mojom and members and methods which implement them. Bug: 955171 Change-Id: I8b9c6ab70a65b8c5661b294ec0ccde742123522a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803940 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#697446}
-
Matt Wolenetz authored
When a decoded audio buffer has an effective front discard that fully discards the decode output for that buffer, and also has an end discard, previously this would fail a DCHECK. Release code would fully discard that buffer, ignore that buffer's end discard, and handle any remaining front discard in future ProcessBuffer calls. Since this scenario can happen when the stream's duration metadata is incorrect relative to the precise decode output (and stream duration metadata sometimes has limited precision, commonly 1ms in webm), this change removes the DCHECK, but adds a comment for clarification. BUG=807515 TEST=associated fuzzer cases no longer fail the DCHECK Change-Id: Ibb0ec6469fbba0111e20758c485d38778983df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809101 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697445}
-
Leon Han authored
The spec change: https://github.com/w3c/web-nfc/issues/328 BUG=520391 Change-Id: Ida8e5d87ef25dc5b194d0cb4aa65104cfafc8614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806357Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#697444}
-
Ted Meyer authored
The play / pause events were missing, because they have no key/value pairs Change-Id: I7944aafa504070ef75a99fad0ec7ee299dc6ff73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808314Reviewed-by:
-
Sophie Chang authored
This should fix 7 out of the top 10 flaky tests for Blink>Previews The RunUntilIdle could potentially invoke a use after free if the UI thread shuts down the http server but then this gets invoked since the RunUntilIdle is actually called on the IO thread Bug: 1004245 Change-Id: Ia749c8f0b412bab6fcf8008764f244b030f1f94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809554 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697442}
-
Lily Chen authored
This adds a histogram to record whether a SameSite=None cookie is also Secure. Bug: 993120 Change-Id: Idd40d395f6ea18bad1ebf2cc951a3f622cb86824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804498 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#697441}
-
Haines Sy authored
Report metrics based off of Built Type instead of channel for Fuchsia metrics Bug: 141130864 Change-Id: I8687514babd14fb5d8cec7289aafa72121bbc0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809674Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Haines Sy <hainesy@google.com> Cr-Commit-Position: refs/heads/master@{#697440}
-
Caroline Rising authored
This animates the new extensions container when extensions are added/removed from the toolbar. There will be a follow up that moved the animating layout to toolbar icon container view so that animating layout will also be used for the avatar button. Bug: 985792 Change-Id: Ia0717e982825ddaa794ad495b20a3ef32bf87060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756983 Commit-Queue: Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#697439}
-
Kunihiko Sakamoto authored
Bug: 993079 Change-Id: Ifca66681f143de24f53a0cc50c9884683763ab0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808944Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#697438}
-
Robert Sesek authored
The base CodeSignConfig is now in a normal Python module and it has unimplemented properties. The build-system-injected variables inherit from that for the BuildPropsCodeSignConfig. A new ChromiumCodeSignConfig class is created to set the signing properties for Chromium, to mirror the InternalCodeSignConfig for Google Chrome builds. Both ChromiumConfig and InternalCodeSignConfig inherit from the BuildPropsCodeSignConfig. This makes it easier to use the signing module without needing to process a config file. Change-Id: I2041da6091f98e3b118a2ddbc9108197ee1003a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808344 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#697437}
-
Jeevan Shikaram authored
This CL removes the chrome://app-management host and deletes related stand-alone page assets. Bug: 1002782 Change-Id: I0a7f5df7886f1765488d2f6c295f709f48024c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804945 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697436}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0033008d95ac..f3c4a829c64f git log 0033008d95ac..f3c4a829c64f --date=short --no-merges --format='%ad %ae %s' 2019-09-17 herb@google.com SkZip - synchronized indexing of several pointers 2019-09-17 ethannicholas@google.com fixed an SkSL parse issue Created with: gclient setdep -r src/third_party/skia@f3c4a829c64f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ic317422d5ac6ab9553cd2907a7f221ab36da57f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810001Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697435}
-
chrome://bluetooth-internalsKyle Horimoto authored
If supported, this toggle is displayed in a new tab named "Debug Logs", and when the toggle's value is changed, BluetoothInternalsHandler::ChangeDebugLogsState() is invoked. In this context, the toggle is only supported if the associated flag is enabled and if the primary account is a Googler's corp account. Bug: 1004572 Change-Id: I2fd7a3a34d95cf5f642c6525a22d84245d81084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804683Reviewed-by:
-
Nick Diego Yamane authored
This is a reland of a798c106 Original change's description: > Get rid of native event (i.e: XEvent) usage in libgtkui > > Get rid of native event (i.e: XEvent) usage when translating ui::KeyEvent into > GdkEvent in GtkUi GdkKeyBindingsHandler and InputMethod context implementation. > Native event usage outside platform code is undesired and blocks changes such > as Aura/X11 => Ozone/X11 migration (e.g: PlatformEvent migration > crbug.com/965991). > > It is worth noting that aura IME code has been slightly modified to set root > window as Event::target() during the PRE_DISPATCH phase (for some reason > InputMethodContext::DispatchKeyEvent() is called at this phase) so that IME > context implementation is then able to retrieve the X11 Window id, needed by > GdkEvent system. > > To be able to retrieve XEvent group field in gtkui code, an Event::Property has > been added and for now is set only for non-ozone X11. Ozone/X11 will be > addressed in a follow-up CL. > > Rationale: > https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc/edit?usp=sharing > > Bug: 965991, 987939 > Change-Id: I64929d6866c1dfcfddbfe75166a1bad139c2da8d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789603 > Commit-Queue: Nick Yamane <nickdiego@igalia.com> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695827} Bug: 965991, 987939 Change-Id: I921805b73cd9c55d1e069026091f0526d242b9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805156Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95dfac5bc324..bbd0b15a0667 Created with: gclient setdep -r src-internal@bbd0b15a0667 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:1004848,chromium:None,chromium:None Change-Id: I4453e1c97d0922f17ab100bf556594a83b200347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809552Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697432}
-
rbpotter authored
Bug: 1001958 Change-Id: I1c90122d4bc43ae9fb073d78ffad5b5516689cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809667Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697431}
-
Julie Jeongeun Kim authored
This CL converts GeneralAudienceBrowsingAPIKeyObserver and GeneralAudienceBrowsingAPIKeyObserver to new Mojo types. It uses PendingRemote, Remote, Receiver and PendingReceiver and also updates GeneralAudienceBrowsingAPIKeySubject from general_audience_browsing.mojom. Bug: 955171 Change-Id: I277c3e5722012bf72d005dd6d6797d35aed4ad5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803944Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697430}
-
Bo Liu authored
Implement the animation demo using webview behind a compile time variable. There is no url bar. Useful for comparison purpose. Duplicates a bunch of code, which is ok assuming demo will not be long lived. Change-Id: I2280255e4d5f546afe1f7c5d054474d228cafe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809623Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697429}
-
Johannes Henkel authored
This is as a debugging aid, to rule out that we're calling io_session_->DeleteSoon twice from this method, for some reason. Bug: 1004684 Change-Id: I13192c75a884f824c7d6ffd92cd17b834a34db6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809999 Commit-Queue: Johannes Henkel <johannes@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#697428}
-
Istiaque Ahmed authored
Extension service workers pause evaluation if the corresponding extension hasn't loaded yet (ExtensionMsg_OnLoaded). However while deciding whether to pause an evaluation, the underlying registry (RendererExtensionRegistry) can change as more extensions can continue to load within GetExtensionOrAppByURL and GetExtensionOrAppIDByURL from DidInitializeServiceWorkerContextOnWorkerThread. Fix this by moving the two accesses to RendererThreadRegistry using the existing single lock. hundred times. Bug: 1004833 Test: Locally by running ServiceWorkerTest.Update(un)PackedExtension few Change-Id: I9830462502e44eb4af7bb46e6f74f2ecc39a65bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809597 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697427}
-
Jeevan Shikaram authored
App Serice updates are issued as delta of changes. This means that every app update will not have the ShowInManagement field. This causes every app update to be sent to the App Management front end. This CL ignores any app updates to apps that are not already in App Management. Adding new apps is unaffected. Bug: 1002233 Change-Id: Ie2d674238a2d43d167c54f45c78bdb9060a770e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807650Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#697426}
-
Gyuyoung Kim authored
This CL applies mojo::Receiver to |client_receiver_| member variable. Bug: 955171, 978694 Change-Id: I6c473edc4cb46d2e92c6dd0e6a3b8a9343b2f978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808658Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/65a5036eb041..a7003d5fc306 git log 65a5036eb041..a7003d5fc306 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 j.vigil@samsung.com Reland "EGL: Implement EGL_KHR_no_config_context" Created with: gclient setdep -r src/third_party/angle@a7003d5fc306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I72622515287957637f154aa7a2364248dae87c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809614Reviewed-by:
-
Joel Hockey authored
Ensure route for /crostini/exportImport is not added when backup and restore is disabled by policy. Bug: 1003944 Change-Id: I9c88d038e928948e5bea2363592612097bf42d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809122Reviewed-by:
-
Weiliang Chen authored
Video smoothness regressed and bisect to previous CL. Since most of that CL is yet to be used, the suspect change is when NotifyPromotionHint is called for ScheduleOverlay. Change the behavior back in attempt to fix video smoothness regression. TBR=liberato Bug: 1004859 Change-Id: I2e32dbc7c38c56e443fffb69721995481ffbaf2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810000Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#697422}
-
Dale Curtis authored
During the changes made for preload=metadata suspend, it was assumed that OnBufferingHaveEnough() had no lingering effects after the next call to MediaIsPlaying(). It turns out this was not true. The method would only clear |cancel_upon_defer_| the first time. The fix is to always clear |cancel_upon_defer_| once the DataSource has been informed of playback. A new unittest verifies this. BUG=1004530 TEST=new unittest, clip from bug does not create more than 1 loader after a seek from the suspended state. R=tguilbert Change-Id: I7655d7ff0ee0ba1024ec0486331d84aeda16918c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807160 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#697421}
-
Ahmed Fakhry authored
- The UMA of color temperatures should only be reported when the user makes changes to it, not whenever we refresh the values on the displays. - The Reported temperature UMA should use the value set by the user, not the effective value we set on the displays (which overrides the user's value to 0 when NL is off). - Fix a bug that caused temperature value of 1.f (100%) to go out of bounds of the UMA range. - Do not animate the temperature if the new value doesn't change the current one. BUG=997931 Change-Id: Ic087cad6901b8d4d8ec56815b48e4afc5b8d66cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808809 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697420}
-
Jazz Xu authored
Bug: 1003450 Change-Id: I5a7a601442cc1d58ba0510f306f76369685f4cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797249 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#697419}
-
Taylor Bergquist authored
When tabs are laid out, some of their widths are rounded down and some rounded up in order to make the sum of their widths exactly equal the available width. This change remembers how many tabs were rounded up in order to ensure that there is no teleportation when the tabstrip enters closing mode. Bug: 958173 Change-Id: I6f239b93531854860737c99c5194a7deaf1b95fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796305 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#697418}
-
Julie Jeongeun Kim authored
This CL converts PasswordManagerDriverAssociatedRequest and PasswordManagerDriverPtr to new Mojo types. It uses PendingReceiver, PendingAssociatedReceiver and Receiver instead of PasswordManagerDriverAssociatedRequest PasswordManagerDriverAssociatedRequest and Binding. Bug: 955171 Change-Id: Ied592687400614e480750dd4e056446bb1ad5e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808937Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Robert Liao authored
BUG=897377 TBR=sky@chromium.org Change-Id: I39a05ebd74bc766f1d54dab54decb518c23294fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809553Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#697416}
-
Lily Chen authored
This adds a histogram that logs whether a cookie's SameSite attribute is present, and if so, whether its attribute value is empty, unrecognized, or one of the currently recognized values. Bug: 993120 Change-Id: I4bf3d86cd58e4a60975eee76e192331bcfa51e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803762Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Matt Simmons authored
Extend the existing impl rather than reimplementing SuggestionsUiDelegate. Bug: 1004609 Change-Id: I6b79967c925be304dcaf93ceb8c65942ce34fecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808787 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697414}
-
