GitLab

Now that hit-testing for views (crbug.com/388838) and
event-targeting for views (crbug.com/391845) use
ViewTargeterDelegate to define custom behaviour for
these operations (instead of the now-obsolete
approach of subclassing ViewTargeter itself), we
should not be calling into EventTargeter for this
purpose. Changes in this CL:

* Finding the target of a scroll event is now
  performed correctly by using the logic in
  ViewTargeterDelegate and its overrides.

* The dead code
  ViewTargeter::SubtreeCanAcceptEvent(),
  ViewTargeter::EventLocationInsideBounds(),
  and ViewTargeter::BoundsForEvent() have been
  removed along with their corresponding tests.

* The class-level documentation for ViewTargeter
  and ViewTargeterDelegate has been updated
  to clarify the purpose of these classes.

BUG=395387,370579
TEST=ViewTargeterTest.*

Review URL: https://codereview.chromium.org/426443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400892
R=robliao@chromium.org
TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/442983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385396
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/446693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/445723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399835

Review URL: https://codereview.chromium.org/427713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/429693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287613 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)"

This reverts https://codereview.chromium.org/320693002/

The original regression this caused (PageRunnerTests.testHandlingOfCrashedTab in telemetry_unittests) does not seem to be happening anymore (locally or on trybots), but please revert and let me know if it happens on the main waterfall.

TBR=tonyg,dtu
BUG=

Review URL: https://codereview.chromium.org/444453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287612 0039d316-1c4b-4281-b951-d872f2087c98

As of https://src.chromium.org/viewvc/blink?view=rev&revision=179240, Blink
no longer implements the behaviour that corresponds to this change.  Everything
is handled blink-side, so remove this support.

Review URL: https://codereview.chromium.org/438733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287611 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, the local NTP resources and the C++ code related to serving it (skipping over search and instant stuff).

BUG=None

Review URL: https://codereview.chromium.org/444593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287610 0039d316-1c4b-4281-b951-d872f2087c98

Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into
aura::Window. The suggestion to do this was made here:
https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h

BUG=NONE

Review URL: https://codereview.chromium.org/425363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287609 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Modify data_reduction_proxy_header to support tamper detection logic. (https://codereview.chromium.org/387353003/)

Reason for revert:
Causes DataReductionProxyHeadersTest.GetDataReductionProxyHeaderWithFingerprintRemoved to timeout on the bots.

TBR=bengr1@chromium.org, tonyg@chromium.org, bolian@chromium.org, yfriedman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381907

Original issue's description:
> 1. Adds action-parsing functionality for data reduction proxy header.
> 
> 2. Adds a couple of functions to return different fingerprint value for tamper detection.
> 
> 3. Adds a function to remove Chrome-Proxy header's fingerprint from its header values, and return the rest of header values.
> 
> 4. Changes HasDataReductionProxyViaHeader to also tell 
> whether data reduction proxy Via header occurs at the last 
> or not.
> 
> 
> BUG=381907
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287561

Review URL: https://codereview.chromium.org/444723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389084,396399

Review URL: https://codereview.chromium.org/437143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287607 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Appears to have destabilized RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap

Original issue's description:
> Start using RenderFrameProxyHost objects.
> 
> Instantiate RenderFrameProxyHost objects for remote frames when using
> --site-per-process.
> 
> BUG=357747, 399709, 399775, 400594
> TBR=kenrb, creis, kalman
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287557

TBR=kenrb@chromium.org,creis@chromium.org,kalman@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357747, 399709, 399775, 400594

Review URL: https://codereview.chromium.org/438393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287605 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/446663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287603 0039d316-1c4b-4281-b951-d872f2087c98

Touching or clicking on the background page while in overview mode will now
dismiss it.

BUG=364507

TEST=TBA

Review URL: https://codereview.chromium.org/435023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287601 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc: https://docs.google.com/a/chromium.org/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit#

BUG=372607

Review URL: https://codereview.chromium.org/435293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287600 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/445573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287598 0039d316-1c4b-4281-b951-d872f2087c98

Add method getAllHeaders to get HttpUrlRequest response headers. It handles multiple headers with the same name.
For compatibility with HttpUrlConnection it includes Http status line as value for NULL key.

BUG=390267

Review URL: https://codereview.chromium.org/423163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394756

Review URL: https://codereview.chromium.org/437353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287596 0039d316-1c4b-4281-b951-d872f2087c98

We no longer sample output and energy_consumption_mwh is the canonical final
metric. This didn't show up on the unittesting bots because they don't run
10.9 where we can measure power.

BUG=400606

Review URL: https://codereview.chromium.org/446593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400734

Review URL: https://codereview.chromium.org/440783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287593 0039d316-1c4b-4281-b951-d872f2087c98

Previously the code would dismiss at most one error dialog before or
after running a test. This now loops until no error dialogs are shown.

This should reduce the instance of INJECTION_EVENT failures, but won't
cure them completely.

BUG=399870

Review URL: https://codereview.chromium.org/445503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287592 0039d316-1c4b-4281-b951-d872f2087c98

Add EM_X86_64 and support for x86_64 relocations.

BUG=369133

Review URL: https://codereview.chromium.org/346583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287591 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287590 0039d316-1c4b-4281-b951-d872f2087c98

This test has been quite flaky on MacOS 10.6 Sync tests.

BUG=400806
TBR=rlarocque

Review URL: https://codereview.chromium.org/441053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287588 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/437383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287587 0039d316-1c4b-4281-b951-d872f2087c98

loading the request. This fixes a bug where large pages would only partially
load.

Review URL: https://codereview.chromium.org/437353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287586 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to r270095 where I tried to do this already, but wasn't quite
successful. (It worked on my box, but nowhere else.)

BUG=400088
R=hans@chromium.org

Review URL: https://codereview.chromium.org/440813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287585 0039d316-1c4b-4281-b951-d872f2087c98

prefetches would be. The hope is to obtain higher numbers than with prerender
control group prerenders, since these still get cancelled for a fair number
of reasons.

R=asvitkine@chromium.org, davidben@chromium.org

Review URL: https://codereview.chromium.org/441923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287582 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces the |SessionLocales| policy that can be used to
recommend one or more UI locales for a public session. If the policy is
set, the first recommended locale is pre-selected when starting a public
session. If more than one locale is recommended, the public session pod
is shown in its advanced form, highlighting the availability of language
and keyboard layout pickers.

The keyboard layout is automatically set to the most popular layout
matching the UI locale.

BUG=214904,241790
TEST=Extensive browser test coverage, including picker UI
R=asvitkine@chromium.org, nkostylev@chromium.org, pneubeck@chromium.org

Review URL: https://codereview.chromium.org/426063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287581 0039d316-1c4b-4281-b951-d872f2087c98

This change links the trusted plugin into the renderer, making it easier for
the trusted plugin to use libraries in Chromium. This removes the
ppGoogleNaClPlugin loadable module file on various platforms.

This is part of a larger effort to remove the "trusted plugin" used to
bootstrap NaCl plugins.

It introduces an "internal_module" interface for setting the value returned by
pp::Module::Get(). This is so that both the trusted plugin and the remoting
plugin can be linked into the renderer. However, I believe this is safe because
the trusted plugin runs in-process and the remoting plugin runs out-of-process.

BUG=394497
R=dmichael@chromium.org, mseaborn@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org, wez@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287071

Review URL: https://codereview.chromium.org/397243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287580 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a method to content::Referrer that allows for sanitizing the referrer before making a network request and uses it to scrub the Referer header for requests originating in the context menu.
It is based on work started by cbentzel@ in https://codereview.chromium.org/277903002/.

BUG=357473

Review URL: https://codereview.chromium.org/438283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287579 0039d316-1c4b-4281-b951-d872f2087c98

It flakes quite frequently on win_chromium_rel_swarming. Locally, it fails 100% of the time on my machine and on scottmg's.

BUG=400646
TBR=msw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/447523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/440163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287576 0039d316-1c4b-4281-b951-d872f2087c98

Fix failing tests on windows platform.

BUG=344379

Review URL: https://codereview.chromium.org/199743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287574 0039d316-1c4b-4281-b951-d872f2087c98

In most files under sync_file_system/drive_backend/,
leveldb::DB and leveldb::WriteBatch are replaced with
LevelDBWrapper to have a database transparent.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabase*:DriveBackend*:LevelDBWrapper*"

Review URL: https://codereview.chromium.org/428063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287573 0039d316-1c4b-4281-b951-d872f2087c98

This was causing latency on switching tabs.

BUG=398103,381820

Review URL: https://codereview.chromium.org/435333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287571 0039d316-1c4b-4281-b951-d872f2087c98

On ChromeOS, this patch should have no effect on the menu's appearance.

On Windows, this patch will give the menu the new style buttons, item placement, and item strings. The rows with buttons should be the same height before and after the patch (which is less than the height for ChromeOS).

BUG=365418

Review URL: https://codereview.chromium.org/431473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287570 0039d316-1c4b-4281-b951-d872f2087c98