- 15 Apr, 2020 40 commits
-
-
Peng Huang authored
wrapped_sk_image()->GetSkSurface() may return nullptr if the deive is lost, so we need to check the result before using it to avoid crash. This CL also improves SharedImageAHB to recreate SkSurface, if surface properties are changed. And it also resets the canvas when write access is done. Bug: None Change-Id: Ic9a7a966ac7063a74f650c1b04c2ee6ba475d918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145467 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759251}
-
François Degros authored
BUG=chromium:1058685 Change-Id: Ifa778623b50c373ac179e6e440f68f89d6b23abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148981Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#759250}
-
Alex Ilin authored
StartSurfaceLayoutPerfTest#testTabToGridFromLiveTabWith10TabsWithoutThumbnail is flaky on an Android O builder as well [1], disabling it for all Android versions. [1] https://ci.chromium.org/p/chrome/builders/ci/test-o-phone/5910 TBR=wychen@chromium.org Bug: 1045938 Change-Id: I40e38d36623add441be0c7e13db7d0b3561165d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144088Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759249}
-
Sigurd Schneider authored
This CL adds a missing enum case which resulted in a triggering a DCHECK. As a drive-by, it fixes a wrong enum case. Bug: chromium:1070234 Change-Id: Ie7f3776d517e43bc93cb93dba0dd9e3d02be253c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146546 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759248}
-
Charlie Hu authored
Previously Document was an instance of ExecutionContext. |document_| not null is equivalent to ExecutionContext not null. However, after recent migration of ExecutionContext to DomWindow, this assumption no longer holds. This CL adds null-check on |document_->GetExecutionContext()| to avoid deref nullptr. Bug: 1069848 Change-Id: Ifadc47b889bf5cd5fc3975b511c92d1dda7d4205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149317Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#759247}
-
Gabriel Charette authored
Design doc: https://bit.ly/chrome-io-jank-metric R=olivierli@chromium.org Bug: 1064645 Change-Id: If0b1ccf43303a6dcd2d77a0fd4b0bcb3d6dd99c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120288Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759246}
-
Mark Cogan authored
This CL updates the SendTabToSelf feature architecturally in several respects. It: - Removes use of the deprecated TabModelList class. - Prepares SendTabToSelf for multi-window by factoring the keyed service (which is scoped to the whole app) into a BrowserAgent (which is scoped to a single window). - Moves the CreateNewEntry() utility method into the BrowserAgent class as SendCurrentTabToDevice(). - Factors away the SendTabToSelf command, since its UI functionality is just a combination of existing commands, and it's invoked from a single location. This removes a responsibility from the BVC. - Adds unit tests to the new browser agent. While this CL *prepares* SendTabToSelf for multi-window, it doesn't add multi-window support -- currently every window will display an infobar when a tab is remotely added to the model. crbug.com/1068482 tracks "full" multi-window support for this feature. Bug: 1056199, 1046378 Change-Id: I1434cf6463b2f96a994345c465be1b952ec58c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137444 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759245}
-
Saurabh Nijhara authored
onBeforeShow() of checking-downloading-update element is not being called due to which the oobe dialogs contained inside it are not being rendered because these dialogs use lazy rendering in OnBeforeShow() of the oobe dialog. This creates a situation with no UI element on the screen but the update process running in the background. Now, calling onbeforeShow() for this element from the defaultControl() of update required screen. This CL also adds a test to avoid such case in future. It tests the update process along with the verification of the UI actually being displayed. Bug: 1048607 Change-Id: Ib1ac1c8d935ec059e62202095e7009f89e98a900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146901Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#759244}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9418b511c73b..094974dab674 git log 9418b511c73b..094974dab674 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 bclayton@google.com VkPipelineCache: Do not publically expose internal mutexes 2020-04-15 bclayton@google.com CMake: Fix build when building with `SWIFTSHADER_ENABLE_VULKAN_DEBUGGER` 2020-04-15 sugoi@google.com Fix fragments depth values not being clamped Created with: gclient setdep -r src/third_party/swiftshader@094974dab674 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5f72e5669020ef9745a19fc465bd6e2c000a00a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759243}
-
Harald Alvestrand authored
Bug: chromium:1068084 Change-Id: Icd3f70b6784ac22ef4e3bc1c99233f51145a917f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146542 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759242}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a5bcf59309b5..dc0359178572 git log a5bcf59309b5..dc0359178572 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@dc0359178572 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd7165e312083aee0003f93c01cdb91f9e6cbb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150605Reviewed-by:
-
Andrew Grieve authored
This reverts commit 01c325ec. Reason for revert: Repro'ed locally and ensured fixed. To elaborate: * The breakage occurred only in incremental builds, and only when building before / after this change. * E.g. Clean builds were correct, but the break was due to the transition of before this CL to after. * The fix I've done here is just to rename the output of the pre-dexsplitter r8 output so that the stale artifact does not break things. I think there might be a bug in dexsplitter that contributed to this breakage as well, but not going to dig into it since I've got another change underway to remove the use of dexsplitter. Original change's description: > Revert "Use .r8dex.jar and .mergeddex.jar rather than .dex.zip" > > This reverts commit 89a7ef17. > > Reason for revert: This is breaking WebView bundles on the official builders, see crbug.com/1069724. It looks like bundletool looks specifically for .dex extensions[1], and this change breaks that assumption. > > 1. https://github.com/google/bundletool/blob/3586f8630e08733503ddbd1e74e10d4fb50e0d69/src/main/java/com/android/tools/build/bundletool/validation/DexFilesValidator.java#L48 > > Original change's description: > > Use .r8dex.jar and .mergeddex.jar rather than .dex.zip > > > > This just renames the extensions in order to make build speed summaries > > distinguish the two. > > > > Bug: 1067273 > > Change-Id: I0a1e14cfed3557d29cd6beb0987436cacfaf6b65 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140908 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Peter Wen <wnwen@chromium.org> > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757855} > > TBR=wnwen@chromium.org,agrieve@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1067273, 1069724 > Change-Id: Ied71fc35aef250bdbf21ee4ec34f5bb2d0eb3423 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145860 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758275} Bug: 1067273, 1069724 Change-Id: I8c505ba68d1c5880a3b39eaec53455e804d48e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149286Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#759240}
-
kylechar authored
The histogram records the wall time for each GPU task. This will eventually be used to add a slow report trigger to capture traces for long running tasks from canary. Bug: 1064662 Change-Id: I30ec4a7f583fc197f916a55eae7dd3b1fbf57bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144340Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#759239}
-
Nicolas Ouellet-Payeur authored
Should make it easier for CL authors to find a reviewer. Change-Id: Ic8edd07691599d308ed3adb2745e08b61387f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148540 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#759238}
-
Brian Salomon authored
Bug: skia:10139 Change-Id: I2d65477a32c6ff95a017000f0d94825dae3e710f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150301 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#759237}
-
Ewann authored
This CL adds Cokkies description to the Cookies screen. screenshot: https://drive.google.com/a/google.com/file/d/1Q_cwV1DR1CFZzFULvq23Rd8c-Z6LPxsC/view?usp=sharing Bug: 1064961 Change-Id: I367c2e2e481687bd5bca7874c2ca7562672ba390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134257 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759236}
-
Ewann authored
To align the footer with the other tableView items, this CL changes the TableViewLinkHeaderFooterItem padding to 16. Bug: 1071013 Change-Id: I98206913b2319f9f51e747058405e86ded0d9e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144023Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#759235}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7b5fba5..55adbeb1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b27b736260d721d8fbb0dd93f8b3a642f6d5e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144249Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759234}
-
Sylvain Defresne authored
On iOS, the application has no access to source_root directly as all applications are bundled. Thus the test data are bundled as asserts and need to be located in DIR_ASSETS. For most of the tests, the directory containing the app binary is the directory containing the assets, but this is not the case for EarlGrey2 test that are part of a PlugIns bundle. Using DIR_ASSETS instead loads the correct path since it is relative to the code that is running, not to the main application. Bug: none Change-Id: I25b0c7b9ac8a7686332591f4488440ffb7f5d4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149427 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#759233}
-
Colin Blundell authored
In WebLayer, both TabImpl and ContentView currently hold on to a reference to the AutofillProviderImpl instance that should be used to talk to the Autofill Service. TabImpl updates its reference when an updateFromBrowser() call is received, and ContentView has its reference set to that of the Tab by BrowserViewController on the Tab becoming the active tab. However, this setup is brittle, as if Tab#updateFromBrowser() is called after the Tab becomes the active Tab, ContentView's reference will become stale. Such a call has indeed crept in, as Tab#updateFromBrowser() is now called from BrowserImpl#onFragmentStart(). This means that autofill no longer works in the initial tab. This CL makes this setup more robust by localizing interaction with AutofillProviderImpl inside TabImpl and having ContentView go through TabImpl as necessary. Bug: 1070296 Change-Id: I1c26ab8e5d8e9decfdcc3155e2577b1dbeda32b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149432Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759232}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3aa998dd83ac..22287060ed91 Created with: gclient setdep -r src-internal@22287060ed91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I62a7eb928f68b12667b9df54ec2c25121f57ac63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759231}
-
Colin Blundell authored
This CL eliminates //weblayer's custom implementation of InterceptNavigationDelegate in favor of using the //components-level implementation that Chrome uses. As part of this change, we adapt //chrome's InterceptNavigationDelegateClient implementation as suitable for WebLayer. With this change, WebLayer now eliminates stale navigation entries left on intent launches as Chrome does and also detects cases where tabs should be closed on intent launches as Chrome does. Actual closing of tabs in those cases is left as a followup. As part of this change, we add an implementation of ContentBrowserClient::IsHandledURL() to //weblayer's ContentBrowserClientImpl. This implementation is needed for the shared InterceptNavigationDelegateImpl to behave as expected. The implementation is based on that in //chrome, with Chrome-specific items deleted (notably, the kChromeSearchScheme is not handled in WebLayer). The diff between PS6 and PS8 contains the differences between //chrome's InterceptNavigationDelegateClient implementation and //weblayer's. One of the notable differences is that WebLayer's Tab objects (a) cannot be directly observed and (b) do not change their associated WebContents during their lifetime. Thus, the //weblayer InterceptNavigationDelegateClient implementation observes WebContents directly, with //weblayer's TabImpl additionally calling directly into the client implementation as necessary. Bug: 1031465 Change-Id: I010c4c3ef066bfb2d718f597c654a3ce3df890db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137441 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#759230}
-
Wez authored
This reverts commit 8e795d5b. Reason for revert: Introduces FlingControllerWithPhysicsBasedFlingTest suite, in which ControllerDoesntBoostFinishedFling test flakes across Fuchsia, Windows, Linux, and Mac platforms. Original change's description: > FlingBoost with experimental fling animation curve > > Currently, if physics based fling curve is enabled, even if the fling is > boosted, the scroll distance is capped by upper bound which is three > times the size of viewport. Thus it nullify the effect of fling boosting > and travels the same distance as it would if fling is not boosted. > > This CL fixes fling boosting with physics based fling curve. It does > so by increasing the upper bound every time a fling is boosted. > > Bug: 647137 > Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#758878} TBR=bokan@chromium.org,nzolghadr@chromium.org,dlibby@microsoft.com,sahir.vellani@microsoft.com Change-Id: Ibfc9e51bf5f86c7d6a626d761c20b3ce97652af6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 647137, 1070776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144087Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#759229}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/93bea5cb50e3..e3f44e3cd6a1 git log 93bea5cb50e3..e3f44e3cd6a1 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 cwallez@chromium.org ShutDownBase, only tick frontend facilities if they have been created 2020-04-15 cwallez@chromium.org Null: Properly fake commands being completed on WaitForIdle Created with: gclient setdep -r src/third_party/dawn@e3f44e3cd6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1068465,chromium:1068886,chromium:1068887 Tbr: cwallez@google.com Change-Id: I22df67e28904c6733db151505b5bd93cac800e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150420Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3ebb6e93f417..43245c56b086 git log 3ebb6e93f417..43245c56b086 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 handellm@webrtc.org Remove excessive log spam in large conferences in downstream project. 2020-04-15 mbonadei@webrtc.org Mark static const class/struct members as constexpr. Created with: gclient setdep -r src/third_party/webrtc@43245c56b086 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1062963 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I69448bcc649674b067a036e87fa2b244d028f1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150422Reviewed-by:
-
Milica Selakovic authored
In this CL password generation is extracted from SetFormFieldValueAction to separate action. Bug: 1064264 Change-Id: If111335c08ec91de250ad8ddc084d15d5ef73cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146545 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#759226}
-
Jan Wilken Dörrie authored
This change fixes a minor bug in the Removal Confirmation Dialog resulting in displaying a wrong placeholder. Fixed: 1070878 Change-Id: I4a96715dc29814ca97a0bc3e38b2aefb1caf1593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149430 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#759225}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f130314cc50c..a5bcf59309b5 git log f130314cc50c..a5bcf59309b5 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 szuend@chromium.org Issues affected by network requests delay requestId to request mapping Created with: gclient setdep -r src/third_party/devtools-frontend/src@a5bcf59309b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070577 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic13c57571a1935031faff1410a3657637a022ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150421Reviewed-by:
-
Yuki Shiino authored
"history.state === popStateEvent.state" should be evaluated to true, however, the result changes depending on their evaluation order. See the bug for details. This patch removes the custom bindings of PopStateEvent.state and reimplements History.state and PopStateEvent.state in a less hacky way, moving caching with V8 private property from Blink-V8 bindings into Blink implementation. WPT failures in this patch are expected. I'll send a fix of WPT separately. Bug: 1070938 Change-Id: Iaf9bdbc6545cdbe18d8f3542944dfce61c443da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147488Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759223}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I472204f0a9a8b02f9b0645c18ed9f9748f757387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150297Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759222}
-
chrome://discardsdpapad authored
Bug: 720034 Change-Id: I3a6b4a4994930b1da62680672efd181506a5a6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148845 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759221}
-
Victor Hugo Vianna Silva authored
In a multi-window scenario, FindBrowserWithProfile has to find the last active one. Since ChromePasswordManagerClient is per WebContents, its browser can be directly retrieved using FindBrowserWithWebContents. Bug: None Change-Id: I8f1cb0c1fe9cf7f8f1a34115a59bdbaf15aa1bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144145Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#759220}
-
Luke Zielinski authored
results viewer. Duplicated from a similar change in crrev.com/c/2140095 Bug: 937369 Change-Id: Ia15291312f41c2b9248c9a7ebc0f214215bf37a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149279Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759219}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8ab5356c195c..aa333ac7985f git log 8ab5356c195c..aa333ac7985f --date=short --first-parent --format='%ad %ae %s' 2020-04-15 hjd@google.com Merge "trace_processor: Update ExtendWithColumn to use SharedPtr" Created with: gclient setdep -r src/third_party/perfetto@aa333ac7985f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3572023c5756974543c2fef4afb89e0f9a2fc633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150418Reviewed-by:
-
Tal Pressman authored
Change-Id: I0ed01ce85cc0c4bd5e1c9475e47fd19771d714e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147406 Auto-Submit: Tal Pressman <talp@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759217}
-
David Van Cleve authored
A previous CL (crrev.com/c/2120102) implemented preliminary data clearing logic for Trust Tokens [*] persistent state, in a manner such that any data removal action clearing cookies would also clear Trust Tokens state. In particular, this clears Trust Tokens state whenever the browser receives a Clear-Site-Data header specifying that cookies should be cleared. This is a problem because persistent Trust Tokens state includes metadata used to enforce privacy invariants. For instance, it contains lists of token issuers associated with each top-level origin and the statuses of origin-scoped rate limits on issuance and redemption. This CL creates a new data removal type for Trust Tokens and adds it to DATA_TYPE_SITE_DATA, with the effect that Trust Tokens state will be cleared through the UI when the user clears cookies and other site data, but the state will not be cleared through the Clear-Site-Data header. [*] https://docs.google.com/document/u/1/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit R=msramek Bug: 1064747 Change-Id: I9c5fbd0ad660199345ab04a89999731d79fded16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144411 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759216}
-
Stephen McGruer authored
This test has non-deterministic failure output, which is blocking the WPT importer. Included a Timeout expectation as there are existing entries with Timeout on some platforms. That expectation may now be unnecessary, but trying to unblock ASAP here :) Bug: 1070995 Change-Id: If77956fb5929d842dc76921aaf1b91634b9e3aa2 TBR=robertma@chromium.org Change-Id: If77956fb5929d842dc76921aaf1b91634b9e3aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147010Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#759215}
-
Guido Urdaneta authored
This reverts commit 9f0e99aa. Reason for revert: Suspect of causing test failures in linux-chromeos-dbg First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18126 services_unittests failed because of: PerfettoIntegrationTest.PacketsEndToEndProducerFirst PerfettoIntegrationTest.ProducerDatasourceInitialized SystemPerfettoTest.MultipleSystemAndLocalSourcesLocalFirst PerfettoIntegrationTest.ClientEnabledAndDisabled ... Original change's description: > Make the producer name include the host_package_name on Android. > > This allows you to trace with perfetto "producer_name_filter" to scope > your system traces to only particular apps (chrome stable/canary/etc). > > Change-Id: I9a677a8d8edfdf6645eb50d9e77e9ffb025ca94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144135 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759188} TBR=dcheng@chromium.org,eseckler@chromium.org,nuskos@chromium.org Change-Id: I3cf97d68304aee6fc4afc90b954d02cbb6ce700e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146906Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, if both payment method manifest and the web app manifest of a payment app were located in the same file, then Chrome would retrieve the same file twice with two separate HTTP GET requests, when looking for installable service worker based payment handlers. This patch compares the URL of the payment method manifest and the web app manifest and, if the two are the same, uses the in-memory copy of the payment method manifest content as the web app manifest content instead of re-downloading it again. After this patch, when Chrome is looking for installable service worker based payment handlers, if the web app manifest and the payment method manifest files are located in the same file, then Chrome performs only one HTTP GET request to retrieve it. This patch does not modify Android payment app signature verification, which always makes two separate HTTP GET requests for the payment method manifest and the web app manifest, without comparing the two URLs for equivalence. Bug: 1069954 Change-Id: I83f82058caf3153e8ab2807acea05d350abd9b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148114Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759213}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2136b569eb2e..3ebb6e93f417 git log 2136b569eb2e..3ebb6e93f417 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 mbonadei@webrtc.org Remove WebRTC-ExcludeTransportSequenceNumberFromFec. Created with: gclient setdep -r src/third_party/webrtc@3ebb6e93f417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia2bd21b75eaef78a7e2122b22efeb6924c118c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150414Reviewed-by:
-
