- 23 Jul, 2018 40 commits
-
-
Aaron Leventhal authored
For get_characterExtents(): - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). - The width/height should not be changed to 1 for offscreen objects. TBR=dmazzoni@chromium.org Bug: 864195 Change-Id: Ib8a57bee7f3b70f46c1c6791ea4c5a294c5ccfe5 Reviewed-on: https://chromium-review.googlesource.com/1146877Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577285}
-
Scott Chen authored
This CL changes imports from iron-icons.html to iron-icon.html (without S), as well as moving element imports to where it's used. Bug: 855205 Change-Id: Ibe22c21ec9270258efafd1e06fed73de1d226f2d Reviewed-on: https://chromium-review.googlesource.com/1145598 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#577284}
-
Jenny Zhang authored
TBR=xiyuan@chromium.org Bug: 854238 Change-Id: I0268b4fbe9e6bc813fe2e7e5d4dfea72084f4102 Reviewed-on: https://chromium-review.googlesource.com/1145761 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577283}
-
Philip Rogers authored
This test is now passing with BGPT and does not need a failing expectation: fast/canvas/synchronous-create-pattern.html Bug: 853947 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id5bdba3ce5de2b6bb8d10d3a9d9d23bf1095a5dc Reviewed-on: https://chromium-review.googlesource.com/1146778Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577282}
-
Jun Mukai authored
It seems Gtk+3 apps are calling this request, which is currently ignored silently and causes an issue like crbug.com/866189. Bug: 866189 Test: manually on device (see the bug for the reproducible steps) Change-Id: I89f24da5a5bced1459b65cc1ff94f63debca90d2 Reviewed-on: https://chromium-review.googlesource.com/1147255Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#577281}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e3c67f2c332..5ba1e9caeecb git log 7e3c67f2c332..5ba1e9caeecb --date=short --no-merges --format='%ad %ae %s' 2018-07-23 ehmaldonado@chromium.org git cl: Start reporting metrics. 2018-07-23 jbarboza@ca.ibm.com fix fetch on aix 2018-07-23 jdoerrie@chromium.org [my_activity] Fix Filtering of Gerrit Reviews Created with: gclient setdep -r src/third_party/depot_tools@5ba1e9caeecb The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386,chromium:NONE TBR=agable@chromium.org Change-Id: Ibd4f5b58f3b63120cb31a6e1850f60be8287a871 Reviewed-on: https://chromium-review.googlesource.com/1147065Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577280}
-
Adrienne Walker authored
This is the GpuImageDecodeCache equivalent of this change: https://chromium-review.googlesource.com/c/chromium/src/+/1147102 Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59da18646c0817f011a464b7571a9b6abf7b8455 Reviewed-on: https://chromium-review.googlesource.com/1147243Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577279}
-
Zach Helfinstein authored
This change is in preparation for creating the Switch Access context menu, which will behave similarly to the ChromeVox Panel. This is a pure refactor with no functional changes. Bug: 864796 Change-Id: I53c34722b97acca482514132c84894c89171c2a2 Reviewed-on: https://chromium-review.googlesource.com/1144308 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
-
Weidong Guo authored
1. Request 48px arc icon instead of 64px because the latter is not supported. 2. Override OnMetadataChanged() in SearchResultSuggestionChipView to update suggestion chip icon when metadata is updated. Bug: 865532 Change-Id: I24628a60fa93e4b434e9fcf70f703df0ec62785c Reviewed-on: https://chromium-review.googlesource.com/1144649 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
Bug: 862358 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I69053e71606a26a0ee7b517768456edbb75120a0 Reviewed-on: https://chromium-review.googlesource.com/1146905Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577276}
-
Findit authored
This reverts commit f7206154. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577271 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y3MjA2MTU0ZmI0OTcwZjQzZWY3YjQ4NTM0OGNkZjMyYzg4ZDkyNjYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/70091 Sample Failed Step: compile Original change's description: > [Background Fetch] Delete the unused FetchedEvent files. > > TBR=jbroman@chromium.org > > Bug: 822765 > Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b > Reviewed-on: https://chromium-review.googlesource.com/1142154 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577271} Change-Id: Ic3771c3853efcdcc742d5aadcbfdf8377b73c7d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822765 Reviewed-on: https://chromium-review.googlesource.com/1146941 Cr-Commit-Position: refs/heads/master@{#577275}
-
Samuel Huang authored
This CL refactors Supersize to prepare for bcanalyzer.py integration. Details: - Variable and function renames. - Split _BulkObjectFileAnalyzerWorker.AnalyzePaths(): - _ClassifyPaths(): Explicitly store .a files and .o files. For LTO we'll split .o into ELF and BC buckets. - _MakeBatches(): Reusable later for ELF and BC separately. - _DoBulkFork(): Reusable. - _RunNm(): Absorbs nm-specific code, will add alternative. - Split _BulkObjectFileAnalyzerWorker.AnalyzeStringLiterals() - _ReadElfStringData(): Separation of concern. - _GetEncodedRangesFromStringAddresses(): ELF-specific code. Will add alternative. - Restructure how results are merged, with more comments. - Split ResolveStringPiecesIndirect() (was ResolveStringPieces()): - _AnnotateStringData(): Reusable. - Will add alternative: ResolveStringPieces(). Bug: 723798 Change-Id: Ib8e0e1785ae11652a17d060c9629e3986df0f93a Reviewed-on: https://chromium-review.googlesource.com/1146775 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577274}
-
James Wallace-Lee authored
Move the code for chrome://accessibility out of content/. Bug: 865733 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4169a666cbf73f5ea9c3383d7aca44577b24193b Reviewed-on: https://chromium-review.googlesource.com/1144187 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bundle up the icon and the title since they will be accessed/modified together in the updateUI call. It also makes sense to move the icon from the metadata proto since that will speed up getting the registration info. TBR=avi@chromium.org Bug: 865063 Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 Reviewed-on: https://chromium-review.googlesource.com/1146650 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577272}
-
Rayan Kanso authored
TBR=jbroman@chromium.org Bug: 822765 Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b Reviewed-on: https://chromium-review.googlesource.com/1142154 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Ian Vollick authored
With this change, it should be possible to support enabling ARCore integration on arm64. I've added a secondary abi analog to loadable_modules and fixed a typo in the __secondary_abi__runtime_deps target that was preventing monochrome_public_test_ar_apk from fulfilling its dependencies. Bug: 841389 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I48182a861e779417a610c20be45cdbe0c52e5b82 Reviewed-on: https://chromium-review.googlesource.com/1145470Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Two capabilities have been added to the GetSettledFetches task: 1. Support CacheQueryOptions, while fetching responses for completed fetches from the Cache Storage. 2. Support for filtering responses corresponding to a specific request from completed fetches. Both will be useful to support match() and matchAll() methods on BackgroundFetchSettledEvent. Bug: 863016 Change-Id: Icababdd71cd1687644cacc9460550de89bdfc4d5 Reviewed-on: https://chromium-review.googlesource.com/1140324Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#577269}
-
Chris Mumford authored
ExtensionThrottleEntryInterface was never strictly necessary. Now that ExtensionThrottleManager does not expose the ExtensionThrottleEntry to any caller (excluding tests) it no longer needs to be a reference counted object. Also, removed the back reference to the ExtensionThrottleManager in the ExtensionThrottleEntry as that was not necessary. Bug: none Change-Id: I5188f7a024304b9159879a9d0763a075c8bfba3c Reviewed-on: https://chromium-review.googlesource.com/1132353 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577268}
-
Jungshik Shin authored
For actual changes, see https://chromium-review.googlesource.com/1145582 TBR=manojgupta@chromium.org BUG=chromium:865100 TEST=locally built chrome os image works. Change-Id: Ifeaa0092937977fbb942741b1f348845c1e4596f Reviewed-on: https://chromium-review.googlesource.com/1147108Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577267}
-
Victor Costan authored
The V2 schema was introduced in WebKit on 2011-07-15, in https://bugs.webkit.org/show_bug.cgi?id=58762. Removing support for the V1 schema allows us to remove the plumbing for a SQLite feature that no other part of the codebase uses. This CL does mean that a hypothetical user who hasn't upgraded Chrome for 7 years and suddenly upgrades will have their DOM storage reset. We generally support database schemas up to 2 years old, so this hypothetical user will most likely start with a clean slate anyways. Change-Id: I8e21c525a114ed1da856af5c393d62a0ad8cfb1c Reviewed-on: https://chromium-review.googlesource.com/1146280Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#577266}
-
Victor Costan authored
The default value for SQLITE_DEFAULT_FILE_FORMAT has been 4 for a while. Besides, the option has a typo in our build file, so it wasn't really used. SQLITE_ENABLE_FTS3_BACKWARDS defines fts1 and fts2 as aliases for fts3. They are not actually used in Chrome. Change-Id: I1bca922862fcff665e614b098cd17e74f908b60d Reviewed-on: https://chromium-review.googlesource.com/1146158Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577265}
-
Khushal authored
R=ericrk@chromium.org Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6c47cf25c2f15c668b50622896170886e23e6658 Reviewed-on: https://chromium-review.googlesource.com/1147253Reviewed-by:
-
Becky Zhou authored
Bug: 860048 Change-Id: Ib8a0daa87d8015f6c13db52484cee59dda22d0cd Reviewed-on: https://chromium-review.googlesource.com/1145822Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577263}
-
Nick Carter authored
JsReplace(script, args...) works by replacing $1, $2, $3, etc in |script| with JS literal values constructed from |args|, similar to base::ReplaceStringPlaceholders, except that args can be a variadic mix of strings, ints, base::Values, GURLs and more. Unlike StringPrintf or manual concatenation, this utility will properly escape string content, even if it contains slashes or quotation marks. Example 1: GURL page_url("http://example.com"); EXPECT_TRUE(ExecuteScript( shell(), JsReplace("window.open($1, '_blank');", page_url))); $1 is replaced with a double-quoted JS string literal: "http://example.com". Note that quotes around $1 are not required. Example 2: bool forced_reload = true; EXPECT_TRUE(ExecuteScript( shell(), JsReplace("window.location.reload($1);", forced_reload))); This becomes "window.location.reload(true);" -- because bool values are supported by base::Value. Numbers, lists, and dicts also work. Change-Id: I11041b6d2db299949266290b940e2d855522f2ea Reviewed-on: https://chromium-review.googlesource.com/1125098 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#577262}
-
Javier Ernesto Flores Robles authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7605dd087b272397bfc028fd7c2de735033d4ea3 Reviewed-on: https://chromium-review.googlesource.com/1141954 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577261}
-
Victor Costan authored
The MemoryDumpProvider API uses 64-bit integers. For consistency, use SQLite's 64-bit API (sqlite_status64) to obtain memory usage statistics from SQLite. This CL also documents the SQLite build configuration setting assumed by the memory usage reporting code. The value needed by the memory reporting code is (currently) the default. However, the SQLite docs [1] recommend a different value, so documenting our needs makes it less likely that we'll accidentally end up with an incorrect configuration. Change-Id: I15217e11bce8d167dce65db345ddf78d21148144 Reviewed-on: https://chromium-review.googlesource.com/1146293Reviewed-by:
-
akaba authored
This CL add a method to SurfaceId that allows for checking if the surfaceId is Inside some SurfaceRange. Bug: 857575 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7b083c82f84e47dc08b9dd2f2ddf8179889ba26e Reviewed-on: https://chromium-review.googlesource.com/1145628 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
This change removes StartListening() and StopListening() methods from Platform and RendererBlinkPlatformImpl since they are not called anymore. Bug: 855308 Change-Id: I8f240737ca7d37abc1eb3267701f76854742d83d Reviewed-on: https://chromium-review.googlesource.com/1144224Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577258}
-
Esmael El-Moslimany authored
Bug: 866359 Change-Id: I5bae80bafd34446eaa35b74d79cb35acb5ba5b6c Reviewed-on: https://chromium-review.googlesource.com/1146991Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#577257}
-
Farah Charab authored
Set the priority of same-origin loading task to high and the priority of cross-origin tasks to low depending on the feature enabled. Bug: 856158 Change-Id: I5bc2e17cf512ccae0cdd7a62d1afc61cc5b53cb7 Reviewed-on: https://chromium-review.googlesource.com/1112252 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Robert Kaplow (OOO until 0730) <rkaplow@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#577256}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2f0fc5687196b274b3235773de212ff46fe67d40 Reviewed-on: https://chromium-review.googlesource.com/1147314Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#577255}
-
Koji Ishii authored
This patch forces legacy layout for the 'text-combine' property, for the first phase of LayoutNG. Also extracted the "if" block to a function because it gets large enough. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2d67e26c506bc560eaf31c574d8552adb785bfb1 Reviewed-on: https://chromium-review.googlesource.com/1144594Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577254}
-
Egor Pasko authored
Since shutil.copy() fails when it cannot open(2) O_WRONLY the destination, introduce an additional step: for a destination that is a file with different contents, delete the destination before copying. Back story: I noticed that in my tree quite a few files were not writeable. It was probably a consequence of a past bug, not sure which one. I was running: shell> build/android/gradle/generate_gradle.py --output-directory out/Debug This caused 'permission denied' from shutil.copy() when it attempted to open the file for writing. One way to reproduce it right now is: shell> cd out/Debug shell> touch obj/third_party/netty4/netty_all_java__process_prebuilt-filtered.jar shell> chmod u-w lib.java/third_party/netty4/netty-all-4.1.9.Final.jar shell> build/android/gradle/generate_gradle.py --output-directory out/Debug BUG=None Change-Id: Ifaa16d52bb2c0e6af362401fc635a3e21f3d7214 Reviewed-on: https://chromium-review.googlesource.com/1146923Reviewed-by:
John Budorick <jbudorick@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577253}
-
Philip Jägenstedt authored
Roll in the most recent version of: testharness.js, testdriver.js, idlharness.js. (webidl2.js has not changed in wpt) Bug: 866467 Change-Id: I5be57429726e2179e0482514158be0e5ec49be04 Reviewed-on: https://chromium-review.googlesource.com/1146804 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#577252}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/89f205cedfcf..ee5a26d974be git log 89f205cedfcf..ee5a26d974be --date=short --no-merges --format='%ad %ae %s' 2018-07-23 hjd@google.com Merge "perfetto-ui: Prefetch resources required resources" 2018-07-23 michaschwab@google.com Merge "Basic gridlines" 2018-07-23 hjd@google.com perfetto-ui: Prefetch resources required resources 2018-07-20 michaschwab@google.com Basic gridlines Created with: gclient setdep -r src/third_party/perfetto@ee5a26d974be The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:111541116 TBR=perfetto-bugs@google.com Change-Id: Id3cc224ea587cc19e94c1a09c454e9cac1e47e38 Reviewed-on: https://chromium-review.googlesource.com/1147101 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577251}
-
Kim Paulhamus authored
Change-Id: I4ca5334941a9f7d83f8a84bbb0f5feffbed2e5ff Reviewed-on: https://chromium-review.googlesource.com/1145949Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#577250}
-
Victor Costan authored
The metrics have not been used in a while, and have no immediately clear use case. Bug: 850539 Change-Id: If11dcadf946bc66071ecb85aa126981a149193b3 Reviewed-on: https://chromium-review.googlesource.com/1146076Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Calder Kitagawa authored
This constitutes the remainder of the changes required for the client to show a larger splash screen icon. The server still needs a few more changes before the larger icons can be shipped but this gets the client to a point where the larger icons can be used. Updates will occur automatically when the new Shell APK version is pushed. Otherwise apps will continue to use the small icons. Because larger splash icons are just app icons, all that is needed to trigger an update is changing the icons in the WebappManifest to update the splash screen icons. Tested on mdpi, hdpi, xhdpi, and xxhdpi devices running L, N, O, P. There is a known issue on P Beta builds where xxhdpi devices don't use the large layout due to Bitmap#getWidth() and Bitmap#getHeight() returning incorrect values for aliased resources. However, this is not something we can solve in Chrome and requires Android changes. See b/111687946 Bug: 819755 Change-Id: I033dba20b766f875b6fc3d7515f24636aa5b0d4a Reviewed-on: https://chromium-review.googlesource.com/1142475Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#577248}
-
Philip Rogers authored
These tests do not appear to be any more flaky with BlinkGenPropertyTrees. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ife14d0bd87e0ba57e9879ea5cb95d291ce83de3b Reviewed-on: https://chromium-review.googlesource.com/1146900 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577247}
-
Victor Costan authored
This CL sets the public interface of //third_party/sqlite to consist of sqlite3.h (general entry point) and recovery.h (header for our custom recovery extension). The CL also adds dependencies on //third_party/sqlite where necessary. These dependencies weren't caught by GN before because SQLite's BUILD.gn has missed sqlite3.h completely, so "gn check" completely ignored the includes pointing to it. Change-Id: I38f95bd30302a6d62d778476893f0d5a2a939581 Reviewed-on: https://chromium-review.googlesource.com/1146320Reviewed-by:
-
