- 24 Sep, 2020 40 commits
-
-
Henrique Ferreiro authored
SetCursorNative is only called from WindowTreeHost::SetCursor, which guarantees that the platform cursor has been set. Bug: 1097556 Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#810120}
-
Leo Lai authored
This reverts commit 6ab3c894. Reason for revert: the project dependency, platform-side proxy, is currently only enabled with device policy and not universally available until M88. Original change's description: > remove cryptohome client from EnrollmentCertificateUploaderImpl > > The new attestation flow doesn't rely on cryptohome client anymore. > > as for testing, EnrollmentCertificateUploaderTest.* are passed. > > Change-Id: Id289cdc1b2e2d4a27179f048c0d6e3d4d968cd88 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303743 > Commit-Queue: Leo Lai <cylai@google.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789865} TBR=emaxx@chromium.org,cylai@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ief64848511e08db9b9b6385c03d15f227a6cd2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425685Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#810119}
-
Sergey Poromov authored
Add Data Leak Prevention features that restricts printing of DLP sensitive content. Bug: 1124651 Test: Browsertest added. Change-Id: I0d653f3ea2518882f3cce8a96195247152fe45fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390651Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810118}
-
Karandeep Bhatia authored
registration. Manifest-only schemas don't need to go through api_registration (which generates api function registration) and generated_api_json_strings (which generates api schema strings) build steps. Exclude them from the same. This also helps ensure we don't redundantly generated schema strings for these apis. BUG=1113513 Change-Id: I69c39cda6a6ac78fd47e6bf01e44110e221bb76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380614 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810117}
-
Victor Hugo Vianna Silva authored
Problem: AndroidSyncSettings (ASS) will soon depend on ProfileSyncService (PSS), particularly in its constructor. Although this is is fine in production code, SyncTestRule poses two issues for this setup on test code. - ASS is created before a fake PSS provided by tests can be injected. This is a problem because the initial state of PSS will be relevant to the constructor logic of ASS, so we need to be able to fake this initial state to write good tests. - ASS is created before the JNI loads in startMainActivityForSyncTest(). For tests that don't provide a fake PSS, ASS will then attempt to talk to the real PSS before JNI is loaded, causing an error. Solution: When SyncTestRule creates an ASS, the goal is actually just to fake one of its internal dependencies, SyncContentResolverDelegate. In this CL, we convert SyncContentResolverDelegate into a singleton. In this way, a fake for this object can be injected without needing to early construct ASS*. Furthermore, JNI is loaded earlier so that the rule can safely use tools like FakeServer and FakeProfileSyncService. * Note that constructing after startMainActivityForSyncTest() is not an option because there's already code talking to ASS when this function is running. Bug: 1125622 Change-Id: I9dd938fd5d8211d58a97adb6d484c1a21a3b67db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424150 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810116}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600905490-263a31e7c986c96eb226e442771660364e68ddae.profdata to chrome-linux-master-1600927122-8b2948f1592bbc4f5258707765d485dd2b5e6892.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4195af499da913cf707b10f35eff715d0b639b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810115}
-
Monica Basta authored
The sync setup frienldy settings has been fully launched. This CL removes the flag and cleans the code accordingly. Bug: 1045423 Change-Id: I32eb5123b6cd473b7b5dc73fb8c99f445afae369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418954Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#810114}
-
Tanmoy Mollik authored
The sync row icons have a border which is white is light mode and black in dark mode. This cl removes the border. Screenshot: https://crbug.com/1131438#c1 Bug: 1131438 Change-Id: I6c16e4fc3ebec0ce971db8e191231c04585c22fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426425Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810113}
-
Dominik Röttsches authored
Use the list of candidates for available fonts implemented in [1], lazily retrieve it and check the list before making IPC calls for requesting a font. After retrieving the list once, this avoids making IPC calls for font retrieval for fonts that are not available through the Android Downloadable Fonts API implemented on the Java side of the IPC interface. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2414514 Bug: 1115064 Change-Id: I0c9bee08082f522cbd00fbf85df0c2f4e806cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425049 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810112}
-
Clemens Arbesser authored
For flows that are triggered by a lite script and show the onboarding, no initial status message should be shown. Details are in the bug, but the tldr; is that we don't want to confuse users by showing the default 'opening' message (since the target site is already loaded). A video of the new behavior is also in the linked bug. Bug: b/166590955 Change-Id: I73fcf1dc2dd32db64d5452d039681f46783d30c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424193Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#810111}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5031f041244ebf3bcae8b157123bd16a8ce2d73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428184Reviewed-by:
-
My Nguyen authored
Use google-grey-600 which is the same color as the disabled text. View: http://screen/QCzfch2vrvgJjuy Bug: 1113439 Change-Id: I1cb748b864cc72e919a997b80a395dfeee670350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423813 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810109}
-
Martin Kreichgauer authored
WebAuthn L2 adds an extension called credProps that is meant to convey additional attributes about a WebAuthn credential at registration time back to the RP. Currently, the only such attribute is an (optional) boolean 'rk' that indicates whether the registered credential was client-side discoverable (aka 'resident key'). This is useful in combination with another L2 feature, the ResidentKeyRequirement enum, which adds a middle value ("preferred") to the previously boolean resident key requirement in a WebAuthn registration request. The 'rk' boolean in the extension output is optional because there are authenticators that may create a discoverable credential, even though the browser didn't request one. In particular, the CTAP2.0 authenticator spec allows for this, but the CTAP2.1 spec doesn't. Hence, if resident key creation was not requested, Chrome will not set the 'rk' field if the responding authenticator is a CTAP2.0 device; but it will set 'rk' to false for CTAP2.1 authenticators. Bug: 1117630 Change-Id: Ide483fc9d597b3658197646f07e174b85d9984cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410419 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810108}
-
Colin Blundell authored
Currently WebLayer/WebView's shared autofill implementation doesn't properly reset state on webpage reload. This results in buggy behavior as the implementation treats the user's session after reload as a continuation of the before-reload session rather than a new session (see [1] for details). This CL fixes the problem by having AutofillProviderAndroid reset its state on receiving a notification to do so from ContentAutofillDriver. This notification is made when a different-documentation navigation is made. As detailed in [1], a reload is always treated as a different-document navigation by //content. We also add a test of that autofill starts a new session in this case, which fails without the change made in this CL. To manually verify: Go to accounts.google.com in WebLayer Shell, focus on the username field to trigger the autofill popup, reload the page, focus on the username field again, and verify that the autofill popup triggers again. [1] https://docs.google.com/document/d/1tyQ5XQLssIoa1AIPJ9WjOnW6-lPZpmpSrxkf5-6HYgc/edit#heading=h.u1hpn0gmjp2e (internal-only, apologies) Bug: 1117563 Change-Id: If6f95aa1fea9dccf0f24a860758fd323d9714c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409492Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810107}
-
Hiroshige Hayashizaki authored
This CL runs tests for module dedicated, shared, service workers and worklets with top-level await enabled. Issue 1111134 will touch module script evaluation code, so needs test coverage of worker/worklet evaluation under TLA. Bug: 1111134, 1022182 Change-Id: I876c94462ac0117c9c743442fe2e34333f86740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418494 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810106}
-
Christian Biesinger authored
..even if contain-intrinsic-size is specified. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1124922 Change-Id: If4c887a3536b65fbeb1c22a8a2e3a66896046ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423584 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#810105}
-
Rushan Suleymanov authored
The feature toggle was enabled by default in M83. Change-Id: I9afb7659990af267540dcd044bafda3dc1c3d8bc Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426426Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#810104}
-
Morten Stenshorne authored
When attempting to clamp the scroll offset during printing, save the scroll offset before clamping, so that it can be restored after printing. Note that there are still issues to fix here. Right now, this CL doesn't fix anything at all, but it will prevent a regression that would otherwise be introduced by crrev.com/2362749. This is what's tested in PrintBrowserTest.NoScrollingVerticalRl PrintBrowserTest.NoScrolling tests scrolling of an iframe and a scrollable DIV, and another scrollable DIV that turns into a non-scrollable flexbox when printed. The iframe part also passes without this CL, and the scrollable DIV ones fail both without and with this CL (and is therefore disabled for now). Same problem for framesets - still not fixed. Added a test. The remaining known scrolling issues when printing are reported as bug 1131598. Based on WIP CL:2402190 by szager. Bug: 1125972 Change-Id: I6c3f5853d329e4731b02b33d67cbd4b016f2675f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418651Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810103}
-
Charles Zhao authored
(1) calling HandwritingModelLoader(spec, receiver, callback).Load() is a bad idea because the .Load() is async and the temporal object could be released very soon. This Cl changes the whole class to be stateless, so that calling HandwritingModelLoader::Load(spec, receiver, callback) won't suffer the same problem. (2) unit tests are fixed accordingly. Bug: 1054628 Change-Id: I56459b14e1fc4a6608d5ed264e6c650d1e076f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415914 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#810102}
-
Dominic Farolino authored
This CL makes AgentSchedulingGroup and its host, implement the mojom::RouteProvider and blink::mojom::AssociatedInterface interfaces. This will make it possible in the future to register ASG-specific routes instead of process-global routes, as well as ASG-specific associated interfaces, as opposed to interfaces that are associated with the process-global IPC channel. Currently the implementations of these interfaces are not operational. Later CLs will flesh out this implementation so we can begin migrating interfaces over to the ASG scope. Bug: 1111231 Change-Id: I3da0a31d31018b18ab616e02f351d3d0876c7694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415949 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810101}
-
Mason Freed authored
Quirks mode layout is slower than no-quirks. This change should not affect the appearance of the image preview document. Bug: 1131185 Change-Id: I79e8b523fa518ddd7a230ea7f669df63e023b9e5 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425008 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#810100}
-
Samuel Huang authored
Previously, SaveDeltaSizeInfo() and LoadDeltaSizeInfo() take an optional |file_obj| parameter, and uses it in a "with" block. This causes the inject |file_obj| to get closed. This side-effect is undesirable for the usual usage pattern of callers lending |file_obj| to functions. This CL fixes the issue by using a one-level recursion to create |file_obj| if it's not provided. Change-Id: I2132aea64bb29edd49576dbaa4b0797a6afb80f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425224 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#810099}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I19660691a5dca58f9ba7b7d7359ee810cbe467cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426368Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810098}
-
Collin Baker authored
Before, an IPH bubble was shown when a second tab was opened. With this CL it is shown as soon as possible after the WebUI tab strip is initialized. Bug: None Change-Id: I2f3e7a7dd04229953af5eefe99e00dbcbbfaa8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418566 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#810097}
-
Hiroshige Hayashizaki authored
This CL adds tests for forcible worker termination during: - Module top-level script evaluation, - Evaluation of dynamic import()ed script evaluation (from module/classic workers), The failure of "Worker is terminated during top-level script evaluation (module)" test on Chromium is tracked by crbug.com/1129793. Bug: 1111134, 1129785, 1129793 Change-Id: I7babf738848a2de51a62679e080a389519fd5884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418751Reviewed-by:
-
Yuki Shiino authored
Introduces build flags to build the new IDL callback function and IDL callback interface bindings. Bug: 839389 Change-Id: I8714d28f1948bdee37cbde0c327f1ad57d406d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418499Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#810095}
-
David Black authored
We should show max 2 downloads in holding space UI. We should show max 3 screenshots in holding space UI. Bug: 1131263, 1131265 Change-Id: I912b87f77bae136d7fcb3095dc7f0b70a83884f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427076 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810094}
-
Darren Shen authored
Previously, the Wrapper message was defined to be: Wrapper { internal_request, internal_reply, reply, request } However, internally, internal_request and internal_reply were the same object, so it seemed a bit overkill. Change Wrapper to just have a public_message or a private_message. Although it's more type-safe to distinguish between request/reply, the terminology can be confusing. Since the private messages don't distinguish between request/reply, might as well do the same for the public messages too. Also change the terminology from internal to public/private, since it better corresponds to the existing terminology about public/private APIs. Fix a bug where the protos were not being serialized at all. Change-Id: I98e96dadf42ce8ccb1a1f28cdbdb06c2386ef2cf Bug: 1019541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423828 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#810093}
-
Ted Meyer authored
Replace the static initializer with helper functions, so that we don't have to modify testing/scripts/check_static_initializers.py when building by default on linux. Bug: 1066176 Change-Id: I1beb107cab47b5d7ece7b10ce5e41b8a407e080f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425446 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810092}
-
Chait Pinnamaneni authored
This is the CL https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2393466 Will rebaseline and enable test again. Bug: 1002914 Change-Id: I0310fd1277158059f9149d38ed97172b4861ef0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422348Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810091}
-
Caitlin Fischer authored
The feature is no longer used in the code. Bug: 1126640 Change-Id: I87611bf977a6e7fcb2df2658675451f1b4a9ea32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427430 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810090}
-
Lei Zhang authored
This reverts commit 6a3c229f. Reason for revert: Collided with https://crrev.com/810071 This CL renamed SetHasAccessBeenGranted(), but the other CL added more calls to it. Original change's description: > [CrOS PhoneHub] Add setter functions to various manager classes > > The added setters are going to be used by a future Cl that implements > the PhoneStatusProcessor class. > > Bug: 1106937 > Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810084} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org Change-Id: I241a33162c008e5f7ab4de0621f1bdb6c0918965 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428103Reviewed-by:
-
David Bienvenu authored
Bug: 813093 Change-Id: I9f9bbdd79924ad1de0d48956413b29de4b45cbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424498Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fb330662. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" 8d82b92f "Origin isolation: add crash test for noopener popup windows" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ie9306f94a3e5447cf46cd6a592d540a6914af201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426549Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810087}
-
tby authored
This CL takes the parsed json from crrev.com/c/2420192 and converts it into Results objects that will later be used to create search results. The next CL will add unit tests. Bug: 1034842 Change-Id: I12dbfd295854475268bc71bc84b3a0e365150d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425688 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#810086}
-
Hiroshige Hayashizaki authored
As ModuleRecord::Evaluate() returns a successful result (with a promise rejected with an exception) for a module script throwing an exception when kTopLevelAwait is enabled, this CL fixes the expectation of ModuleRecordTest accordingly. This also fixes ModuleRecordResolverImplTest to call ParametrizedModuleTest::TearDown() appropriately. Bug: 1111134, 1129743 Change-Id: I7f8267bd7966df58158f4cf70597276d2a0acd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419055 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Jimmy Gong authored
The added setters are going to be used by a future Cl that implements the PhoneStatusProcessor class. Bug: 1106937 Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
David Black authored
With the ability to select multiple holding space items at a time, we want to be able to open, pin, and unpin items in bulk. Bug: 1129981 Change-Id: Ifa0f80de5f3a30c87678858d66c697b8852381a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426085 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
James Vecore authored
Reland as is because the fix was in the parent CL: https://crrev.com/c/2426864/2 Original commit message: > [Nearby] Trigger onboarding when first enabling Nearby > > This CL adds a pref to track if onboarding was run by this user before. > If it has not, when enabling for the first time, onboarding is run first > by navigating to the subpage and showing in a dialog. Once onboarding > has been done once, the user can freely toggle on/off without > triggering onboarding. However, onboarding will still run if the user > triggers the pod button and the feature is disabled. This matches the > Android behavior. > > Additionally, this CL fixes a bug with the premature closing of the > shared receiveManager which needs to stay alive and connected after the > dialog closes otherwise getReceiveManager returns a remote with a closed > pipe. > > Bug: b/154866951 > Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#809623} Change-Id: I91e3a3749ae15ae6bf7879c259e3622e74eba337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427004Reviewed-by:
-
Jeffrey Young authored
Only allow approved topics to be displayed. All topics are defaulted to false and must be enabled by finch params. BUG=b:167458920 TEST=turn on ambient mode with "GeoPhotosEnabled" param set to false. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I2ce8057999279d4792840ce99cd379edba2955ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422583 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#810081}
-
