- 22 Mar, 2018 40 commits
-
-
Avi Drissman authored
It hasn't been broadcast as a notification since r369162, more than two years ago. The code that listens for it is dead. BUG=268984 Change-Id: Ia8ed45dcf334c5eb96a8ea4c1fe6706f82b299b3 Reviewed-on: https://chromium-review.googlesource.com/974324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544958}
-
Yuwei Huang authored
Make HostViewController call EnableVideoChannel(false) when the app is inactive. This can save some battery for the device. Bug: 824554 Change-Id: Ic468344509bcb9458a592cf4eea8e5b28a939f90 Reviewed-on: https://chromium-review.googlesource.com/974506Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544957}
-
Yuwei Huang authored
The weak_ptr_ in ChromotingSession seems to be unused. This CL removes it. Bug: 817566 Change-Id: I4f07be8e8047b76ce36f5fe658b17bf6cf45ec72 Reviewed-on: https://chromium-review.googlesource.com/974563Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#544956}
-
Steven Bennetts authored
This CL: * Delays setting Proxy.Type to PAC unless a PAC value is set. * Sets proxyModified_ = true otherwise so that the type is not overridden on an update. * Focus the appropriate input field when the proxy type changes. Bug: 822670 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e9a68fc8982d2286e144e57dfe14dc61fa84b1b Reviewed-on: https://chromium-review.googlesource.com/974119 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#544955}
-
Steven Bennetts authored
Currently setting automatic_ may trigger automaticChanged_ before ipConfig_ is set, causing unexpected behavior. We should only trigger the automaticChanged_ function on user action. Bug: 823525 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id653bb88bb20b22abd9c85d8c1417b2b8355f5ca Reviewed-on: https://chromium-review.googlesource.com/974510Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544954}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8943d0bd..b8eac287 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic25d7661df6652d9a42e8aeac192fde7e07bf18d Reviewed-on: https://chromium-review.googlesource.com/974451Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544953}
-
Yoshifumi Inoue authored
This patch moves sentence granularity related tests from "VisibleUnitsTest.cpp" to "VisibleUnitsSentenceTest.cpp" for ease of maintenance. Change-Id: I637f054dcb700aee6969113a0287d82656d98508 Reviewed-on: https://chromium-review.googlesource.com/970128Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544952}
-
Yuki Awano authored
- Activate and focus notification content view with text selection changed event in Android. If text selection changed is dispatched from Android, it means that user is trying to type something in Android notification. Bug: 822140 Test: unit_tests:ArcAccessibilityHelperBridgeTest Change-Id: I9e7613d2121cbd43e2cfd9ecc602a8834f18bfdf Reviewed-on: https://chromium-review.googlesource.com/963960 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#544951}
-
Yafei Duan authored
This CL contains the following changes: - Combined consistency checks for temporary/persistent pages, along with clearing legacy archives directory into the StartupMaintenanceTask. Also removed old files. - Combined related tests. - Adding a step to report storage usage for ClearStoragePreRunUsage2 at startup. - Adding an ArchiveManager instance and a method AddPageWithoutDBEntry() to ModelTaskTestBase. Bug: 778813 Change-Id: I9af446da29dbbf912ae0a4f2d73531c224e81f80 Reviewed-on: https://chromium-review.googlesource.com/965634 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#544950}
-
Alan Cutter authored
Bug: 822144 Change-Id: I810ee10d0f428f8893d90281079341101d7d8c04 Reviewed-on: https://chromium-review.googlesource.com/963956 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#544949}
-
Andrey Kosyakov authored
... and do the same in ShellDevtoolsBindings (sigh). Also, add a browser test to cover the implementation in DevToolsUIBindings. Bug: 721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I83bd0c8160feb6a0de764bb4f6615ef421516f4b Reviewed-on: https://chromium-review.googlesource.com/973811 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544948}
-
Christopher Lam authored
This CL fixes focus getting trapped by the cr-action-menu which has tabindex set on it. Since this is moved to the internal dialog, it can be removed from the host. Bug: 823195 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88f012f9d94c31557917a64ae64c34ef0472a836 Reviewed-on: https://chromium-review.googlesource.com/968044Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#544947}
-
Wez authored
While adding the |dcheck_is_configurable| build argument, the new dependency of base/logging.h on a buildflags_header() caused missing GN dependencies to break the build. Add the (known) missing dependencies, and enable GN checks for those targets. Bug: 812058 Change-Id: I5aed4d5a62619e026cdb86e5d6a5c33858875bd4 Reviewed-on: https://chromium-review.googlesource.com/970165 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544946}
-
Khushal authored
If an image fails to decode on a shader, abort early instead of trying to decode the flags further. Since Flags() returns nullptr based on whether the decode failed, it was causing crashes. R=enne@chromium.org Bug: 824068,824058 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1040598df19c94a10a71a5b494f196abfffee2ab Reviewed-on: https://chromium-review.googlesource.com/974480Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#544945}
-
Pavel Feldman authored
Change-Id: Ifa009db981608d2fa0efbcb4d43652010e60e17c Reviewed-on: https://chromium-review.googlesource.com/974077 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544944}
-
Avi Drissman authored
BUG=411569 Change-Id: I711882b31f106ea55de23fedf7e32077be430696 Reviewed-on: https://chromium-review.googlesource.com/974642Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544943}
-
Hector Carmona authored
See screenshot in bug. Bug: 821686 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iddc5c0bc3e2eddc5d1e7d06f30f996191560fba6 Reviewed-on: https://chromium-review.googlesource.com/972548Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#544942}
-
Andrew Grieve authored
Also tweaks the cronet rules to not have to create dummy build_config targets. Bug: 824516 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia0d67c423060abbd6669fb37359f5588bc0ca38f Reviewed-on: https://chromium-review.googlesource.com/974712Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544941}
-
Zhiheng Vincent Li authored
and updates some debug logs. Change-Id: Ib6f108d7ac90d355b8d80eee16b893ef0eaa6ee7 Bug: 72436104 65100261 Test: CastWebContentsIntentUtilsTest.java Reviewed-on: https://chromium-review.googlesource.com/974453 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#544940}
-
Rune Lillesveen authored
Reify as an identifier. Bug: 820299 Change-Id: I483a1e3c126e5b280a2337772584070f96cd533e Reviewed-on: https://chromium-review.googlesource.com/970263Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#544939}
-
Alan Lau authored
Change-Id: I52953684bd1588b4ceda11379cbd2856de7b1273 Reviewed-on: https://chromium-review.googlesource.com/972626 Commit-Queue: Alan Lau <alanlau@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#544938}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3065fb6a19f..9f531298e1a3 $ git log b3065fb6a..9f531298e --date=short --no-merges --format='%ad %ae %s' 2018-03-20 ehmaldonado gclient eval: Get rid of global_scope, local_scope and functions other than Var. Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I23d275808726efddfe477e6f61ff43d2365607a5 Reviewed-on: https://chromium-review.googlesource.com/974502Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544937}
-
Jinsuk Kim authored
This CL moves Android system captioning bridge management out of ContentViewCoreImpl to accessibility/captioning, and lets WebContentsAccessibility keeps the reference to it. No behavioral change was made. Bug: 598880, 727210 Change-Id: I811970ea3654fe8e976ae4000c11e077b14b1f8c Reviewed-on: https://chromium-review.googlesource.com/970045 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544936}
-
Filip Gorski authored
Update of feed library and build file. Monochrome.apk_Dex +5 entries methods +474 bytes Java code size +1,076 bytes Compiled Android resources size +1,819 bytes Transfer size (deflate) +5,584 bytes normalized apk size +396 bytes main dex size +5,188 bytes APK size +6,787.84 bytes Estimated installed size +396 bytes Java code size +36 bytes DexCache +20 bytes Package metadata size +2,073.84 bytes Java code size +1,076 bytes Compiled Android resources size Change-Id: I13a124e124451b7e0bb059fe2886c350298446db Reviewed-on: https://chromium-review.googlesource.com/974467Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#544935}
-
Allen Vicencio authored
Bug: chromium:757625 Change-Id: I519a7baf67bc30084bab6af1dd7c9e2404d45317 Reviewed-on: https://chromium-review.googlesource.com/959526Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#544934}
-
David Trainor authored
Cover another case of PackageManager.resolveActivity() and preemptively catch the Android API PackageManager.queryIntentActivities(). BUG=795934 Change-Id: I5705dbee325b5a9cabebe01cd6e18ddf711bf8e7 Reviewed-on: https://chromium-review.googlesource.com/972345Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#544933}
-
Luciano Pacheco authored
Mojo communication remains between CacheStorageDispatcherHost on the browser side, on renderer side merged CacheStorageDispatcher on WebServiceWorkerCacheStorageImpl, it now uses Mojo callbacks instead of responding via another IPC call. Changed the origin from an argument to be part of the mojo binding context, using origin known by browser at binding time, instead of trusting renderer to provide its origin. Mojo interface split in 2 interfaces, CacheStorage for global operations and CacheStorageCache for operations specific for each individual cache. Add CacheImpl class to implement mojo interface CacheStorageCache. Add CacheRef on renderer side to maintain the mojo connection and client callbacks to guarantee its execution independent of client keeping a reference to WebCache. Replace the timing of method calls from TimeMap member with function arguments passed via base::Bind. Add some includes to fix lint errors from "git cl lint". Remove MessageFilter from CacheStorageDispatcherHost and added the reference count directly to it, instead of inherited from MessageFilter. Add new mojom CacheStorage to content_browser_manifest, allowing it to be used on renderer on the 3 types of web workers and on navigation frame. Bug: 612287 Change-Id: I9744f27c72be232e153595977c07f3a2df7c5e17 Reviewed-on: https://chromium-review.googlesource.com/875510 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#544932}
-
Sammie Quon authored
"No recent items" only shows up on the primary window grid now. If all the windows on a grid are closed, the grid is still kept alive until all windows on all grids are closed, so that the wallpaper blur and opacity change are still seen. Previously, the grid would destroy as soon as all its items were closed, removing the blur and fade from that display, but the system was still in overview mode because another grid was active. If old UI is enabled, the behaviour is unchanged. Test: WindowSelectorTest.OverviewNoWindowsIndicatorMultiDisplay Bug: 804979 Change-Id: I2ed9d4d13301a14ddf7a2ed39a299a5b8183eb2f Reviewed-on: https://chromium-review.googlesource.com/967367Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#544931}
-
Yue Li authored
Bug: 820255 Test: Manual Change-Id: I465d79c3b9cc2d8c0e1b0d6ea33a6b7db4833c37 Reviewed-on: https://chromium-review.googlesource.com/961081 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544930}
-
Timothy Loh authored
This patch begins the implementation of the Crostini App Registry, which will be used to maintain a cache of the installed apps so that we can populate the app launcher without requiring Crostini to be running. For now we just support the most basic fields from .desktop files, but this will be expanded later to support other fields and localization. We key the stored data off an extension id generated from the desktop file id to simplify integration with the App List, which currently expects the id to be a valid extension id. Bug: 821662 Change-Id: I196de114cf975c1402dce4b7550bc4eb5ce0ef1e Reviewed-on: https://chromium-review.googlesource.com/961169Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#544929}
-
Hector Carmona authored
Bug: 821675 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I68f3856a2c7dad75219d480a5618417e69e9cfcd Reviewed-on: https://chromium-review.googlesource.com/969944Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#544928}
-
Eugene But authored
1.) Call updateViewConstraints in the end of the method (per API documentation). 2.) Add constrains only when updateViewConstraints called for the first time (because this method can be called multiple times) Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0a9385a240abd3327e47749c8767f0a908546468 Reviewed-on: https://chromium-review.googlesource.com/974320Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544927}
-
Daniele Castagna authored
Currently scheduling an overlay with ScheduleOverlayCHROMIUM will result in alpha blending being enabled for planes that are not the primary, and alpha blending disabled for the primary planes. We want to be able to explicitly control if alpha blending is enable/disabled. In this way we can: - Have primary planes with alpha blending enabled to support underlay strategies. - Scanout RGBA buffers with alpha blending disabled (this happens with buffers coming from exo). This CL adds a parameter "enable_blend" to glScheduleOverlayCHROMIUM, and to all the layers necessary to bring this information to KMS, in order to explicitly control alpha blending behavior. Bug: 789288, b/74997524 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0b39c3b6e10a03aef983367f71b518ddb84a9ec8 Reviewed-on: https://chromium-review.googlesource.com/967415Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#544926}
-
Scott Chen authored
CL 969741 accidentally broke parity during refactoring, this CL fixes it, so in the case that sync has the "Confirm Sync Settings" error, the page is still reachable. Bug: None Change-Id: I9fa811b8c3e5f220b9d856dbbf860a06f51b1e4a Reviewed-on: https://chromium-review.googlesource.com/973946Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544925}
-
Alan Cutter authored
This is a simple refactor CL that has no changes to behaviour. We wish to use this function in a couple more places in the future so bringing it up to this util file will avoid further duplication. Change-Id: I448ddc47001e9755d514de16e1b2c056e0346886 Reviewed-on: https://chromium-review.googlesource.com/961567Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#544924}
-
Ben Wells authored
Bug: None Change-Id: Ie6933542314eec84d58d3fed67aa43a414e4835a Reviewed-on: https://chromium-review.googlesource.com/972705Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#544923}
-
Jialiu Lin authored
In the previous implementation, a raw ProfileIOData* is passed around to facilitate enterprise whitelist checking. However, it is possible (e.g. during browser shutdown) the UrlCheckerDelegate outlives ProfileIOData, thus causes crash when calling this raw pointer. To fix this lifespan issue, we remove the ProfileIOData raw pointer that is indirectly passed to URLCheckerDelegateImpl, and move all the enterprise whitelist checking logic to earlier stage where we're sure the ProfileIOData pointer is valid. This CL doesn't change the existing behavior of enterprise whitelist checking, therefore SafeBrowsingBlockingPageBrowserTest:: VerifyEnterpriseWhitelist still passes after this change with or without enabling kNetworkService feature. Bug: 818559 Change-Id: Idba3c03f90dad3a78e033c43016179b8cc6e5515 Reviewed-on: https://chromium-review.googlesource.com/969642 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#544922}
-
Kent Tamura authored
Because DEPS include_rules will be qualified with "third_party/blink", any #includes including generated files should be qualified. This CL updates #includes for generated files, and change the output directories for Blink from out/$config/gen/blink to out/$config/gen/third_party/blink. * css_property_names.cc.tmpl Remove "blink/" because move_blink_source.py doesn't handle this pattern, and it violates the current DEPS include_rules. Bug: 578345 Change-Id: I2c97d727b93e158997bec215cdec20d8a406ebb1 Reviewed-on: https://chromium-review.googlesource.com/970386 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#544921}
-
Avi Drissman authored
BUG=823087 Change-Id: I8f01414bbeb1472f2fe062afa5b4c66f4bf1f621 Reviewed-on: https://chromium-review.googlesource.com/972184Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544920}
-
Thomas Guilbert authored
This reverts commit c27ca05e. Reason for revert: This change seems to have started to cause MSAN bot failures. The first build in which which it was included was this one: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/6729 Original change's description: > Allow content script requests to attach SameSite cookies. > > When a content script is injected into a document, it can make requests > to origins in its manifest. With recent changes to allow Chrome to block > cross-site documents, the initiator of content scripts requests was > changed to reflect the extension origin. This change meant that SameSite > cookies were not attached to those requests. > > This CL introduces a check for content scripts making subresource requests > and tags those requests to allow attaching SameSite cookies. > > Bug: 796480 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I021156e346035267d98802cfb0205fc419e970bd > Reviewed-on: https://chromium-review.googlesource.com/896690 > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544790} TBR=creis@chromium.org,nasko@chromium.org,jam@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org Change-Id: I2286f5185bff189f9177bd600cb1a7ca94334cb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796480 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/974349Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#544919}
-