- 08 Feb, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de578cdd6b58..295aca65583b Created with: gclient setdep -r src-internal@295aca65583b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4ef1452efd1e2891508a781faf945dd5065553ac Reviewed-on: https://chromium-review.googlesource.com/c/1461151Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630494}
-
Hector Carmona authored
Navigator.language can return either a language only ('en') or a full locale ('en-US'). If a locale is not found ('ru-RU'), then fall back to using only the language ('ru'). Bug: 922088 Change-Id: I215071e55a9a01a97348491603a4bdabe739ff87 Reviewed-on: https://chromium-review.googlesource.com/c/1460479Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#630493}
-
Mounir Lamouri authored
There is a regular bug being filed by ClusterFuzz about a CHECK when converting an infinity value to base::Value. I fixed a regular issue for duration. Folding the different events into the same entry guarantees that we don't repeat this work. Bug: 927634 Change-Id: I4d8833e8430d42036e6501db65cf4b5349772b07 Reviewed-on: https://chromium-review.googlesource.com/c/1461305 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630492}
-
Lukasz Anforowicz authored
Drag-and-drop into a web page is obviously handled by the web page. If the drag-and-drop started from outside the web page and contains a URL, then it needs to trigger a top-level navigations to that URL. Examples of such navigation-triggering drags are: dragging a Chrome bookmark into a web page; dragging a file from an platform-specific file viewer (e.g. Windows Explorer) into a web page. The navigation above needs to use a unique origin as the initiator of the navigation: 1. This matches other navigations initiated outside of a web page (e.g. omnibox navigations). Here also we have a navigation initiated by a user, to a destination chosen by a user (not by the webpage handling the navigation). One could argue that drag-and-drop started from another web page (say foo.com) should use the origin of that web page as an initiator. Unfortunately, drag-and-drop data doesn't have this information - it only has the destination URL (which can be a different site - say bar.com). I think treating this situation consistently with drags started from outside the browser is fine (at least for now). At the very least, using a unique origin is safer than using the destination origin (which might not always match the origin of the source of the drag). 2. The renderer process handling the drag-and-drop might be locked to a specific site or origin (and therefore not able to use arbitrary origin as the initiator). This has led to renderer kills in https://crbug.com/930049. A regression test will be authored and landed separately - please see https://crrev.com/c/1461339. Bug: 930049 Change-Id: I9c16ea30086d78dc010c8479ea528b0cb3181158 Reviewed-on: https://chromium-review.googlesource.com/c/1460424 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#630491}
-
Sylvain Defresne authored
The override of RegisterListPref taking a std::unique_ptr<base::Value> is never used, so remove it. Bug: 646113 Change-Id: I0267d0ac034f3d8c59c40f20b6e77b534e960184 Reviewed-on: https://chromium-review.googlesource.com/c/1460932 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#630490}
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is never used, so remove it. Bug: 646113 Change-Id: I72b981b2bd9f92394be65eddde1ad3d269552552 Reviewed-on: https://chromium-review.googlesource.com/c/1459538 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#630489}
-
Samuel Huang authored
Details: * Add 2 classes and 1 helper function to rel32_utils.h. * Rel32ReaderArm: ReferenceReader for ARM. * Rel32WriterArm: ReferenceWriter for ARM. * ArmCopyDisp(): Copies displacement data from one ARM instruction to another (of the same type) to make them more similar. This will be used for ReferenceBytesMixer. * These funtions take ADDR_TRAITS template argument, which matches ArmAddrTraits in arm_utils.h. * Add extensive tests. Bug: 918867 Change-Id: I7e7f8bee8cb2a8b49f7fd0e7115b39c49f576398 Reviewed-on: https://chromium-review.googlesource.com/c/1452780 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#630488}
-
Sreerenj Balachandran authored
Add the Hardware Accelerated VA-API based VP9 Encoder support in chromium. The vp9 specific webrtc metadata to make the encoding work with appr.tc is added by Erik Språng<sprang@webrtc.org>. BUG=811912 TEST=run the video_encode_accelerator_unittest on supported devices(eg: soraka) VEA: ./video_encode_accelerator_unittest --gtest_filter=SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/0 --test_stream_data=bear_320x192_40frames.yuv:320:192:12:bear.ivf:100000:30 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm TEST=appr.tc/?debug=loopback&vsc=VP9&vrc=VP9 Change-Id: I50b77d642684a03f7ecc35befd5442d35b41e3ae Reviewed-on: https://chromium-review.googlesource.com/c/1383540Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Cr-Commit-Position: refs/heads/master@{#630487}
-
Dominic Battre authored
We have received a few crashes indicating that failures to access the pref store but none were related to asynchronous loading. This looks like a red herring. TBR=holte@chromium.org Bug: 859477,930274 Change-Id: I71a0653471a102ea310be5c225bd0539b2449e03 Reviewed-on: https://chromium-review.googlesource.com/c/1459624 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630486}
-
Ian Barkley-Yeung authored
Add unit test for CrostiniPackageService. Also fixes a corner case found by unit test (queuing uninstalls while install starts up). BUG=822514 TEST=Ran unit test Change-Id: Ieede7119febda6a2fb67ca9835e8d859ddf08400 Reviewed-on: https://chromium-review.googlesource.com/c/1401611 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630485}
-
Robbie Gibson authored
This CL adds differentiating between searching text and navigating to a url from the search action widget. As the text from the clipboard is displayed to the user, it uses recent_clipboard_content to add an expiration time to the text for privacy reasons. Bug: 915220 Change-Id: I3d70c65301f811a78955db6340df0836ca6150c3 Reviewed-on: https://chromium-review.googlesource.com/c/1378101 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#630484}
-
David Benjamin authored
It's been commented out for a while and isn't very useful. See bug. Bug: 397639 Change-Id: I675ab74725c193b9cc5fcd5ecd74e591f9dc033f Reviewed-on: https://chromium-review.googlesource.com/c/1456350 Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#630483}
-
Daniel Rubery authored
We can use this metric to validate estimates about the time it takes to extract screenshots. Bug: 922226 Change-Id: I26c6429a3f902a6f45b5366e2a9ab1ea44647e77 Reviewed-on: https://chromium-review.googlesource.com/c/1454634Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#630482}
-
Christian Fremerey authored
There are various places in the video capture stack where frames can be silently dropped. The browser-side stack already emits events from code sites where frames are dropped, which get counted via UMA and produce log entries that can be collected by applications such as Hangouts. This CL adds event emitting code to 10 frame drop sites in the renderer-side video capture stack. For reference, here is an overview of how the frame drop events travel from their various origins: MediaStreamVideoTrack::OnFrameDropped() MediaStreamVideoSource::OnFrameDropped() <- Defaults to no-op MediaStreamVideoCapturerSource::OnFrameDropped() <- Overrides media::VideoCapturerSource::OnFrameDropped() <- Defaults to no-op LocalVideoCapturerSource::OnFrameDropped() <- Overrides VideoCaptureImplManager::OnFrameDropped() VideoCaptureImpl::OnFrameDropped() --- IPC to Browser Process --- VideoCaptureHost::OnFrameDropped() VideoCaptureController::OnFrameDropped() MediaStreamVideoRendererSink::FrameDeliverer::OnVideoFrame() MediaStreamVideoSink::OnFrameDropped() MediaStreamVideoTrack::OnFrameDropped() same as above MediaStreamVideoTrack::FrameDeliverer::DeliverFrameOnIO() MediaStreamVideoTrack::OnFrameDropped() same as above VideoTrackAdapter::VideoFrameResolutionAdapter::DeliverFrame() MediaStreamVideoSource::OnFrameDropped() same as above VideoTrackAdapter::VideoFrameResolutionAdapter::DoDeliverFrame() MediaStreamVideoSource::OnFrameDropped() same as above VideoTrackAdapter::DeliverFrameOnIO() MediaStreamVideoSource::OnFrameDropped() same as above Bug: 924182 Change-Id: Icf990cab84e01a406c488cff48d7e94c5ef7355c Reviewed-on: https://chromium-review.googlesource.com/c/1437181Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#630481}
-
Ken Rockot authored
Bug: None Change-Id: I056cfdc91089b63ad20336ff9124f67bb2087e19 Reviewed-on: https://chromium-review.googlesource.com/c/1461304 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Paul Miller <paulmiller@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#630480}
-
Min Chen authored
Tablet.AppWindowDrag.CountOfPerUserSession: The number of the app window drag from top in tablet mode per user session. Tablet.AppWindowDrag.InSplitView.CountOfPerUserSession: The number of the app window drag from top in tablet mode when splitview is active per user session. Tablet.TabDrag.CountOfPerUserSession: The number of the tab drag in tablet mode per user session. Tablet.TabDrag.InSplitView.CountOfPerUserSession: The number of the tab drag in tablet mode when splitview is active per user session. Tablet.TabDrag.DragType: The type of the tab drag in tablet mode. Tablet.WindowDrag.OpenedWindowsNumber: The number of windows in overview when app window drag happens. Tablet.AppDrag.EndWindowState: The end state of app window drag from top, e.g, in overview, splitview or back to maximized or fullscreen. Tablet.WindowDrag.DragEndEventType: Window drag end event, normal end, revert or fling. Tablet.WindowDrag.OpenedOverview: Count the times that overview has been opened when drag a window from top in tablet mode. Used to compare with "Tray_Overview", which count tapping overview button to open overview. Bug: 916830 Change-Id: Ida204a02445f8fbef6c0f0c7040117dfa99bde13 Reviewed-on: https://chromium-review.googlesource.com/c/1388556Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#630479}
-
Erik Jensen authored
The code review for the Mac chooser led to some changes that are also applicable to the Linux chooser. Bug: 679313 Change-Id: I301f9c08aa6afcbf356023b9c0eaea39e171b435 Reviewed-on: https://chromium-review.googlesource.com/c/1457480Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#630478}
-
Wez authored
We provide a ::modular::AgentImpl base-class that implements the Agent protocol, using a caller-supplied function to create per-component state, services, etc, and then managing that state's lifetime on behalf of the caller. Related changes included in this CL: - Add the option of constructing & initializing ServiceDirectory as separate steps, to make it easier for it to be a member of a class. - Add a new modular_unittests target under Fuchsia, and configure it to run on our bots. Bug: 927988 Change-Id: Ifd801460f5bf19f0f59cdb514b5fca57f7155467 Reviewed-on: https://chromium-review.googlesource.com/c/1455683 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#630477}
-
Greg Thompson authored
In preparation for migrating the company name in Chrome's version resource. BUG=928220 R=csharp@chromium.org Change-Id: I6ca745a092a0377dc61b04bd3acec61f647dac96 Reviewed-on: https://chromium-review.googlesource.com/c/1458097 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#630476}
-
Xianzhu Wang authored
In pre-CompositeAfterPaint we have rare cases that a clip escapes an effect's output clip. We have tolerated non-composited cases in PaintChunksToCcLayers [1], and now we also tolerate composited cases in PropertyTreeManager. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc?rcl=e4eadfd6f18ded4d369b8e0e7a7ef93018ff2b85&l=335 Bug: 927556 Change-Id: I0619116ab3b9e56bf839a849c51e8418e929d40c Reviewed-on: https://chromium-review.googlesource.com/c/1456292 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630475}
-
bsheedy authored
Ignores all "render_tests/*.png" files in git instead of explicitly listing directories to ensure that any new RenderTest golden directories that get added don't accidentally get committed without being ignored. Bug: 930181 Change-Id: Iec0178f47fc6d2ca0948b6cd9697f3cdd29f0c8c Reviewed-on: https://chromium-review.googlesource.com/c/1461319 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#630474}
-
Istiaque Ahmed authored
Bug: None Change-Id: I36623aa2bbb0a3fd1aeebbf3a9f44f94fc7164b5 Reviewed-on: https://chromium-review.googlesource.com/c/1460193 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630473}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d6841487eb8e..e59d40e0bcab git log d6841487eb8e..e59d40e0bcab --date=short --no-merges --format='%ad %ae %s' 2019-02-08 herb@google.com Simplify mask handling in SkRemoteGlyphCache 2019-02-08 herb@google.com Split getOrCreateCache into a SkFont and descriptor based calles 2019-02-08 brianosman@google.com Remove support for GPU bone transformations 2019-02-08 mtklein@google.com add more test cases to DAA gm Created with: gclient setdep -r src/third_party/skia@e59d40e0bcab The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I25926e7855bb75b01fb9710227ca3a8498f6a438 Reviewed-on: https://chromium-review.googlesource.com/c/1461147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630472}
-
John Lee authored
Bug: 927717 Change-Id: Ieeb9789977b83587a1dd7869721ba43aea616929 Reviewed-on: https://chromium-review.googlesource.com/c/1455516Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#630471}
-
Aidan Wolter authored
It is unsafe to observe WebContents in any thread other than the browser main thread. Depends-On: chromium/1437623 Bug: None Test: cast_shell_unittests Change-Id: I9f824043afe33bfb97797ac886c99677c1e858ba Reviewed-on: https://chromium-review.googlesource.com/c/1437624 Auto-Submit: Aidan Wolter <awolter@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630470}
-
John Lee authored
Bug: 923259 Change-Id: I9ef936ad47e49f9e67fc9fa49386de9366597888 Reviewed-on: https://chromium-review.googlesource.com/c/1455521Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#630469}
-
Klaus Weidner authored
This creates a new destination directory based on the Cr-Commit-Position of the top local commit, and updates the index.html file to cover all found commit positions. Run with "-h" to see command line options. Bug: 923149 Change-Id: I6bbef88f6472ae78ee67f153d62acd0874ed1297 Reviewed-on: https://chromium-review.googlesource.com/c/1459928 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630468}
-
Vlad Tsyrklevich authored
Currently headless_browsertests manually copies the crashpad handler's dependencies to Helpers/, instead set an an appropriate rpath. Bug: 929873 Change-Id: I6011b833084762a1b07132a9cb1e0642f04deca1 Reviewed-on: https://chromium-review.googlesource.com/c/1460068Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#630467}
-
Becky Zhou authored
+ Add night- variant for some semantic color references + Change themes to inherit DayNight theme + Unify some themes to share the base set of style and color attributes + Add naming convention for themes NOPRESUBMIT=true (Bypass AlertDialog.Builder error since I'm not adding new ones) Bug: 925564 Change-Id: Ice5066812027ae791522ca0cdc5a21110b597b11 Reviewed-on: https://chromium-review.googlesource.com/c/1437201 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#630466}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a0ff7c51200a..12b3d7e9d661 git log a0ff7c51200a..12b3d7e9d661 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 zoddicus@users.noreply.github.com Add strip-debug to webgpu-mode passes (#2368) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@12b3d7e9d661 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I08e4c0248c31027e7a20ba37eeb1c1b216ade3ac Reviewed-on: https://chromium-review.googlesource.com/c/1461195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630465}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4103ceacac3e..f256339a1959 git log 4103ceacac3e..f256339a1959 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 geofflang@chromium.org Vulkan: Implement eglBindTexImage 2019-02-08 jmadill@chromium.org Use github link to SVG example image in docs. Created with: gclient setdep -r src/third_party/angle@f256339a1959 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I43913af29aceabbeec989bfdedc8e2020c582c8d Reviewed-on: https://chromium-review.googlesource.com/c/1461149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630464}
-
Oksana Zhuravlova authored
This page copies the content from an old documentation site page to //docs/mojo_ipc_conversion.md Bug: 929385 Change-Id: I08a1856e0c7acca3d30e876abeefd71cff386c22 Reviewed-on: https://chromium-review.googlesource.com/c/1456200 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#630463}
-
Zhongyi Shi authored
Remove various memeber variables to config QuicStreamFactoryTest and move the configuration to HttpNetworkSession::Params. To configure a new QuicStreamFactoryTest, set the configuration via |test_params_| and call Initialize(). Change-Id: I05789db7fa10a3001d4aa2421e1fdaefff693984 Reviewed-on: https://chromium-review.googlesource.com/c/1461088 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#630462}
-
Nick Diego Yamane authored
Currently, WaylandPointer is not emitting MOUSE_ENTERED events. This has been causing a couple of issues, among them: - When you open a new window using keyboard shortcut for example, the mouse cursor is invisible until you start moving the pointer around. - When a window looses focus with no movement events fired and one tries to open a new window (e.g: using keyboard shortcut), the browser crashes (in builds with dchecks enabled) when it tries to reset cursor for that window. This happens because cursor is not set in this case for the first window (holding a CursorType::kNull in this case), because WaylandWindow::SetCursor is only being triggered when WaylandPointer::Motion events are fired (what doesn't happen in this case). This patch fixes these issues by dispatching a MOUSE_ENTERED platform event in WaylandPointer::Entered() function. Bug: 928272 Change-Id: I13e01f28116fd6ce3a47ce8dc14cedcd51ed72ed Reviewed-on: https://chromium-review.googlesource.com/c/1460357Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#630461}
-
Mihai Sardarescu authored
Consent for Google service is no longer unified. This CL is removing the client of the UnifiedConsentService as it is now obsolete. Bug: 929372 TBR=asvitkine Change-Id: I4cacda2c65e97e13dd79304a337468897a1a0414 Reviewed-on: https://chromium-review.googlesource.com/c/1460918 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#630460}
-
Karan Bhatia authored
The test times out on multiple bots. BUG=923226 TBR=kenrb@chromium.org Change-Id: Ief2710141129c4a2e5fddfa358f7a874a5075f63 Reviewed-on: https://chromium-review.googlesource.com/c/1461299Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630459}
-
Gabriel Charette authored
Modernizes state and makes it easier to perform queries without modifying state (Interlock*() methods can only inspect the current value by replacing it..). Uses the default std::memory_order_seq_cst. We could potentially be slightly less strict but there probably isn't a reason to given this isn't the most expensive operation in PostTask() or DoWork() already. Clarifies things for https://crrev.com/c/1455266/9/base/message_loop/message_pump_win.cc#470 It's fairly weird that the whole algorithm depends on ScopedNestableTaskAllower invoking ScheduleWork() when it's not even a concept known to MessagePump... but this has long been the case... R=fdoray@chromium.org Bug: 885371 Change-Id: Id98fb6e72793cff0485ed916906a313a96f95332 Reviewed-on: https://chromium-review.googlesource.com/c/1460598 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#630458}
-
Scott Violet authored
There were a couple of problems here: . EmbedRoot was Showing() the WindowTreeHost. Instead the visibility should be initially set from WindowTreeClient when it gets information about the root. . The server needs to send IsVisible() for non-top-levels roots. This way, the correct visibility is set in the client. Without this, windows in a hidden container think they are visible. I'm mildly worried this should apply to top-levels too, and it's trickier to get right. I'm postponing that for now. BUG=929454 TEST=covered by tests Change-Id: Icf287c00b866dcaf62f7eb34377f9e950967eb94 Reviewed-on: https://chromium-review.googlesource.com/c/1460489 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630457}
-
Luciano Pacheco authored
Manual edit: - change to reset onMergeItems_ inside FileTabledecorate because that replaces the class constructor. - remove closure markup @struct and @extends because they aren't needed with ES6 class (they're implicit). CL 3 of 4. Bug: 778674 Change-Id: Iddbc2278b700f55588b85567aa9fbbe25a595b3f Reviewed-on: https://chromium-review.googlesource.com/c/1460200 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630456}
-
Anastasia Helfinstein authored
Specifically adds support for standard actions. Bug: 920659 Change-Id: I69e93a695092028f3583695c56b70bc35f71f144 Reviewed-on: https://chromium-review.googlesource.com/c/1460067Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#630455}
-