- 30 Dec, 2019 40 commits
-
-
Chris Harrelson authored
All of the referenced crashes are due to this. I was unable to reproduce a situation when this would happen unfortuantely. Bug: 1038355 Change-Id: Idb7ceb468bd11cc6bc33d48b04cf7212d7f85d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984420Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727798}
-
Nina Satragno authored
Pull GetEphemeralKey down into FidoDeviceAuthenticator and call it from the methods that require a key agreement instead of exposing it as part of the public API. This way we avoid repeating the key agreement logic on fido handlers. A minor downside of doing this is we now get a new ephemeral key when using the PIN we just created on MakeCredential calls. Fixed: 1037617 Change-Id: Ifa2563f1c7ea22c73bed75dc2c407ade95827a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980957 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#727797}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6043069708e1..c9e75ab1ff47 git log 6043069708e1..c9e75ab1ff47 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 hypan@google.com Add support of android app bundle for reference build Created with: gclient setdep -r src/third_party/catapult@c9e75ab1ff47 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986990 Tbr: skyostil@google.com Change-Id: Ib3fa7d18599fbb1a9f2a3bdf9e7364b6442b1411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981496Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727796}
-
Austin Eng authored
This reverts commit 7ede3d62. Reason for revert: dawn_perf_tests are migrated to use histograms and should be fixed. Original change's description: > [Benchmarking] Disable broken dawn_perf_tests from perf waterfall. > > Bug: 1035957 > Change-Id: Ia1e5ac2001c8c165d9a70545ed12456ad577d75a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978874 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726898} Bug: 1035957 Change-Id: I46bde9876bf5bb83c89da892e24ad032bf6b063b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979404 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727795}
-
Rahul Arakeri authored
This CL adds a design doc for the feature in a markdown format under cc/input. Bug: 973568 Change-Id: I1686bc4e73dfb1113f2ab301d23756c080ae4323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982712 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
-
Philip Rogers authored
This patch enables the direct property node update optimization with CompositeAfterPaint. CompositeAfterPaint (CAP) skips updating layer debug info (used for layer dumps) when directly updating transform nodes because PaintArtifactCompositor::Update (PAC) is skipped. It is not straightforward to update the layer debug info without a PAC update, and forcing a PAC update would introduce differences when tracing. As a result, the CAP expectation for multiple-backgrounds-style-change has been changed to have a stale class name. This was not done when landing the direct property node update optimization due to animation worklet web test failures (see: https://crbug.com/953322#c2) but these tests now pass with this change: [run webkit tests] virtual/threaded-no-composited-antialiasing/animations/animationworklet --additional-driver-flag=--enable-blink-features=CompositeAfterPaint [run webkit tests] virtual/threaded/external/wpt/animation-worklet --additional-driver-flag=--enable-blink-features=CompositeAfterPaint Bug: 953322 Change-Id: Icae50c76fa228d1853223642a923c64d8d10c0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983462 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727793}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I5740829fab35dd7f65490ca9c1f2604e44e62108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984352Reviewed-by:
-
John Abd-El-Malek authored
In general content embedders are supposed to get web platform features working with reasonable quota. However if they didn't implement this optional method on ContentBrowserClient, service workers' cache storage wouldn't work. Move the logic that all embedders in the repo used into content, and allow tests to override it if necessary. Also move the logic to use a consistent quota from browser_tests to all browser test based integration tests. Bug: 1035420 Change-Id: Ib1b7c27f8af35dfd9d6a693d33b3b41d0677ea08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977394 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#727791}
-
Xiaocheng Hu authored
Test failed: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/43536 Bug: 1038366 Change-Id: Iad292b9c35ae53cf8b172d93fe101a20dc260545 NoTry: True Tbr: jbudorick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984472Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727790}
-
Rahul Arakeri authored
This CL re-enables a test and updates assert_approx_equals to assert_equals. The test was run successfully 100 times locally and once on the bots. Bug: 1019076 Change-Id: Iea2863fec6f6012051d5094a6a95ae413baabef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981634Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe2d3c73348b..c65d0069ec56 git log fe2d3c73348b..c65d0069ec56 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 mtklein@google.com streamline ReadOpAndSize() 2019-12-30 mtklein@google.com range check before casting to DrawType 2019-12-30 benjaminwagner@google.com Enable ASAN on Windows 2019-12-30 reed@google.com simplify normalizePerspective -- don't compute type, precheck corner value 2019-12-30 bsalomon@google.com Remove TecnoSpark adv. blend workaround. 2019-12-30 brianosman@google.com Remove third_party warning suppression for MSVC:4244 2019-12-30 reed@google.com starter bench for canvas matrix operations Created with: gclient setdep -r src/third_party/skia@c65d0069ec56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I7ff56e70df4eeebc649099512002378f3d199395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984349Reviewed-by:
-
Hesen Zhang authored
- TalkBack will skip the NTP offline card in default granularity. - Adding focusable and focusableInTouchMode attributes in for the TextView fixed it. TBR=dtrainor@chromium.org TBR=twellington@chromium.org Bug: 1035179 Change-Id: I05ca3fc4e1f2ad83b38515114ce067dee08274fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973093 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727787}
-
Chris Harrelson authored
Change-Id: I2f3666162db095bcef150bc85f1a84ab338d9c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979630Reviewed-by:
-
Kurt Horimoto authored
InfobarBannerOverlayCoordinator is a coordinator that will be shared amongst all infobar banners. InfobarBannerOverlayMediator is a superclass that implements behavior shared amongst all InfobarTypes, such as setting the consumer, dispatching responses for user interaction events, and setting up the overlay completion response. This CL also introduces the response infos necessary for banners: - InfobarBannerConfirmButtonTapped is dispatched to notify the model layer that the main button on a confirm infobar banner was tapped. - InfobarBannerModalButtonTapped is dispatched to notify the model layer that the modal button was tapped. - InfobarBannerCompletion is used a completion response and stores whether the dismissal was user-initiated. Bug: 1030357 Change-Id: Ic08d76cb6b65638ebf26986116f5afd960251277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970551 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc5a6b58d2c1..576e75e99e18 Created with: gclient setdep -r src-internal@576e75e99e18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia2faf1f39a4f7b38a531a669454316d4b58a3272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984343Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727784}
-
Xiaocheng Hu authored
Test failed on https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/21231 Bug: 1037651 Change-Id: I982f6e49cccb46df2798fba5a89a77fea818ab37 NoTry: True Tbr: stkhapugin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984499Reviewed-by:
-
Shahbaz Youssefi authored
A change upstream required the presence of build_overrides/vulkan_headers.gni to determine the use of X11. This file already exists in ANGLE, but not in Chromium, which is added in this change. Bug: angleproject:4116 Change-Id: I387deaa26f3f97a66ba90e5e93b8151b999ad30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981097 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#727782}
-
Andrew Grieve authored
Bug: 1036426 Change-Id: Id036e44db06732a837eae7f6d98c1c596a11fe5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984173 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#727781}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.0-1577099071-benchmark-81.0.4005.0-r1 to 81-3987.0-1577099071-benchmark-81.0.4009.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifce685f51b9bae6a832676ad9b3c8b8e672c8a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984459Reviewed-by:
-
Sophie Chang authored
This change adds support for URL-keyed requests and hints to be provided by the optimization guide. Bug: 1036490 Change-Id: Ic261c776a9b8ec54158faff2ac90be81d5f8cd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979350Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727779}
-
Kaustubha Govind authored
This change adds a non-hermetic manual browser test to verify Chrome's DoH implementation against a handful of external DoH servers. The test loops through each server, and attempts to load a test URL. Fallback to Do53 is disabled, so a successful navigation indicates that DoH passed. A new setter set_allow_network_access_to_host_resolutions has been added to BrowserTestBase to allow browser tests to opt-in to using the full host resolver stack (instead of the mock host resolver). This mode then invokes SetAllowNetworkAccessToHostResolutions() on the NetworkServiceTest interface to disable the test host resolver. Bug: 1032710 Change-Id: I8e9e029e69a9e8281adb23e55179d9dd94707ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961006 Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#727778}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf6e7836. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib5e78d0eaca596ecaf8d04d5f50552c15901aced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981098Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727777}
-
Xiaocheng Hu authored
Bug: 1038354 Change-Id: I03c38410a2bc277cd9a2083c26f32f508c7510fa Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984461Reviewed-by:
-
David Bokan authored
This CL is a first step in making scroll offset animations work sensibly with the scroll latching logic of the compositor. In this CL we stop calling ScrollEndImpl from ScrollAnimated, ScrollAnimatedBegin and ScrollOffsetAnimationFinished so that animations don't clear the latched scroller (the |CurrentlyScrollingNode|). We inline the only remaining callsite into ScrollEnd. As a result of this change, we can now simplify the state of several scroll element id tracking variables. Since we no longer clear the latch at the end of a scroll animation, we can set these variables at a scroll begin and assume they will survive unchanged until a ScrollEnd is received. These are: |last_scroller_element_id_| is used to determine which scroller to send a scrollend event to. |scroll_animating_latched_element_id_| was previously used to relatch to the same scroller after an animation ends and another GSU arrives. This is now likely redundant and will be removed in a future CL. Similarly, |scroll_animating_overscroll_target_element_id_| was needed to know which element to send overscroll events to since they're sent when no scrolling is possible and thus the latch is cleared. Since we no longer clear the latch this can also probably be removed. For now, this CL keeps the above variables but simplifies their lifetimes. We also keep the re-latching logic in ScrollAnimated but ensure it re-latches to the same node if we're already latched. A future CL will clean this up so that ScrollAnimated can assume a node is already latched. Bug: 996537,940508 Change-Id: I84d5e74ab174043576e829f85b60f269ae21966b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981066Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727775}
-
Jérôme Lebel authored
Second part of crrev.com/c/1967491 Moving all accessibility identifiers in ui/settings/google_services into ":constants" target. Bug: 866147 Change-Id: I4eda0aeeb77f54e89e9db8dcb329b2660437d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967190 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#727774}
-
Xiaocheng Hu authored
Bug: 1038351 Change-Id: I22dcbecad69c604136d0fccf4372238556ce2559 Tbr: tienmai@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984353Reviewed-by:
-
Caleb Rouleau authored
performance test suite is failing here https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80918 the issue is that we assume that the file will be named .exe, but it isn't sometimes. I revert the changes that were made to the shard map in this change and turn off the unittests that depended on the old version. R=adithyas@chromium.org Bug: 1024767 Change-Id: I0a732dd7c3c35a096ea40b65d43f246513a8913a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984175Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727772}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I98867c7ae88b31e35a56f1585a98a80d4ccdabc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982148Reviewed-by:
-
haozhe authored
Chrome passed all tests Firefox passed all tests other than background-size-composition Bug: 1034538 Change-Id: I0588c7e06c4ef1d545a88098e6dd4af74eb906d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972812Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#727770}
-
haozhe authored
Chrome pass all tests Firefox does not support hanging: https://bugzilla.mozilla.org/show_bug.cgi?id=784648 Bug: 1034538 Change-Id: Ic60846b2e439eb325c682b01376ac0805f0b6a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976494Reviewed-by:
-
Boris Sazonov authored
This CL revises how ProfileOAuth2TokenServiceDelegate is keeping track of the list of accounts that have been advertised to the native code by OnRefreshTokenAvailable. Before, the persistent storage on the Java side was used. Now, a simple instance variable on the C++ side is used instead. Bug: 1006772 Change-Id: I4bb7ddec56f387d332abdef6d1b5c43add617207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983225Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727768}
-
haozhe authored
Chrome passes all the tests Firefox failed the offset-position composition(https://bugzilla.mozilla.org/show_bug.cgi?id=1559232) Bug: 1034538 Change-Id: I245a6d8e9da8252aed7f5d76ddfbadd052813fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974690Reviewed-by:
-
Evan Stade authored
Convert a condition/early out to a DCHECK. There should always be a URL pattern, because an extension that has a content script but no URL pattern ("matches" in the manifest) fails to load. This conditional has been there since user_script_listener.cc was added ~10 years ago, but I don't think it's possible to fail. That said, this check failing is the only logical way I can see the other DCHECK (the one causing the bug) might fail, so adding it might shed light on the cause of the bug. Bug: 1036028 Change-Id: Id91dcf66cb0d02f134cc2a7de7b2003d20b4e621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977240Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#727766}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f04938adfc40..7449dc8a7f22 git log f04938adfc40..7449dc8a7f22 --date=short --first-parent --format='%ad %ae %s' 2019-12-30 lalitm@google.com trace_processor: remove RowId type from trace_processor Created with: gclient setdep -r src/third_party/perfetto@7449dc8a7f22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0bf5c14651b64097e0a7c211d8b71c5380aedebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982147Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Mark virtual/gpu-rasterization/images/exif-orientation-image-document.html as flaky on Mac Sample flake: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20(retina)/23669 Bug: 1037798 Change-Id: I686ecb3eb070277ff755c44d20a089197d343e25 NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984419Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1038342 Change-Id: I9189f756a00b8f5a170c5c76a956340e4aef4968 Tbr: jamescook@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984174Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96464fc25283..fe2d3c73348b git log 96464fc25283..fe2d3c73348b --date=short --first-parent --format='%ad %ae %s' 2019-12-30 reed@google.com SkBlurMaskFilter.h is only needed for (deprecated) emboss Created with: gclient setdep -r src/third_party/skia@fe2d3c73348b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I3e16961be7be1186168d4bc4281e25830663103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982145Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5b94048566ab..471dda709844 git log 5b94048566ab..471dda709844 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 fqj@chromium.org config: build betty-arcvm-master for vmmst-android-pfq 2019-12-28 chrome-bot@chromium.org Update config settings by config-updater. 2019-12-28 saklein@chromium.org query_build_logs: fix builder link and row order. Created with: gclient setdep -r src/third_party/chromite@471dda709844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I589d9c01e995146da794e2eb5f6059675a7ba4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984341Reviewed-by:
-
Kaustubha Govind authored
This method is needed to allow tests to exercise the full host resolution manager stack. Bug: 1032710 Change-Id: Ib302caa9e1eb2438e63a5a144a8e50a51eb094e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980759Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
R=adithyas@chromium.org NOTRY=true Bug: 1024767 Change-Id: I722ea30fe7b9d32f24cb6325102144ea455879d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984172Reviewed-by:
-
