- 20 Jun, 2018 40 commits
-
-
Takumi Fujimoto authored
When the sink list goes from empty to non-empty, we select the first sink with a media route, so that if the user wants to terminate the route, they can do so with just one click on the "Stop" button. Bug: 851586 Change-Id: I6a6309de0ef577ffe4e3dbf3537a748695e555d3 Reviewed-on: https://chromium-review.googlesource.com/1103453Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#568984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dba81d77. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19939 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/secure-contexts TBR=robertma No-Export: true Change-Id: I6d9f72e41dd7bcc79f48621ecd248c33456507f5 Reviewed-on: https://chromium-review.googlesource.com/1108384 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568983}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b3345feca274..b6b01cb2cbaf git log b3345feca274..b6b01cb2cbaf --date=short --no-merges --format='%ad %ae %s' 2018-06-20 tsepez@chromium.org Re-work some more c_str() usage. Created with: gclient setdep -r src/third_party/pdfium@b6b01cb2cbaf The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iee4b6ae0104f5b30da4c7b1b12201009203a5606 Reviewed-on: https://chromium-review.googlesource.com/1108299Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568982}
-
Farah Charab authored
Change-Id: I16992e8f7a593f4dbf8f0516952ed86ed0566e6d Reviewed-on: https://chromium-review.googlesource.com/1106384 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#568981}
-
kylechar authored
The UseSurfaceLayerForVideo feature is still enabled in Android WebView perf tests. WebView isn't compatible with the feature, so force it to disabled always. Bug: 853832 Change-Id: Ide874c0947dfad92ea95edfaec9e7c396ea1520d Reviewed-on: https://chromium-review.googlesource.com/1108385Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#568980}
-
Jamie Madill authored
The test conformance2/rendering/attrib-type-match.html was so flaky it was failing multiple bot runs. We should mark it failing. Bug: 782254 Tbr: kbr@chromium.org Change-Id: I7e634a3ef81d24a692f38140246b5ff5a51d23e6 Reviewed-on: https://chromium-review.googlesource.com/1108477Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#568979}
-
Rintaro Kuroiwa authored
- Watch for events from IDXGIAdapter3::RegisterHardwareContentProtectionTeardownStatusEvent(). - Watch for power-suspend events. - Both notifies the client that there has been a content protection teardown. Bug: 787657 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I531abb2c13f9f635989624d9c624da5227bd5bfa Reviewed-on: https://chromium-review.googlesource.com/1093536 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568978}
-
Tim Zheng authored
This change start up the Crostini terminal in the same display as the shelf/launcher used to launch the terminal app. BUG=chromium:843001 TEST=Manual test on an eve device. Change-Id: Ie4f748eda46151ecba3b3597513a7b22753dfca6 Reviewed-on: https://chromium-review.googlesource.com/1103577Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#568977}
-
Rohit Rao authored
When the bots run, they trigger all tests simultaneously, then collect results in the order that the tests are listed in the json file. If a test has not yet completed, the bot will wait for it to complete before continuing to collect results for the next test. If the slower tests are run first, the bot spends its time waiting when it could otherwise be collecting results from faster tests. By shuffling tests around and running the faster tests first, we may be able to reduce the overall cycle time for this bot. BUG=None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I869a7ba4dbf0362a9d50b6f2e286046db5cc9bea Reviewed-on: https://chromium-review.googlesource.com/1108358Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568976}
-
Ben Pastene authored
Bug: 836447 Change-Id: I08e90548e90e8f4c14e2551dd736a4fcf00b7b20 Reviewed-on: https://chromium-review.googlesource.com/1107262Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2db15690d5..c203a76fa400 git log 5b2db15690d5..c203a76fa400 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 hjd@google.com Merge "perfetto: Fix two small build issues." 2018-06-20 hjd@google.com Merge "perfetto: Silence gmock warning" 2018-06-20 hjd@google.com perfetto: Silence gmock warning 2018-06-20 hjd@google.com perfetto: Fix two small build issues. Created with: gclient setdep -r src/third_party/perfetto@c203a76fa400 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic33f84440e87983b93555e35a7aa96aab8afd944 Reviewed-on: https://chromium-review.googlesource.com/1108221 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568974}
-
Xiaohan Wang authored
This is only used by CastContentBrowserClient internally and does not need to be on the interface. Test: No functionality change Change-Id: Ib020e13e7137b9e8b216aee720fa03e72e2967bb Reviewed-on: https://chromium-review.googlesource.com/1103384Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568973}
-
Victor Costan authored
This CL exposes the following attributes in CookieListItem members returned by cookieStore.get() and cookieStore.getAll(), and contained in cookie change events. * expires: "expiry-time" attribute * domain: "domain" attribute, or null for host-only cookies * path: "path" attribute * secure: "secure-only-flag" attribute The "same-site-flag" attribute will be exposed in a future CL that will also add support for setting it. The following attributes are not exposed intentionally. * "creation-time", "last-access-time": no clear use case * "persistent-flag": exposed implicitly as a null expiration time * "host-only-flag": exposed implicitly as a null domain * "http-only-flag": would always be false This CL also fully implements setting a cookie's domain attribute, and updates the relevant WPT tests. CookieListItem is covered by the API explainer: https://wicg.github.io/cookie-store/explainer.html Cookie attributes are described in the cookie storage model: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-5.4 Bug: 729800 Change-Id: I8061f20d348b53ba8d0dabbd4b97564f6c3b4217 Reviewed-on: https://chromium-review.googlesource.com/1102339 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568972}
-
Fredrik Söderquist authored
SVGElementProxy no longer exist. Change-Id: I552e9d3d0d092ba5d0c51c8bacc8b27bdf29fe4c Reviewed-on: https://chromium-review.googlesource.com/1105977Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#568971}
-
Zach Helfinstein authored
Bug: 801393 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6100aab6e304109480852ab19abde6ae2a46ee17 Reviewed-on: https://chromium-review.googlesource.com/1107246Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#568970}
-
stkhapugin@chromium.org authored
Creates a new popup presenter, renames the old one to "Legacy". Removes existing forking on IsUIRefreshPhase1Enabled, otherwise the new class is a copy of the Legacy one. Adds a protocol to allow having two implementations for presenters. This will allow not having forking everywhere in the file. Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1c3ee5c30d50123544f2288ec95d8e80e7b59032 Reviewed-on: https://chromium-review.googlesource.com/1107981 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568969}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de212ca0391c..beb2d9813c71 git log de212ca0391c..beb2d9813c71 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 mbonadei@webrtc.org Removing usage of //build/config/compiler:no_size_t_to_int_warning. Created with: gclient setdep -r src/third_party/webrtc@beb2d9813c71 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id042b5c99c3c78d7961acfbc8386d3a247fbd7a9 Reviewed-on: https://chromium-review.googlesource.com/1108220Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568968}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a27f2694f0af..ae17e65ef4b4 git log a27f2694f0af..ae17e65ef4b4 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a914f7ff310d..e5c614fbaf79 (3 commits) 2018-06-20 fmalita@chromium.org [skottie] Fix start-time/stretch-time handling 2018-06-20 caryclark@google.com fix for new fiddle compiler 2018-06-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-20 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 964dde93808d..20eea3cd3b2d (1 commits) 2018-06-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-20 allanmac@google.com Overdue reorg of source tree to support multiple platforms & devices. Created with: gclient setdep -r src/third_party/skia@ae17e65ef4b4 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I87b09d62c8ce14778a751216e52b30db110e0dfb Reviewed-on: https://chromium-review.googlesource.com/1108300Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568967}
-
Christian Fremerey authored
Adds a dedicated thread to the video capture service for operating the IO between the capture device and the gpu process for acceleraged Mjpeg decoding. This fixes a deadlock during shutdown of video capture in the video capture service after a session that uses the accelerated jpeg decoder. See the crbug for details. The deadlock and the fix for it can currently only be provoked/verified manually by running a ChromeOS device with a camera attached and command-line flag --enable-features=MojoVideoCapture. Getting coverage in automated integration testing is possible but requires modification of the fake video capture device implementation, see crbug/852606. Bug: 852606, 820608 Change-Id: Id9a57e386d2a741f15fd1de72539f4a9885624da Reviewed-on: https://chromium-review.googlesource.com/1102878Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#568966}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a2cee4816d7b..99525875794b git log a2cee4816d7b..99525875794b --date=short --no-merges --format='%ad %ae %s' 2018-06-20 dproy@chromium.org Adds ALL_CACHE_TEMPERATURES variable Created with: gclient setdep -r src/third_party/catapult@99525875794b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib5545466f523a996138fa34b73b25cc857cc61c1 Reviewed-on: https://chromium-review.googlesource.com/1108219Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568965}
-
rbpotter authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie05684e0aacb7606b107e879f7da0defaf449793 Reviewed-on: https://chromium-review.googlesource.com/1086239Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568964}
-
Boris Sazonov authored
This CL reimplements ExpandablePreferenceGroup to make it usable in other contexts by decoupling it from SingleCategoryPreferences. It also reimplements expand/collapse arrow and adds transition animations to it. Bug: 814728 Change-Id: I126bd08c1841d282f889dfde1ff71b35fe0a2262 Reviewed-on: https://chromium-review.googlesource.com/1106144 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568963}
-
Yoichi Osato authored
This patch is a follow-up of previous patch: [LayoutNG] Paint LayoutReplaced selection considering line height: crrev.com/c/1102287 The test is styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I253917127951a4139ece4191df37a9b68b9a4da3 Reviewed-on: https://chromium-review.googlesource.com/1107526Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568962}
-
Ben Pastene authored
And add two mojo libs that were added to the list of required runtime deps in: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1066085 Change-Id: I0e2d90ba922508f2f22802780944100e8c17b17e Reviewed-on: https://chromium-review.googlesource.com/1072490 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Christopher Cameron authored
BrowserAccessibilityManagerMac::GetParentView is used to get the NSView for a RenderWidgetHostViewMac (via a delegate interface -- it doesn't know it's talking to a RenderWidgetHostViewMac). It does this by calling AccessibilityGetAcceleratedWidget, and then converting to an NSView via ui::AcceleratedWidgetMac::GetNSView. Two problems with this approach: 1. This is roundabout -- the RenderWidgetHostViewMac knows its NSView directly. 2. When the RenderWidgetHostViewMac doesn't do its own compositing, this ends up being incorrect. The gfx::AcceleratedWidget used by compositing is the same as the main window. There exists no gfx::AcceleratedWidget mapped to the RenderWidgetHostViewCocoa. Change BrowserAccessibilityManagerMac::GetParentView to call the delegate method AccessibilityGetNativeViewAccessible, which returns an NSView directly. Remove the implementation of AccessibilityGetAcceleratedWidget, since it will lead to trouble. Bug: 852781 Change-Id: I74985d678f3cb10128a0e2caeb17fb3f22aa1752 Reviewed-on: https://chromium-review.googlesource.com/1105502Reviewed-by:Leonard Grey <lgrey@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568960}
-
Justin Novosad authored
BUG=854068 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie19b1595538a6dad8d8c095233fe16d9383cfd00 Reviewed-on: https://chromium-review.googlesource.com/1108347Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568959}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia153c02e3f88c27a430c50cc85b2f3906f1b9c32 Reviewed-on: https://chromium-review.googlesource.com/1102189 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568958}
-
Xiangjun Zhang authored
When audio/video capturing stops, the capturing count is not decremented before stopping observing the WebContents due to some thread racing on Mac. This CL ensures the correct order of these two operation. Bug: 704797 Change-Id: Ia6168facbb5241321bf5a193da3f67811969f314 Reviewed-on: https://chromium-review.googlesource.com/1101920 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568957}
-
Jun Mukai authored
It turned out that some X11 events arrive to the surfaces when the tests run with Xvfb (without -noreset flag), and that causes additional events which causes mismatches on mock expectations (especially on OnPointerFrame). RunAllPendingInMessageLoop() will consume such events, so those failure won't happen again. BUG=854674 TEST=exo_unittests with Xvfb :9 -nolisten tcp -screen 0 1280x800x24 Change-Id: I2c40aa29708362bd8eb4d05dd6448948622cfd81 Reviewed-on: https://chromium-review.googlesource.com/1105492Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#568956}
-
Fabrice de Gans-Riberi authored
All the remaining tests have been manually disabled. Bug: 706592 Change-Id: I043163517817794891f8a31d6f09913ca74b500c Reviewed-on: https://chromium-review.googlesource.com/1105020Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Ryan Daum authored
Provide VLOGging of system gesture event timing metrics. Bug: internal b/110376393 Test: manual Change-Id: I5fa2c1ac52b02d3b81653bab485cd5379dc07944 Reviewed-on: https://chromium-review.googlesource.com/1108157Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#568954}
-
Justin Cohen authored
This bug is fixed in beta 2. Bug: 852431 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I799dffa75f0de39c4593de6f8f6cf67252df082c Reviewed-on: https://chromium-review.googlesource.com/1107777Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568953}
-
Jialiu Lin authored
This CL further propagates the ReusedPasswordType to warning UIs in order to display correct warning text, and to UMA tracking. To achieve this, 3 page info related enum values are introduced: SB_THREAT_TYPE_ENTERPRISE_PASSWORD_REUSE, SITE_IDENTITY_STATUS_ENTERPRISE_PASSWORD_REUSE MALICIOUS_CONTENT_STATUS_ENTERPRISE_PASSWORD_REUSE And 3 enums are renamed: SB_THREAT_TYPE_PASSWORD_REUSE -> SB_THREAT_TYPE_SIGN_IN_PASSWORD_REUSE SITE_IDENTITY_STATUS_PASSWORD_REUSE -> SITE_IDENTITY_STATUS_SIGN_IN_PASSWORD_REUSE MALICIOUS_CONTENT_STATUS_PASSWORD_REUSE -> MALICIOUS_CONTENT_STATUS_SIGN_IN_PASSWORD_REUSE 2 UMA histogram suffixes are added to cover 2 different enterprise cases: "GSuiteSyncPasswordEntry" Reuse of sync password for GSuite enterprise users "NonGaiaEnterprisePasswordEntry" Reuses of non-Gaia enterprise password (captured on enterprise login page) Bug: 852138 Change-Id: I234791c498a3679a9e5cfbfa371d931b16338408 Reviewed-on: https://chromium-review.googlesource.com/1100104Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568952}
-
Reid Kleckner authored
This test causes a use-after-free when network services are enabled. Disable the test when network services are enabled until the bug is fixed. NOTRY=True TBR=tbansal@chromium.org, thakis@chromium.org BUG=850945 Change-Id: I73526165107c7ecc03c87febbcd772c910177092 Reviewed-on: https://chromium-review.googlesource.com/1108487Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568951}
-
Allen Bauer authored
There are issues here that manifested differently. They where all caused by the same core issue. Since the tabs overlap visually, two tabs can report as being hovered so make sure the |hovered_tab| variable isn't blindly overwritten without first making sure it's painted. Bug: 853240 Bug: 854371 Change-Id: I62643659c6416cb23637613d0c3da83c6f4605f2 Reviewed-on: https://chromium-review.googlesource.com/1108338 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568950}
-
Scott Little authored
The current description of the preview type histogram suffix "LoFi" says that it only refers to server-side LoFi previews, but in reality it actually refers to both server-side and client-side LoFi previews, so this CL updates that description. Change-Id: I4f933186c39adcbb6bc68805ad64f1da2e934904 Reviewed-on: https://chromium-review.googlesource.com/1107200Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Ryan Tseng authored
Most of these have been migrated. Bug: 840631 TBR: tikuta Change-Id: I3a4846c42c401da337f48b60e278c7f7bba52cae Reviewed-on: https://chromium-review.googlesource.com/1108481Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568948}
-
Xiaocheng Hu authored
When an inline child has margin, its parent's rect is no longer a simple union of the descendant rects. Currently, LayoutNG fails to handle this, and produces wrong rects for inline elements. This patch forces box fragment creation if any of its children has inline margin to ensure that LayoutNG returns the correct rects for it. Tests: - fast/forms/form-element-geometry-expected.txt: LayoutNG computes wrong rects for two FONT elements, which is corrected - Three related hit test failures are fixed Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I08bd749620ed108930f832fb518d062268fbae89 Reviewed-on: https://chromium-review.googlesource.com/1107157Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568947}
-
Ned Nguyen authored
Change-Id: I4c7be0b4e3124799c91c45399e063e68d71d480a NOTRY=true # test by PRESUBMIT Change-Id: I4c7be0b4e3124799c91c45399e063e68d71d480a Reviewed-on: https://chromium-review.googlesource.com/1108359 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
-
Orin Jaworski authored
Tab hover opacity is boosted using a linear function ranging from minimum boost on max-width tabs to maximum boost on min-width tabs. The idea here is that wide tabs need less boost than narrow tabs, and the single constant boost of 0.33 was not enough to make tabs stand out. The new range intends to help tabs stand out more on various themes. Bug: 848415 Change-Id: I335035c2cc1760c314eeff71a59a727c321dcc57 Reviewed-on: https://chromium-review.googlesource.com/1097744 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
-
