GitLab

This replaces the nacl_helper_bootstrap program, dynamically-linked against
nacl_helper.so, with a standalone, statically-linked nacl_helper_bootstrap
program that loads the dynamic linker, instructing it in turn to load the
nacl_helper program (now a PIE rather than a DSO).

This avoids two problems with the old scheme:
1. The nacl_helper_bootstrap program remained in the dynamic linker's
   list of loaded objects, as the main executable, even though the
   memory where its .dynamic section had been was overwritten with
   the NaCl untrusted address space.  Code that traverses the list of
   all loaded objects could thus attempt to look at pointers into this
   part of memory, and be led astray.
2. nacl_helper_bootstrap's large (~1G) bss segment could cause the kernel
   to refuse to load the program because it didn't think there was enough
   free memory in the system for so large an allocation of anonymous memory.

The bootstrap program is kept very small by avoiding all use of libc
(except for memset and integer division routines needed on ARM).  It has
its own custom start-up code hand-written in assembly and its own custom
system call stubs done with hand-written GCC inline asm statements.

To avoid the second problem, the bootstrap program no longer has a large
bss.  Instead, it has a special ELF segment (i.e. PT_LOAD header) that
specifies no memory access, and a large (~1G) mapping size from the file.
This mapping is way off the end of the file, but the kernel doesn't mind
that, and since it's all a file mapping, the kernel does not do its normal
memory accounting for consuming a large amount of anonymous memory.

Unfortunately, it's impossible to get the linker to produce exactly the
right PT_LOAD header by itself.  Using a custom linker script, we get the
layout exactly how we want it and a PT_LOAD header that is almost right.
We then use a build-time helper program to munge one field of the PT_LOAD
to make it exactly what we need.

BUG= http://code.google.com/p/chromium/issues/detail?id=94147
TEST= hand-tested chromium build, invoked with --nacl-linux-helper

R=bradchen@google.com,mseaborn@chromium.org


Review URL: http://codereview.chromium.org/7795010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98909 0039d316-1c4b-4281-b951-d872f2087c98

Refactor to put the logic for NTP app grayscaling in Javascript.
Disabled and terminated apps don't disappear from the NTP.
Update the NTP apps when offline status changes.

Caveat: the webstore icon doesn't get desaturated.

BUG=89655,94322,90433
TEST=Open NTP with packaged apps in disabled/enabled state; observe them changing
color when disabled/enabled via chrome://extensions page. Observe color changes
when network interface is unplugged.

Review URL: http://codereview.chromium.org/7792024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98908 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=mpcomplete@chromium.org,darin@chromium.org

Review URL: http://codereview.chromium.org/7774012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98907 0039d316-1c4b-4281-b951-d872f2087c98

Previous code was resizing, and clearing the front buffer as soon as the back
buffer was resized. It can lead to race conditions where the compositor draws a
black texture if it triggers between the resize and the swap.

BUG=None
TEST=Pepper Flash


Review URL: http://codereview.chromium.org/7795015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7812002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7790013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98902 0039d316-1c4b-4281-b951-d872f2087c98

The file manager code depends on the prepareSort method to fetch required sort fields from the filesystem before a sort happens, but the ArrayDataModel doesn't always call it.  This makes for unsorted file lists in certain situations.

BUG=chromium-os:19834
TEST=manual testing


Review URL: http://codereview.chromium.org/7799034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98901 0039d316-1c4b-4281-b951-d872f2087c98

This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In
the current version, we simulate the performance of the existing forward
rendering model; coming changes will prototype a new model.

BUG=None
TEST=self

This is http://codereview.chromium.org/7718020/ with trivial fixes
Original change by Joshua Trask <joshtrask@google.com>

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98706

Review URL: http://codereview.chromium.org/7792002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=browser test
Review URL: http://codereview.chromium.org/7646003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98898 0039d316-1c4b-4281-b951-d872f2087c98

Treat files downloaded from the address bar as "always safe" (including extensions per discussion with asargent and the extensions folks).

This required plumbing the PageTransition::Type from render_view.cc back up through various layers to the download system, as well as adding an extra state qualifier bit on the Type to mark navigations triggered "FROM_ADDRESS_BAR" (since the Type itself sans-qualifier cannot be used to reliably check this).

This also fixes an inconsistency in IsDangerousFile() where "auto-open" lowered our safety checks for Dangerous files but not for AllowOnUserGesture files.

BUG=87192,92345
TEST=Paste the PDF link from bug 87192 comment 0 into your address bar and hit enter.  The file should download without triggering any warning UI in the download shelf.
Review URL: http://codereview.chromium.org/7624031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98897 0039d316-1c4b-4281-b951-d872f2087c98

This depends on https://bugs.webkit.org/show_bug.cgi?id=66746 and http://codereview.chromium.org/7461059/, neither of which have been landed. So this should be considered a preliminary review at this stage :)

BUG=
TEST=

Review URL: http://codereview.chromium.org/7714017

TBR=koz@chromium.org
Review URL: http://codereview.chromium.org/7740056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98896 0039d316-1c4b-4281-b951-d872f2087c98

it to a different class.
R=ziga, dominich
Review URL: http://codereview.chromium.org/7812011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WebIntentControllerPickerTest.*

Review URL: http://codereview.chromium.org/7715037

TBR=binji@chromium.org
Review URL: http://codereview.chromium.org/7778032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/7785007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7778017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WebIntentControllerPickerTest.*

Review URL: http://codereview.chromium.org/7715037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98888 0039d316-1c4b-4281-b951-d872f2087c98

Third attempt at the following.  Unreviewed, this was originally reviewed in http://codereview.chromium.org/7550002 .

Clean up SSL false start blacklist code. Numerous changes, including:
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7804001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/7776018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98884 0039d316-1c4b-4281-b951-d872f2087c98

* Bug fix: fix the issue when there is some files with file names other than '%Y-%m-%d-%H' format in result directory.
* Add two command-line parameter to choose test group CSV file and test group name. The example of such CSV file can be found in testname/media.csv. The test group name shows up in the status email subject. This is necessary to make this analyzer works for arbitrary test group name.
* minor doc change.

Review URL: http://codereview.chromium.org/7806008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87632
TEST=Manual

Review URL: http://codereview.chromium.org/7740065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98882 0039d316-1c4b-4281-b951-d872f2087c98

Make the "get window rect" message handlers report the work area, rather than the true window size, for maximized windows, since that's how the calling code expects them to function.

BUG=88523
TEST=Open DevTools maximized (full single screen) on Windows Vista/7, click the Gearbox button in the Elements panel's Styles pane. The SELECT popup should not stick beyond the right screen edge and should be right-aligned with the right edge of the button. Move the Windows taskbar to the right edge of the screen and repeat. The popup should still get the correct alignment and should not get clipped in any way.
Review URL: http://codereview.chromium.org/7799004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=86536
TEST=ChunkDemuxerTest.TestReadsAfterEndOfStream, ChunkDemuxerTest.TestEndOfStreamWithPendingReads

Review URL: http://codereview.chromium.org/7806002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98880 0039d316-1c4b-4281-b951-d872f2087c98

Fix link error with components build and media.dll. I have no idea why the bots aren't seeing this, it might be an interaction with supalink.
Review URL: http://codereview.chromium.org/7785013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7800012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98878 0039d316-1c4b-4281-b951-d872f2087c98

If a plugin dies with an open modal window the browser window will not be enabled. So, we re-enable the browser if it's ever disabled without any child dialogs.

BUG=90002
TEST=Kill the Flash process while a modal dialog (e.g. file, print) is open. Browser should remain responsive.
Review URL: http://codereview.chromium.org/7812005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98875 0039d316-1c4b-4281-b951-d872f2087c98

Corresponds to stability issues and also a security update:
http://service.real.com/realplayer/security/08162011_player/en/
Review URL: http://codereview.chromium.org/7776019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98873 0039d316-1c4b-4281-b951-d872f2087c98

* Constraint favicon size for bookmarks & most-visited to 16x16.
* Make color strip on bookmarks and most-visited full opacity.
* Set padding space between icon and title for bookmarks & most-visited to 8px.
Review URL: http://codereview.chromium.org/7794005

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/7776020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98872 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7778019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98868 0039d316-1c4b-4281-b951-d872f2087c98

Also adds an Aura test suite.

http://crbug.com/93933
http://crbug.com/93943
TEST=see unittest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98850
Review URL: http://codereview.chromium.org/7791030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98866 0039d316-1c4b-4281-b951-d872f2087c98

We should never use raw pointers of v8 objects in client code.

We should always use v8::Handle and it subclasses, v8::Local and v8::Persistent,
whenever referencing them.

Any allocation from v8 heap can make raw pointers invalid.

BUG=None
TEST=None

R=mnaganov@chromium.org
TBR=tonyg@chromium.org

Review URL: http://codereview.chromium.org/7779012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98865 0039d316-1c4b-4281-b951-d872f2087c98

1. make drag-over state match hover state for page switchers and nav dots
2. make recently closed text and arrow a hardcoded color (looks fine on a variety of themes; matches nav dot text)
3. don't show pulse for right click on apps

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7799015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98864 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7785003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98863 0039d316-1c4b-4281-b951-d872f2087c98

Add means for running some tests only o-o-p, add messaging o-o-p test.

BUG=None
TEST=included
TBR=dmichael@chromium.org

Review URL: http://codereview.chromium.org/7799031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94661
TEST=New unit test; also manually add a syncable app to profile, sync, then install extension with same ID: with change, no crash, without, crash on sync.


Review URL: http://codereview.chromium.org/7795011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98860 0039d316-1c4b-4281-b951-d872f2087c98

* Constraint favicon size for bookmarks & most-visited to 16x16.
* Make color strip on bookmarks and most-visited full opacity.
* Set padding space between icon and title for bookmarks & most-visited to 8px.
Review URL: http://codereview.chromium.org/7794005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98859 0039d316-1c4b-4281-b951-d872f2087c98

Logs a subset of the stack backtrace from the point of -dealloc into a
breakpad key to help debug messages to CrZombie objects.  This
productionizes the basic approach taken to debug a few recent zombie
object crashes.

BUG=none
TEST=monitor crash server.

Review URL: http://codereview.chromium.org/7766013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7790020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98857 0039d316-1c4b-4281-b951-d872f2087c98

Changed all @code to <code> and @endcode to </code> as per dmichael. Adding Polina to the review to look at url_loader.h and give approval of text that points to example.
Review URL: http://codereview.chromium.org/7715005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98856 0039d316-1c4b-4281-b951-d872f2087c98

I removed a bunch of static initializers, so update the expectations
so we don't regress.

Review URL: http://codereview.chromium.org/7806019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98855 0039d316-1c4b-4281-b951-d872f2087c98