- 02 Feb, 2018 40 commits
-
-
Chandan Padhi authored
This is a reland of 2b33f996. Original change's description: > Migrate MediaStreamDispatcherHost to be per frame > > Currently, there is only one MediaStreamDispatcherHost per renderer > process, but almost all its methods require a frame ID to be supplied > by the caller. This CL migrates this object to be per frame. > > Bug: 807274 > Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890 > Reviewed-on: https://chromium-review.googlesource.com/894864 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533970} TBR=guidou, avi, tsepez Bug: 807274 Change-Id: Idca20b52a27123cabfbbb55fe570c97a582d4e7a Reviewed-on: https://chromium-review.googlesource.com/897321Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534010}
-
Tien-Ren Chen authored
This CL adds clip-path support to SPv175+ by the following changes: 1. PropertyTreeBuilder now builds a clip node (ClipPathClip) or a effect node (ClipPath), depend on whether path-based or mask-based clip path should be used. 2. A per-fragment clip-path cache that saves the bounding box and (if available) the path of path-based clip path. This cache will maintain the same pointer identity across document lifecycles so that clip node comparison during raster invalidation won't incur expensive by-value comparison for paths. 3. ClipPathClipper now paints path-based clip path in appropriate property state. HTML-based contents apply property state in a bundle by local border box property (unchanged), while SVG-based contents apply property states manually in SVGPaintContext. 4. Implement SPv1 composited mask layer adjustment. The hierarchy of effect tree and clip tree are slightly different because in SPv1 composited clip path are always applied to a mask layer then apply to actual contents indirectly. BUG=769942,792769 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8dcd5fad685067dc22efda9dedfd6ab6366a26a7 Reviewed-on: https://chromium-review.googlesource.com/896607 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534009}
-
Jens Widell authored
In jumbo/unity builds, it conflicts with another constant in bindings/ api_event_listeners.cc (that has a different value.) This particular constant didn't seem to add too much. It was only used in one place; in a function with a comment that talks about the constant's value. It could be argued that the code is easier to follow if the (very simple) function implementation then uses the value directly. (In particular since the "value" is in fact the name of another constant.) Change-Id: I728a34b0a8b43382e742c6b640ace3baadc4d2db Reviewed-on: https://chromium-review.googlesource.com/897489Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#534008}
-
Jens Widell authored
They conflict in jumbo/unity builds. Since one read a file as binary data (into a `std::vector<uint8_t>`) and one as text (into a `std::string`), it seems reasonable to change the names to `ReadAndDeleteBinaryFile()` and `ReadAndDeleteTextFile()`. Change-Id: I8d8402c64cfe45132df9640bd5664df28742d6d7 Reviewed-on: https://chromium-review.googlesource.com/897603Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#534007}
-
Chris Pickel authored
This reverts commit f0baa069. Reason for revert: "BackgroundTest.ActiveDescendantUpdates" is flaky. Since it appears to have been added in this CL, reverting for dtseng to take another look. Original change's description: > Force updates to related nodes > > Test: chromevox_tests. Prior to the change, > BackgroundTest.ActiveDescendantUpdates fails because 'Selected' is not spoken. > > Compute text content for list items without names > > Chrome doesn't compute descendant name on focus. > > Test: manually on twitter.com using j/k. Verify all text gets read. > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ie75dff41f98b8aa3904e435afa4bd245b9771cce > Reviewed-on: https://chromium-review.googlesource.com/891676 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533960} TBR=dtseng@chromium.org,nektar@chromium.org Bug: 808337 Change-Id: I4f838f27aa81a607bcb83934bec0dc321d336466 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/897789Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#534006}
-
Jens Widell authored
They conflict in jumbo/unity builds. Change-Id: Ie5eae8aa303f5a163eabb74ff931f696127ff032 Reviewed-on: https://chromium-review.googlesource.com/897602Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#534005}
-
Shanmuga Pandi M authored
This patch will show deprecate warning for the extra form data which was added, if "value" attribute present with non-empty value for <input type='image'> Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hp1_-1tgvDs Bug: 753746 Change-Id: I565132d6ef8c6d4a93ce5447e5d18d7f7f8c1910 Reviewed-on: https://chromium-review.googlesource.com/896740Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#534004}
-
Yoshifumi Inoue authored
This patch makes |ComputeSelectionType()| to take |EphemeralRange| instead of two positions |start| and |end| to make sure we keep invariant of |start| < |end| for improving code health. Change-Id: Ibe2427899f7b60b9a37e23c516172203276ab12c Reviewed-on: https://chromium-review.googlesource.com/898683Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534003}
-
Yuta Kitamura authored
This reverts commit 6d10aad7. Reason for revert: Caused MSAN bot failure. https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/7639 Original change's description: > [css-typed-om] Refactor CSSStyleImageValue to prepare for gradients. > > Currently CSSStyleImageValue implements the CSSImageValue class in > Typed OM. CSSImageValue can be anything that's an <image> i.e. a <url>, > <gradient>, or <cross-fade>. > > However, the current implementation of CSSStyleImageValue only really > works for <url>s. This patch moves <url> specific logic into > CSSURLImageValue. This prepares for the implementation of <gradient> and > <cross-fade>, which will be subclasses of CSSStyleImageValue. > > We also do some cleanup work (e.g. making things const, moving code in > header to cpp). > > Bug: 803680 > Change-Id: I848b3eab5dbbcb9bbe7f0aea0d377497f63bfda3 > Reviewed-on: https://chromium-review.googlesource.com/882786 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: nainar <nainar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533949} TBR=nainar@chromium.org,shend@chromium.org Change-Id: I9aedca3ac9e3ecb07ed283447febede0628d7aeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803680 Reviewed-on: https://chromium-review.googlesource.com/896671Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#534002}
-
Marina Ciocea authored
Replace duplicate implementation of AudioDeviceDescription::IsLoopbackDevice with function call. Bug: 783109 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I896038026359723d8fe1c4366cd3a54ddd51e9c1 Reviewed-on: https://chromium-review.googlesource.com/897534Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#534001}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09eb87e6..33f6b756 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id386ff99db678d09ae255d4b2a066f209b443bf0 Reviewed-on: https://chromium-review.googlesource.com/898783Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534000}
-
Jens Widell authored
In jumbo/unity builds, some of the constants conflicted with (identical) declarations in the anonymous namespace in verified_content.cc. Change-Id: I66e9ecb180e99cfd468c914ddce44613a5013242 Reviewed-on: https://chromium-review.googlesource.com/897604Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#533999}
-
Yoshifumi Inoue authored
This patch changes "push-down-implicit-styles-mac.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. Following patch will rename this test file with remove "-mac" suffix to "push-down-implicit-styles.html" since this test file no more depends on MacOS. [1] http://crrev.com/c/896764 Rewrite editing/execCommand/remove-format-multiple-elements-{mac,-win}.html to use selection_test() Bug: 679977 Change-Id: I5c9a77d5d48651a9f3936496ca14b195a5633828 Reviewed-on: https://chromium-review.googlesource.com/898765Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533998}
-
Yoshifumi Inoue authored
This patch changes |CreateVisibleSelection()| to utilize |ComputeRange()| of |SelectionTemplate| to simplify source code for improving code health. Change-Id: I3d19d963cf04acba7f7bb0cb090dd45139f914a4 Reviewed-on: https://chromium-review.googlesource.com/897290Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533997}
-
Yoshifumi Inoue authored
This patch changes "push-down-font-styles{,-mac}.html" into "push-down-font-styles.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. [1] http://crrev.com/c/896764 Rewrite editing/execCommand/remove-format-multiple-elements-{mac,-win}.html to use selection_test() Bug: 679977 Change-Id: If2a26ed1d3007048d6799ce8f7fb20e12903d9c4 Reviewed-on: https://chromium-review.googlesource.com/898764Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533996}
-
Yoshifumi Inoue authored
This patch Introduces printers for |EphemeralRange| and |EphemeralRangeInFlatTree| for ease of debugging and a preparation of the patch[1]. [1] http://crrev.com/c/898683 Make ComputeSelectionType() to take EphemeralRange Change-Id: I2988679b2c9febe50d29a9330ac6e5577972ca20 Reviewed-on: https://chromium-review.googlesource.com/896739Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533995}
-
Yoshifumi Inoue authored
This patch changes "push-down-implicit-styles-around-list-{mac,win}.html" into "push-down-implicit-styles-around-list.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. [1] http://crrev.com/c/896764 Rewrite editing/execCommand/remove-format-multiple-elements-{mac,-win}.html to use selection_test() Bug: 679977 Change-Id: I21267338d42fe7400be683b102fb85168bb6b01b Reviewed-on: https://chromium-review.googlesource.com/896777Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533994}
-
Jens Widell authored
They conflict in jumbo/unity builds. Also rename the overly generic `g_static`/`g_lazy_instance` variables. They did not conflict with anything currently, but generic names in the anonymous namespace are likely to become a problem eventually, sadly. Change-Id: Ie90ca3c7eee3d357c3aca205a5551034b768eb77 Reviewed-on: https://chromium-review.googlesource.com/897488Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#533993}
-
Hajime Hoshi authored
This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I16585f0cf479191f33fdac9a7afc924cd077b908 Reviewed-on: https://chromium-review.googlesource.com/897318 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533992}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/994eb2b34934..036bdc0c9a4f $ git log 994eb2b34..036bdc0c9 --date=short --no-merges --format='%ad %ae %s' 2018-01-28 wl [truetype] Minor typo. 2018-01-27 wl [truetype] Better protection against invalid VF data. 2018-01-27 wl * src/truetype/ttinterp.c (Ins_GETVARIATION): Avoid NULL reference. 2018-01-27 wl * src/truetype/ttgxvar.c (tt_set_mm_blend): Minor. 2018-01-27 wl [truetype] Better trace VF instances. 2018-01-27 wl Fix comment. 2018-01-27 wl [truetype] Beautify tracing of VF axis records. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng Change-Id: Ia6e13f2b4ccff77c6f968c91dacd3235272231bc PDFium-Bug: https://bugs.chromium.org/p/pdfium/issues/detail?id=995 Reviewed-on: https://chromium-review.googlesource.com/889868 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533991}
-
Sam Zackrisson authored
This CL removes the render_fifo_ buffer from MediaStreamAudioProcessor and DCHECKs that the input audio is 10 ms long. MediaStreamAudioProcessor currently buffers audio provided to OnPlayoutData, to feed frames in 10 ms chunks to the APM. However, the caller of OnPlayoutData already DCHECKs that this is the case. This CL also modifies the unit tests. They use the same configuration for capture input as for render input, even though only capture needs to support input other than 10 ms. Bug: 804277 Change-Id: Ia20cf0e0810c59570305f1ca295016e0ca11057e Reviewed-on: https://chromium-review.googlesource.com/875862 Commit-Queue: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533990}
-
Scott Violet authored
Original is here: https://chromium-review.googlesource.com/c/chromium/src/+/882558 This differs from the patch that landed in two ways: 1. I completely misunderstood RunsTasksInCurrentSequence(). It may be called on any thread and basically comes down to checking if the current thread matches the thread the TaskRunner runs on. Changed implementation of DeferredSequencedTaskRunner and DeferringTaskRunner appropriately (added test for this). 2. Master prefs need ResourceBundle loaded with the data pack, so, shuffled around loading of that. This is covered by browser_tests that sadly only run on official builder. There are two motivations for this change: 1. In order to run a field trial for state setup in creating toolkit. 2. To have local state ready at the time ash is created. In order to have field trial ready I need to load local state and everything it touches. This ended up including ResourceBundle (not really the ResourceBundle, but the ResourceBundle code is used to determine the locale, and the locale is needed by code related to metrics, specifically ChromeMetricsServiceClient::GetApplicationLocale). As much of this code was previously created at a time when task runners were available I had to create a deferring task runner that queues up tasks and then flushes them when the real task runner is available. I've tried to only move what is necessary and leave as mush initialization as possible in the place before this change. You'll notice this creates g_browser_process early on. I explored not doing this, but it turns out very painful as instead some code then has to cache state that is later available in g_browser_process. The camel that broke the straws back was the application locale. See https://chromium-review.googlesource.com/c/chromium/src/+/853300 for the early approach. BUG=800358 TBR=mark@chromium.org,jamescook@chromium.org,mpearson@chromium.org Change-Id: I3343e8959321900daec0de16f6a86715d3760f29 Reviewed-on: https://chromium-review.googlesource.com/898070 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533989}
-
tzik authored
WebMIDI backend implementations have used double as a time type. As base::TimeTicks is available in Blink now, it's better fit to use as the timestamp. Change-Id: Ide762f3a8dd503b3bd77eae9077f5ecde18e3796 Reviewed-on: https://chromium-review.googlesource.com/892726Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#533988}
-
Yuta Kitamura authored
TBR=ssid@chromium.org Bug: 808152 Change-Id: I50f6ef21551e59aa7aa92f21863b0b24cc2b56c3 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/897237Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533987}
-
Takashi Toyoshima authored
This is a preparation to implement CORS preflight in content/network. These methods originally in FetchUtils are used to create a blink ResourceRequest or URLRequest for a CORS preflight request. Original code roughly implements the mime-type checks, but new implementation relies on //net API that checks mime-type strictly. This will cause a behavior change, and some that were in a wrong format but luckily passed will start failing. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iaac0809d4af9011cf4bcc9e7e431a1b1ad762e0a Reviewed-on: https://chromium-review.googlesource.com/883861 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533986}
-
https://webrtc.googlesource.com/src.git/+log/ed7b4ff9e38c..c7b964cd71fb $ git log ed7b4ff9e..c7b964cd7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b24b726bda4dbb0f2eaa80f9c5a5db5055460ad Reviewed-on: https://chromium-review.googlesource.com/898193 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533985}
-
Sean Kau authored
Without this observer, we never see printers for the new policy. Bug: 805825 Change-Id: I4d5f0b3f3035e65572631c4464e795c5a56549c3 Reviewed-on: https://chromium-review.googlesource.com/887281 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#533984}
-
Mike Dougherty authored
This feature flag will be used for adding Context Menu support to iFrames by using the PostMessage WebKit API to return the found element. (Instead of directly returning the element details from __gCrWeb.getElementFromPoint) Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I17fec9afb74e7fe5f7b2818902f4b872ba8d445a Reviewed-on: https://chromium-review.googlesource.com/896546 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533983}
-
Yuta Kitamura authored
TBR=qyearsley@chromium.org,treib@chromium.org,sfiera@chromium.org Bug: 805756, 808153 Change-Id: Id7e8b218cf37d51c7ef0d6cd34b2abe6bd9d1be2 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/897236Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533982}
-
Erik Luo authored
This test was flaky because it logged console messages but did not wait for the viewport to render their elements in DOM. This CL unflakes the test by waiting for pending viewport refreshes. Bug: 789225 Change-Id: I9861b067df72c66b00021050cf07562b0064f66c Reviewed-on: https://chromium-review.googlesource.com/898389Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#533981}
-
Yoichi Osato authored
On SlimmingPaintV175, we should point LayoutRect to invalidate with DisplayItem::PartialInvalidationRect() virtual function but PaintFragment didn't override it. This patch implements the override that returns visual rect of including NGBlockFlow. This patch reduces 7 image failures of selection in NG. Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9342e72791e4a8eec533081fb5da2f6d16c3d4b2 Reviewed-on: https://chromium-review.googlesource.com/897303Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#533980}
-
Yuta Kitamura authored
TBR=treib@chromium.org,sfiera@chromium.org Bug: 808185 Change-Id: Ie18b58450b9893f0f3b8a92f719769fe20eec0c0 Reviewed-on: https://chromium-review.googlesource.com/896772Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533979}
-
Takeshi Yoshino authored
It doesn't need to be a part of the interface. Each implementation of the interface can just have their implementation as their private method. Change-Id: I7acac5e71c70534998345147dba487394fc2737b Reviewed-on: https://chromium-review.googlesource.com/897317Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#533978}
-
tzik authored
This adds FromNanoseconds{,D}() and FromMicrosecondsD() to TimeDelta to align to existing InNanoseconds(). Change-Id: I1043d2fad8b47e5791418225a1d2e236be09ead5 Reviewed-on: https://chromium-review.googlesource.com/898722Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#533977}
-
Yuta Kitamura authored
This test is flaky on Fuchsia. TBR=treib@chromium.org,sfiera@chromium.org,sahel@chromium.org,tdresser@chromium.org Bug: 807803 Change-Id: Ie05cca6552c447af612bb36cb86663a8ba118b05 Reviewed-on: https://chromium-review.googlesource.com/898763 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533976}
-
Dominick Ng authored
This CL ensures that native app banners resolve the userChoice promise on beforeinstallpromptevent. Specifically, the |weak_manager_| of AppBannerInfoBarDelegateAndroid was not being set in the constructor for native app banners. Now it is set correctly, which allows userChoice to resolve. BUG=806923 Change-Id: I468c8dbc24e2451a3f6c044d8a2d95768d25347d Reviewed-on: https://chromium-review.googlesource.com/892183Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#533975}
-
Jia authored
This means we will only log events after user remains inactive for 30sec. This will also reduce number of events logged to UKM by ~55%. Bug: 784232 Change-Id: I558505ac3bd9daacd25458852d549e1f44071ecd Reviewed-on: https://chromium-review.googlesource.com/896769 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#533974}
-
Yuta Kitamura authored
This reverts commit 767edb03. Reason for revert: Causing layout test failure everywhere. Seems like dependent scripts aren't loaded: > CONSOLE ERROR: line 49: Uncaught ReferenceError: selection_test is not defined Original change's description: > Move doubleclick-inline-first-last-contenteditable.html to editing/selection/mouse > > This patch moves "doubleclick-inline-first-last-contenteditable.html" to > "editing/selection/mouse" because this test verifies selection with mouse for > ease of maintenance. > > This is a follow-up of reviewer's suggestion in the patch[1]. > > [1] http://crrev.com/c/896903 Rewrite > editing/selection/doubleclick-inline-first-last-contenteditable.html to use > selection_test() > > NOTRY=true > TBR=yoichio@chromium.org > > Bug: 679977 > Change-Id: I35e79f27723204dd697b8920028300c6584ee354 > Reviewed-on: https://chromium-review.googlesource.com/897391 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533951} TBR=yosin@chromium.org Change-Id: I47eb8154a7c873d21adc94a57633d7ebad77abf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679977 Reviewed-on: https://chromium-review.googlesource.com/898822Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533973}
-
Kent Tamura authored
custom-elements: Fix a DCHECK failure with external/wpt/custom-elements/upgrading/Node-cloneNode.html. V0CustomElementRegistrationContext::SetTypeExtension() is not expected to be called for autonomous custom elements. Element:: AttributeChangedFromParserOrByCloning() should check it. Bug: 805061 Change-Id: Ie91256bb6b6b8671d4a6a65374db31394a08d2ea Reviewed-on: https://chromium-review.googlesource.com/897169Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533972}
-
Chandan Padhi authored
This reverts commit 2b33f996. Reason for revert: <INSERT REASONING HERE> Original change's description: > Migrate MediaStreamDispatcherHost to be per frame > > Currently, there is only one MediaStreamDispatcherHost per renderer > process, but almost all its methods require a frame ID to be supplied > by the caller. This CL migrates this object to be per frame. > > Bug: 807274 > Change-Id: I0b7f93e067b789cea5eba020374eb6da243e4890 > Reviewed-on: https://chromium-review.googlesource.com/894864 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533970} TBR=avi@chromium.org,tsepez@chromium.org,c.padhi@samsung.com,guidou@chromium.org Change-Id: I3b35db7ae519b3b5111b290a8611dff5a2101d76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807274 Reviewed-on: https://chromium-review.googlesource.com/897320Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#533971}
-