- 21 Dec, 2019 40 commits
-
-
Samuel Huang authored
This reverts commit 268d26b8. Reason for revert: stack-use-after-return error found by ASAN bot, likely due to returning reference of local variable. Original change's description: > ARC: Add a mojo method for getting the primary account > > ARC needs to know the identity of the primary account, but it cannot > retrieve that from Android account manager. > > Add a mojo method in ArcAuthService for returning the primary account > information from Chrome OS. > > Bug: b/141108534 > Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" > Change-Id: I01ec976a330d52421ab2ddfe5155c712c81967af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810359 > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726738} TBR=mnissler@chromium.org,khmel@chromium.org,sinhak@chromium.org,anastasiian@chromium.org Change-Id: Ibb01613e8f4a7e640b3c1d9983fdf669f3f17271 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/141108534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978255Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#727032}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/254ce3f8dfb0..d892991127bf git log 254ce3f8dfb0..d892991127bf --date=short --first-parent --format='%ad %ae %s' 2019-12-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d892991127bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I30389b571f7567202ddbb3a01a5465eb9f8504af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727031}
-
David Black authored
Currently Assistant uses Content Service for embedding WebContents in Ash. Moving forward, we're migrating back to WebView as it better handles focus and ChromeVox related corner cases. To work around dependency restrictions in Ash, this CL adds a new: - AssistantWebViewFactory, and - AssistantWebView2 which are implemented in Browser. AssistantWebView2 is named as it is because there already exists an AssistantWebView in Ash, but the existing AssistantWebView is soon to be removed and the name will free up. AssistantWebView2 abstracts away the concept of WebContents so that the APIs invoked on AssistantWebView2 are delegated to the underlying WebView or WebContents as needed. Bug: b:146351046 Change-Id: Ica75899ca8d5426333b0501a7c4e34698bab4b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974460 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727030}
-
Hirokazu Honda authored
This removed raw images used in image processor test. They are created from bear_320x192.i420.yuv.webm and puppets-1280x720.i420.yuv.webm. bear_320x192.i420.yuv.webm is 40KB and puppets-1280x720.i420.yuv.webm is 334KB. Bug: None Test: None Change-Id: I20af7ecaff514b3c7b22e6e56e86106cb6a47ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976143Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727029}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I12ed7ebb633a983bcf40d0fd139ed3c94eaa5d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978220Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727028}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2723af6a6d43..af203a677aac git log 2723af6a6d43..af203a677aac --date=short --first-parent --format='%ad %ae %s' 2019-12-21 reed@google.com make clipIsWideOpen virtual, so device's don't have to rely on regions Created with: gclient setdep -r src/third_party/skia@af203a677aac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Idf33757b31ec2d20e108dbda7349940f5c0cd3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979627Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79f568e2863e..041b5b6ffaa5 Created with: gclient setdep -r src-internal@041b5b6ffaa5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:998161 Tbr: jbudorick@google.com Change-Id: If247eec3afb78ac6bff733506502f8cd7ec4e7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979624Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727026}
-
Natalie Chouinard authored
Replace usages of java_files with sources in above directory's gn files, and automatically format. Bug: 1035074 Change-Id: I3862d89fd6a381c061868af75e4d24dd8e66a2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976704 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#727025}
-
Fish Lin authored
With device's native orientation being Portrait mode, for devices with camera orientation of 0 or 180 degs, the capturing width and height needs to be swapped in order to capture in respect to device's current orientation. Bug: 1032902 Test: Duo calling on devices with different camera orientation Change-Id: Ib8d718cd2787011003ba9b1e2e578eaf310d50de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961300 Commit-Queue: Fish Lin <linfish@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#727024}
-
Natalie Chouinard authored
Replace usages of java_files with sources in all //chrome/browser BUILD.gn files, and automatically format. TBR=yfriedman@chromium.org Bug: 1035074 Change-Id: I50923d85e311ba9b072684beb2d0099910903005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973236 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#727023}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Icafcd889b4e28c8200da9316bd2af6efb7d13593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979628Reviewed-by:
-
Peter Kotwicz authored
This CL makes WebappActivity use: - TabModelImpl - CustomTabTabPersistencePolicy instead of WebappDirectoryManager BUG=1032291 Change-Id: I7adc8288105aa161eedbab4ba37724d91c305e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965900 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#727021}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1c9b1c07affb..a919e1bd9dd0 git log 1c9b1c07affb..a919e1bd9dd0 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 thestig@chromium.org Update documentation for PDFium initialization. 2019-12-20 tsepez@chromium.org Add CXFA_FFWidget::{Has,Process}EventUnderHandler(). 2019-12-20 thestig@chromium.org Use NoDestructor in a couple obvious places. 2019-12-20 thestig@chromium.org Use spans in testing/image_diff/image_diff_png.h and related code. 2019-12-20 thestig@chromium.org Import Chromium's base/no_destructor.h. 2019-12-20 tsepez@chromium.org Avoid directly including xfa/ layer in fpdf_save.cpp. 2019-12-20 thestig@chromium.org Do IWYU in testing/utils/file_util.cpp. 2019-12-20 thestig@chromium.org Only hash pixel data in EmbedderTest::HashBitmap(). Created with: gclient setdep -r src/third_party/pdfium@a919e1bd9dd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie2b0a1b6b307f42286b3ac88159236fef28c27ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979618Reviewed-by:
-
rbpotter authored
- Delete powerwash dialog from browser settings - Remove settings animated pages, main page behavior, and route observer behavior from browser about page Bug: 990170 Change-Id: I1f2f0a1eb454d55c8f84b7374c7be4e66b238ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979082 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#727019}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/988db63351c4..2723af6a6d43 git log 988db63351c4..2723af6a6d43 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2723af6a6d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I15353fa613fede632e3c02f83d7050daae70ee3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979599Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2cb76ab598e5..87d31381588b git log 2cb76ab598e5..87d31381588b --date=short --first-parent --format='%ad %ae %s' 2019-12-20 enga@chromium.org Revert "fuzzing: Add supportsErrorInjection option to DawnWireServerFuzzer" Created with: gclient setdep -r src/third_party/dawn@87d31381588b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id57ba22aa1a07ef4ba52ac39506ef393eabc7dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979507Reviewed-by:
-
Peter Kasting authored
The biggest change here is removing the idea of load success callbacks, which are never used. Bug: none Change-Id: I31c1790e2c7e3bb1c3275327893ddee32533c808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962610 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#727016}
-
chrome://flagsMoe Ahmadi authored
Adds an option to chrome://flags/#omnibox-on-focus-suggestions to enable zero-prefix suggestions on the extension NTP. Bug: 1035711 Change-Id: I5e327828d9b0d7c2895262b00d221f49af0b256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978043 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#727015}
-
Caleb Rouleau authored
I copied the existing win-10-perf shard map since we don't have test runtime data for this yet. That is also why I used only 26 shards for this for now. We can add more shards in later. TBR'ing John since I have Haiyang's non-committer review and this change is low-risk (it only adds a new perf builder and does not affect Chrome.) TBR=johnchen@chromium.org Bug: 998161 Change-Id: I98ab934614380bf5a9678f1765c7f67001a3c7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979094Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727014}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic0add2d836abd30fb2ef89afcce3e2b1ac3d9a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979597Reviewed-by:
-
Regan Hsu authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1967803, addressing more complicated cases of using the settings-localized-link element. Bug: 1015924d Change-Id: I38d64731511f8fd64ec474db47327ff4241b4841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971056Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Evan Stade authored
TBR=avi@chromium.org Bug: 1025256 Change-Id: I2cdc1c86559e3c9217326a452563946fcff149ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972137Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#727011}
-
Connie Wan authored
Changes in this CL: Theme updates: - Refactored TabGroupVisualData to take a TabGroupColorId as the color rather than an SkColor. This required creating a TabGroupColor enum and refactoring restore. - Updated all tab group UI elements to paint a theme-appropriate color (dark or light). ^ This is the source of most of the wide-reaching changes here. Everything below is isolated to 1 or 2 chunks of code, pointed out in comments. Color set updates: - Changed the color values according to crbug.com/1005502 - Changed the hard-coded labels to localized ones. Group updates: - Changed groups to be initialized with the next unused color, rather than a random or default color. - Added tests for group color initialization. Bug: 1030737, 1005502, 1003165 Change-Id: I6c4f8f4df03b6d42a380b38d02334cd90ea4fc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968039 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#727010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/abc8f2777133..84f45f105bce git log abc8f2777133..84f45f105bce --date=short --first-parent --format='%ad %ae %s' 2019-12-20 cnorthrop@google.com Use checkout_angle_internal for non-public files Created with: gclient setdep -r src/third_party/angle@84f45f105bce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032708 Tbr: jmadill@google.com Change-Id: Ib3ce9e398b9161b0506c1b61d922e24cfea8a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979405Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16caad77d2b7..79f568e2863e Created with: gclient setdep -r src-internal@79f568e2863e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifde1035308493255599573c321f026a6e2f4adc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979589Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8b876bd4074b..44134341fa8b git log 8b876bd4074b..44134341fa8b --date=short --first-parent --format='%ad %ae %s' 2019-12-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@44134341fa8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I85b7ceb7932186c56c8009d7326a19d214f2f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979593Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d98b8aed. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 779c13f2 "[IndexedDB] Adding web platform test for File object in IndexedDB." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3085d67f4f3925aaa0f75864e4432785b89f5217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979086Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727006}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/129defb3..3b458621 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If53deb3e5a08c4dd71ff4bc2b16309b58cfa8dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978423Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727005}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28b0c5d4b3bb..988db63351c4 git log 28b0c5d4b3bb..988db63351c4 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 khushalsagar@chromium.org gpu: Disable dual source blending support on buggy driver versions. 2019-12-20 bsalomon@google.com Disable advanced blend equations on Imagination driver 1.10 and earlier 2019-12-20 robertphillips@google.com Add BC1_RGB8_UNORM support Created with: gclient setdep -r src/third_party/skia@988db63351c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027981 Tbr: borenet@google.com Change-Id: I62a59943b16c7f7701a95daec820004709568fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979506Reviewed-by:
-
Nathan Zabriskie authored
More work to remove GLInterface from the shared GPU context on the main thread. This updates CopyRenderingResultsFromDrawingBuffer to use the CopySubTexture API on RasterInterface. Bug: 1023252 Change-Id: I2bbc047362fa38bce5a6f698710acdaad95bfadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960184Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727003}
-
Yue Li authored
Currently we check if the keyboard has the 'Assistant' key to enable Assistant. It seems some external wireless keyboards report they do have the 'Assistant' key. Since the reason we were checking the keyboard is for nocturne, we decide to only special case board 'eve', 'nocturne' and 'atlas' instead of doing the keyboard layout check. For more background, see discussion in crbug/1025961 Bug: 1025961 Test: Manual Test Change-Id: Iacb42a6b8bfc01b662002f0d93258642b6976ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978838 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I63b7292b633762c3dcbab53498e9cc99bd0ba569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979151Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e430429c148..254ce3f8dfb0 git log 1e430429c148..254ce3f8dfb0 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 comoody@microsoft.com Add undefined check in contentAsDataUrl to prevent unhandled exceptions 2019-12-20 tmathmeyer@chromium.org Redesign Media properties view Created with: gclient setdep -r src/third_party/devtools-frontend/src@254ce3f8dfb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I048c9e34393e50ace6600a892333f2268b3d27b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979419Reviewed-by:
-
Vincent Scheib authored
TBR=scheib@chromium.org Change-Id: I2b665cc24dea17e3b585df1f925262121f577b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978915Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#726999}
-
rbpotter authored
Remove manage input section from the browser settings resources and move the files to the OS settings. Bug: 990139 Change-Id: I5feac5828b964ee51afae48f6064ae41169ffc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977840 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Address zmo's comments on the earlier change: https://chromium-review.googlesource.com/1885636 which were published after the CL landed. Bug: 681341 Change-Id: Ib89967cc4f6b7f11371e7694689445d8afc34883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977739 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726997}
-
Brandon Wylie authored
This reverts commit 24eca4b9. Reason for revert: Crashing Tot Original change's description: > Reparent the current Tab when the theme is changed > > * Creating a class which handles reparenting the current tab when the > theme is swapped. > * Hooking that class into ChromeActivity. > * Adding plumbing to a few ReparentingTask/TabReparentingParams to > facilitate the process. > > Bug: 944302 > Change-Id: I2801eba979b3acafa02856a9053bc474bf2f581c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931763 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726136} TBR=fgorski@chromium.org,yusufo@chromium.org,wylieb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 944302 Change-Id: If032ff5e4cf61f4047e4cf146c8ae6a03a78aa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979398Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726996}
-
Marijn Kruisselbrink authored
Instead of going through mojom::blink::FileUtilitiesHost and passing a path from the renderer back to the browser, add a new method to mojom::blink::Blob to do the same thing. Since the blob already knows what file a blob is referencing, this both makes things slightly more secure (or at least gets us closer to a place where we can get rid of things like ChildProcessSecurityPolicyImpl::CanReadFile) and makes this work in a couple more cases after a File is for example postMessaged to a worker or frame in a different process as well. Additionally this gets us closer to unifying what the renderer and browser processes consider to be "the" snapshot state of any particular blob. In a follow-up CL the browser side code will change to return its snapshot state (if any), rather than always returning the current state on disk. This is part of a series of changes to improve consistency surrounding how snapshot state of files/blobs is implemented. Bug: 844874 Change-Id: Ia05cfd21a3d78955ff70933995e93bbe59e3bb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970301 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#726995}
-
Khushal authored
If the frame count of an image decreases after appending more data to it, the image is assumed to be broken. Avoid painting such images. This can result in fatal errors in the downstream code. And also miscellaneous cleanups. R=pdr@chromium.org Bug: 867479 Change-Id: I90b5c7030f80076fdc44beb88910667c6182cb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972904 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#726994}
-
Nate Fischer authored
This CL completes the basic implementation of the flags UI. During startup, the embedded WebView implementation will check if the user has enabled developer mode, and if so, fetch the flag overrides from the service. This uses a ContentProvider instead of an aidl method on the service interface for the sake of a simple synchronous IPC. Although aidl itself supports synchronous IPC, the Android framework only supports binding to the service asynchronously. We require fully synchronous IPC so we can block startup while we fetch the flags. Now that we've settled on using a ContentProvider to plumb information from the developer UI to embedded WebViews, this changes "developer mode" to be defined by the ContentProvider's state rather than the Service's state, which has the side benefit of simplifying some of the Activity/Service code. We rely on PackageManager APIs to check if developer mode is enabled. The check itself should have very little impact to startup time, since PackageManager caches its state in RAM. I benchmarked this check (when developer mode is disabled) at 0ms on my Google Pixel 2 device. For simplicity, we do not care about performance when developer mode is enabled, as this is not the usual user experience. Bug: 981143 Test: Manual - toggle debug border flag, start WebView shell, see borders Test: Benchmark isDeveloperModeEnabled() with System.currentTimeMillis() Test: run_android_webview_junit_tests -f *ServiceNamesTest* Change-Id: I7cc67d1bdf8f0f2ce0fce714fb359160899354a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977828 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#726993}
-
