GitLab

Currently we are not showing cookies in the site details page. It is
confusing when we enter the site details page from the All Sites page,
which shows the cookies for the origin. This CL shows the cookies in the
site details page and also allow the user to clear the cookies from the
site details page. In addition, if there are cookies on the etld+1 level
and we only have one origin, we will show them as a grouped entry
instead of collapsed to the top level entry. This is because otherwise
the collapsed entry will look weird if we enter the site details page,
which only shows the cookies number from the origin, not the etld+1.

BUG=835712,935269

Change-Id: Id145657099f9d12fb9efd0200cb57c8e3ba8bb55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493691
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638474}

This CL fixes extraHeaders event listeners for webviews in network-service
path. r611357 began requiring the 'extraHeaders' specifier for event listeners
which wanted to intercept certain headers.

However this doesn't work for webviews in the network service path.
ExtensionWebRequestEventRouter::HasAnyExtraHeadersListenerImpl doesn't correctly
handle web view event names, causing the WebRequestProxyingURLLoaderFactory to
enter into an inconsitent state. Fix this by changing how
HasAnyExtraHeadersListenerImpl is implemented.

BUG=938095

Change-Id: I8ceb830fd16a2ec671d3b7f49f891ae4c30cb6b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504817
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638473}

No longer needed after mojofication.

Bug: 931084
Change-Id: I3fe93ee2e7c9899ef9f76b2a8a42a548fc03267d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504665Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638472}

V8 updated the signature of MicrotasksCompletedCallback to take a void
pointer user data, and is deprecating the old signature.
This CL updates its user to use the new one.

Change-Id: I24990f68b2964fa80554689947746636958f59cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504660Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638471}

Before, we were retrieving the scope for the app associated with the
current URL. This approach had a couple of problems:

1. If WebKit prefs were recomputed while out-of-scope we would set
   the scope based on the wrong URL
2. Sometimes WebKit prefs are recomputed before the navigation has
   finished, so there would be no URL that we could use to get the app.

This CL fixes these issues by retrieving the app associated with the
app window. This association is set when the app window is created and
it never changes.

Additionally, it adds a GetScopeUrlForApp and HasScopeUrl to
AppRegistrar.

Bug: 934171
Change-Id: I0f0d78d97f85f6e6a7de3fa4266828bb852b0716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504592
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638470}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4c5c3fce..0a7a6252

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia4f92d7c0115bae7fc8b5ed1750e1941c3c44b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507038Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638469}

BUG=None
TEST=Video recording and photo taking function normally with/without
timer tick. Timer tick can be canceled from stop shutter button.

Change-Id: I62feaec286513b3eca7933a85f7f070c63cf74d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486791Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638468}

Activatable-locked subtrees are counted in total find-in-page matches,
but we currently still skip over them for active match navigation
(the specially-highlighted match). This CL makes us unlock/commit
relevant locked elements needed to show the active match (the ancestors
of the nodes in the active match range). This includes sending the
"beforeactivate" event to those elements.

Bug: 882663
Change-Id: I743faf1391ff0157fdca12a1cbba51fd29a680c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491069
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638467}

Follow up of CL:1475315.

Change-Id: Ia6d4e8ab329fb93826182025f6f6c221d4471266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506922
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638466}

Previously we created render surface only based on the current value
of opacity, filter and backface-filter, but the compositor may change
the values without informing blink, causing incorrect rendering due to
missing render surfaces.

Also change the condition checking composited animation from
HasActiveXXXAnimation() to IsRunningXXXAnimationOnCompositor()
which has been available since crrev.com/c/1498030 and is
more accurate.

Bug: 836884
Change-Id: I4b14a56c93c9baeb7c0d59da43e3be314f9f9c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498022
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638465}

https://android.googlesource.com/platform/external/perfetto.git/+log/5abc126b0795..df42f3b1d646


git log 5abc126b0795..df42f3b1d646 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 oysteine@google.com Merge "Add API to enable additional producer_name_filter entries in a session"


Created with:
  gclient setdep -r src/third_party/perfetto@df42f3b1d646

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I75cc4350660a84ac80e6cb804aadef7fb9021b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507252Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638464}

As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates
some classes of //third_party/blink/renderer/platform/testing with the macros of
Allocator.

After some analyzes, it was concluded that for the case of HistogramTester,
LayerTreeHostEmbedder, ScopedMainThreadOverrider, ScopedSchedulerOverrider classes,
they make sense to use USING_FAST_MALLOC because they have been used as a member variable
with new() or smart pointers.

In FuzzedDataProvider classes, it makes sense to use DISALLOW_NEW because it's used
as member variable with a reference type.

Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED.

Bug: 919389
Change-Id: I1599e8879f39952d9699218a906ec8e7e193b5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506675Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638463}

Add a PRESUBMIT check to ensure new |short| use don't come in.

Bug: 929985
Change-Id: Ifae1e6ba1af4d6c6ee0b0b8dffe608e0e710b291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503174Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638462}

Fix My files expanding when selecting or expanding entries in other
roots.

Change-Id: I5c87f371ef500608100b6e07ae118f84e71f0311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505744
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638461}

The test is already disabled for non-OMT fetch cases. Disable the
test for OMT fetch case too.

Bug: 937048
Change-Id: I4397c954cace41d4e1553e929c00c74d32da3deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506059
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Auto-Submit: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638460}

Renaming to KioskNextHome to reflect the refactoring work and ultimate
goal. Also considered MojoKiosk, but Mojo team prefers to keep the Mojo
name referring specifically to the Mojo library, not uses of the library.

Bug: 933530
Change-Id: I3113fa6f2a8e95843a9bd82bfcf8a2c75b32bcfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491832Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Bruno Santos <brunoad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638459}

Add a meta tag to have long timeout for the test.
This should deflake the test.

Bug: 937544
Change-Id: I87e0dda7647371e1082639037090264240a5bd06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506058
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638458}

Add a DCHECK in swap chain so we will know if this is the cause of the overlay
complex test failure. If swap chain fails, there won't be any video frame
available. This is only a temporary change to pin-point the cause of a flaky
test on the bot.

Bug: 937545
Change-Id: Ibec91a4408d7a9500738b69fc407085a0f696033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507280
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638457}

This reverts commit fb0e6284.

Reason for revert: crbug.com/939241. Breaking chrome informationals.

Original change's description:
> Launch Android Intent for media playback.
> 
> Bug: b:124796759
> Test: Manual
> Change-Id: I197f984578e9f80096ada1701e0399058bf9e848
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: Li Lin <llin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638359}

TBR=dcheng@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,llin@chromium.org

Change-Id: If851181e745e76170383e3355f231dda2fe1285e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:124796759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507255Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638456}

https://skia.googlesource.com/skia.git/+log/e62d14c1d9ba..692122e3ef23


git log e62d14c1d9ba..692122e3ef23 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 herb@google.com Don't apply the view matrix twice for complicated fallback


Created with:
  gclient setdep -r src/third_party/skia@692122e3ef23

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: Ie27616697f6e5357ae90ebc5ec7e6399dc43040d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506668Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638455}

USB grouping wasn't updating the group when new partitions were added or
removed after the initial grouping.

This was causing devices with more than 2 partitions to only display 2
partitions if device was plugged when Files app was already open,
because each partition is mounted individually so files app updates for
every partition.

Change-Id: I27c62051774b9a73b20005967c09d48a1d2a3c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506680
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638454}

This CL removes support for Diamond key. The feature was supported by
--has-chromeos-diamond-key Chromium flag.

Chrome OS side change: https://crrev.com/c/1474861

TEST=manual
BUG=929027

Change-Id: I0f338ca1776af59409068bd963c636fbc6ee3658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478571Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638453}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ad364d5cbb9..a6918d7b72a9


git log 4ad364d5cbb9..a6918d7b72a9 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 zamorzaev@chromium.org cbuildbot: Add Skylab support for *-android-pfq


Created with:
  gclient setdep -r src/third_party/chromite@a6918d7b72a9

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I2f5005ce6e4f3e894b4249c875b51c2c378b3eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638452}

It's only used now by unit tests. I'm keeping it as a private member of
tab for now until i move the overscrollController out of Tab.

Bug: 902044
Change-Id: Ic326796a71e0c27f62c4e4b3198a01ad7098c085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504836
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638451}

The implementation matches the default, i.e.
WidgetDelegate::GetWindowAppIcon().

Bug: none
Change-Id: I8c0980cbc676dd835105c551df9039cd2fca666e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506695Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638450}

https://dawn.googlesource.com/dawn.git/+log/1cc386687cde..579cf621f3dc


git log 1cc386687cde..579cf621f3dc --date=short --no-merges --format='%ad %ae %s'
2019-03-07 cwallez@chromium.org Split off common and libdawn / dawn_headers from BUILD.gn
2019-03-06 cwallez@chromium.org BUILD.gn: Split dawn_component/generator in their own files


Created with:
  gclient setdep -r src/third_party/dawn@579cf621f3dc

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If135e279f6fdd9818334f334b45267eb3293b98a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506669Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638449}

This CL fixes extraHeaders modification for webviews in non-network-service
path. r611357 began requiring the 'extraHeaders' specifier for event listeners
which wanted to intercept certain headers. However
ExtensionWebRequestEventRouter::OnEventHandled doesn't handle webview listeners
while computing the extraInfoSpec.

Fix this by sending the webViewInstanceId to the browser process as part of the
webRequestInternal.eventHandled function. This allows us to accurately determine
the listener which called the function. Also, add a regression test.

The network service path will be fixed in a follow-up.

BUG=938095

Change-Id: I89a5383c6ba1eac67efc8c3fe25a7714a54e2605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504961
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638448}

There could be multiple ui::InputMethod instances in SPM.
This CL makes ArcInputMethodManagerService observe ui::InputMethod
changes.

Bug: 937769
Test: manual - Android IMEs show up when tapping on a text field.
Change-Id: Ie507d6ef612ce4ef60b93e6391353d485f7c5258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504669
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638447}

This CL tracks metrics about:
  - The core operation of the service (e.g. client communication,
    cache hit rates, etc.)
  - The performance (e.g. amount of data transferred to/from,
    latency) of the image annotation server
  - The distribution of metadata (e.g. confidence values, empty
    results) returned by the server

Also fixes two bugs found during metrics testing:
  - We no longer attempt to parse an engine result if we receive
    a non-OK status. The counterexample to this behavior is an
    OCR engine failure, which returns an empty OCR result
    (which is otherwise successfully parsable) along with a
    non-OK status code.
  - We were sometimes accidentally populating the cache with
    failure results (we should only cache successful results).

Bug: 916420

Change-Id: I996cebf644865d0135efb73c57785745e5cb7585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498747
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638446}

All usages have been removed in favour of per-screen exit codes.

BUG=930267

Change-Id: I0f5b0164f3c74cf3fdf3f0c45743f0df71b30852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506564
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638445}

Changelog: https://github.com/googlechrome/lighthouse/compare/v4.1.0...v4.2.0

Bug: 772558
Change-Id: I12f8cf514afb7fff2503f2b4ca797803f804c4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507206
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638444}

ShowAvatarMenu is updated to open correct menu in Guest mode.

Bug: 938600, 896235
Change-Id: I2407c1c6065afd698d2b571c4f86ad0020b1dca2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505612
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638443}

Here we are recording allocation metadata for a slot, but not *in* a
slot. This is in anticipation of an upcoming change that will make
slots/metadata not have a 1:1 mapping so poor wording like this is
particulary noticable.

Bug: 939142
Change-Id: I55deae7b9290334329e1cc48759859c68ccab11c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507312
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638442}

Previously, such effects were only applied to Extension apps. This
commit lets other app publishers apply the same effects. A follow-up
commit will do so for ARC++ apps.

BUG=826982

Change-Id: I063cabf7a44efb111638e42565a5792b24c38eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505743
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638441}

There is an optimization to omit solid-color transparent draw quads,
since they don't do anything. However, this optimization is incorrect
if the draw quad has a blend mode other than kSrcIn.

Also add support for non-kSrcOver blend mode for SolidColorLayerImpl.

Bug: 937258,939168

Change-Id: Id779b9bbe06d2ff5c6e9c34a18026b500f5791a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506383Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638440}

Bug: 902646
Change-Id: Idd2e85b2b5b1e228639120858c9defe9ec207d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506919
Commit-Queue: dstockwell <dstockwell@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Auto-Submit: dstockwell <dstockwell@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638439}

Bug: 920027
Change-Id: I6af75af13d85f44ed55bd175dc169836b2a83716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504149
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638438}

The ARM64 Win32 builders still run a bit slow (30 - 160 minutes) due to
the large number of build steps (cross compilation) and the use of -j 80
when many other builders use -j 150. This changes to -j 150 by using the
appropriate mixin.

Builder is here:
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-arm64-rel

Bug: 938085
Change-Id: I6c7b7cb8d6fb81c5ed3969cd5d31368f09b009ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506949
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638437}

When a user interacts with a fast app reinstall result, how many times
did we show it before they clicked.

Change-Id: I29cf36c2511a8ab3025d24ebb3c5432f699ed599
Bug: 911427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503180
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638436}

The primary motivation is that the function names are not following
proper naming conventions within probe_sink.h.tmpl and
instrumenting_probes_impl.cc.tmpl. This CL renamed functions to follow
proper case style.

Bug: 936684
Change-Id: I06903ede66a09c133978f4ff940c7b505d1123f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503276Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638435}