- 18 Jul, 2018 20 commits
-
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/004af3cf8045..82b059ecb6a4 git log 004af3cf8045..82b059ecb6a4 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 vapier@chromium.org lint: fix singleton-comparison warnings 2018-07-17 vapier@chromium.org lint: fix no-value-for-parameter warnings Created with: gclient setdep -r src/third_party/chromite@82b059ecb6a4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I45415863772236473072d5116dd8ac87caff7654 Reviewed-on: https://chromium-review.googlesource.com/1140613Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575881}
-
Dominick Ng authored
BUG=None. Change-Id: I3edc7ba50a20c6e1fb87cd950a9f73d5c9a6c724 Reviewed-on: https://chromium-review.googlesource.com/1140112 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#575880}
-
Takuto Ikuta authored
This is for following nearly 1 hour builds. * linux_chromium_tsan_rel_ng 3783s https://ci.chromium.org/b/8940786382570619168 * mac_chromium_compile_dbg_ng 3534s https://ci.chromium.org/b/8940786382570619152 * linux_chromium_compile_dbg_ng 3534s https://ci.chromium.org/b/8940786382570619056 Bug: 804251 Change-Id: If82c10b26628271dfc01011da204c59858395bd7 Reviewed-on: https://chromium-review.googlesource.com/1139934Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#575879}
-
Roberto Carrillo authored
R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv Bug: 787918 Change-Id: I0766fa1c9d575b9960d336152aa62c56a7a2b945 Reviewed-on: https://chromium-review.googlesource.com/1141117Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575878}
-
Luum Habtemariam authored
This service will serve the ARC CUPS API by accepting an IPP request via mojom calls, validate its format in a heavily restricted/jailed process, and return the result. This change just contains the scaffolding for the service, validation/jailing to follow soon. Test: WIP Bug: chromium:831913 Change-Id: I5cd88b82746d999743e3ebddfc6aef15e408506d Reviewed-on: https://chromium-review.googlesource.com/1121108Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#575877}
-
Victor Costan authored
0-based ref-counting is deprecated. 1-based counting is described in //base/memory/ref_counted.h. In summary, instaces must be created by base::MakeRefCounted<T> or (less ideal) base::AdoptRef(new T). This CL switches Connection::StatementRef to 1-based ref-counting, and std::move()'s scoped_refptr<StatementRef> in a few places where that avoids refcount churn. Bug: none Change-Id: I14755dc2482f18c8a9582066104f346c2873941d Reviewed-on: https://chromium-review.googlesource.com/1137848 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#575876}
-
Zach Helfinstein authored
Dictation is an accessibility feature that allows users who opt-in to have their speech transcribed into any text field in ChromeOS. Screenshot: https://screenshot.googleplex.com/EkLrrNDAohB.png BUG=850690 TEST=None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I11ca4051b38a4beec7876ba35899e337f36411e4 Reviewed-on: https://chromium-review.googlesource.com/1120852 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575875}
-
Hongchan Choi authored
Because AudioWorkletHandler is ThreadSafeRefCounted, wrapping with CrossThreadUnretained() when the handler is passed via CrossThreadBind() is unnecessary. Use scoped_refptr<> instead. Bug: 853520 Test: All existing layout/WPT tests pass. Change-Id: I83409b89e80a9bbb60ea98649b16efb59facbbd4 Reviewed-on: https://chromium-review.googlesource.com/1140744 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#575874}
-
Min Qin authored
if DownloadDB is enabled, there is no need to update incomplete download in history db. The DownloadDB should contain all information. BUG=863602 Change-Id: Idf20bbb91e8e5156aa21354695b0781493c723ef Reviewed-on: https://chromium-review.googlesource.com/1137235 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575873}
-
Christian Biesinger authored
This reverts commit 43df04fe. Looks like there is no need for a flag-specific expectation anymore for virtual/layout_ng_experimental/fast/multicol/flexbox-with-overflow-auto-child-crash.html Original change's description: > [layoutng] Use the correct layout algorithm to compute min/max sizes > > This also required adding a check in NGBlockNode::ComputeMinMaxSize > for whether we are inside of PerformLayout -- on Mac, we can > compute preferred sizes outside of layout; however, we can't do > actual layout in that case, so we have to fallback to legacy > min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize()) > > Bug: 635619 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715 > Reviewed-on: https://chromium-review.googlesource.com/1131562 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575545} Bug: 635619 Change-Id: I28ca2367e21327d9f911c75b9f9950d171d48e1b Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1140206Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#575872}
-
Becca Hughes authored
min() and max() are not supported and should throw a parse error when used with env() and var(). BUG=864435 Change-Id: I7e89607cc6bb41910131b35a72dabb979f10b7dc Reviewed-on: https://chromium-review.googlesource.com/1140746 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: I0ff88b708c490cc760902e245e6473e90546c4b9 Reviewed-on: https://chromium-review.googlesource.com/1137750Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575870}
-
Xiaocheng Hu authored
Bug: 864797 Change-Id: I4becdf1fcbc4b9cfd9821ad61641753df14e1407 Tbr: afakhry@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1141136Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575869}
-
Weidong Guo authored
1. Add TransitionAnimationObserver to layout app list at the end of animation to make sure child views are in right position. 2. Replace old expand arrow icon with Skia-drawn arrow and implement the new transition. 3. Change the layout of apps grid and make the rows and cols adaptive to the width and height. 4. Enlarge the folder icon. Demo: https://drive.google.com/open?id=1xlGUpNv1X-s4D9mSjAPkyfZBMWhCjJag Change-Id: I3bc86870c66d0b35b36a801c16befb2624a33a55 Reviewed-on: https://chromium-review.googlesource.com/1121547Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575868}
-
Xiaocheng Hu authored
Bug: 830337 Change-Id: Ica61483028f3cd92787191d3115476f54b5f84c2 Tbr: achuith@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1140798Reviewed-by:
-
Miguel Casas authored
Follow up and correction to crrev.com/c/1132112: we should only log those VideoFrames that are not supported _and_ that are not Textures/GMBs already. This CL adds the latter part. Bug: 787122 Change-Id: Ieb4e4fff0f2e14e9beb6949f1531507ac80733ce Reviewed-on: https://chromium-review.googlesource.com/1140834Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#575866}
-
CJ DiMeglio authored
This reverts commit fed7475d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable two flaky tests on ChromeOS > > Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList > Disable WindowSelectorTest.RoundedEdgeMaskVisibility > > Tbr: xiyuan, xdai > Bug: 864467, 864465 > Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167 > Reviewed-on: https://chromium-review.googlesource.com/1140683 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575707} TBR=zmin@chromium.org Change-Id: I2aaceb5588030a1b14edf9b0c1d2da6165cbf8f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864467, 864465 Reviewed-on: https://chromium-review.googlesource.com/1140460Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#575865}
-
Yuri Wiitala authored
With no other screen capture implementations dependent upon media::ScreenCaptureDeviceCore, ThreadSafeCaptureOracle, etc.; this change merges this code into ScreenCaptureMachineAndroid. Unused functionality has been stripped-out, and minor callpoint- and lint- related clean-ups were made. No behavior/functional changes. Testing: Built monochrome_public_apk, installed it to my phone, and confirmed Android screen capture from that Chromium build still works by running a demo app: https://paulkinlan.github.io/screenrecord/. Bug: 806366,487935 Change-Id: I3edb2603261b6ed60e31edf795ac8da9a2a8525c Reviewed-on: https://chromium-review.googlesource.com/1137733 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575864}
-
Min Qin authored
DownloadManagerService may start too early before full browser is started. In this case, downloadItem doesn't have a BrowserContext object assocuated, BUG=695115 Change-Id: Ie7dcc88bb63cdfc8af0d0e4d4670e808e22f175e Reviewed-on: https://chromium-review.googlesource.com/1140519Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575863}
-
Jinho Bang authored
This is one of several patches that will remove the sequence version of supportedMethods member. This patch stops using it by removing the related code in browser side. - [1/2] https://crrev.com/c/1078687 - [2/2] This patch Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU Bug: 754779 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia276a90240dc817e60ce8cf793454eb822e67a4e Reviewed-on: https://chromium-review.googlesource.com/1108057Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#575862}
-
- 17 Jul, 2018 20 commits
-
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed1bf6ade339..718bcd15ec60 Created with: gclient setdep -r src-internal@718bcd15ec60 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/79769347 TBR=mmoss@chromium.org Change-Id: Ib368183b3420bc4568814737cf57199b33937040 Reviewed-on: https://chromium-review.googlesource.com/1140538Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575861}
-
Kurt Horimoto authored
This CL updates ContentSuggestionsMostVisitedActionItem to support custom a11y labels that differ from their titles, and adds a custom label for the Reading List cell that states the number of unread articles. Bug: 862299 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I972b5996fb3398154f656b8ea056b9028d468af0 Reviewed-on: https://chromium-review.googlesource.com/1137027 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575860}
-
Vaclav Brozek authored
ScopedLayoutPreventer was used to avoid detecting visibility of form elements in situations when it was believed to cause pre-mature layout (see https://crbug.com/595078). Visibility is approximated through calling IsFocusable on the WebNodes corresponding to forms and their fields. Looking at recent documentation, though, the WebNode-based API seems robust enough to prevent such dangerous calls: (1) The contract of Element::IsFocusable() only states the need to call Document::UpdateStyleAndLayoutTree() beforehand. (2) Document::UpdateStyleAndLayoutTree() does not cause the layout. (3) WebNode::IsFocusable() causes calling Document::UpdateStyleAndLayoutTree() as necessary before delegating to Element::IsFocusable(). See https://crbug.com/855598#c14 for more context. As a result, ScopedLayoutPreventer blocked visibility checks unnecessarily, leading to bugs like https://crbug.com/851808. Therefore this CL removes ScopedLayoutPreventer. Bug: 855598,851808,595078 Change-Id: Ic415919be5c40821dfa965eeb16372ae92ba92d5 Reviewed-on: https://chromium-review.googlesource.com/1136531Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575859}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40bacee96a94..e6ddf1942ca0 git log 40bacee96a94..e6ddf1942ca0 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 bratell@opera.com Stop gclient sync from scrolling during progress output 2018-07-17 ehmaldonado@chromium.org gclient: Start reporting metrics. Created with: gclient setdep -r src/third_party/depot_tools@e6ddf1942ca0 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386 TBR=agable@chromium.org Change-Id: I9f5a812dba6fa48f05ee1ec16a19065b3bc4e255 Reviewed-on: https://chromium-review.googlesource.com/1140536Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575858}
-
Dominick Ng authored
Some types of user interactions are used as a signal to ResourceDispatcherHostImpl. Prior to https://crrev.com/1735833002, scrolling was not one of them, and part of that CL's work explicitly filtered out MouseWheel events from being passed to ResourceDispatcherHostImpl. It also changed user-initiated navigations to call the new DidGetUserInteraction method with the blink::WebInputEvent::Undefined type. However, only a limited subset of user-initiated navigations were passed through this method: Ctrl-R/refresh button reloads, omnibox navigations, and NTP/bookmark navigations. Other user-initiated navigations such as back/forward buttons were omitted. https://crrev.com/1776843003 introduced wheel gesture events that generalised touch and mouse scrolling into one concept. https://crrev.com/1748553002 updated the user interaction code to use the new GestureScrollBegin event in place of MouseWheel events, but did not update the type check for forwarding to ResourceDispatcherHostImpl. https://crrev.com/1964863002 introduced NavigationHandle::IsRendererInitiated, which returns true if a navigation was initiated by the renderer process, and false if it was initiated by the browser process (i.e. it was user-initiated). This is a broader scope that the existing user-initiated navigations signaled through DidGetUserInteraction, namely including back/forward navigations. This CL improves on the user gesture handling in WebContentsImpl by: * removing user-initiated navigations from DidGetUserInteraction, and updating clients to listen to Did{Start/Finish}Navigation and check NavigationHandle::IsRendererInitiated. This includes more types of user-initiated navigations. * restoring the user gesture signal to ResourceDispatcherHostImpl back to how it was prior to https://crrev.com/1748553002 - listening to keydown, mouse click, taps, and certain user-initiated navigations. BUG=827659 Change-Id: I639270b21446104f22c8ae9b8b939eb96af3cabd Reviewed-on: https://chromium-review.googlesource.com/1125703Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
This should help investigate a theory that a message to create a RenderFrameProxy is sent when that proxy already exists in the renderer process. Bug: 794625 Change-Id: I2bf7dc1312dc3cbf8d307c8358ac64c8402fe875 Reviewed-on: https://chromium-review.googlesource.com/1139186Reviewed-by:
-
Chris Harrelson authored
This matches behavior already implemented in PaintLayerPainter, which was added to greatly simplify the problem of detecting clip property node invalidations upon change of clip (but not addition or removal of such clips). With the rollout of SPv175, invalidation under SVG transforms is also subject to this need. Before SPv175, non-composited transform mutations caused a forced subtree invalidation. Now there is an invalidation of the property on the PaintChunk under the transform, but the chunk itself is not re-painted. This requires the chunk to be complete and not partially culled out, which is why there is a requirement for an infinite cull rect. Note that this will increase performance of animations under SVG transform, which no longer need to paint the sub-content. (This same type of use case for CSS transform was another justification for the infinite cull rect in PaintLayerPainter). Bug: 862318 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibb65c7fd491b1be725a6aa05a33e9ba7cc03782d Reviewed-on: https://chromium-review.googlesource.com/1139583 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#575855}
-
Georges Khalil authored
Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8 Bug: 826298 Reviewed-on: https://chromium-review.googlesource.com/1141050Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575854}
-
Darren Shen authored
In the new UI, we have to draw the keyboard drop shadow manually in the extension because of the non-rectangular geometry of the new floating keyboard. So we just disable shadows. When shadows are added in the extension, the keyboard window should resize correctly. Change-Id: I8530779930c109c834f33c5f673dbcc553ced6a2 Reviewed-on: https://chromium-review.googlesource.com/1139948 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#575853}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3229e65886a0..21a99d42c34f git log 3229e65886a0..21a99d42c34f --date=short --no-merges --format='%ad %ae %s' 2018-07-17 junov@chromium.org Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTarget 2018-07-17 ethannicholas@google.com fixed SPIR-V memory layout 2018-07-17 allanmac@google.com Use std::chrono for measuring timing 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-17 ruiqimao@google.com fix MSAN dm failures Created with: gclient setdep -r src/third_party/skia@21a99d42c34f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:788439 TBR=bungeman@chromium.org Change-Id: I0d28ef2fa612e4d10cb0e778a4332769bba7aa49 Reviewed-on: https://chromium-review.googlesource.com/1140537Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575852}
-
Chris Lu authored
- Increases top spacing to 13px - Decreases bottom spacing to 0px so that the vertical spacing between footnote labels in Clear Browsing Data is not massive. Screenshots: https://drive.google.com/open?id=12DY7uMoFwu0qpy93N3nUEdsBPIDeaJlQ, https://drive.google.com/open?id=1XARsG_J1dvUu1gSDVBJW4qTfPVMTp8mN Bug: 863330 Change-Id: I92b7b4d09617353d6ccba088ea8fa3675b32c986 Reviewed-on: https://chromium-review.googlesource.com/1141056Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#575851}
-
Peter Collingbourne authored
We aren't currently building libc++ ourselves, which means that once we enable ThinLTO in official builds, libc++ won't be built with LTO, which is a violation of the LTO visibility rules, which require all classes with hidden visibility to be built with LTO when using the CFI or whole-program devirtualization features: https://clang.llvm.org/docs/LTOVisibility.html This hasn't caused any problems in practice as far as I know, but it could in theory, so it's probably best to disable it to be safe. We should be able to re-enable it on Android once issue 767901 is fixed and we create another GVR shim prebuilt compiled with ThinLTO. Bug: 469376, 767901 Change-Id: Ic5554c48c1d4a458a834b16b9f7bd20523871282 Reviewed-on: https://chromium-review.googlesource.com/1141108Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575850}
-
danakj authored
RenderViewImpl should not be a RenderWidget, but it must be while it is a WebViewClient and RenderWidget, which is a WebWidgetClient. So this contributes to the separation of RenderViewImpl and RenderWidget. This also removes the diamond inheritance of WebWidgetClient by RenderWidget and RenderViewImpl: RenderWidget WebWidgetClient -< >- RenderViewImpl WebViewClient So RenderWidget no longer needs to use virtual inheritance of the WebWidgetClient. Previously WebViewClient was-a WebWidgetClient. Instead make them separate interfaces, and start to pass them both explictly when they are both used. Since WebViewClient has a method to return the WebWidgetClient, we can use that in cases where we only have one. We could pass them both explicitly to cover these cases too, as a path to migrate the method off WebViewClient and make them completely independent. Layout tests create a RenderWidget by creating a WebWidgetTestProxy which subclasses RenderWidget and overrides behaviour of WebWidgetClient methods that RenderWidget implements. This continues to work okay. But they also create a RenderViewImpl by creating a WebViewTestProxy which subclasses RenderViewImpl, and also try to override behaviour of the WebWidgetClient. However since RenderViewImpl is no longer visibly a WebWidgetClient, it does not by changing what WidgetClient() returns instead of overriding methods on RenderViewImpl. This means that production code in RenderViewImpl and RenderWidget trying to call methods on WebWidgetClient must not do so directly on |this| (ie on the RenderViewImpl-RenderWidget). Instead they must go through WidgetClient() which will point to the RenderWidget() in production but to an injected WebWidgetTestClient in layout tests. Before: WebViewTestProxy is-a RenderViewImpl (is-a WebViewClient is-a RenderWidget is-a WebWidgetClient *1*) WebViewTestProxy has-a WebViewTestClient (is-a WebViewClient is-a WebWidgetClient *2*) WebViewTestProxy is-a WebWidgetTestProxyBase WebWidgetTestProxyBase has-a WebWidgetTestClient (is-a WebWidgetClient *3) WebWidgetTestProxy overrides some methods from RenderWidget *1* and redirects them to the WebWidgetTestClient *3* After: WebViewTestProxy is-a RenderViewImpl (is-a WebViewClient is-a RenderWidget is-a WebWidgetClient *1*) WebViewTestProxy has-a WebViewTestClient (is-a WebViewClient has-a WebWidgetClient *2*) WebViewTestProxy is-a WebWidgetTestProxyBase WebWidgetTestProxyBase has-a WebWidgetTestClient (is-a WebWidgetClient *3) WebWidgetTestProxy has a ProxyWebWidgetClient which forwards most things to the RenderWidget *1* but ProxyWebWidgetClient redirects some methods to the WebWidgetTestClient *3* Note that *2* changes from inherited to ownership instead, though it's not clear that the WebWidgetTestClient ever is asked for its WebWidgetClient, since it is only used to capture some calls that would have gone to the RenderViewImpl. R=dcheng@chromium.org TBR=jochen Bug: 419087 Change-Id: I26ce181e8cf31d1fa9244d448a7e01f401081ac8 Reviewed-on: https://chromium-review.googlesource.com/1134427 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575849}
-
Aidan Wolter authored
Internal CMA backends may need to be created lazily, because they depend on the initialization of other internal components. BUG=b:111465269 TEST=Build, play YT and GPMusic Change-Id: I781b028391e35e8c21b6a3e28e5d11ad891adad3 Reviewed-on: https://chromium-review.googlesource.com/1139099 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#575848}
-
Alexander Alekseev authored
This Cl adds basic elements of the Discover App: DiscoverManager, DiscoverUI, DiscoverModule, etc... Bug: 828999 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I526032df033d68bfae4583e9872262ad8af79219 Reviewed-on: https://chromium-review.googlesource.com/1103457 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575847}
-
Ben Pastene authored
Some tests are failing, so this adds them to a filter file and adds it in a la fuchsia. Bug: 860066, 840967 Change-Id: I6ebe67a0d4a5ab5e58c543524d36ada6ae55219f Reviewed-on: https://chromium-review.googlesource.com/1136884Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#575846}
-
Aidan Wolter authored
Just as media_service currently can access the multizone service, we are adding this capability to the content_browser service. CastAudioOutputStream runs in content_browser and requires this. BUG=b:111465269 TEST=Build, play to MZ group through CastAudioOutputStream Change-Id: I1ffad39d6c61a457f516960228e546462581bef6 Reviewed-on: https://chromium-review.googlesource.com/1139102Reviewed-by:
-
Koji Ishii authored
This patch adds NGLineInfo and NGInlineItemResults to the member field of NGLineBreaker. These are the output of the NGLineInfo, analogous to NGContainerFragmentBuilder to NGLayoutAlgorithm. Adding to the member fields makes NGLineBreaker closeer to NGLayoutAlgorithm. Note, NGInlineItemResults should be local and should std::move when the line is complete if we follow the existing pattern. It has inline buffer however, which makes std::move expensive. This patch keeps it as a pointer to the buffer in NGLineInfo. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibc66fae8a8653196535dfa469b94a3255c0cd8e8 Reviewed-on: https://chromium-review.googlesource.com/1138136 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 857464 Change-Id: I36d154ddcbafd4592b0fb4e73e201c2ffdcdf197 Reviewed-on: https://chromium-review.googlesource.com/1141062 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575843}
-
Xiaocheng Hu authored
This reverts commit 84c92630. Reason for revert: Suspected to cause compile failure at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Release%20%28Nexus%205X%29/8033 Original change's description: > Return unclipped bounds for get_characterExtents > > For get_characterExtents(): > - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). > - The width/height should not be changed to 1 for offscreen objects. > > Bug: 864195 > Change-Id: Ibea1f3ecb0b8f5f72c6fc967892ac9e6b1af135b > Reviewed-on: https://chromium-review.googlesource.com/1138800 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575831} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: I5efff2e628b9518039777b8317a581c4c0bc326e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864195 Reviewed-on: https://chromium-review.googlesource.com/1140459Reviewed-by:
-
