GitLab

R=enne, reveman, vmpstr

Review URL: https://codereview.chromium.org/644153003

Cr-Commit-Position: refs/heads/master@{#299226}

This is needed to help transition the client to a device-based OAuth
flow.

BUG=417799

Review URL: https://codereview.chromium.org/633703004

Cr-Commit-Position: refs/heads/master@{#299225}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/93bee71..ba5fb93

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/647143003

Cr-Commit-Position: refs/heads/master@{#299224}

An upcoming TabModel will diverge in key ways from the current TabModelBase.  Break apart the JNI calls from TabModelBase so that the new TabModelJniBridge class is basically a way to call out to the Java-side TabModel.

BUG=415747

Review URL: https://codereview.chromium.org/583373002

Cr-Commit-Position: refs/heads/master@{#299223}

Reduce the duration of MISSING_VIA_HEADER_4XX data reduction proxy bypasses down to 1 second instead of 1-5 minutes, since any 4xx error that could occur at that point would be scoped to just the current request.

BUG=422526

Review URL: https://codereview.chromium.org/651433003

Cr-Commit-Position: refs/heads/master@{#299222}

Previous fix was submitted without tests to facilitate merging.

BUG=419288

Review URL: https://codereview.chromium.org/641453002

Cr-Commit-Position: refs/heads/master@{#299221}

R=tonyg@chromium.org,nduca@chromium.org
BUG=

Review URL: https://codereview.chromium.org/643273002

Cr-Commit-Position: refs/heads/master@{#299220}

The previous fix (https://codereview.chromium.org/637933004) attempted
to fix LayerWithRealCompositorTest.(DrawTree|HierarchyNoTexture) by
drawing a color.  However, it was drawing transparent.  Because of the
default blend mode, this was a no-op.  Instead, fill with an opaque
color that will actually clobber the right texels.

R=piman@chromium.org,danakj@chromium.org
BUG=421107

Review URL: https://codereview.chromium.org/643223003

Cr-Commit-Position: refs/heads/master@{#299219}

The HandleWrapper is part of the Mojo JavaScript bindings, not part of the
underlying gin library. For some reason HandleWrapper and HandleCloseObserver
were declared in the gin namespace, which is incorrect. This CL moves them to
the mojo::js namespace, which is correct.

R=hansmuller@chromium.org

Review URL: https://codereview.chromium.org/651523002

Cr-Commit-Position: refs/heads/master@{#299218}

C++11's std::hash provides a default hash for T* that hashes by pointer value.
So does MSVC's stdext::hash_value, but not GCC's __gnu_cxx::hash (and STLPort's
std::hash). To align non-MSVC with both MSVC and the standard, provide a
default hash for pointers. This removes a lot of GCC-specific hash definitions.

Confusingly, all three provide a default hash for const char * that hashes as C
string, while not changing their equality. This CL does not change this on any
platform.

BUG=420242

Review URL: https://codereview.chromium.org/630503002

Cr-Commit-Position: refs/heads/master@{#299217}

This should unstick us if a unittest times out in a weird way.

BUG=418577

Review URL: https://codereview.chromium.org/645233002

Cr-Commit-Position: refs/heads/master@{#299216}

Included mojo_public_gles2_for_loadable_module that provides
MojoSetGLES2ImplThunks.

Review URL: https://codereview.chromium.org/647893002

Cr-Commit-Position: refs/heads/master@{#299215}

This was left out when https://codereview.chromium.org/632013002/ lands.

BUG=418375

Review URL: https://codereview.chromium.org/645213002

Cr-Commit-Position: refs/heads/master@{#299214}

BUG=312462

Review URL: https://codereview.chromium.org/474723002

Cr-Commit-Position: refs/heads/master@{#299213}

Missed that they were alphabetized earlier.

BUG=none

Review URL: https://codereview.chromium.org/647773002

Cr-Commit-Position: refs/heads/master@{#299212}

This refactors the net->mojo adapter currently in the URL loader and moves it to the net_adapters file so it can be shared with the tcp_socket. An adapter going in the opposite direction (currently unused) is also added.

Makes some changes to the existing adapter: naming for clarify (since there is now one going in the opposite direction, things were getting pretty confusing), and some of the setup logic was moved into a static function so it can be shared.

Clarify requirements for calling EndWriteData (the old code called this in error cases as well).

Review URL: https://codereview.chromium.org/649783002

Cr-Commit-Position: refs/heads/master@{#299211}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

BUG=422516
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/650483003

Cr-Commit-Position: refs/heads/master@{#299210}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6f078f3f..b07aa9c

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/647853003

Cr-Commit-Position: refs/heads/master@{#299209}

This is in preparation for adding DirectWrite support for text rendering in the browser UI.

BUG=389649

Review URL: https://codereview.chromium.org/644813004

Cr-Commit-Position: refs/heads/master@{#299208}

Changes in 5.8 are described here:
http://checkstyle.sourceforge.net/releasenotes.html

BUG=318404
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/644133002

Cr-Commit-Position: refs/heads/master@{#299207}

Previously, the script killed only the Xvfb process, relying on the
broken X connection to terminate other processes. This CL ensures that
all managed processes are explicitly killed.

BUG=388957
NOTRY=true

Review URL: https://codereview.chromium.org/635953002

Cr-Commit-Position: refs/heads/master@{#299206}

For certain unittest failures, these long timeouts were causing cycle
time problems for the bots. This CL mitigates those delays.

BUG=418577

Review URL: https://codereview.chromium.org/646063002

Cr-Commit-Position: refs/heads/master@{#299205}

Send the CGL renderer ID for the context being used by the
CAOpenGLLayer.

Tested with WebGL apps, gfxCardStatus switching.

BUG=312462

Review URL: https://codereview.chromium.org/647053002

Cr-Commit-Position: refs/heads/master@{#299204}

IME support in Chrome OS mode/Windows 8 mode is currently implemented in two parts.
1. Metro driver (Viewer process):
   Here we rely on the Text services framework for IME notifications and relay those
   to the browser process.

2. Chrome Browser:
   The browser initializes the input method via the RemoteInputMethodWin class which initializes
   the input method if the viewer is an immersive process.

Fixes as below:-
1. The metro driver initializes the text services framework by instantiating the CLSID_TF_ThreadMgr
   COM object and requests the ITfThreadMgr2 interface.
   This interface is not implemented for Windows 7. Fix is to use the ITfThreadMgr interface instead
   for Windows 7 and up. This provides all the functionality we need.

2. The metro driver was instantiating a MTA COM apartment. The text services COM objects expect to be
   instantiated in a STA.

3. The AppListService object on Windows attempts to bring up the app list bubble in ASH mode even if we are in desktop
mode. Fix is to avoid that.

4. The IsRemoteInputMethodWinRequired function initialized the remote input method if the viewer was an immersive process.
To ensure that it also works on Windows 7 we check whether the browser process is launched with the kViewerConnect switch.

BUG=421980

Review URL: https://codereview.chromium.org/645683002

Cr-Commit-Position: refs/heads/master@{#299203}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7bb9ed7..93bee71

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/644113002

Cr-Commit-Position: refs/heads/master@{#299202}

The previous logic doesn't account for divide truncation and
border texels, resulting in an additional visible tile with
only a couple of rows visible. This is hidden by the URL bar
sometimes, but it still affects full-screen, web-apps and
desktop browsers.

BUG=365877

Review URL: https://codereview.chromium.org/626113004

Cr-Commit-Position: refs/heads/master@{#299201}

This change pulls in the following from BoringSSL:

7ea8481 Add generic OPERATION_NOT_SUPPORTED error code.
bc8d737 Add tests for AlgorithmIdentifier support in EVP.
8f160a6 Add EVP_DigestVerifyInitFromAlgorithm and EVP_DigestSignAlgorithm.
2e1594d Remove #if-0'd ASN1_sign.
75a1dd0 Remove EVP_PKEY_CTX case in rsa_pss_to_ctx.
f4b4952 Fix rsa_pss_to_ctx return value.
5db5d4e RSA_encrypt and RSA_sign_raw aren't the same.
a87941a Remove misspelled error code.
b1659f5 Fix err_test.
57e52f2 Fix invariant broken in 5f1374e2.
5f1374e Retain ownership of malloced error data.
622a6db Fix SHA*_Final documentation.
83e52bc HASH_UPDATE always succeeds.
bce495c Fix a_{digest,verify}.c error codepaths.

BUG=none

Review URL: https://codereview.chromium.org/649503002

Cr-Commit-Position: refs/heads/master@{#299200}

BUG=419876

Review URL: https://codereview.chromium.org/649773002

Cr-Commit-Position: refs/heads/master@{#299199}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

BUG=422460
TBR=isherman@chromium.org, caitkp@chromium.org

Review URL: https://codereview.chromium.org/647123002

Cr-Commit-Position: refs/heads/master@{#299198}

This is the final step towards the goals listed in crbug.com/419160. It builds on https://codereview.chromium.org/628763002. The trivial NativeViewport application listed there can now be written relatively simply:

  define("test", [
    "mojo/services/public/interfaces/geometry/geometry.mojom",
    "mojo/services/public/interfaces/native_viewport/native_viewport.mojom",
    "mojo/apps/js/mojo",
    "console",
  ], function(geometry, viewport, mojo, console) {

    var client = {
      onDestroyed: mojo.quit,
      onEvent: function(event) {
        console.log("event.type=" + event.action);
        return Promise.resolve(); // This just gates the next event delivery
      },
    };
    var viewport = mojo.connectToService(
      "mojo:mojo_native_viewport_service", viewport.NativeViewport, client);
    viewport.create(new geometry.Size({width: 256, height: 256}));
    viewport.show();
  });

The mojo connectToService() function now just returns a proxy to the remote interface. The 3rd (optional) connectToService() parameter is an object that implements the client interface for the remote interface.

In this version the NativeViewportClient interface implementation is just an object with function properties whose names match the interface. Subclassing isn't needed and it's not necessary to implement all of the client functions.

The Mojo JS bindings now generate a subclass of each FooStub class called DelegatingFooStub. The Delegating version just forwards the Stub methods to the value of |this.delegate$|. The ugly "$" suffix avoids collisions with mojom function names. The JS bindings' interface Foo object now includes a delegatingStubClass property whose value is FooDelegatingStub.

|mojo.connectToService(url, Foo, client)| only uses Foo.client.delegatingStubClass if a client is specified.

The mojo_module has been split into two: a native part, called MojoInternalsModule, which integrates with JSApp, and a JavaScript part that depends on the internals. Apps must now import "mojo/apps/js/mojo", rather than just "mojo". For now, quit and connectToService() are the only functions in the JS mojo module.

BUG=419160

Review URL: https://codereview.chromium.org/637373002

Cr-Commit-Position: refs/heads/master@{#299197}

Depends on https://codereview.chromium.org/642203002.

BUG=346764
TEST=Input events work in OOPIFs with --site-per-process.

Review URL: https://codereview.chromium.org/647653002

Cr-Commit-Position: refs/heads/master@{#299196}

This allows us to query version information (e.g. the build version,
whether it's an offical build) whether or not the native library is
loaded.

Future work: put channel information in this file too, and delete the
ChromeVersionInfo.init() method.

TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/623403002

Cr-Commit-Position: refs/heads/master@{#299195}

TESTED=Build valgrind on Linux/Mac, tests pass 100/100 times.
BUG=159234,227278,222532

Review URL: https://codereview.chromium.org/647103002

Cr-Commit-Position: refs/heads/master@{#299194}

BUG=413855

Review URL: https://codereview.chromium.org/639183003

Cr-Commit-Position: refs/heads/master@{#299193}

This moves the ExtensionCache interface out to extensions and
delegates instance provisioning out to ExtensionsBrowserClient
implementations.

BUG=398671

Review URL: https://codereview.chromium.org/612423003

Cr-Commit-Position: refs/heads/master@{#299192}

SigninManager.Observer was renamed to SignInFlowObserver, which should now
be used instead.

BUG=421058

Review URL: https://codereview.chromium.org/648843002

Cr-Commit-Position: refs/heads/master@{#299191}

BUG=422386
NOTRY=true

Review URL: https://codereview.chromium.org/648783002

Cr-Commit-Position: refs/heads/master@{#299190}

R=tonyg@chromium.org,qyearsley@chromium.org,nednguyen@chromium.org
BUG=422093

Review URL: https://codereview.chromium.org/645753002

Cr-Commit-Position: refs/heads/master@{#299189}

BUG=None

Review URL: https://codereview.chromium.org/649793002

Cr-Commit-Position: refs/heads/master@{#299188}

BUG=None
TBR=oshima@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/649803002

Cr-Commit-Position: refs/heads/master@{#299187}