- 02 May, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3cefa2e3358b..3fd4a332759b git log 3cefa2e3358b..3fd4a332759b --date=short --no-merges --format='%ad %ae %s' 2019-05-02 treehugger-gerrit@google.com Merge "Add ProfilePacket support to trace processor." Created with: gclient setdep -r src/third_party/perfetto@3fd4a332759b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic71da89522d0ce5e322a6815b721f8882b8c6a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#655990}
-
Etienne Pierre-doray authored
It's possible to have a late Wakeup event in SchedulerWorkerCOMDelegate that become spurious if the worker was woken up by a system event in between. In that case, just reset |worker_awake|. Change-Id: I31d0e976b988a610552d0100e9d3cc81752d88d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590380Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#655989}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01d698f3..041193e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65e2a6486e4c08d1ed850739f3d4f9c817bdcfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593023Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#655988}
-
Tien Mai authored
- Add extra parameter to request extraction of the password when doing SAML sign in so that it can be passed to GCPW. Bug: 958446 Change-Id: Iba80b08266b02face202ccda05541c982c196d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592071 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#655987}
-
Rayan Kanso authored
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c23 Bug: 942174 Change-Id: Ic9149588f5f9804cef805a77026b52fb0d7fc456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588569 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#655986}
-
Bence Béky authored
This flag has been removed from QUICHE at https://quiche.googlesource.com/quiche/+/98669f57, which was rolled into Chromium at https://crrev.com/c/1574150. Change-Id: I17af560fcb8b49626ed737294b8c3fe88c9c292d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592128 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#655985}
-
Saman Sami authored
We need the size for creating promise SkImages in SkiaRenderer. This CL also merges MakeGLOverlay into MakeGL, because the only difference was that MakeGL doesn't take size which is not the case anymore. Bug: 955456 Change-Id: Iffc5f544009d5dfd4bae8a2f26a6ff878807eb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588197Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#655984}
-
Saman Sami authored
When a client misses the display deadline, it should not be blocked until the next DrawAndSwap because it will forever lag behind the display by one frame: - Renderer submits CompositorFrame after display deadline. - On next BeginFrame, display schedules an immediate deadline because the renderer has an undrawn frame. - Since the renderer can't beat display's immediate deadline, its CompositorFrame comes after display's deadline again. Repeat. Instead, we should immediately ack the client when it misses the display deadline. Bug: 951992 Change-Id: I672912c0cef346dd29aa9d6b2e9deb8eb04a4c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588436 Auto-Submit: Saman Sami <samans@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#655983}
-
Henrique Ferreiro authored
As advised in [1], after porting calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/html, this CL removes unused Create() methods. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: Iefe48afd34fe4d232bffec293a6ebdc818e8f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583895 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#655982}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c80e4d756e61..b93c4e622f85 git log c80e4d756e61..b93c4e622f85 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 titovartem@webrtc.org Add propagation of test duration to PC framework user. 2019-05-02 srte@webrtc.org Adds control of active layers in scenario tests. 2019-05-02 johnny@vidyo.com ManageFrameH264 for temporal layers (PART 3/3) Created with: gclient setdep -r src/third_party/webrtc@b93c4e622f85 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I88355b98b586e80441c7338b2c71ca5e3af53800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592834Reviewed-by:
-
Max Morin authored
This change defers unmuting with one "post task", same as output stream destruction, so that the ordering of operations is respected. Likely fixes crbug/957728. Bug: 957728 Change-Id: I0c8b6dcebe5c6f2c24f673ecf80cd7c2e48be157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591521 Commit-Queue: Max Morin <maxmorin@chromium.org> Auto-Submit: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#655980}
-
Michael Lippautz authored
Separate out tests unit tests for just the data structure. Change-Id: Ic05a96319898b3e05c02835839ba236e41ecf73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591838 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Amr Aboelkher authored
Bug: 552439 Change-Id: I390afd318b2bb2344d09447545a881a4e6e6efa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582500Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#655978}
-
Niels Möller authored
Bug: webrtc:6463 Change-Id: I592be72d5de0d8efbcd147330fe8b2eac825190b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593255Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#655977}
-
Dave Tapuska authored
BUG=958457 Change-Id: Iea7e0637b9c6a09810f75d1f855835c565a92579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592476Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#655976}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f9297dff115..cd5d14619fe2 git log 2f9297dff115..cd5d14619fe2 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 robertphillips@google.com Disable opList-splitting reduction on Pixel3 Vulkan test bots Created with: gclient setdep -r src/third_party/skia@cd5d14619fe2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I39ebd7cc46fdc6580bb1a759cc70348b1d4112d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592867Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/263da2a5734e..7793da691871 Created with: gclient setdep -r src-internal@7793da691871 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I71132231b70949d10b5f47eea4e276d208886015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593217Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#655974}
-
Hwanseung Lee authored
There are multiple g_monitor globals after patch[1]. let's rename one of them to avoid jumbo build breakage. [1]https://chromium-review.googlesource.com/c/chromium/src/+/1540309 Bug: 775547 Change-Id: I2dbb0f812e61e91f644760b24ae9aa3e1db03f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592974 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
The old URLs no longer work due to recent LUCI changes. Also add a note for Android Go bots to hint they are running gobo devices. TBR=crouleau@chromium.org Bug: 958739 Change-Id: I8242ef42435ac186356749afc0a68962f0112429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591928Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#655972}
-
Rune Lillesveen authored
Getting rid of LazyReattachIfAttached for shadow DOM. FlatTreeParentChanged() will mark the node for kLocalStyleChangestyle style recalc (for new inheritance parent), and forced re-attachment in the next lifecycle update instead of doing a synchronous DetachLayoutTree() first. Bug: 925826 Change-Id: Ia14964f855bfea35089b66d11c9412fe22800813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591620Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#655971}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0421d3d0cd7..c80e4d756e61 git log a0421d3d0cd7..c80e4d756e61 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 45d077a5..449727e8 (655737:655859) Created with: gclient setdep -r src/third_party/webrtc@c80e4d756e61 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iac6997778ec49b2ee8dc270ae431f116d79392b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593213Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/30b5ab61..01d698f3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d53c8e2e0b18f5f5d91dd1dac5d1fe865188078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593022Reviewed-by:
-
Alice Boxhall authored
(Taken over from dmazzoni's original change: https://crrev.com/c/1588883) ClusterFuzz has repeatedly found ways to cause mischief by registering an accessibility notification listener using testRunner, then doing malicious things in the notification listener callback, which we were triggering synchronously. The notification listeners in AccessibilityController are triggered as part of the document lifecycle update, so by postponing them we ensure that process is complete before any callback code attempts to mutate the page, triggering another update. Bug: 948683 Change-Id: I908914eddd72e5e8bfffe22ece10c8df32d140c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588602Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Auto-Submit: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#655968}
-
François Beaufort authored
This CL includes cosmetic changes such as a darker scrim, button size adjustments, the removal of hover button states, a new playback button, and new minimum window size. Screenshots: https://imgur.com/a/e7tA4bH Change-Id: I81d1ee69312c3d4a1b7056e99544ba32c2175d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1466742 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#655967}
-
Michael Lippautz authored
This test ensures that no slots are overallocated over before compaction runs. Bug: 918064 Change-Id: Ia917e4aec1ce6a8c9709e96af406b37771626c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591926Reviewed-by:
-
Rune Lillesveen authored
Use SetForceReattachLayoutTree instead. Also mark code with TODO for removal when LazyReattachIfAttached can be removed. Bug: 925826 Change-Id: I330f91be7993e70a345148f69087441cafbd2e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591917Reviewed-by:
-
Jose Dapena Paz authored
In libstdc++, std::pair copy constructor is deleted. So inserting into a map with a pair constructed with brace notation will fail, as it will imply a copy. Instead of that, use make_pair for populating the map of omnibox pedal implementations. Bug: 957519 Change-Id: I1de69e655c2aa6f8f7cbbd0de86613863aa2dd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584293Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#655964}
-
Rouslan Solomakhin authored
The Google Pay integration in Chrome no longer uses the following parameters parsed in the renderer process: - merchant_name - merchant_id - allowed_card_networks - tokenization_type - parameters Bug: 620173 Change-Id: I8514add38b3e2fa095d794e513d77fad900f2329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592067 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#655963}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e5ba24774500..2f9297dff115 git log e5ba24774500..2f9297dff115 --date=short --no-merges --format='%ad %ae %s' 2019-05-02 borenet@google.com [infra] Update to Go 1.12.4 Created with: gclient setdep -r src/third_party/skia@2f9297dff115 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ibc8d9c21d066208f912bd0360fcfbba01b61d72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593216Reviewed-by:
-
Mugdha Lakhani authored
This CL adds a permission and a feature flag for Periodic Background Sync. The permission will be denied when the feature is disabled, which is true by default while we're implementing it. We currently only grant the permission if accessed from a secure origin. Unit tests and a web test have also been added. Future CLs will add more logic to PeriodicBackgroundSyncPermissionContext. Bug: 925297 Change-Id: I41e8d692a8bea9c356dad8681a8c79e23d7eda4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567748 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Andy Paicu authored
This sets the default flash content setting to block and enables an already-prepared information banner that warns users who override the setting that flash will stop being supported in December 2020. Bug: 882276 Change-Id: Ifa27c0462abc1e17bb5309b8eea187997096aa9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585882 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#655960}
-
Rune Lillesveen authored
Style and layout tree and existence for an iframe depends on the display value of the owner node. It should be enough to trigger style recalc on the documentElement for such changes. Make a common method for doing this for the display change and the printing change cases. TEST=WebFrameSimTest::DisplayNoneIFrameHasNoLayoutObjects Bug: 925826 Change-Id: Ib1f791b93f08eb04dc49fcc7d9ec490ae2b0ea78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591925Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d80ac69c8bc..263da2a5734e Created with: gclient setdep -r src-internal@263da2a5734e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=gogerald@chromium.org,caseq@chromium.org,ksakamoto@chromium.org,drott@chromium.org Change-Id: I8b116bbd8c84f44eae70fba6a2a43492979960ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593212Reviewed-by:
-
Morten Stenshorne authored
I don't see any reason to condition this on whether we're running as a web test or not, since it's useful for us to test fullscreen behavior (e.g. with Blink layout) manually. Note that going fullscreen doesn't actually resize the content shell window, but that may be seen as more of a feature than a bug, for the purpose of debugging layout. This code was originally added on: https://chromiumcodereview.appspot.com/11308223 Change-Id: I630e63d556c8479728467407aa146f4841e8ab26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588642Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#655957}
-
Rune Lillesveen authored
Display:none iframes do generate style/layout-tree for printing as opposed to non-printing. We need to trigger this on the transition to printing. Marking documentElement() with style recalc is a gentler way of doing this. Plus, we can get rid of yet another call to LazyReattachIfAttached. TEST=WebFrameSimTest::DisplayNoneIFramePrints Bug: 925826, 819327, 838760 Change-Id: I53e71af46d26a4e3bc001cd6add357af1dd4d7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591833 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds basic init and dealloc tests for AlertViewController Bug: 951300 Change-Id: I3da58a62a19d07d15112915c5637b671f551c993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588568 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#655955}
-
Rune Lillesveen authored
LazyReattachIfAttached() will cause unnecessary style recalc and a synchronous DetachLayoutTree(). The removed DCHECK is no longer valid. We should no longer have such craziness that the comment talked about, and it had to be removed since it did trigger with this change. Also had to add an extra GetForceReattachLayoutTree() check before using the layout object in ForwardEvent since the LayoutObject type may be out of date with the input type. Before this CL, we would synchronously detach the layout object on type changes such that GetLayoutObject() would return null there. TEST=fast/forms/ Bug: 925826 Change-Id: I6f8f58e73bf548fc3d90b7f28713ae90ca62ea33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592732Reviewed-by:
-
Dominik Röttsches authored
This reverts commit 5ffcbb07. Reason for revert: Suspected to cause failures on Android CFI https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/5246 More details in bug below. Bug: 958746 Original change's description: > Fix an issue that wake lock is not acquired for download with network service > > In Non-network service path, wake lock is acquired in > DownloadRequestCore. > However, when network service is enabled, download code never > acquires the wake lock. > This CL fixes that behavior. > > BUG=935125 > > Change-Id: I54e76d5dfefd2fdd2dcbae9c0733f77cf988e61e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588891 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655827} TBR=jam@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,tsepez@chromium.org,xingliu@chromium.org Change-Id: I4d2825fef1359aed37a66711b2df33655720a19c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591929Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#655953}
-
Jose Dapena Paz authored
libstdc++: do not assume std::pair copy constructor is available inserting cached results in image annotator In libstdc++, std::pair copy constructor is deleted. So inserting into a map with a pair constructed with brace notation will fail, as it will imply a copy. Instead of that, use make_pair for populating the map of cached results in image annotator. Bug: 957519 Change-Id: Ic6aa50145c0b2e85e00b3327ec0461c060539937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584294Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#655952}
-
Jan Wilken Dörrie authored
This changes introduces PasswordAutofillAgent::HasFillData(). This method returns whether the password agent as filling data for the passed in FormControlElement, which will be useful for the upcoming TouchToFill feature. Bug: 957532 Change-Id: I5dd062819e0b2efdedefdf848bdd1ddb9cdfda9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588252Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#655951}
-
