- 17 Jun, 2019 40 commits
-
-
Morten Stenshorne authored
Fails in legacy, though. Must have got added to the expectations file during landing of the rebaseline for NG. TBR=eae@chromium.org Change-Id: I24756c7ccf52e4f11d1e3770fbff079e3224eaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662455Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#669839}
-
Aleks Totic authored
Bug: 974712 Change-Id: I8cd7c9ab91a0722782d444ccece69d705bfe1074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661485 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#669838}
-
Julian Kung authored
The MakeRedImageTestScript function used by the takeElementScreenshot* tests is difficult to understand and would benefit form being abstracted away since the code following it was identical for every test. In this CL MakerRedImageTestScript is replaced in the tests with a new function takeScreenshotAndVerifyCorrect, which calls MakeRedImageTestScript and passes on its output. R=johnchen@chromium.org Bug: chromedriver:2957 Change-Id: Id66c0165acd52a09c1fc9569a2ddbd94970dbdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662589Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Julian Kung <juliankung@google.com> Cr-Commit-Position: refs/heads/master@{#669837}
-
Boris Sazonov authored
Adds GaiaAuthFetcher::StartLogOutWithBlankContinueURL that specifies a blank page as a continue URL for Logout requests. This continue URL is necessary as sometimes Gaia redirects Logout requests to large pages that exceed 1MB body limit for SimpleURLLoader::DownloadToString. Bug: b/134618807 Change-Id: Ie4d57ac959f8936077f98fce6a288ebf41122fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656488 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#669836}
-
Joel Einbinder authored
The watch pane passes null to ObjectPropertiesSection.createNameElement, expecting a blank name element. But it was being incorrectly returned as an element with "null" as its textContent. Bug: 973807 Change-Id: Ibd3a88c6ad8756ebed86ec7d77659ea8e3bb1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661269Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#669835}
-
Nina Satragno authored
According to the CTAP2 spec, devices may return CTAP2_ERR_PIN_AUTH_INVALID if internal User Verification fails on MakeCredential requests or if the PIN token is not valid on either MakeCredential or GetAssertion requests. This patch handles this code treating it as a permission denied error. Bug: 974876 Change-Id: I7565b17a98bb4cc46da086c5412be8b19b7b269d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661486Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#669834}
-
Raymond Toy authored
When a long running decode task is finished, check to see if the execution context still exists. If not, don't bother to resolve the promises or run any of the callbacks for decodeAudioData. It's difficult to write a non-flaky test for this because decoding may take various amounts of time on the bots. Plus, we don't want to add a huge resource to the tests or take large amounts of time to decode. Bug: 812151 Change-Id: Ida72197b0e3a7a2a2f395cc74125c95762bf021e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661078 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669833}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ea38f958d072..9283b2559c05 git log ea38f958d072..9283b2559c05 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 chrisforbes@google.com Wire up some required external functions for arm32 Created with: gclient setdep -r src/third_party/swiftshader@9283b2559c05 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/135298866 TBR=swiftshader-team+autoroll@google.com Change-Id: I7984d86247e87e7421bb4655ea317b6f924af3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669832}
-
rbpotter authored
Apply the advanced settings when the enter key is pressed, unless: - Focus is on the search box, where enter normally means "search" - Focus is on a select, where enter selects an item in the dropdown - Focus is on a cr-button (e.g. cancel or apply), where enter activates the button. This matches the behavior to the behavior on the main Print Preview UI, where enter is equivalent to clicking Print unless a control that normally handles the key event is focused. Bug: 974161 Change-Id: I4818996fb960bfc0c6ee3e92d2c132fc7f8dd466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661302 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#669831}
-
Bryan McQuade authored
I tested this manually, both by resizing a Chrome window, and by simulating mobile device rotation in devtools. Change-Id: I69297b2501827070de4255b152d3099cb91ab11e Bug: 958832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653609 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#669830}
-
Victor Costan authored
Chrome currently builds SQLite with SQLITE_TEMP_STORE=3, which disables temporary storage, so unixTempFileDir should never be called. Bug: 244385 Change-Id: Idfa8bf86d997654c619db5d2abf3198afae41983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661499Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#669829}
-
Julian Kung authored
The email input type being considered a text input caused bugs and crashes. In this commit it is removed from textControlTypes and thus no longer considered a text input. Also added support for content editable elements in compliance with the following W3C procedure: "Set the text insertion caret after any child content." Added test to run_py_test to test correct functionality. R=crouleau@chromium.org, johnchen@chromium.org Bug: chromedriver:2704 Change-Id: I95bb9ff2396aa0e6bdfa35dde33f338be83607b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658966 Commit-Queue: Julian Kung <juliankung@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#669828}
-
Jian Li authored
We can't use the CSS text included in the inline style elements. Instead, we scan document.stylesheets to look for those from style elements and wrap them in link elements. I also converted from collecting serialized elements to calling delegate method to add resource. This addressed the FIXME in the code and should improve the memory usage. Bug: 892492 Change-Id: I7ee36df1f3f72e4d2b725f030c7a12762e5fe447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661158Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#669827}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f40bcf804943..8b2600f715e5 git log f40bcf804943..8b2600f715e5 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 google-shaderc-autoroll@skia.org Roll third_party/googletest fd20d1eccef6..176eccfb8f42 (1 commits) (#718) Created with: gclient setdep -r src/third_party/shaderc/src@8b2600f715e5 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I3a8a1fc9f2ea56c84c8f28fb1bf30767e324f755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662634Reviewed-by:
-
Kevin Marshall authored
Removes the package signing step, because "pm genkey" is deprecated in the Fuchsia builder toolchain. Change-Id: I8aebaf1658f77850f9d727a9952515b542d31fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662601 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#669825}
-
rbpotter authored
When directly navigating to chrome://print, it is possible to see "0 sheet of paper" as the summary. Rather than introducing a new set of strings to handle this case (since the singular/plural convention for 0 may differ by locale), hide the summary for this case, since it is not providing any useful information; there is no document to be printed from chrome://print. Bug: 92015 Change-Id: I64d9b5bb2762490993dd6e2cb6e3acac473658ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661390 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#669824}
-
Brian Osman authored
SkSL is being split into CPU and GPU sub-components, this is necessary to continue building the entire thing. Change-Id: Id58e4d0a7a68504a76be28f27df605492602f47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661369 Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#669823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/731454a08543..b97824d4d1d1 git log 731454a08543..b97824d4d1d1 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 fmalita@chromium.org [skottie] Motion tile effect 2019-06-17 rmistry@google.com Fix ingested perf data from Skottie tracing bots + add renderer key 2019-06-17 bsalomon@google.com Revert "Store GrSwizzle on proxies for texturing and swizzling." 2019-06-17 egdaniel@google.com Store GrSwizzle on proxies for texturing and swizzling. Created with: gclient setdep -r src/third_party/skia@b97824d4d1d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: If3b8272054fa57f081c3bf605b9e70057e81cdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662672Reviewed-by:
-
Francois Doray authored
This CL adds the following histograms: Browser.Tabs.TabSwitchResult.NoSavedFrames_Loaded Browser.Tabs.TotalSwitchDuration.NoSavedFrames_Loaded Browser.Tabs.TotalIncompleteSwitchDuration.NoSavedFrames_Loaded Which combine the samples that were already recorded to the corresponding histograms with suffix: *.NoSavedFrames_Loaded_Frozen or *.NoSavedFrames_Loaded_NotFrozen The goal is to facilitate analysis when an experiment affects the number of frozen tabs, and thus the number of samples in the existing frozen-state-suffixed histograms. Change-Id: I51ff9b73de192aaaab76765f37640b8f5b1ddd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651764Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#669821}
-
Jérôme Lebel authored
Fixing -[MainController dismissModalDialogsWithCompletion:dismissOmnibox:] to get it working. This is a temporary fix. A better implementation can be done once crbug.com/966414 is fixed. Bug: 966061 Change-Id: If6245c71e386cfc42ed73bbe333f5464006de339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626860 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#669820}
-
Brian Sheedy authored
Rolls the version of goldctl that is DEPSed in to pick up some improvements such as correctly identifying a negative vs. an untriaged image and writing triage links to the failure file in addition to stdout. TBR=kbr@chromium.org Bug: 850107 Change-Id: Id77f24eb0146ab85a101060ebe58fad48c35cba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660287Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#669819}
-
Kyle Milka authored
Now that image previews are supported this special handling is no longer needed. Bug: 854028 Change-Id: I51719b6dd7d53e3212034b2a9f69cc36db7518f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661482Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669818}
-
Navid Zolghadr authored
Change-Id: I86149eaf90356f9bc2216a463f51db00533402bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658841Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669817}
-
Weiliang Chen authored
After removing overlay validators, the only difference between GLOutputSurfaceBufferQueueAndroid and its parent class GLOutputSurfaceBufferQueue is calling to send display transform over. Since sending display transform over is a no-op for not Android Surface Control (BufferQueue Android) case, always calling to send the display transform. R=khushalsagar@chromium.org Bug: 963597 Change-Id: Ie4654dc7482e57ff3094518f60672cf1c1849792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634399 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#669816}
-
Steven Zhu authored
Run CheckForMissedHeartbeat on |io_task_runner_| as opposed to |maybe_power_wrapped_io_task_runner| to avoid waking up the system unnecessarily. Bug: internal b/132993317 Change-Id: I0d2e77bfec9ae7a2f823d71fd6534a047a860041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650722Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#669815}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c49d0b0936a..08b5629336d0 git log 2c49d0b0936a..08b5629336d0 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 dongja@google.com Vulkan: add LINE_LOOP with primitive restart Created with: gclient setdep -r src/third_party/angle@08b5629336d0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I7e9c979766cae5eecc9e383966d73019a3d94928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662543Reviewed-by:
-
Benjamin Shaya authored
Test: BT Audio Bug: internal b/134964839 Change-Id: If82a46b226fd1308f5a150f586561f5259759475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658643 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
-
Clark DuVall authored
Uses of these were removed in 9d906a92 Bug: 934009 Change-Id: Ife8f70748d9659204419a72192d831da751ea395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660975 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#669812}
-
Gayane Petrosyan authored
Bug: 974317 Change-Id: I9d29819b83b07af3dc01ff7ceaf55ce82b41e8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660954 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
GN already has the concept of a minSdkVersion. This CL adds target- and maxSdkVersion and makes GN the source of truth by removing the <uses-sdk> element from all manifests. There are three steps that require [min|target|max]SdkVersion: linting, manifest merging and resource compilation. Each of these steps get the versions passed from GN. Furthermore, manifest merging removes the SDK version from the output manifest so that GN stays the source of truth. + Add a manifest_utils to unify manifest parsing, rewriting, etc. in a single place. + Move manifest verification to compile resources steps, where the final manifest is written. This CL adds some temporary workarounds to keep downstream working. Those will be removed once downstream is updated. Bug: 891996 Change-Id: If24be69d9c6b03a0d2423fad830a4da375d68505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650265Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669810}
-
Kyle Milka authored
Image previews should set the opacity to 1, otheriwse it might not be visible. Bug: 854028 Change-Id: Iacdcb50316a60a50bfeab8958b59fe46d7ef17e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661765 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#669809}
-
Lukasz Anforowicz authored
Change-Id: Iec1b1090a675ff6af74661f5a000c41a9a8df940 Bug: 972220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650463Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#669808}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bf7a9d7. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 3d4f72a8 "Worker: Add service worker interception tests for shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie4793b4c82e7826530bd1f8fe95ec4914ef19dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662630Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669807}
-
Dale Curtis authored
Also moves the DCHECKs up to before the task is posted, so these issues can be caught at the call site rather than in the posted task. BUG=974681 TEST=new unittest Change-Id: I155e43bc931760af61e02b1707637e4d163d2d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662500 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#669806}
-
Richard Knoll authored
This extracts a FakeDeviceInfoTracker that was implemented in multiple places already and uses it instead. Bug: 958016 Change-Id: Ia7d01008af5925cfa8ad0b50bc14d10ae07d8ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662450 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669805}
-
Tarun Bansal authored
Adding some more browsertests before I refactor the code. Bug: 891328 Change-Id: I1fafb431a860a5912c22703376b414caf6d9c5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660285 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#669804}
-
Paul Miller authored
WebView now persists prefs. Internal Google doc on WebView prefs: https://docs.google.com/document/d/1X6Xoz9hl3qoAj3EhAKcvZ6hWLVcY_QpQgmUexpgDHKA/ BUG=733857 Change-Id: I4134458df8d05cb640b28e1debc4d6e761719ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662673Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#669803}
-
Wez authored
TBR=alexclarke Bug: 970187 Change-Id: I0b8825b4adfd729b13cb01cac2dfadacedc7b319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662731Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#669802}
-
Matt Menke authored
He's no longer working on Chrome, unfortunately. As he's the only one in /components/wifi/OWNERS, also make net/OWNERS owners of /components/wifi. Bug: none Change-Id: I797ad3d6e7ebae9f39dfc4c1ee4f588190b54deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661481Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Adds default values and an empty-constructor for empty search terms. This is a code health patch split off from this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1652555 Bug: 963173 Change-Id: Id07fd5768b3ff954a1ca68e4ae507cf41c955ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662599Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#669800}
-
