- 15 Oct, 2018 40 commits
-
-
Sergio Villar Senin authored
It was using SigninManager API. Migrated to IdentityManager so it could eventually make use of the identity service. By the way, PrivetNotificationsFactory was lacking the dependency with the SigninManagerFactory. Adding the new one with IdentityManagerFactory instead. BUG=890784 Change-Id: I0a3c3eb44ea28e8e388728b3e4e58841873057e4 Reviewed-on: https://chromium-review.googlesource.com/c/1278791 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#599638}
-
Jaeyong Bae authored
This patch is just a code simplification by applying conversion logic. Bug: 853874 Change-Id: I3f9db03fa3b140856b388599ac65ed4ca0dadc98 Reviewed-on: https://chromium-review.googlesource.com/c/1278918Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#599637}
-
Justin Cohen authored
This work is in preparation for allowing the BVC to present the NTP. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I593ec30092fc3ab3e1a955093b0300d2af3eba6c Reviewed-on: https://chromium-review.googlesource.com/c/1280045 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599636}
-
Justin Cohen authored
This CL introduces a feature flag kBrowserContainerPresentsNTP to gate this change. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If313f707a0c02d3af3b9c538a2b08ce3dda6bdd3 Reviewed-on: https://chromium-review.googlesource.com/c/1280044 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599635}
-
David Jean authored
- Fixed Edit button to be disabled when seaching and no results. - Fixed problem with background during search. - Fixed clunky animation by closing search controller first. Bug: 893559,893687,894031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6846006abf82d2e6ef1b6a9d783f6824d27df076 Reviewed-on: https://chromium-review.googlesource.com/c/1276646Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599634}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcefe396..1012874a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: Id014a51675cc07ae4c845216ec9020c48efd1e36 Reviewed-on: https://chromium-review.googlesource.com/c/1280608Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599633}
-
Luke Zielinski authored
This method will always return true going forward. Also update calling code to not use this method, which includes removing references to the legacy Extended Reporting preference that is no longer used. Bug: 662944 Change-Id: I1a091377a86c3dd5ff5d10452c751b05fd0dfc11 Reviewed-on: https://chromium-review.googlesource.com/c/1271401Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599632}
-
Ben Kelly authored
This enables removes the feature previously deprecated in 71. See the blink-dev discussion here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/l2YVa_M4ODs/o0PqQOl6CgAJ Bug: 720919 Change-Id: I2e4ee40b34385ccf88fbdcbf97702aea11f7e2b1 Reviewed-on: https://chromium-review.googlesource.com/c/1278905Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#599631}
-
Etienne Pierre-Doray authored
This reverts commit 8aeb9cc9. Reason for revert: Formatting error Original change's description: > [TaskScheduler]: Add section to faq: when to annotate with ScopedBlockingCall. > > Developpers are often wondering whether or not ScopedBlockingCall is redundant. > > Change-Id: Ic7936ef805f43f7fc02d0ad3020c31d8364b099d > Reviewed-on: https://chromium-review.googlesource.com/c/1271878 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599626} TBR=gab@chromium.org,fdoray@chromium.org,etiennep@chromium.org Change-Id: I3a78aedaa9f5807826c9c36447769b7c11b0bbaa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280765Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599630}
-
Brian White authored
This reverts commit fc3a0226. Reason for revert: M71 branch has occurred. Re-enable this for continued debugging on M72. Original change's description: > Revert bucket-boundary checks for branch. (part 2) > > Part 1 was here: > https://chromium-review.googlesource.com/c/chromium/src/+/1270345 > > I expect to revert this revert once the branch is done as there is > still more testing to be done here. > > Bug: 836238 > Change-Id: I1f85b6fa21405ceb3e569335aa995faf2050fd0f > Reviewed-on: https://chromium-review.googlesource.com/c/1271716 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598319} TBR=asvitkine@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836238 Change-Id: If2f1911f538c11170fff5e8de4bc3115262aa6c6 Reviewed-on: https://chromium-review.googlesource.com/c/1280782Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#599629}
-
Daniel Bratell authored
Quickfix to resolve some jumbo build problems after a duplicate instance of the GetHitTestQuery function was added. Change-Id: I924ff8254e59d00a92170d09664c20328209103a Reviewed-on: https://chromium-review.googlesource.com/c/1256688 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#599628}
-
Fredrik Söderquist authored
This function specifically checks only the shape(s) defined by the 'clip-path' property. It will also learn to handle more than just points in the near future. Change-Id: Icae665ff000ed5da2f7b0c5fad77411c856d176b Reviewed-on: https://chromium-review.googlesource.com/c/1278402Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#599627}
-
Etienne Pierre-doray authored
Developpers are often wondering whether or not ScopedBlockingCall is redundant. Change-Id: Ic7936ef805f43f7fc02d0ad3020c31d8364b099d Reviewed-on: https://chromium-review.googlesource.com/c/1271878 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#599626}
-
Chris Hall authored
R=dmazzoni,nektar BUG=889370 Change-Id: I7de6e4cd074a288595220b736816ec918945992d Reviewed-on: https://chromium-review.googlesource.com/c/1278461 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599625}
-
W. James MacLean authored
Disabling another flaky test from this suite. TBR=nyquist@chromium.org Bug: 882937 Change-Id: I53faca6b628a745ac543681f0adb34af00856144 Reviewed-on: https://chromium-review.googlesource.com/c/1280280Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599624}
-
Colin Blundell authored
I happened across this recently: FakeSigninManagerBuilder's factory function is called BuildFakeSigninManagerBase, which is confusing as it actually builds a FakeSigninManager (which is *not* a BuildFakeSigninManagerBase) on all platforms except ChromeOS. This CL gives it a name that matches the name that FakeSigninManagerBuilder uses internally to abstract across the two fakes. TBR=jochen@chromium.org Change-Id: I4910b320dd659e5e84e50cc3d3ec9c9f7205cb4f Reviewed-on: https://chromium-review.googlesource.com/c/1280250 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599623}
-
Philip Jägenstedt authored
An apparent bug in macOS's BSD grep caused wpt.sh to be deleted in attempts to sync wpt tools from a MacBook: https://chromium-review.googlesource.com/c/chromium/src/+/1278640 https://bugreport.apple.com/web/?problemID=45268819 (not public) https://bugs.chromium.org/p/chromium/issues/detail?id=895239#c5 (copy) Using `comm` is faster, more "semantic", and importantly, it works. Bug: 895239 Change-Id: I6dedb2000c059d367aa10a7448a5d0ee991471e5 Reviewed-on: https://chromium-review.googlesource.com/c/1280543 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#599622}
-
Michael Lippautz authored
Bug: 843903 Change-Id: I51f920f3e775e09ebb8b1dcc569f229b1c98c678 Reviewed-on: https://chromium-review.googlesource.com/c/1280662Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599621}
-
Valeriya Sinevich authored
Change-Id: I1b9fee123149e2f1371f8a568acaf8ceb59e9f07 Reviewed-on: https://chromium-review.googlesource.com/c/1251581 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599620}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1569ee5f6ea3..6164a6e58d71 Created with: gclient setdep -r src-internal@6164a6e58d71 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38e3a213bc31dee644859bebfdde5d81cdac1bde Reviewed-on: https://chromium-review.googlesource.com/c/1280403Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599619}
-
Rune Lillesveen authored
Tried to remove it only to discover it's needed by WebView on older Android versions. Document that need. Bug: 76362 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6f2d94aab1fb35721d01d275469ed865fcfce3ca Reviewed-on: https://chromium-review.googlesource.com/c/1280305 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#599618}
-
Robert Ma authored
The most important two changes to roll: * [wptserve] Rework header encoding/decoding in Request (https://github.com/web-platform-tests/wpt/pull/13246): needed to fix tests with non-ASCII cookies * Fix handling of about:blank in lint (https://github.com/web-platform-tests/wpt/pull/13489): needed to unblock the importer Bug: 895239 Change-Id: I10b308c19bdb20d2a1ec5af8dece42d7ada7e25b Reviewed-on: https://chromium-review.googlesource.com/c/1279195 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#599617}
-
Hitoshi Yoshida authored
An extended attribute [EnforceRange] is applicable to integer types, and not applicable to others, e.g. arguments. This CL fixes the folloing wrong usage of [EnforceRange], and it follows the spec of IDBOjbectStore. https://w3c.github.io/IndexedDB/#object-store-interface Bug: 819112 Change-Id: I65fa19cfd4d1119213390a54dba3247ee0cd2b4a Reviewed-on: https://chromium-review.googlesource.com/c/1280622Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#599616}
-
Peter Hanspers authored
Bug: 804870 Change-Id: I7ba8e6a61eccfb1ea9f4096cb2839d7a9f71c7af Reviewed-on: https://chromium-review.googlesource.com/c/1151108 Commit-Queue: Peter Hanspers <peterhanspers@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#599615}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a25b208..dcefe396 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: Ia5d634a104c7891f23c4ed74e11e79735bcb8b61 Reviewed-on: https://chromium-review.googlesource.com/c/1280602Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599614}
-
Michael Lippautz authored
Bug: 843903 Change-Id: I9271138dfcdf72cd67965ada3b3e8b03b3b89222 Reviewed-on: https://chromium-review.googlesource.com/c/1277803Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599613}
-
Marc Treib authored
Also add a ForTest suffix since it's only used in tests. Bug: 865936 Change-Id: I207e72a19905d77003aee1d9a4d951bbeaed105d Reviewed-on: https://chromium-review.googlesource.com/c/1280428 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599612}
-
Sergio Villar Senin authored
It was using the SinginManager API instead. The unit test was partially migrated too as the object now receives the IdentityManager as argument. The test still uses some APIs that will be eventually replaced by follow up CLs. Bug: 890791 Change-Id: I7a2f18bd8ce01eec85954b716b9064a914b613e3 Reviewed-on: https://chromium-review.googlesource.com/c/1278788Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599611}
-
David Roger authored
Dasher accounts generally are not allowed to signout, because they may have synced data that belongs to their administrator, and this data must not leave their account. The intended way to remove a dasher account from Chrome is to delete the associated profile. Due to this restriction, aborting signin was not possible for a dasher account, even though the UI was shown. This results in a bad user experience where the user clicks on the "cancel" button, but signin is actually not cancelled. The fix implemented here is to allow the user to signout without deleting the profile. This is acceptable because the data has not been synced yet. Bug: 864761, 804360 Change-Id: Iffbcde87ee242ada2815cd13d0bf8c660726d900 Reviewed-on: https://chromium-review.googlesource.com/c/1278734Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599610}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/fb462224c0..445998d7ac Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/fb462224c0..445998d7ac Bug: None Change-Id: I33633b8471e968656eea5fd6c3c5bd8acba1c188 Reviewed-on: https://chromium-review.googlesource.com/c/1273139Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#599609}
-
Morten Stenshorne authored
TBR=foolip@chromium.org,kojii@chromium.org Change-Id: I3c7257c49e863229ffaa49b9519cb509e9fb7091 Reviewed-on: https://chromium-review.googlesource.com/c/1278733Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599608}
-
Arthur Sonzogni authored
Bug: None. Change-Id: I029c610108b54ea703ffa6afa7b5bdee22fc87e2 Reviewed-on: https://chromium-review.googlesource.com/c/1276567Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#599607}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8de6fec..6a25b208 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: I928bd61eb317067542db2f8062e07cf4494f3792 Reviewed-on: https://chromium-review.googlesource.com/c/1280123Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599606}
-
Rakina Zata Amni authored
This CL moves find-in-page scoping methods and idle task to a new class, FindTaskController and use the term "finding" instead of "scoping" there. FindTaskController is responsible for managing IdleFindTask, and notifying TextFinder of matches etc, so that TextFinder can manage markers, tickmark, notifying frame etc. Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I20701ec0542acb40ace471891a490612e73d700b Reviewed-on: https://chromium-review.googlesource.com/c/1278074 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#599605}
-
Florent Castelli authored
TBR=rmcilroy@chromium.org Bug: 863599 Change-Id: I01b49946bc5e704aaad0ae6aa39867417462eb26 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280427Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599604}
-
Darren Shen authored
This is a reland of a643a13e Changed it to use HideKeyboardByUser instead of HideKeyboardImplicitlyBySystem as we do not want to reshow the VK if there's focus (see description of HideKeyboardImplicitlyBySystem). A "proper" fix is to actually allow clients to specify whether an input field should bring up the VK (like inputmode="none" in HTML). Then we can just remove this special case code. TBR=jamescook@chromium.org, xdai@chromium.org Original change's description: > [VK] Hide the virtual keyboard when we enter window overview mode. > > When we enter window overview mode (e.g. by dragging the top of an app), > we need to hide the virtual keyboard because: > > 1) It blocks the overview mode UI for no reason. > 2) The previews of windows have blank space at the bottom because that's > where the keyboard is. > > Bug: 893856 > Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2 > Reviewed-on: https://chromium-review.googlesource.com/c/1278565 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599561} Bug: 893856 Change-Id: Ibe9a1873cda3972520c75338db1b108d6274e005 Reviewed-on: https://chromium-review.googlesource.com/c/1280098Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#599603}
-
Sergio Villar Senin authored
It's currently using the SigninManager API to retrieve the currently authenticated account's email. Replaced by the IdentityManager equivalent API so it could eventually use the identity service. Bug: 890778 Change-Id: Icff574cb51ee2ae32bb0e5edc8f658c0061e0343 Reviewed-on: https://chromium-review.googlesource.com/c/1280265Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599602}
-
Nikita Podguzov authored
There is no "DeviceSetting" field in ManagedProperty, so it should be replaced with "SharedSetting". Bug: 877424 Change-Id: I09254246be27ead01a43aa79a648a12d3382daeb Reviewed-on: https://chromium-review.googlesource.com/c/1277790Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#599601}
-
Andrew MacPherson authored
This is a reland of 96b1bcfd Original change's description: > Implement the IAudioClient3 interface to allow lower output latency > for use in Web Audio via the latencyHint. Update AudioParameters > adding HardwareCapabilities with min_ and max_frames_per_buffer > representing the min and max buffer sizes supported by the audio > hardware so that requested buffer sizes can be appropriately clamped > in AudioLatency::GetExactBufferSize(). > > Bug: 316908 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ibafe6d917ec4d57a16092f040b57b4ff27ed54b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1165236 > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> > Cr-Commit-Position: refs/heads/master@{#597497} Bug: 316908 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I804e9546332ba00e69a032e587e451bc75b7f022 Reviewed-on: https://chromium-review.googlesource.com/c/1269527Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#599600}
-
Florent Castelli authored
TBR=drott@chromium.org Bug: 895257 Change-Id: I21c5097c48a46ce8cf3843dd179f69d628c23f0d No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280422Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599599}
-