- 26 Feb, 2019 40 commits
-
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I5c1a0002afd82cfbcfc2e6fcc72576e266b9791d Reviewed-on: https://chromium-review.googlesource.com/c/1488472Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635455}
-
Ivan Sandrk authored
This is a purely refactoring CL which doesn't modify any behaviour. Currently ArcSessionManager::RequestDisable also calls ArcSessionManager::RequestArcDataRemoval - there are use cases where we want to disable ARC and preserve user data, so decouple the two. This CL is a preparation for disabling of ARC inside of locked fullscreen mode. More details can be found on the design doc go/disabling-arc-locked-fullscreen Bug: 888611 Change-Id: Ifd2aad309c0300416aae3124d3f526ec7cf30a44 Reviewed-on: https://chromium-review.googlesource.com/c/1363202Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635454}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0bd66935e1028ca587363e5b045ac210344de291 Reviewed-on: https://chromium-review.googlesource.com/c/1488499Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635453}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 714018 Change-Id: I4268e80cb016b4a8958ea4803656396f66854f11 Reviewed-on: https://chromium-review.googlesource.com/c/1486611 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635452}
-
Ricky Liang authored
BUG=b:124281296 TEST=Take picture on people page and make sure the user-facing camera is opened if present. Change-Id: I80e1ab45289a1be924e06941a26364a3db784001 Reviewed-on: https://chromium-review.googlesource.com/c/1475017Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Auto-Submit: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635451}
-
Sriram authored
These tests are using "white" videos and the rendering is not actually "white" (the CSS color) used in ref test. Also the ref test has the font property (sans-serif) applied to the inner span, so we get a different font for the other span - that font has slightly different metrics (even though it's still 9px), so over the whole line this ends up yielding an "extra pixel" in height. Fixed the ref tests to use the actual <video> element instead of white background <div>, and also fixed the font size issue by applying font family to parent <span> element. BUG=930608, 626703 Change-Id: I44c33a8cda08aff2e8b84f2542cc504866bd4c10 Reviewed-on: https://chromium-review.googlesource.com/c/1485628Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#635450}
-
Adam Rice authored
Wrap v8.createPromise() in a createPromise() function which always sets the isSettled flag to false. Make resolvePromise() and rejectPromise() ignore promises that don't have the isSettled flag present. Replace Promise_resolve() and Promise_reject() with createResolvedPromise() and createRejectedPromise() functions that also set the isSettled flag. Strictly speaking, the createR*Promise() functions only need to be used when a promise is stored and might be resolved or rejected later. But to avoid confusion about where they are needed, always use them in place of Promise_resolve() and Promise_reject(). BUG=931640 Change-Id: I5472cb4a78f7b970ab256084b819ae28ffda6a33 Reviewed-on: https://chromium-review.googlesource.com/c/1481178Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#635449}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/478c5c145fc9..0ba9f084228f Created with: gclient setdep -r src-internal@0ba9f084228f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iecff5c34214da0974210d5faee58564e60b08ef8 Reviewed-on: https://chromium-review.googlesource.com/c/1488500Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635448}
-
Luciano Pacheco authored
Fix closure errors Bug: 778674 Change-Id: I00f239f14f906e0489f038f24d90ccf343bcaf63 Reviewed-on: https://chromium-review.googlesource.com/c/1488480 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635447}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/202077e2810d..346e10e8ae1a git log 202077e2810d..346e10e8ae1a --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 377d493a0847..9a16248dedf3 (2 commits) Created with: gclient setdep -r src/third_party/skia@346e10e8ae1a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icaee3879cf477efeee763caaa1f64a4b2e64592d Reviewed-on: https://chromium-review.googlesource.com/c/1488498Reviewed-by:
-
Rakina Zata Amni authored
Currently when looking for locked ancestors of a node we are using the ParentOrShadowHostNode instead of doing a flat-tree traversal. Slotted nodes that are inside a display-locked subtree might behave incorrectly due to this. Example, affecting focus: <div id=shadowHost> #shadowRoot <div id='locked'> // locked div <slot> <input> // originally shadowHost's child Flat-tree: <div id=shadowHost> #shadowRoot <div id='locked'> // locked div <slot> <input> // slotted The slotted input shouldn't be focusable since it's actually inside a locked subtree, however ParentOrShadowHost will return the node tree parent - the shadowHost - because the slot is not the parent of the slotted input. Bug: 882663 Change-Id: Ic455aaec00554b0fb5a878a2d80636a3e902648e Reviewed-on: https://chromium-review.googlesource.com/c/1466547 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:vmpstr <vmpstr@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#635445}
-
Adam Rice authored
Expose methods and accessors that are used between the WritableStream C++ implementation classes publicly so that they don't have to be friends of each other. The order of the methods in the C++ files will be updated to match the headers in a follow-up CL. Bug: 902633 Change-Id: I26787cf13a1e4dcba63686d090dd5f36142cd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/1481144Reviewed-by:
-
Camille Lamy authored
This CL is part of a series of CLs that removes members from NavigationHandleImpl and queries them from NavigationRequest instead. This CL removes parameters passed to NavigationHandleImpl::WillProcessResponse. Bug: 916537 Change-Id: If35835e7034238fabe8dc4b9a4d933093b1249e1 Reviewed-on: https://chromium-review.googlesource.com/c/1450193Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#635443}
-
Oleg Davydov authored
Years ago there was a variable |not_updated| in handle successfully/unsuccessfully downloaded extension manifests. Now it is handled more elegant via ExtensionDownloader::DetermineUpdates method, so we may remove it and replace its only usage with actual data. ExtensionDownloader: :HandleManifestResults method, and it was used to Change-Id: I188b588c061dd6595c2bb5d6030afe5200b28130 Reviewed-on: https://chromium-review.googlesource.com/c/1486271Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635442}
-
Sergio Villar Senin authored
As part of the Onion Soup effort, the base::time primitives should replace any usage of platform/wtf ones in Blink. In this first step we're replacing the following 2 calls: * TimeTicksInSeconds() -> base::TimeTicks::since_origin()::InSecondsF() * TimeTicksFromSeconds() -> base::TimeTicks() + base::TimeDelta::FromSecondsD() Bug: 919383 Change-Id: I3bb3b4fe76c11ca3c6c5b1bfb8ebffce51f03bf7 Reviewed-on: https://chromium-review.googlesource.com/c/1472625Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I059fc47bbabf89deb753d14944694a5bab2382b5 Reviewed-on: https://chromium-review.googlesource.com/c/1487435 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/storage have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of StorageAreaMap and StorageController classes, they make sense to use USING_FAST_MALLOC because they have been created by smart pointers. Bug: 919389 Change-Id: Ic440735af3bb0e2e87fce36b41564ade69a6ebfb Reviewed-on: https://chromium-review.googlesource.com/c/1488398Reviewed-by:
-
Leon Han authored
Make ServiceWorkerNetworkProviderForFrame::Create() be called only in case of creation for a valid instance. Have those callsites intending to create an empty instance just call ServiceWorkerNetworkProviderForFrame::CreateInvalidInstance() directly. BUG=931092 Change-Id: Icec8a537b96bc420c8dbc0b79a09d6ff3bd51598 Reviewed-on: https://chromium-review.googlesource.com/c/1477513Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#635438}
-
Tim Song authored
BUG=934608 Change-Id: Id673d62c802072036a8b6b63161104b26f9768bd Reviewed-on: https://chromium-review.googlesource.com/c/1482115 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635437}
-
Yutaka Hirano authored
SinkPeer is designed to read all the response body in order to let the network stack store the contents to the HTTP cache. We need to read the response body rather than discarding it. Bug: 894819 Change-Id: I9ba34d3b765c7d3f1127ad18f5aac17c3eddd6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1481137Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b2ef4ac9fd6..478c5c145fc9 Created with: gclient setdep -r src-internal@478c5c145fc9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38b49fce033267045a7848c41f08bba34a5db9c4 Reviewed-on: https://chromium-review.googlesource.com/c/1488497Reviewed-by:
-
Nate Fischer authored
net-debugging.md was accidentally omitted from navbar.md, making it less discoverable. This adds it in, so this page can be discovered from the grey-ish top bar of the other docs pages. Details on navbar can be found: https://gerrit.googlesource.com/gitiles/+/HEAD/Documentation/markdown.md#Navigation-bar R=ctzsm@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia3e870833a3e86c8703301e296effce7139e66dd Reviewed-on: https://chromium-review.googlesource.com/c/1488533 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#635434}
-
Yutaka Hirano authored
This is a reland of https://crrev.com/5432359239b23e0810aea8c78adcd37f637936f4. The original CL caused crashes due to handle reset in a two-phase read, so this CL delays the reset operation a bit. Original description: WebURLLoaderImpl is not destructed when the request is cancelled, so it's better to destruct the response body handle in WebURLLoaderImpl::Context::Cancel manually. Bug: 894819, 927184, 929793 Change-Id: Ie3822049bb796ba180ad428f97bd873cec3a17f0 Reviewed-on: https://chromium-review.googlesource.com/c/1481143 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t. - Used ToUnsigned instead of ToFloat - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I0701321485e056d639f43d1f32af8d0054ea6b52 Reviewed-on: https://chromium-review.googlesource.com/c/1488471Reviewed-by:
-
Miyoung Shin authored
- unsigned short/int -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I072bdca3916a24def0ceda5915b4b45afaf1dfad Reviewed-on: https://chromium-review.googlesource.com/c/1487760Reviewed-by:
-
Rakina Zata Amni authored
ReattachLayoutTree/RebuildLayoutTree can't be called on elements with the NeedsStyleRecalc/ChildNeedsStyleRecalc flag set, which might be the case for locked elements because we block style recalc. Marking of the NeedsReattachLayoutTree/ChildNeedsReattachLayoutTree is done inside RecalcStyle and whitespace reattachment marking. The first case is OK because we already block RecalcStyle, this CL is fixing the second case. In this CL, we save a per-DisplayLockContext |whitespace_reattach_set_| that will save locked elements needing whitespace reattachment. After we finished style recalc on locked elements (after forced update or when the budget allows), we will mark those elements as needing layout tree reattachment, just like the global whitespace reattachment in StyleEngine. Bug: 882663, 912949 Change-Id: Ib83845601db24342a30d556689c2a08244491a33 Reviewed-on: https://chromium-review.googlesource.com/c/1460581 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Fix for https://bugs.chromium.org/p/chromium/issues/detail?id=922875#c107 Bug: 922875 Change-Id: Ifddc1f7ebf14117ed734bfbab6fd16b13632979a Reviewed-on: https://chromium-review.googlesource.com/c/1488395 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#635429}
-
Maksim Sisov authored
This patch fixes software rendering path by adding mojo APIs to call newly created WaylandShmBufferManager, which uses Wayland APIs to create shm buffer and commit it. Also, some code is rearrenged and moved to WaylandShmBufferManager instead. WaylandSurfaceCanvas is also moved to a separate file. gn args: use_ozone=true ozone_platform_wayland=true use_xkbcommon=true ./chrome --ozone-platform=wayland --use-gl=swiftshader --in-process-gpu Test: ./chrome --ozone-platform=wayland --use-gl=swiftshader Bug: 910998 Change-Id: Id52fc41e165232cd08eeb471542eab11d6e1cae4 Reviewed-on: https://chromium-review.googlesource.com/c/1454623 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635428}
-
Dan Beam authored
The changes in this CL should be exactly equivalent and have less superfluous symbols. There's precedent for discouraging unnecessary characters when safe, i.e. https://google.github.io/styleguide/cppguide.html#Return_Values R=dpapad@chromium.org BUG=none Change-Id: I04d7480ebd54a33cfb962a3d2d9e1a58a3d1ea4c Reviewed-on: https://chromium-review.googlesource.com/c/1450645Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (doing your perf) <dbeam@chromium.org> Auto-Submit: Dan Beam (doing your perf) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635427}
-
Shawn Anastasio authored
Ideally page size would be detected at run-time on ppc64 systems, but this would most likely require a significant refactor. Since 64k is the de-facto standard and binaries compiled for 64k are likely to function on 4k systems, it was chosen to use 64k as the default page size in the partition allocator on ppc64. This change is part of the effort to upstream a set of patches that allow chromium to build and run on ppc64le hosts available here: https://wiki.raptorcs.com/wiki/Porting/Chromium Change-Id: I23369f261766bdf7aab1b3dc730b94b7f4ba4a96 Reviewed-on: https://chromium-review.googlesource.com/c/1480970 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#635426}
-
Mei Liang authored
This CL adds a package-protected API getTabCount(boolean isIncognito) to TabCountProvider. This API is needed because the IncognitoToggleTabLayout need the count for normal model even when the current model is incognito. As is, TabCountProvider only provides current model count. Bug: 935818 Change-Id: I0b6f2184226c74820ef6b6e00d7a04118d07d6e0 Reviewed-on: https://chromium-review.googlesource.com/c/1488021 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635425}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac6d4c0c8eae..202077e2810d git log ac6d4c0c8eae..202077e2810d --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 53c8957c337d..377d493a0847 (1 commits) 2019-02-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@202077e2810d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I2cec030b69543573a7c104740e1e3848de7d135a Reviewed-on: https://chromium-review.googlesource.com/c/1488495Reviewed-by:
-
Michael Martis authored
This change updates the HTTP request sent to the image annotation server to request image descriptions as well as OCR, and updates the service API to expose this data. This change has been manually tested, but more unittests are to come shortly in another CL. Bug: 916420 Change-Id: Ifd919c376f117e25db93389ab4091c18c684e016 Reviewed-on: https://chromium-review.googlesource.com/c/1478652 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635423}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c6b8283de9c..7b2ef4ac9fd6 Created with: gclient setdep -r src-internal@7b2ef4ac9fd6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iada240a538f285b8af5386ca65cacd87d8e3d204 Reviewed-on: https://chromium-review.googlesource.com/c/1488494Reviewed-by:
-
Joey Arhar authored
Manually tabbing through the network panel with and without the search sidebar open worked fine after removing the "tabindex = 0" Bug: 933049 Change-Id: Ifd5c85f27c0cf0311323c5da1dd289c2fa31b27b Reviewed-on: https://chromium-review.googlesource.com/c/1481604Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#635421}
-
Jinsuk Kim authored
Detached state of Tab from Activity/WindowAndroid can be obtained dynamically from Tab. This CL removes the private field that caches the state. Bug: 925242 Change-Id: Ib6050875843239d346f46eb7c5a26d1f881c4339 Reviewed-on: https://chromium-review.googlesource.com/c/1474883 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635420}
-
Alexey Baskakov authored
Refactor ReparentTab util. ReparentTab and RevealAppShim are unrelated steps. Bug: 915043 Change-Id: I37a1f463bf06e41e91c4bb0229a125af11903bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1482432Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#635419}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bcfbf6e94c22..ac6d4c0c8eae git log bcfbf6e94c22..ac6d4c0c8eae --date=short --no-merges --format='%ad %ae %s' 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b433073ba38..53c8957c337d (1 commits) Created with: gclient setdep -r src/third_party/skia@ac6d4c0c8eae The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I4291acfae1f48be1ef809be68469f3529478c165 Reviewed-on: https://chromium-review.googlesource.com/c/1488492Reviewed-by:
-
Mohit Hotwani authored
Bug: internal b/125939889 Change-Id: I636ca19438715f364ea5c62edc7a02a340798dd8 Reviewed-on: https://chromium-review.googlesource.com/c/1487530 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Auto-Submit: Mohit Hotwani <hmohit@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635417}
-
Antonio Gomes authored
This is the first out of N CLs that switch blink away from using ToLocalFrame() / IsLocalFrame() macro-based downcast helpers to use the new DowncastTraits mechanism from t_p/blink/renderer/platform/wtf/casting.h R=jbroman@chromium.org CC=blink-reviews-onion-soup@chromium.org BUG=891908 hange-Id: I9dcd3b40361370d4595ccf291b2fb698f2726e43 Change-Id: I9dcd3b40361370d4595ccf291b2fb698f2726e43 Reviewed-on: https://chromium-review.googlesource.com/c/1487391 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635416}
-
