GitLab

The stacktrace in the bug revealed a path where we don't check that the
LocalFrameView isn't null.

No test since I couldn't reproduce the crash.

Bug: 805420
Change-Id: Ief57e784e765efadb18b5c9c040e7b5a40ee904c
Reviewed-on: https://chromium-review.googlesource.com/887826Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532412}

This change:
1) Resurrects the 10.6/10.7/10.8 deprecation strings and updates them to 10.9;
2) Adds a feature "Enable109ObsoleteInfobar";
3) Shows the obsolete system infobar on 10.9 systems when that feature is
   enabled;
4) Adds a *placeholder* chrome::kMac10_9_ObsoleteURL link for the "learn more"
   link in the infobar.

Bug: 806071
Change-Id: I48ab95e50fd2be7438650bc7f7cbb35fd2c2b02b
Reviewed-on: https://chromium-review.googlesource.com/889020
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532411}

We want to merge various smoothness page sets into desktop and mobile
page sets for the new rendering benchmark. Since the same urls are
duplicated in different page sets e.g. same page with scroll and
pinch-zoom or same page with and without gpu raster, it's necessary to
have unique names for each instance.

This CL allows specifying a name when instantiating these pages.

BUG=760553

Change-Id: I7fe789fbda625c6700e089433e75c07cad7d7db8
Reviewed-on: https://chromium-review.googlesource.com/885644Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#532410}

Split out input task queue from the compositor task queue and use it in
content/renderer/input's MainThreadEventQueue.

For now scheduler applies the exact same policies to the new queue, so
this patch does not affect scheduling policies. It is planned in the
future to run input task queue with high priority unconditionally.

R=skyostil@chromium.org,haraken@chromium.org,dtapuska@chromium.org
BUG=806271

Change-Id: I73204187131d01b936a0a5d5052b8969a62205eb
Reviewed-on: https://chromium-review.googlesource.com/888521Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532409}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b4e468e1..ce789d48

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Id4572c982100e3f97b43e13f4a8f59f0ae12e6a6
Reviewed-on: https://chromium-review.googlesource.com/891138Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532408}

Disable ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked
because it timeouts constantly on Win.

TBR=rdevlin.cronin@chromium.org

Bug: 806684
Change-Id: Ic86b6219db299489ec6392b2fd2fe885904bb3d9
Reviewed-on: https://chromium-review.googlesource.com/891022
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532407}

This patch removes use of filesystem's MetadataCallback.  The
motivation is the same as https://crrev.com/844307 .

Bug: 778580
Change-Id: I75dda3272deb5cd641aa01da638b9ea5fee98bff
Reviewed-on: https://chromium-review.googlesource.com/886921
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532406}

Add tracing for methods in BrowsingData[Counter]Bridge and each
browsing data counter. This will allow easier debugging of performance
issues with the Clear Browsing Data dialog.

Bug: 804839
Change-Id: I971d08edea77fee4e76e48b901516253e46fcb33
Reviewed-on: https://chromium-review.googlesource.com/883530Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532405}

- No longer necessary to wait for NotificationDisplayService mutation
now that we are back to waiting for the 'show' event in this test,
since f5ae28

Change-Id: I19506c1a8cf1a1f040919a20be131986fff7df44
Reviewed-on: https://chromium-review.googlesource.com/888819Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532404}

BUG=None
R=ljusten@chromium.org

Change-Id: I0c0f6e061c5d81e0d823d155b84dbf887867bbde
Reviewed-on: https://chromium-review.googlesource.com/889499Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532403}

Add a developer hint to an otherwise cryptic error when accidently registering a second RunLoop::Delegate on a thread.

While Runloop::Delegate isn't aware of MessageLoop/ScopedTaskEnvironment:
I find useful to add developer hints about the typical developer mistake
a DCHECK catches. This avoids multiple developers wasting time figuring
out the same thing. Started doing this in a few places in //base and this
is another instance recently surfaced by chrisha @
https://groups.google.com/a/google.com/d/topic/lucky-luke-dev/9_eZ6pnvo7Y/discussion

R=chrisha@chromium.org

Bug: Cryptic error when creating a ScopedTaskEnvironment over an
existing MessageLoop.

Change-Id: I427e0400b2a2b91ab9b175fa2427014bc8fc4406
Reviewed-on: https://chromium-review.googlesource.com/890174
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532402}

This reverts commit 4db68ed9.

Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712).

Original change's description:
> [Variations] Avoid duplication of the safe seed value stored in prefs.
> 
> When the safe seed and the latest seed have identical contents, use a sentinel
> value to avoid storing a duplicate value for the two seeds. This is purely a
> storage space optimization; no difference in observed functionality is expected.
> 
> R=​asvitkine@chromium.org
> 
> Bug: 727984
> Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb
> Reviewed-on: https://chromium-review.googlesource.com/880482
> Commit-Queue: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532027}

TBR=isherman@chromium.org,asvitkine@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 727984, 806712
Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456
Reviewed-on: https://chromium-review.googlesource.com/891119Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532401}

The CSS WG has resolved that it doesn't make sense to define Baseline
Content-Alignment in the inline/main axis.

https://github.com/w3c/csswg-drafts/issues/1184

The spec has been updated so that <baseline-postion> is not valid for
the 'justify-content' property's syntax. This CL updates our parsing
logic to match the new spec, including the parsing logic of the
place-content shorthand.

Additionally, this CL updates the computed value of the
<baseline-position> values to match other browsers.

We don't implement support for <baseline-position> values in the
Content Distribution properties (align-content and justify-content),
so I don't expect this change to break content of sites using the CSS
Box Alignment feature.

Bug: 802248, 803275
Change-Id: I0d3b1b7e7dd28552ee7e131bfe09ef7198565283
Reviewed-on: https://chromium-review.googlesource.com/882362Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#532400}

In anticipation for incremental marking, disable promptly free for weak collection backings. This is required to avoid callbacks to objects that can be destroyed during the mutator between incremental marking.

This CL:
- Disable prompty free for weak hash table backings
- Adds CheckObjectNotInCallbackStacks which checks that an object doesn't have any callback registered

Bug: 757440
Change-Id: Ibeffed9e5a2f15a1b88c934f68e5d86f54c2e2c9
Reviewed-on: https://chromium-review.googlesource.com/836299
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532399}

Remove the -tabs suffix from CBD code as the old dialog has been removed
and the new dialog isn't special anymore. Also remove some footer
related code as the footer has been removed.

Bug: 800184
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I937e2133feb192eff9f043c5bc060d8296806070
Reviewed-on: https://chromium-review.googlesource.com/873911
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532398}

Change-Id: I6b8d69e82bc99b1a01ca053afb31b044362048ae
Reviewed-on: https://chromium-review.googlesource.com/888621
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532397}

Accessing FetchContext passed to ResourceLoadScheduler causes
indeterminate crashes. This implies that there might be a race to
access NullInstance because dedicated FetchContext instance
should be passed in usual production code path, and NullInstance
use is only the exception. XHR will touch this regardless of
threads, and can cause a race condition among the first and the
second access over multiple-threading.

This patch creates new FetchContext instance always instead of
sharing one instance among all threads. If this affects performance
we would consider to make it thread-local.

Bug: 803849
Change-Id: I8bcdab577aceccaaea15288c6e3ae4c83f218213
Reviewed-on: https://chromium-review.googlesource.com/880421
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532396}

This reverts commit d26dcac0.

Reason for revert: Seems to cause an exception (time out) on Linux ChromiumOS MSan Tests (see crbug.com/806715). The original CL (the one relanded) caused this exception too.

Original change's description:
> Re-land "FrameSinkVideoCapturer: Fix refresh logic for damaged sources."
> 
> This reverts commit 52c31b74, to re-land
> the original CL (https://chromium-review.googlesource.com/884996). The
> viz_content_browsertests were failing because of a bug in the posix
> shmem impl (in base/memory/shared_memory_helper.cc) when the pool is
> being run in the VIZ process. For now, the tests have been added to the
> viz_content_browsertests filter file; and once the root-cause issue has
> been resolved, they can be re-enabled.
> 
> TBR=xjz@chromium.org,kylechar@chromium.org
> 
> Bug: 806635, 785072, 754872
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I0f419ce2aee170a0fbd966ff8e10bb99c3b7067f
> Reviewed-on: https://chromium-review.googlesource.com/889934
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532322}

TBR=miu@chromium.org,kylechar@chromium.org,xjz@chromium.org

Change-Id: Ia3715ed63494598badbe85e2f418b792c952dadb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 806635, 785072, 754872, 806715
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/890445Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532395}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/707cd028b2b4..994eb2b34934

$ git log 707cd028b..994eb2b34 --date=short --no-merges --format='%ad %ae %s'
2018-01-26 wl [truetype] Fix multiple calls of `FT_Get_MM_Var' (#52955).
2018-01-23 apodtele [apinames] Anonymous version map for GNU linker.
2018-01-21 apodtele [unix] Call libtool to clean up.
2018-01-18 apodtele * src/base/ftver.rc: Fix mingw-w64 compilation.
2018-01-18 apodtele [build] Enable VERSIONINFO resource for Cygwin/MinGW.
2018-01-18 apodtele [build] Move VERSIONINFO resource.
2018-01-12 apodtele [build] Expand dllexport/dllimport to Cygwin/MinGW.
2018-01-12 apodtele [build] Improve and document MSVC build.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng
PDFium issue: pdfium:995

Change-Id: I2a3483beea08685c6ce68c23e6f07f77988d751f
Reviewed-on: https://chromium-review.googlesource.com/889767Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532394}

The feature shipped in M63 so the old code is not required anymore.
This CL removes the old CBD dialog and the kTabsInCBD flag as well as
migration code for preferences. Users that have not been migrated
will get default values for selected checkboxes in the basic tab.

Bug: 800184
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If9325462be1bf652206b7956d5d25dcfec717078
Reviewed-on: https://chromium-review.googlesource.com/857059Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532393}

VrShellTransitionTest#testExitPresentationWebVrToVrShell and
VrShellNavigationTest#test2dFullscreenToWebVr continue to fail and
keep the bot red.

Bug: 804808
TBR: bsheedy@chromium.org,mthiesse@chromium.org
Change-Id: I1721df42012b11662998f54627a8dd561c1a3253
Reviewed-on: https://chromium-review.googlesource.com/890182Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532392}

The test harness has working directory /, which is not readable in
this test.

Bug: 804348
TBR: aberent@chromium.org,brettw@chromium.org,thestig@chromium.org
Change-Id: I31f02bef8aa61f62e2e07c94279e875d8b6d9570
Reviewed-on: https://chromium-review.googlesource.com/891158Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532391}

Bug: 777962
Change-Id: I6cf85600830ddd6c2398a15e4a1c4c74aa9fbfd9
Reviewed-on: https://chromium-review.googlesource.com/886830Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532390}

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I26f97dba5a0bb07f83df184db59b8f610c220877
Reviewed-on: https://chromium-review.googlesource.com/888750Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532389}

Added stringifier to support MediaList |toString| method.
Specification:
https://drafts.csswg.org/cssom/#the-medialist-interface

Bug:

Change-Id: I0dd14cd1843a5d3fde424021a443669db374df85
Reviewed-on: https://chromium-review.googlesource.com/890959Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com>
Cr-Commit-Position: refs/heads/master@{#532388}

We want to remove Nullable.h, but UnionTypeConversionMode needs to remain.
Move it to V8BindingForCore.h, as the enum is generally used in ToImpl()
calls.

While here, document it a little bit.

Bug: 798464
Change-Id: Iecbb481114ad934264dcfb0efffc248bcc420981
Reviewed-on: https://chromium-review.googlesource.com/891019Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#532387}

Bug: None
Change-Id: I9fbb01166c6dbf6f5dc58de116c9de1a739b904e
Reviewed-on: https://chromium-review.googlesource.com/890143Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532386}

This CL fixes the OmniboxPerfTest.TestTypeOneCharInTextField test which
was failing because it was using the WebToolbarController even if the
flag to disable it is turned on. It was creating a conflict.

Bug: 806685
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If846ac3ecf0963700da4e1dd71156037c87653c4
Reviewed-on: https://chromium-review.googlesource.com/891018Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532385}

DeviceSingleWindowEventController::DidAddEventListener() is not
called if {deviceorientation|deviceorientationabsolute|devicemotion}
events are blocked by feature policy.

A console message referencing to
https://github.com/WICG/feature-policy/blob/gh-pages/features.md
is send to warn the user.

Bug: 796894
Change-Id: I350ff75ca55766b7ebb42944d66470ecd2b8a4c1
Reviewed-on: https://chromium-review.googlesource.com/870510Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#532384}

Only mechanical changes in this CL. Presubmit (correctly) complains
about Time::Now() usage AudioInputSyncWriter. This is pre-existing,
but only for logging, and will be fixed in a followup to keep this CL
completely trivial.

Bug: 803102
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I422f80e376f89428ed8f69a1de1a5751c31bf4bb
Reviewed-on: https://chromium-review.googlesource.com/886345
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532383}

Using wpt-import in Chromium 55129433.
With Chromium commits locally applied on WPT:
9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11260

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=leon.han@intel.com

No-Export: true
Change-Id: Icd58b44866f3a48702a2a31ea839489ce0c202a7
Reviewed-on: https://chromium-review.googlesource.com/889803
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532382}

Bug: none
Change-Id: I995b5edbce2969313424fc71ef6dc240c268dd24
Reviewed-on: https://chromium-review.googlesource.com/885806Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Niels Möller <nisse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532381}

The CSS WG resolved in May 2017 to replace the 'auto' keyword by
'legacy' in the CSS syntax of the justify-items property.

https://github.com/w3c/csswg-drafts/issues/1318

According to the spec, the 'auto' (now 'legacy') value applied to the
justify-items property should be resolved, during the style resolution
phase before layout, with its inherited value if this includes the
'legacy' keyword (plus 'left', 'right', or 'center').

There is no behavior change in the affected property due to this syntax
change.

Since 'auto' (now 'legacy') is the default value of the justify-items
property, this change has a relative big impact. However, we are only
interested on evaluate the use of the 'legacy' alignment, which has to
be explicitly set in the parent element.

Change-Id: Id2ae6735fb28ac44062aaec79828ce97d7edd5d6
Reviewed-on: https://chromium-review.googlesource.com/886365Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#532380}

Bug: 588931
Change-Id: Ie1118c0efa0cc3e274d3f66ce4ea536979014aa0
Reviewed-on: https://chromium-review.googlesource.com/875964
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532379}

When deleting a profile, the profile will be marked as deleted and all
browsing data is removed but the profile folder will remain until shutdown
and it still contains some data like bookmarks and settings. Using command
line arguments it is possible to open a new window for this profile.
This CL changes the profile manager to not return profiles that have
been deleted. Instead of opening a window for a deleted profile,
Chrome will refuse to open the window.

Bug: 803643
Change-Id: Iae3caf93b2895d23b90aeb6550197a81038a1ec6
Reviewed-on: https://chromium-review.googlesource.com/883342Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532378}

When the ClearBrowsingDataDialog is opened, a CBDPreferences is
created for each of the tabs. Each preference queries for information
about browsing history and fetches important sites. As these are
non-trivial operations, a class is introduced to only request both
infos once and share them between preferences.

Bug: 804839
Change-Id: I8495bc2e2ebeaeb8640d9d0775f701911d0045c8
Reviewed-on: https://chromium-review.googlesource.com/883783
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532377}

Also convert another trace event in WarmupManager to
TraceEvent.scoped().

Bug: 804302
Change-Id: I1e21c4ccfeb8310fe7a412d9cef308bc479320af
Reviewed-on: https://chromium-review.googlesource.com/886845Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532376}

In order to remove tab history correctly, we need to know the time range
that was specified for a history deletion. Otherwise there can be edge
cases, where a NavigationEntry could not be removed because it doesn't
have a corresponding history.
This CL replaces the boolean all_time parameter of
HistoryServiceObserver::OnURLsDeleted with a DeletionTimeRange object.

Bug: 407074
Change-Id: Id0fc5535e6cfd0874edb83fe75f61e6d112666e7
Reviewed-on: https://chromium-review.googlesource.com/800932
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532375}

This reverts commit 3d3a5267.

Reason for revert: Causes UnhandledEventOnPeeking to fail constantly (see crbug.com/806690).

Original change's description:
> cros: Don't dismiss AppList on right click/two finger tap
> 
> UX request:
> - Don't dismiss AppList if the right click/two finger tap
>   is on the shield of the AppList.
> 
> - Added a test.
> 
> Bug: 805937
> Change-Id: Id38b5872c3836680d08adbcb84922fe62201be19
> Reviewed-on: https://chromium-review.googlesource.com/887282
> Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532023}

TBR=jennyz@chromium.org,newcomer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 805937, 806690
Change-Id: I4acd4bbea8a85988224efa7573b719655628e445
Reviewed-on: https://chromium-review.googlesource.com/890264Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532374}

There is a global comparison operator allowing to check whether
a GURL is equal to a constant URL. This avoid needlessly parsing
the constant to a GURL everytime the comparison is done.

Bug: 655467
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9c876b542f09235042c36026b32977d88c2f0d0b
Reviewed-on: https://chromium-review.googlesource.com/886421
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532373}