GitLab

Previously Desktop.dispatchKeyEvent() was sending keyboard events to
the host and then pretending that it didn't handle the event. Now it
returns correct result telling the caller when the event was handled.

BUG=385972

Review URL: https://codereview.chromium.org/341693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278331 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes several changes to the EME player to enable test
specific expectations possible.

The EME player can be still used as a stand alone player.

BUG=356892
TESTS=out/Release/browser_tests --gtest_filter=*EncryptedMedia*

Review URL: https://codereview.chromium.org/308553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278330 0039d316-1c4b-4281-b951-d872f2087c98

Gsutil tries to create a dir (for keeping track of resumable downloads)
under home dir. On ChromeOS this is, given that the tests must be run
by root, read-only '/root/'. This causes gsutil commands to fail. To
avoid this, override HOME dir to writable '/home/chromeos-test'.

(this will also require gsuitl to be configured with the same HOME dir)

BUG=359293,386416

Review URL: https://codereview.chromium.org/334603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278329 0039d316-1c4b-4281-b951-d872f2087c98

1. Make the chrome://devices issue run right to left for RTL languages
2. Make the chrome://devices page show icons correctly when displayed right to left
3. Remove unnecessary comment about needing i18n

BUG=386020

Review URL: https://codereview.chromium.org/339403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278328 0039d316-1c4b-4281-b951-d872f2087c98

Now the browser will register or unregister a Service Worker only if document url,
scope, and script url have the same origin.

This patch removes TODOs for adding SW to ChildProcessSecurityPolicy, since it
turns out the only security check needed here is the URL origin one. SW is
expected to be enabled always, not a permission granted per-process.

BUG=311631

Review URL: https://codereview.chromium.org/334413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278326 0039d316-1c4b-4281-b951-d872f2087c98

Previously, when the device scale factor >= 1.5, selects the 2x
resource, but then scales it by the DSF. So, for example, at 1.5,
it selects 64x64, and draws it as 96x96 pixels, which causes it to
overlap. Setting the size explicitly seems to fix it, but I'm not
sure if this is the right fix.

R=kalman@chromium.org
BUG=366377
TEST=manual with --force-device-scale-factor={1,1.25,1.5,2}

Review URL: https://codereview.chromium.org/343473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/340523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278324 0039d316-1c4b-4281-b951-d872f2087c98

The approach here is to literally copy most of the logic in VideoSender
over into AudioSender, since VideoSender already solves a number of
transmission/re-transmission issues using heuristics that should work
well for audio.  (This also brings us much closer to being able to merge
AudioSender and VideoSender into one implementation.)

Testing: Confirmed correct halting and recovery behavior between
cast_sender_app and cast_receiver_app (SIGSTOPP'ed and SIGCONT'ed each
to simulate a temporary outage).  Also tested a Chromium sender with a
Chromecast receiver.

BUG=380023

Review URL: https://codereview.chromium.org/340903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242982,382679

Review URL: https://codereview.chromium.org/342743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278322 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278321 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176427:176443&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/343693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278320 0039d316-1c4b-4281-b951-d872f2087c98

+ Minor fixes to using order, comments and chromium indentation nits.
+ Use EXPECT_EQ instead of EXPECT_TRUE.

Merge internal change: 69401047

R=rch@chromium.org,wtc@chromium.org,

Review URL: https://codereview.chromium.org/345453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278319 0039d316-1c4b-4281-b951-d872f2087c98

PTP devices on Windows don't always provide ctime or mtime.

The Nikkon provides ctime only. The Sony provides neither. We shouldn't refuse to use these files just because they lack ctime/mtime.

BUG=381807
TEST=manually verified that this fixed the Nikkon and Sony test cameras on my Windows machine.

Review URL: https://codereview.chromium.org/322333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376900

Review URL: https://codereview.chromium.org/320223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278317 0039d316-1c4b-4281-b951-d872f2087c98

Merge internal change: 69295877

R=rch@chromium.org, rjshade@google.com

Review URL: https://codereview.chromium.org/322333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278316 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 276260 "Win Video Capture: Add support for HDYC pixel for..."
> 
> > Win Video Capture: Add support for HDYC pixel format.
> > 
> > This pixel format is a synonym of YUYV and is needed
> > for at least the DeckLink video capture card.
> > This format is not specified in Windows headers
> > probably because this is just a synonym of other
> > pixel formats, IOW they are all the same except for
> > the first word, which is the name read in hex
> > backwards:
> > 30323449 --> 0x30 0x32 0x34 0x49 -> 024I
> > 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH
> > 
> > and then all the YUV (422 and 420 alike) use the same
> > trailing sequence 
> > ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}}
> > 
> > HDYC: http://www.fourcc.org/yuv.php#HDYC
> > 
> > BUG=380939
> > 
> > Review URL: https://codereview.chromium.org/317073010
> 
> TBR=mcasas@chromium.org
> 
> Review URL: https://codereview.chromium.org/333643009

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/336183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278315 0039d316-1c4b-4281-b951-d872f2087c98

> Win Video Capture: Add support for HDYC pixel format.
> 
> This pixel format is a synonym of YUYV and is needed
> for at least the DeckLink video capture card.
> This format is not specified in Windows headers
> probably because this is just a synonym of other
> pixel formats, IOW they are all the same except for
> the first word, which is the name read in hex
> backwards:
> 30323449 --> 0x30 0x32 0x34 0x49 -> 024I
> 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH
> 
> and then all the YUV (422 and 420 alike) use the same
> trailing sequence 
> ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}}
> 
> HDYC: http://www.fourcc.org/yuv.php#HDYC
> 
> BUG=380939
> 
> Review URL: https://codereview.chromium.org/317073010

TBR=mcasas@chromium.org

Review URL: https://codereview.chromium.org/333643009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278314 0039d316-1c4b-4281-b951-d872f2087c98

embeds. This also adds the 'RequestNavigate' part of the
navigation protocol.

I will rename the mojo_browser target and related names to
mojo_launcher_ui in a separate CL.

This depends on https://codereview.chromium.org/331323007/.

BUG=386275
R=ben@chromium.org

Review URL: https://codereview.chromium.org/342003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278312 0039d316-1c4b-4281-b951-d872f2087c98

Add a service to request & cache images for Answers in Suggest.

This service allows the UI thread to request images that are fetched
via http(s) and then decoded in a render process, caching the most
recent images to avoid repeated network requests.

BUG=380916

Review URL: https://codereview.chromium.org/319623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278311 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a bug where user starts a right click through double tap long press or split tap long press, and places down more fingers, resulting in a no-entry sign over a grey box appearing on the screen that the user cannot leave by clicking.

This was fixed by making sure the release of the long press has the same touch id as the press, where before it was the id final finger to be released.

BUG=385302
TEST=TouchExplorationTest.*

Review URL: https://codereview.chromium.org/334223007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278310 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278309 0039d316-1c4b-4281-b951-d872f2087c98

Changes from r282:

- Add a comma between city and state for US.
- Show only one example postal code in error messages.
- Addresses with Latin script names are now valid.
- Pass UI language to BuildComponents instead of Localization.

TBR=estade@chromium.org
BUG=327046

Review URL: https://codereview.chromium.org/341893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=305852

Review URL: https://codereview.chromium.org/346493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278307 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/343783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278306 0039d316-1c4b-4281-b951-d872f2087c98

On Android < 4.2, the libkeystore.so ENGINE uses CRYPTO_EX_DATA and is not
added to the global engine list. If all references to it are dropped, OpenSSL
will dlclose the module, leaving a dangling function pointer in the RSA
CRYPTO_EX_DATA class. To work around this, leak an extra reference to the
ENGINE we extract in GetRsaLegacyKey.

This is exacerbated by https://codereview.chromium.org/27500004 which, at least
on 4.1.2, causes the session cache and OpenSSLClientKeyStore to get dumped
every time a client auth prompt comes up (https://crbug.com/381912).

In 4.2, this change avoids the problem:
https://android.googlesource.com/platform/libcore/+/106a8928fb4249f2f3d4dba1dddbe73ca5cb3d61

BUG=381465

Review URL: https://codereview.chromium.org/322533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278305 0039d316-1c4b-4281-b951-d872f2087c98

- restructured existing code to allow some tests to run in only normal mode
- added AddBookmark test to check ChromeVox while adding a bookmark
- switched SendKeyPress to SendKeyPressToWindowSync throughout all tests
- reordered expected ChromeVox messages and reenabled TypeInOmnibox test

BUG=None
TEST=this
R=dmazzoni@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/342773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278304 0039d316-1c4b-4281-b951-d872f2087c98

The previous change (https://codereview.chromium.org/332893004/) wasn't quite right. To avoid errors, we need to only fire focus and load events when the web view itself has focus, not say when the location bar has focus. And because there are transient periods when we can't fire events, we need to keep track of whether we need to fire a focus event with a flag and fire it later.

BUG=368549
NOTRY=true

Review URL: https://codereview.chromium.org/344573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307323

This change is linked to https://codereview.chromium.org/300873002/

Review URL: https://codereview.chromium.org/319553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278302 0039d316-1c4b-4281-b951-d872f2087c98

The path to feedback generation scripts has changed. This broke some
feedback reports. This CL updates the command line to generate touch
logs for feedback reports.

BUG=chromium:384454
TEST=file feedback and check submitted system_logs. Don't check
chrome://system, those logs are generated in a different way.

Review URL: https://codereview.chromium.org/335453008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278301 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278300 0039d316-1c4b-4281-b951-d872f2087c98

MSVC lexes L#macro_arg as a single wide string literal after
pre-processing.  Clang and other conforming C preprocessors lex this as
a single 'L' token followed by a normal string literal.  Using
L###macro_arg works with all compilers.  It should be parsed as 'L' '##'
'#' 'macro_arg', where '#' stringizes the macro arg and '##' token
pastes the two tokens together to form a single string literal.

R=dtseng@chromium.org
CC=thakis@chromium.org,hans@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/342773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278299 0039d316-1c4b-4281-b951-d872f2087c98

By advancing to revision 272757, we should be able to pick up the GN
Build file that was added in
https://src.chromium.org/viewvc/chrome?view=revision&revision=272757

BUG=None
TEST=green trybots
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/337113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370567
BUG=327783
R=jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277607

Review URL: https://codereview.chromium.org/321283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278297 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278296 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278295 0039d316-1c4b-4281-b951-d872f2087c98

As of r277056, the gpu memory manager is no longer using
managed memory stats produced. This patch removes the managed
memory stats calculation from the tile manager. As well, this
patch removes ununsed gpu managed memory stats plumbing.

BUG=377065

Review URL: https://codereview.chromium.org/342483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278294 0039d316-1c4b-4281-b951-d872f2087c98

Before, the hash argument was simply ignored and defaulted to SHA-1. Instead it accepts now all values specified by WebCrypto, i.e. SHA-{1,256,384,512}.

BUG=385085

Review URL: https://codereview.chromium.org/331173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386246
TEST=unit_tests

Review URL: https://codereview.chromium.org/340703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278292 0039d316-1c4b-4281-b951-d872f2087c98

(minor pixel diffs due to https://skia.googlesource.com/skia/+/f3b50276a4ad71c9e8ba13d752a5db0c073cae2c)

BUG=379147
TBR=reed@google.com

Review URL: https://codereview.chromium.org/342823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278291 0039d316-1c4b-4281-b951-d872f2087c98

Added a colour to the version number and updated the font size to better
match the mocks. Also fixed a small bug in the logic that lays out the
name and version to place the version number on the next line if there
are no links (no webstore or license links) for the app.

Based off CL 335523002.

BUG=385423, 383720

Review URL: https://codereview.chromium.org/336333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278290 0039d316-1c4b-4281-b951-d872f2087c98