- 10 Nov, 2017 40 commits
-
-
Shivani Sharma authored
Since multiple transactions can now be added to Writers, those transactions will have a WRITE bit set. Thus remove the DCHECKS that assume otherwise in HttpCache::DoneWithResponseHeaders. Bug: 750725 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I791177522956ca23d6702254bbf7ee0b25c83bdf Reviewed-on: https://chromium-review.googlesource.com/760540Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#515459}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14592920..c8bfcb14 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic25a1925dc5146416f56a0af3b0e4771620d8384 Reviewed-on: https://chromium-review.googlesource.com/762576Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515458}
-
Luciano Pacheco authored
Add named arguments to "bool" arguments with default values for readability, as identified by the following command: $ git ls-files | grep -E '*\.(h)$' | xargs egrep --color \ "bool = (false|true)" Also update the unnamed double argument in the transform include file, IdentityTransformOperation.h Bug: 781101 Change-Id: I7cd541b1329063805c60b3ee86247d494f8793b4 Reviewed-on: https://chromium-review.googlesource.com/759272Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#515457}
-
Lily Houghton authored
This adds a CronetMetricsDelegate interface, as well as addMetricsDelegate and removeMetricsDelegate methods, which are used to register/unregister metrics callbacks. Currently the callback is never actually called; this is simply defining the interface and registration methods. Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0a3933bf623265d675e3a10ef5ed25149c89e101 Reviewed-on: https://chromium-review.googlesource.com/748819 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515456}
-
Yoshifumi Inoue authored
This patch makes |SelectionModifier| constructors to take |SelectionInDOMTree| instead of |VisibleSelection| since constructors don't need to take |VisibleSelection|, to reduce usage usage of |VisibleSelection| for improving code health. Bug: 657237 Change-Id: Ibe8989566d23530b13bd50d9365da2339051f571 Reviewed-on: https://chromium-review.googlesource.com/760062Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515455}
-
Yuichiro Hanada authored
The cause of the failure was fixed in crrev.com/c/645586. Bug:515596 Test: Run the test 100 times on local machine Change-Id: I64c613b23f3147f5c8cdb69f9c23adb1cb7bff21 Reviewed-on: https://chromium-review.googlesource.com/667556 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#515454}
-
Kunihiko Sakamoto authored
This fixes a bug where @font-face with font-display: optional causes unnecessary font downloads of subsequent sources when the first source fails to download by the "short time limit" (100ms). Bug: 770978 Change-Id: I24ad7c803d04b9eb310b6b916c999660a23c61b5 Reviewed-on: https://chromium-review.googlesource.com/760137Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515453}
-
Stuart Langley authored
This patch removes the hand crafted implementation of WTF type traits with the versions now available in the std:: type_traits library. The first patch will have the WTF versions use the std:: implementation, a followup patch will remove the WTF versions entirely. This patch replaces the implementations of -> with: WTF::IsCopyAssignable -> std::is_copy_assignable WTF::IsMoveAssignable -> std::is_move_assignable WTF::IsTriviallyCopyAssignable -> std::is_trivially_copy_assignable WTF::IsTriviallyMoveAssignable* -> std::is_trivially_move_assignable WTF::IsDestructible -> std::is_destructible WTF::IsTriviallyDefaultConstructible -> std::is_trivially_default_constructible Bug: 579462 Change-Id: I4ac335929e298f8b28a23021fef8e58ae855f3c6 Reviewed-on: https://chromium-review.googlesource.com/756258 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515452}
-
Joel Hockey authored
Fixes ICU flush and pivot buffer causing fuzzing error. BUILD.gn updated to not set WIN32_LEAN_AND_MEAN which is defined in libxml. Bug: 722420 Change-Id: Ib4ff2f870f99fb78e02f9841e33f6ad7e72e059e Reviewed-on: https://chromium-review.googlesource.com/759919 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515451}
-
Findit authored
This reverts commit c4ea951f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 515427 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZWE5NTFmMzZlYTFjMTk2MGQ1Njk0OTQyZGE5OWMzN2M2ODE3YWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Mac/34475 Original change's description: > Serialize more of message_center::Notification for mojo. > > Adds NotificationType and (partial) RichNotificationData. Now you can > see progress bars in download item notifications on Chrome OS when > using --enable-features=NativeNotifications > > Bug: 578868 > Change-Id: I781c10387479ed921f0a7b4efce262b18f04844f > Reviewed-on: https://chromium-review.googlesource.com/755317 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515427} Change-Id: I3eac7eb2400781c22fd59c8f6eb7fc2cdd80e1b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868 Reviewed-on: https://chromium-review.googlesource.com/762881 Cr-Commit-Position: refs/heads/master@{#515450}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I4ed482399911f51506d9aea50fbad090c4c22b18 Reviewed-on: https://chromium-review.googlesource.com/762987Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515449}
-
Tatsuhisa Yamaguchi authored
This is a preparation before enabling the feature by default. Bug: 780688 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4a1bf78085f24289a9e2c8955815ebc6752d95ff Reviewed-on: https://chromium-review.googlesource.com/758279Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515448}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/9e888a46f04d..ee6884e7be66 $ git log 9e888a46f..ee6884e7b --date=short --no-merges --format='%ad %ae %s' 2017-11-09 geofflang Generate generic error messages for Error objects without messages. Created with: roll-dep src/third_party/angle BUG=783054 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I73a79aab393f4a52c030dde8fb945571e3758f47 Reviewed-on: https://chromium-review.googlesource.com/762519Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515447}
-
Kyle Horimoto authored
This CL changes icons such that: (1) If no networks exist for the network type, a light-grey "0-bar" icon is displayed. (2) If at least one network exists for the network type but none of them are connected, a light-grey icon with an X is displayed. (3) If the network type is disabled, a darker strikethrough icon is displayed. (4) If a network is connecting, the icon is animated. (5) If a network is connected, an icon displaying the signal strength is displayed. Bug: 764110, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie433e21017bda469da81f7a297f08cf3cd515fd6 Reviewed-on: https://chromium-review.googlesource.com/762598Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515446}
-
Matt Menke authored
Also convert ChromeMojoProxyResolverFactory to a ProxyResolverFactory. The class now relies on the the proxy service to manage its own lifetime, instead of expecting to be responsible for managing that itself. Bug: 754007 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifab3624ea083b4e1e00beaa66e274ab8d0656496 Reviewed-on: https://chromium-review.googlesource.com/660723Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515445}
-
Lily Houghton authored
[Cronet] Define CronetMetrics class implementing the iOS NSURLSessionTaskTransactionMetrics interface This creates a class |CronetMetrics| which provides setters for all of the propeties defined in NSURLSessionTaskTransactionMetrics. Bug: 702796 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icdcc917001c0ceb20107e2f128dba88259330f78 Reviewed-on: https://chromium-review.googlesource.com/744401 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#515444}
-
Patti authored
Extract the BackgroundColorHoverButton from the ProfileChooserView and turn it into a standalone View which is compliant with the Harmony spec. This prepares the HoverButton to be used in the Harmony Page Info bubble view. Notable changes include the blue background changing to a gray one, and some padding changes. Screenshot - https://drive.google.com/open?id=1z97-fEe9LTw0BCBpIMZj9-ft34UYXMGa Bug: 535074 Change-Id: Idd964d17868a7057d5c18b1b96c6d150b7a6d866 Reviewed-on: https://chromium-review.googlesource.com/730031 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515443}
-
Gregory Chatzinoff authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I11e058b4dbb86a547ffbb7d96fd5c11286ec80d2 Reviewed-on: https://chromium-review.googlesource.com/759141Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515442}
-
Jay Civelli authored
Making the SafeArchiveAnalyzer interface part of the Chrome file_util service. Moving the associated calling classes, SandboxedZipAnalyzer and SandboxedDmgAnalyzer to chrome/services/file_util/public/cpp, making them the client library to the service. The unit-tests have been moved as well. Bug: 781072 Change-Id: I2947ca13742baef85ab4f9d539f743ea427c883e Reviewed-on: https://chromium-review.googlesource.com/752555 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#515441}
-
Shivani Sharma authored
Bug: 472740 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I959c0e461b1388ab3d812569ca90be3b68571098 Reviewed-on: https://chromium-review.googlesource.com/738531 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515440}
-
Daniel Cheng authored
Bug: 780139 Change-Id: Ie67187ba0ee59a87a50dd18df36e5ae38082184f Reviewed-on: https://chromium-review.googlesource.com/755526Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#515439}
-
Darren Shen authored
This patch adds some tests for serialization of style values constructed from the IDL. Tests for the following classes were added: - CSSKeywordValue - CSSUnitValue - CSSPositionValue There's currently three types of serialization [1]. We are testing the second case ("the value was constructed using an IDL constructor"). Along with testing the IDL constructor, we also test what happens when we obtain a CSSStyleValue from a DOMString or CSSOM (case 1 and 3) and modify it using IDL setters. Currently our code will trivially pass this test, but it'll be harder when we implement all three serialization types, as the style value needs to remember whether which case it belongs to. There's a failing test due to the fact that we haven't implemented normalization of <position> values. Bug: 782103, 774887 Change-Id: I4a379dcb51ea718642e6889f9c0b63bf0bc7d60c Reviewed-on: https://chromium-review.googlesource.com/759407Reviewed-by:nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515438}
-
Tom Anderson authored
BUG=782028 R=sky@chromium.org Change-Id: Idc91012a8cd8d851f85d6c45d81677354f05364e Reviewed-on: https://chromium-review.googlesource.com/759100 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Weidong Guo authored
Changes: Remove the Caps Lock modifier for key event when Caps Lock key is remapped to another key. BUG=782572 TEST=EventRewriterTest.TestRewriteCapsLock Change-Id: I561931034acb94719750f9c70f7b8feb6cee5219 Reviewed-on: https://chromium-review.googlesource.com/759816Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515436}
-
Joel Einbinder authored
These were accidentally removed in crrev.com/512716 and broke C++ syntax highlighting. Change-Id: Ic86ad294792aa2b1f11c5e40812ebefd07f3b6de Reviewed-on: https://chromium-review.googlesource.com/762103Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515435}
-
Brett Wilson authored
Creates a new view for rendering the experimental tab strip and tabs. The experimental tabs use rendering code copied from the regular tab strip. Currently it's pretty broken but new tabs do show up and the title updates. No mouse events are supported. This is really a skeleton for future additions. Minor C++11 improvements to TabStripImpl. Also fixes a model dialog initialization crash with the experimental tab strip. Bug: 778461, 780932 Change-Id: Icba2048e8f5abb3b10907456d7f093e4074a8cad Reviewed-on: https://chromium-review.googlesource.com/755623Reviewed-by:
-
Chris Mumford authored
Instead of moving std::unique_ptr<std::vector<ServiceWorkerResponse>> am now moving std::vector<ServiceWorkerResponse>. This reduces heap use and fragmentation. Bug: None Change-Id: Ia0ee309eecd6d5603bd3b5bdf6a522b0b74d6d1a Reviewed-on: https://chromium-review.googlesource.com/762076Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#515433}
-
Xianzhu Wang authored
In the following case: Parent layer paint chunk property scope Parent layer background <-- chunk1 Negative z-index layers Child layer paint chunk property scope <-- chunk2 ... Parent layer foreground <-- chunk3 ... previously chunk3 didn't have an Id because of no dedicated paint chunk property scope associated with it. We couldn't use chunk1's id because that would cause duplicated ids for chunk1 and chunk3. For the case we used the id of the first display item in the chunk as the chunk id. This caused unnecessary full layer raster invalidation for some layout tests e.g paint/invalidation/css-grid-layout/grid-item-z-index-change-repaint.html, before repaintTest, there is only one chunk for HTML. Then a layer gets a negative z-index, causing a no-id chunk after the negative z-index layer chunk. PaintController sees that the HTML chunk disappeared, and a no-id chunk appeared, and invalidates the whole HTML layer. Actually the no-id chunk contains most of the content of the original HTML layer, and we just need to invalidate the changed part. Now always give chunk1 and chunk3 dedicated chunks with meaningful ids. In the top example, now we give chunk1 Id(layer, kLayerChunkBackground) and chunk3 Id(layer, kLayerChunkForeground). Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic1a304b84a007d86a8f3e4d48a2bd45b98c05879 Reviewed-on: https://chromium-review.googlesource.com/756339Reviewed-by:Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515432}
-
chrome://interventions-internalsThanh Le authored
Since the log type already indicate whether the message is a navigation or a decision made, there is no need to put that in the description. Bug: 764419 Change-Id: I869173fb7c14a98de633bf006754819e350ebbc5 Reviewed-on: https://chromium-review.googlesource.com/762406Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#515431}
-
Yafei Duan authored
This CL is the fourth CL of implementing OfflinePageModelTaskified. It contains: - DeletePages* workflow. - Related tests for DeletePages* workflow. Bug: 753595 Change-Id: If1993639be0986ede3aab2e4b9868cfe0b773a84 Reviewed-on: https://chromium-review.googlesource.com/756094 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#515430}
-
shinyak authored
I've converted CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging, and CrWin7Goma(clbr) to CrWinClexeGoma. So, CrWinGomaGCEStaging and CrWin7Goma(clbr) are not necessary any more. Let me remove them. Bug: 777705 Change-Id: Icf23e23d01a4d1f7c4d0f96d0fef99aa5f4680c6 Reviewed-on: https://chromium-review.googlesource.com/760099Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#515429}
-
Fumitoshi Ukai authored
GomaCanaryiOS matches with chromium.mac/ios-device with clobber: true, user_goma_canary: true % diff -u chromium.mac/ios-device.json chromium.fyi/GomaCanaryiOS.json --- chromium.mac/ios-device.json 2017-11-10 10:51:06.406179023 +0900 +++ chromium.fyi/GomaCanaryiOS.json 2017-11-10 10:50:47.689907892 +0900 @@ -1,8 +1,7 @@ { "comments": [ - "Builder for 32-bit devices.", - "Build is performed with gn+ninja.", - "If modified, please change chromium.fyi/GomaCanaryiOS.json too." + "Goma canary builder for iOS.", + "It is chromium.mac/ios-device.json + use_goma_canary, clobber." ], "xcode version": "9.0", "gn_args": [ @@ -22,5 +21,7 @@ "explain": true, "sdk": "iphoneos11.0", "tests": [ - ] + ], + "clobber": true, + "use_goma_canary": true } Bug: 740416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4f98630eec51455cf28538e0f4c9e85261111e83 Reviewed-on: https://chromium-review.googlesource.com/759703 Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#515428}
-
Evan Stade authored
Adds NotificationType and (partial) RichNotificationData. Now you can see progress bars in download item notifications on Chrome OS when using --enable-features=NativeNotifications Bug: 578868 Change-Id: I781c10387479ed921f0a7b4efce262b18f04844f Reviewed-on: https://chromium-review.googlesource.com/755317Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Eddy Mead authored
This may allow us to speed up compilation by removing includes of ComputedStyle in some places. Gist diff: https://gist.github.com/wilddamon/56eb08d2493db7d67bed9c7fa728ed1f/revisions ComputedStyleBase by itself: https://www.diffchecker.com/lR5pzim1 StyleBuilderFunctions by itself https://www.diffchecker.com/B3XLnnLr Bug: 763306 Change-Id: Ie302c6a3aab4a75cc8fe9385b2dea8c053b22f2a Reviewed-on: https://chromium-review.googlesource.com/714896 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#515426}
-
Benjamin C. Wiley Sittler authored
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星
🌟 星★•¤~XYZ Old output: Bytes: ABC~¤•␛$B!z@1🌟@1!z•¤␛(B~XYZ Meaning: ABC~¤•★星Γ渦祁卦酸院惕８臆胸Γ蔚柑~XYZ New output: Bytes: ABC~¤•␛$B!z@1␛(B🌟␛$B@1!z␛(B•¤~XYZ Meaning: ABC~¤•★星🌟星★•¤~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581 Reviewed-on: https://chromium-review.googlesource.com/758405 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by:Jungshik Shin <jungshik@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515425}
-
dpapad authored
FocusOutlineManager previously deferred updating the focus-outline-visible CSS class until a 'focus' event was received. This does not work in Shadow DOM, since 'focus' events do not reach the top level document element. Updating focus-outline-visible CSS class when a mouse or keyboard event occurs fixes the issue. Note: This slightly changes the behavior of FocusOutlineManager when 1) an element is focused by keyboard 2) while the element is focused the user clicks on it. Before, the focus outline would remain visible (introduced at crrev.com/22521002/). After, clicking on an element that already shows the outline will remove the outline. Bug: 772571,781459 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie233c212fd17724ca8a43e46eb51398612644331 Reviewed-on: https://chromium-review.googlesource.com/749887 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515424}
-
Xianzhu Wang authored
The code for these logs is compiled when DCHECK is on. The logs can be controlled using the --vmodule command line. Sample usage: out/Debug/content_shell --vmodule="*/paint/*=2,*/graphics/*=3" Details of modules and levels: - Module "*/paint/*" (matching core/paint and platform/graphics/paint) =1: paint property trees =2: =1 plus paint layer trees paint controller debug data without paint records (also for "*/graphics/*") =3: =2 plus (debug build only) paint controller debug data with paint records (also for "*/graphics/*") (debug build only) layout trees - Module "*/graphics/*" (matching platform/graphics) =2: graphics layer trees (spv1*) or composited layers (spv175+) with less verbosity =3: =2 trees with full verbosity and paint controller debug data as described in "*/paint/*" Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I71039a295d699f42d3a8e3ddcabd1ef05ce5af67 Reviewed-on: https://chromium-review.googlesource.com/754997 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#515423}
-
Misha Efimov authored
Bug: 775564 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia042509d3686d501f2b459c1fe03956422b5af4a Reviewed-on: https://chromium-review.googlesource.com/760487 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
-
Qiang Xu authored
changes: - Move accessibility_types.h to ash/public/cpp/ since it is used in both ash/ and chrome/. - Move kMagnificationScaleFactor to ash::MagnificationController. Majorly done by tools/git/move_source_file.py Bug: 618070 Test: still compiles Change-Id: Id8e641cc34d22395d12755df3ef372eb53187254 Reviewed-on: https://chromium-review.googlesource.com/761337 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
-
Johann authored
Update scripts and build files for avx512 but disable it by default. Windows support is incomplete. Change-Id: I2a1b52651f205a88100302262f5d6aba540a3754 Reviewed-on: https://chromium-review.googlesource.com/758802 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515420}
-
