1. 28 Mar, 2011 40 commits
    • mitz@apple.com's avatar
      <rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes · 128a4df4
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57197
      
      Reviewed by Maciej Stachowiak.
      
      Source/WebCore: 
      
      Tests: fast/repaint/overflow-flipped-writing-mode-block.html
             fast/repaint/overflow-flipped-writing-mode-table.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
      with the damage rect.
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::paint): Made the intersection check more like the one in
      RenderBlock::paint().
      
      LayoutTests: 
      
      * fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
      * fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
      * fast/repaint/overflow-flipped-writing-mode-block-expected.txt: Added.
      * fast/repaint/overflow-flipped-writing-mode-block.html: Added.
      * fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
      * fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
      * fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
      * fast/repaint/overflow-flipped-writing-mode-table.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82123 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      128a4df4
    • sergio@webkit.org's avatar
      2011-03-28 Sergio Villar Senin <svillar@igalia.com> · 5c19a64c
      sergio@webkit.org authored
              Unreviewed, rebaseline GTK+ test results.
      
              * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
              * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
              * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5c19a64c
    • xji@chromium.org's avatar
      2011-03-28 Xiaomei Ji <xji@chromium.org> · 8943635a
      xji@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              move directionOfEnclosingBlock() to be global so that it could be reused.
              https://bugs.webkit.org/show_bug.cgi?id=57233.
      
              Provide global function directionOfEnclosingBlock(Node*) so that it could be
              reused in SelectionController and other functionalities that need enclosing
              block's direcionality, such as moving caret by word in visual order.
            
              No new functionality, so no new tests.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::directionOfEnclosingBlock):
              * editing/htmlediting.cpp:
              (WebCore::directionOfEnclosingBlock):
              * editing/htmlediting.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82121 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8943635a
    • darin@apple.com's avatar
      Set eol-style to native on more files. I noticed the last check-in had an entire file · 5bd251c0
      darin@apple.com authored
      changing because of an EOL style change, and setting this property prevents that from
      happening in future. We may want to do this systematically for more of WebKit later.
      
      * AccessibleBase.cpp: Added property svn:eol-style.
      * AccessibleBase.h: Added property svn:eol-style.
      * AccessibleDocument.cpp: Added property svn:eol-style.
      * AccessibleDocument.h: Added property svn:eol-style.
      * AccessibleImage.cpp: Added property svn:eol-style.
      * AccessibleImage.h: Added property svn:eol-style.
      * COMVariantSetter.h: Added property svn:eol-style.
      * FullscreenVideoController.cpp: Added property svn:eol-style.
      * FullscreenVideoController.h: Added property svn:eol-style.
      * WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
      * WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
      * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
      * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
      * WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
      * WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
      * WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
      * WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
      * WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
      * WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
      * WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5bd251c0
    • jberlin@webkit.org's avatar
      http/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard · c8fb79dd
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57236
      
      Unreviewed, skip the flakey test in order to get the bots green.
      
      * platform/mac-snowleopard/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c8fb79dd
    • sergio@webkit.org's avatar
      2011-03-28 Sergio Villar Senin <svillar@igalia.com> · 5ea3de06
      sergio@webkit.org authored
              Unreviewed, update pixel test expectations after r82105.
      
              * platform/gtk/fast/css/text-align-expected.checksum:
              * platform/gtk/fast/css/text-align-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82118 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5ea3de06
    • commit-queue@webkit.org's avatar
      2011-03-28 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com> · e614ab68
      commit-queue@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
              https://bugs.webkit.org/show_bug.cgi?id=56825
      
              Fixes for context attribute handling:
              - Initialize depth and stencil buffer depending on whether they
              are enabled in context attributes.
              - Always enable depth buffer when stencil buffer is enabled.
              - Disable stencil buffer on OpenGL ES 2.0
              - Cleaned up clutter code from initialization. Made code paths
              more sane.
              - Clear mask is now set correctly in reshape().
      
              Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
      
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3DInternal::isValid):
              (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
              (WebCore::GraphicsContext3DInternal::reshape):
              (WebCore::GraphicsContext3DInternal::paint):
              (WebCore::GraphicsContext3DInternal::getProcAddress):
              (WebCore::GraphicsContext3D::GraphicsContext3D):
              (WebCore::GraphicsContext3D::reshape):
              (WebCore::GraphicsContext3D::bindFramebuffer):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82117 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e614ab68
    • rniwa@webkit.org's avatar
      2011-03-28 Ryosuke Niwa <rniwa@webkit.org> · e58dc0cd
      rniwa@webkit.org authored
              [Chromium] [Mac Leopard] Update test expectations after r82105.
      
              * platform/chromium-linux/fast/css/text-align-expected.checksum:
              * platform/chromium-linux/fast/css/text-align-expected.png:
              * platform/chromium-win/fast/css/text-align-expected.checksum:
              * platform/chromium-win/fast/css/text-align-expected.png:
              * platform/chromium-win/fast/css/text-align-expected.txt:
              * platform/mac-leopard/fast/css/text-align-expected.checksum:
              * platform/mac-leopard/fast/css/text-align-expected.png:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e58dc0cd
    • abecsi@webkit.org's avatar
      2011-03-28 Andras Becsi <abecsi@webkit.org> · 17bd2de3
      abecsi@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt] QtWebKit does not link with --3d-canvas using MinGW
              https://bugs.webkit.org/show_bug.cgi?id=57225
      
              * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      17bd2de3
    • jeffm@apple.com's avatar
      Remove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now. · bd4912dc
      jeffm@apple.com authored
      Rubber-stamped by Adam Roben.
      
      * win/lib/WebKitSystemInterface_debug.lib: Removed.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bd4912dc
    • ossy@webkit.org's avatar
      REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile. · 50386c37
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57183
      
      Reviewed by Andreas Kling.
      
      Windows buildfix after r82065.
      
      * Api/DerivedSources.pro: Readding escaping on Windows platforms.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      50386c37
    • rniwa@webkit.org's avatar
      2011-03-28 Ryosuke Niwa <rniwa@webkit.org> · 67f1de1e
      rniwa@webkit.org authored
              [GTK] Update text expectations after r82105.
      
              * platform/gtk/fast/css/text-align-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      67f1de1e
    • pfeldman@chromium.org's avatar
      2011-03-28 Pavel Feldman <pfeldman@chromium.org> · ca492863
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
              https://bugs.webkit.org/show_bug.cgi?id=57226
      
              * inspector/Inspector.json:
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::willSendRequest):
              (WebCore::InspectorResourceAgent::markResourceAsCached):
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveContentLength):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::didFailLoading):
              (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
              (WebCore::InspectorResourceAgent::setInitialContent):
              (WebCore::InspectorResourceAgent::didCommitLoad):
              (WebCore::InspectorResourceAgent::frameDetachedFromParent):
              (WebCore::InspectorResourceAgent::didCreateWebSocket):
              (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorResourceAgent::didCloseWebSocket):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
              (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
              (WebInspector.NetworkDispatcher.prototype.responseReceived):
              (WebInspector.NetworkDispatcher.prototype.dataReceived):
              (WebInspector.NetworkDispatcher.prototype.loadingFinished):
              (WebInspector.NetworkDispatcher.prototype.loadingFailed):
              (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
              (WebInspector.NetworkDispatcher.prototype.frameDetached):
              (WebInspector.NetworkDispatcher.prototype.initialContentSet):
              (WebInspector.NetworkDispatcher.prototype.frameNavigated):
              (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
              (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
              (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
              (WebInspector.NetworkDispatcher.prototype.webSocketClosed):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ca492863
    • ossy@webkit.org's avatar
      [Qt] Update expectations after r82105. · 2bbe7588
      ossy@webkit.org authored
      * platform/qt/fast/css/text-align-expected.checksum:
      * platform/qt/fast/css/text-align-expected.png:
      * platform/qt/fast/css/text-align-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82110 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2bbe7588
    • andreas.kling@nokia.com's avatar
      2011-03-28 Andreas Kling <kling@webkit.org> · 1daff464
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
              https://bugs.webkit.org/show_bug.cgi?id=57224
      
              * QtTestBrowser/mainwindow.cpp:
              (MainWindow::buildUI):
              (MainWindow::onTitleChanged):
              * QtTestBrowser/mainwindow.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1daff464
    • mnaganov@chromium.org's avatar
      2011-03-28 Mikhail Naganov <mnaganov@chromium.org> · ec3754c7
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal.
              https://bugs.webkit.org/show_bug.cgi?id=57099
      
              * bindings/v8/ScriptHeapSnapshot.cpp:
              (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
              * bindings/v8/ScriptHeapSnapshot.h:
              * bindings/v8/ScriptProfile.cpp:
              (WebCore::ScriptProfile::~ScriptProfile):
              * bindings/v8/ScriptProfile.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ec3754c7
    • podivilov@chromium.org's avatar
      2011-03-24 Pavel Podivilov <podivilov@chromium.org> · 873ed7da
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix console messages positions in formatted scripts.
              https://bugs.webkit.org/show_bug.cgi?id=57010
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
              (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestMapping):
              (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
              (WebInspector.DebuggerPresentationModel.prototype.clearConsoleMessages):
              (WebInspector.DebuggerPresentationModel.prototype._reset):
              * inspector/front-end/ResourceTreeModel.js:
              (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
              (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
              (WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceFile):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype.addMessage):
              (WebInspector.SourceFrame.prototype._addExistingMessagesToSource):
              (WebInspector.SourceFrame.prototype.addMessageToSource):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      873ed7da
    • pfeldman@chromium.org's avatar
      2011-03-27 Pavel Feldman <pfeldman@chromium.org> · bde4571f
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=57186
      
              * http/tests/inspector/console-resource-errors-expected.txt:
              * http/tests/inspector/console-resource-errors.html:
              * http/tests/inspector/resources/console-resource-errors-iframe.html: Added.
              * inspector/report-protocol-errors.html:
              * inspector/storage-panel-dom-storage.html:
      2011-03-27  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
              https://bugs.webkit.org/show_bug.cgi?id=57186
      
              - ResourceTreeModel is now event target (Object)
              - There is no ResourceTreeModel -> UI dependencies
              - NetworkManager -> ResourceTreeModel dependencies has been removed
              - NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
              - ResourceTreeModel requests tree structure from the backend separately
              - Cached resources tree payload is now limited to url and type (no headers involved)
              - Resources tree is being rendered lazily upon request from the panel.
      
              * inspector/Inspector.json:
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::resourceContent):
              (WebCore::InspectorResourceAgent::resourceContentBase64):
              (WebCore::buildObjectForFrameTree):
              (WebCore::InspectorResourceAgent::enable):
              (WebCore::InspectorResourceAgent::getCachedResources):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/InspectorStyleSheet.cpp:
              (WebCore::InspectorStyleSheet::resourceStyleSheetText):
              * inspector/front-end/InspectorFrontendHostStub.js:
              (.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
              (.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkManager):
              (WebInspector.NetworkManager.prototype.frontendReused):
              (WebInspector.NetworkManager.prototype.requestContent):
              (WebInspector.NetworkDispatcher):
              (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
              (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
              (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent):
              (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkPanel):
              (WebInspector.NetworkPanel.prototype._updateSummaryBar):
              (WebInspector.NetworkPanel.prototype._onFrameCommitLoad):
              * inspector/front-end/ResourceTreeModel.js:
              (WebInspector.ResourceTreeModel):
              (WebInspector.ResourceTreeModel.prototype.frontendReused):
              (WebInspector.ResourceTreeModel.prototype._processCachedResources):
              (WebInspector.ResourceTreeModel.prototype._addOrUpdateFrame):
              (WebInspector.ResourceTreeModel.prototype.frames):
              (WebInspector.ResourceTreeModel.prototype.subframes):
              (WebInspector.ResourceTreeModel.prototype.resources):
              (WebInspector.ResourceTreeModel.prototype._onCommitLoad):
              (WebInspector.ResourceTreeModel.prototype._onFrameDetachedFromParent):
              (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
              (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
              (WebInspector.ResourceTreeModel.prototype.resourceForURL):
              (WebInspector.ResourceTreeModel.prototype._bindResourceURL):
              (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
              (WebInspector.ResourceTreeModel.prototype._clearResources):
              (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
              (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
              (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
              (WebInspector.ResourceTreeModel.prototype._createResource):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel):
              (WebInspector.ResourcesPanel.prototype.show):
              (WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
              (WebInspector.ResourcesPanel.prototype._populateResourceTree):
              (WebInspector.ResourcesPanel.prototype._frameAdded):
              (WebInspector.ResourcesPanel.prototype._frameDetached):
              (WebInspector.ResourcesPanel.prototype._resourceAdded):
              (WebInspector.ResourcesPanel.prototype._frameNavigated):
              (WebInspector.FrameTreeElement.prototype.setTitles):
              * inspector/front-end/inspector.js:
              (WebInspector.frontendReused):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bde4571f
    • rniwa@webkit.org's avatar
      2011-03-27 Ryosuke Niwa <rniwa@webkit.org> · 832d7fde
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              WebKit's behavior for text-align inherit differs from other browsers
              https://bugs.webkit.org/show_bug.cgi?id=56377
      
              The bug was caused by WebKit's resolving text-align: start and text-align: end too early.
              As discussed on the bug, when text-align: start and text-align: end are inherited by descendent nodes,
              the alignment of the text in those nodes should be determined based on the directionality of the text,
              not by the directionality of the ancestor node from which text-align property is inherited.
      
              Fixed the bug by introducing new enum values to ETextAlign: TASTART and TAEND. These two values will
              align text to the left in a LTR context and to the right in a RTL context respectively.
      
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added the support for TASTART and TAEND.
              (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): No longer processes CSSValueStart and CSSValueEnd.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::localCaretRect): Added the support for TASTART and TAEND.
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added the support for TASTART and TAEND.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::localCaretRect): Ditto.
              * rendering/style/RenderStyle.h: ETextAlign now has 10 values and requires 4 bits.
              * rendering/style/RenderStyleConstants.h: Added TASTART and TAEND to ETextAlign.
      2011-03-27  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              WebKit's behavior for text-align inherit differs from other browsers
              https://bugs.webkit.org/show_bug.cgi?id=56377
      
              Added test more cases to text-align, which already has some tests for text-align: start and text-align: end.
      
              * fast/css/text-align-expected.txt:
              * fast/css/text-align.html:
              * platform/mac/fast/css/text-align-expected.checksum:
              * platform/mac/fast/css/text-align-expected.png:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      832d7fde
    • abecsi@webkit.org's avatar
      2011-03-28 Andras Becsi <abecsi@webkit.org> · 4cd1e4ec
      abecsi@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt] Fix the linking of jsc with MinGW after r81963.
      
              * jsc.pro: add -l and remove the lib suffix.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4cd1e4ec
    • podivilov@chromium.org's avatar
      2011-03-28 Pavel Podivilov <podivilov@chromium.org> · b0fe44bc
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix breakpoints positions in formatted scripts.
              https://bugs.webkit.org/show_bug.cgi?id=56931
      
              Add async requestMapping method to SourceFile interface as required for populating
              breakpoints sidebar pane when in "format all scripts" mode.
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
              (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
              (WebInspector.PresentationBreakpoint): Breakpoint wrapper for UI.
              (WebInspector.PresentationBreakpoint.prototype.get sourceFileId):
              (WebInspector.PresentationBreakpoint.prototype.get lineNumber):
              (WebInspector.PresentationBreakpoint.prototype.get condition):
              (WebInspector.PresentationBreakpoint.prototype.get enabled):
              (WebInspector.PresentationBreakpoint.prototype.get url):
              (WebInspector.PresentationBreakpoint.prototype.get resolved):
              (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
              * inspector/front-end/ScriptFormatter.js:
              (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
              (WebInspector.ScriptFormatter.prototype.formatContent):
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceFile.prototype.requestSourceMapping):
              (WebInspector.FormattedSourceFile.prototype.requestSourceMapping):
              (WebInspector.FormattedSourceFile.prototype._didRequestContent):
              (WebInspector.SourceMapping):
              (WebInspector.SourceMapping.prototype.scriptLocationToSourceLocation):
              (WebInspector.SourceMapping.prototype.sourceLocationToScriptLocation):
              (WebInspector.FormattedSourceMapping):
              (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLocation):
              (WebInspector.FormattedSourceMapping.prototype.sourceLocationToScriptLocation):
              (WebInspector.FormattedSourceMapping.prototype._convertPosition):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b0fe44bc
    • ossy@webkit.org's avatar
      This patch fixes linking errors on Qt Webkit Windows MinGW builds. · 1fe3f5da
      ossy@webkit.org authored
      This patch sets the BUILDING_WEBKIT & QT_MAKEDLL macros so that
      QWEBKIT_EXPORT is defined as follows:
      
      Patch by Nancy Piedra <nancy.piedra@nokia.com> on 2011-03-28
      Reviewed by Csaba Osztrogonác.
      
      No new tests needed since only changing .pro file.
      
      * WebCore.pro:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1fe3f5da
    • paroga@webkit.org's avatar
      2011-03-28 Patrick Gansterer <paroga@webkit.org> · 07023e63
      paroga@webkit.org authored
              Unreviewed build fix.
      
              * COMPropertyBag.h: Added missing include.
              * WebKitCOMAPI.h: Ditto.
              * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82101 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      07023e63
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · 3c8297bb
      yutak@chromium.org authored
              Unreviewed. Yet another test result fix for fast/blockflow/fallback-orientation-expected.html.
      
              * platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82100 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c8297bb
    • podivilov@chromium.org's avatar
      2011-03-28 Andrey Adaikin <aandrey@google.com> · 4426288a
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: source frame should show the error to user when live edit is failed
              https://bugs.webkit.org/show_bug.cgi?id=57002
      
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._handleSave.didSaveScriptSource):
              (WebInspector.SourceFrame.prototype._handleSave):
              (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82099 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4426288a
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · eb7ffef4
      yutak@chromium.org authored
              Unreviewed, add Chromium test expectation for inspector/debugger/debugger-activation-crash.html.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      eb7ffef4
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · 6a959d02
      yutak@chromium.org authored
              Unreviewed, move Chromium test results into the right directory (move WinXP
              baseline into chromium-win-xp).
      
              * platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum.
              * platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.png.
              * platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82097 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6a959d02
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · b8673517
      yutak@chromium.org authored
              Unreviewed, add new Chromium test results and expectation.
      
              * platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum: Added.
              * platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82096 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b8673517
    • mario@webkit.org's avatar
      2011-03-26 Mario Sanchez Prada <msanchez@igalia.com> · f80168a6
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Expose the AtkValue interface for WAI-ARIA sliders
              https://bugs.webkit.org/show_bug.cgi?id=56655
      
              New test to check WAI-ARIA sliders required attributes.
      
              * platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Added.
              * platform/gtk/accessibility/aria-slider-required-attributes.html: Added.
      2011-03-26  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Expose the AtkValue interface for WAI-ARIA sliders
              https://bugs.webkit.org/show_bug.cgi?id=56655
      
              Implement AtkValue interface for WAI-ARIA sliders.
      
              Test: platform/gtk/accessibility/aria-slider-required-attributes.html
      
              * accessibility/gtk/AXObjectCacheAtk.cpp:
              (WebCore::AXObjectCache::postPlatformNotification): Emit the
              'property-change::accessible-value' signal when needed.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (core): New, returns a core object from an AtkValue.
              (webkitAccessibleValueGetCurrentValue): New, implements AtkValue.
              (webkitAccessibleValueGetMaximumValue): Ditto.
              (webkitAccessibleValueGetMinimumValue): Ditto.
              (webkitAccessibleValueSetCurrentValue): Ditto.
              (webkitAccessibleValueGetMinimumIncrement): Ditto.
              (atkValueInterfaceInit): Ditto.
              (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_VALUE.
              (getInterfaceMaskFromObject): Set the WAI_VALUE bit for sliders.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82095 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f80168a6
    • sergio@webkit.org's avatar
      2011-03-28 Sergio Villar Senin <svillar@igalia.com> · 07db218d
      sergio@webkit.org authored
              [GTK] Fullscreen tests failing after r82084
              https://bugs.webkit.org/show_bug.cgi?id=57219
      
              Skipping some fullscreen tests failing since r82084
      
              * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82094 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      07db218d
    • mjs@apple.com's avatar
      2011-03-28 Maciej Stachowiak <mjs@apple.com> · c1ab2f17
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Assigning location.path to something that doesn't start with / mangles the authority
              https://bugs.webkit.org/show_bug.cgi?id=57209
              <rdar://problem/9195132>
              
              Tests: http/tests/uri/assign-path-with-leading-slash.html
                     http/tests/uri/assign-path-without-leading-slash.html
      
              * platform/KURL.cpp:
              (WebCore::KURL::setPath): If the new path does not have a leading slash, add one.
      2011-03-28  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Assigning location.path to something that doesn't start with / mangles the authority
              https://bugs.webkit.org/show_bug.cgi?id=57209
              <rdar://problem/9195132>
      
              * http/tests/uri/assign-path-with-leading-slash-expected.txt: Added.
              * http/tests/uri/assign-path-with-leading-slash.html: Added.
              * http/tests/uri/assign-path-without-leading-slash-expected.txt: Added.
              * http/tests/uri/assign-path-without-leading-slash.html: Added.
              * http/tests/uri/resources/assign-path-landing.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c1ab2f17
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · 14a32605
      yutak@chromium.org authored
              Unreviewed, add Chromium test expectation for fast/text/justify-ideograph-leading-expansion.html.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      14a32605
    • rniwa@webkit.org's avatar
      2011-03-28 Ryosuke Niwa <rniwa@webkit.org> · 3dcf54c4
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Extract functions to update logical width from computeInlineDirectionPositionsForLine
              https://bugs.webkit.org/show_bug.cgi?id=57213
      
              Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
              and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.
      
              They are used to update logical widths, logical left, and total logical width for left,
              right, and center aligned blocks.
      
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::updateLogicalWidthForLeftAlignedBlock):
              (WebCore::updateLogicalWidthForRightAlignedBlock):
              (WebCore::updateLogicalWidthForCenterAlignedBlock):
              (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82091 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3dcf54c4
    • evan@chromium.org's avatar
      2011-03-28 Evan Martin <evan@chromium.org> · 0b2ef2a8
      evan@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Refactor duplicate code in HTMLTextElement
              https://bugs.webkit.org/show_bug.cgi?id=57215
      
              * html/HTMLTitleElement.cpp:
              (WebCore::HTMLTitleElement::childrenChanged):
              This method did an equivalent loop to the text() method on
              the same object.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82090 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0b2ef2a8
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · 8d964ac2
      yutak@chromium.org authored
              Unreviewed, update Chromium test results for plugins/plugin-javascript-access.html.
      
              * platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
              * platform/chromium-win/plugins/plugin-javascript-access-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82089 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d964ac2
    • ukai@chromium.org's avatar
      2011-03-27 Fumitoshi Ukai <ukai@chromium.org> · c070063b
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Don't call WebSocket::didClose() more than once.
              https://bugs.webkit.org/show_bug.cgi?id=57081
      
              If WebSocket close() is called, and connection is established, then
              it will call didClose() that resets m_channel to 0.
              After that, when connection is closed, WebSocketChannel will call
              didClose for the WebSocket instance.
      
              * http/tests/websocket/tests/close-unref-websocket-expected.txt: Added.
              * http/tests/websocket/tests/close-unref-websocket.html: Added.
              * http/tests/websocket/tests/hanging-handshake_wsh.py: Added.
      2011-03-27  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Don't call WebSocket::didClose() more than once.
              https://bugs.webkit.org/show_bug.cgi?id=57081
      
              If WebSocket close() is called, and connection is established, then
              it will call didClose() that resets m_channel to 0.
              After that, when connection is closed, WebSocketChannel will call
              didClose for the WebSocket instance.
      
              Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
              WebSocketChannel suppress the second didClose().
      
              Test: http/tests/websocket/tests/close-unref-websocket.html
      
              * websockets/WebSocket.cpp:
              (WebCore::WebSocket::didClose):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82088 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c070063b
    • aestes@apple.com's avatar
      2011-03-27 Andy Estes <aestes@apple.com> · 5a95a5f2
      aestes@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
              https://bugs.webkit.org/show_bug.cgi?id=57205
              
              If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
              plug-in MIME types, WebKit has to check for a property list file in
              ~/Library/Preferences for the MIME type dictionary.
      
              * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
              (WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary
              has the key WebPluginMIMETypesFilename, open the property list
              specified by that key's value and return the MIME type dictionary from
              there. Otherwise, return the MIME type dictionary specified by the key
              WebPluginMIMETypes.
              (WebKit::getPluginInfoFromPropertyLists): Call
              getMIMETypesFromPluginBundle().
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82087 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5a95a5f2
    • yutak@chromium.org's avatar
      2011-03-27 Yuta Kitamura <yutak@chromium.org> · 2c902848
      yutak@chromium.org authored
              Unreviewed, add Chromium test results for fast/blockflow/fallback-orientation.html.
      
              * platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.checksum: Added.
              * platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.png: Added.
              * platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.checksum: Added.
              * platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c902848
    • abarth@webkit.org's avatar
      2011-03-27 Adam Barth <abarth@webkit.org> · 1dd689c0
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fix script-src redirect handling
              https://bugs.webkit.org/show_bug.cgi?id=57196
      
              Test both allow => disallow and disallow => allow redirect cases.
              Previously, we had incorrect expectations for one of the redirect
              cases.  Also, I've updated the policy syntax to match the default-src
              syntax.
      
              * http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
              * http/tests/security/contentSecurityPolicy/script-src-redirect.html:
      2011-03-27  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Fix script-src redirect handling
              https://bugs.webkit.org/show_bug.cgi?id=57196
      
              Resource-loading requirements in CSP apply to each hop in the redirect
              chain.  To make that work properly, we need to move enforcement into
              the loader.  Fortunately, we already have a choke-point in the loader
              for enforcing this kind of policy.
      
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElement::requestScript):
              * html/parser/HTMLDocumentParser.cpp:
              * html/parser/HTMLDocumentParser.h:
              * html/parser/HTMLScriptRunnerHost.h:
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::canRequest):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowScriptFromSource):
              * page/ContentSecurityPolicy.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82085 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1dd689c0
    • jer.noble@apple.com's avatar
      2011-03-27 Jer Noble <jer.noble@apple.com> · b13ab418
      jer.noble@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Pass whether keyboard access was requested up to ChromeClient when asking
              if fullscreen mode is supported.
      
              * dom/Document.cpp:
              (WebCore::Document::webkitRequestFullScreenForElement):
              * page/ChromeClient.h:
              (WebCore::ChromeClient::supportsFullscreenForElement):
      2011-03-27  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Take into account whether keyboard access was requested when deciding whether full
              screen mode is supported.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::supportsFullScreenForElement):
              * WebView/WebView.mm:
              (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
              * WebView/WebViewInternal.h:
      2011-03-27  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Take into account whether keyboard access was requested when deciding whether full
              screen mode is supported.
      
              * UIProcess/WebFullScreenManagerProxy.cpp:
              (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
              * UIProcess/WebFullScreenManagerProxy.h:
              * UIProcess/WebFullScreenManagerProxy.messages.in:
              * WebProcess/FullScreen/WebFullScreenManager.cpp:
              (WebKit::WebFullScreenManager::supportsFullScreen):
              * WebProcess/FullScreen/WebFullScreenManager.h:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::supportsFullScreenForElement):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      2011-03-27  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Accept the withKeyboard parameter to supportsFullScreenForElement.
      
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82084 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b13ab418