GitLab

BUG=394993
TBR=felt

Review URL: https://codereview.chromium.org/667023005

Cr-Commit-Position: refs/heads/master@{#300605}

When a new cross-site frame is created, RFHM::CreateProxiesForSiteInstance walks the frame tree and creates proxies for the new frame in other nodes' SiteInstances.  This traversal currently hits this CHECK in RFHM::CreateRenderFrameProxy in cases where the new frame is added to a SiteInstance that already has other frames:

  CHECK_NE(instance, render_frame_host_->GetSiteInstance());

For example, if site A embeds two frames, B1 and B2, both pointing to site B, we hit this when we are visiting B1's frame tree node to create a proxy for B2, since B2's and B1's SiteInstance is the same.

This CL ensures that we aren't trying to create a proxy at frame tree nodes that share the new frame's SiteInstance.

BUG=None

Review URL: https://codereview.chromium.org/660083003

Cr-Commit-Position: refs/heads/master@{#300604}

BUG=

Review URL: https://codereview.chromium.org/667453004

Cr-Commit-Position: refs/heads/master@{#300603}

Review URL: https://codereview.chromium.org/656583006

Cr-Commit-Position: refs/heads/master@{#300602}

These targets are being developed canonically in the mojo repo and
tested there, no reason to run the tests in the chromium repo. The mojo
tests that should run in the chomium repository are:

mojo_public_* - the mojo SDK tests
mojo_system_unittests - mojo EDK tests
mojo_common_unittests - tests for mojo<->chromium glue
mojo_*_js_unittests - mojo JS bindings tests, which is being developed
in chromium.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/656423003

Cr-Commit-Position: refs/heads/master@{#300601}

This adds a gclient hook that downloads prebuilt mojo_shell binaries
from google storage (linux only for now) and gyp/gn flags to toggle
using these prebuilt binaries instead of ones built from source. This
also adds a helper script that uploads a locally built mojo_shell binary
to the appropriate place in google storage.  The versioning scheme is:

*) mojo/public/VERSION contains an identifier (committish currently) for
  the mojo public SDK. The mojo_shell binary must match the interfaces
  defined in this version of mojo/public/.

*) gs://mojo/shell/$VERSION/$PLATFORM.zip contains a prebuilt mojo_shell
  binary for a particular version. $PLATFORM for now must be linux-x64,
  but we can add more later as needed.

gclient runhooks downloads the shell binary referred to by
mojo/public/VERSION if it is available for the host platform to
mojo/public/tools/prebuilt/ and updates mojo/public/tools/prebuilt/VERSION
to tag the version downloaded if successful. On subsequent runs the hook
will check this against mojo/public/VERSION and avoid downloading again if
the binary is up to date.

This also adds variables to the GYP and GN builds that control if building
'mojo' builds a mojo_shell binary from source or copies the prebuilt binary
into the outdir.  They both default to false for now.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/667853002

Cr-Commit-Position: refs/heads/master@{#300600}

This reworks the way typ handles multiprocessing again, to make the API
(and the implementation) simpler for the common case.

TBR=dtu@chromium.org
BUG=402172

Review URL: https://codereview.chromium.org/664123005

Cr-Commit-Position: refs/heads/master@{#300599}

When I changed this PRESUBMIT.py in http://crrev.com/292434, I didn't properly test it, so it hasn't actually been checking auto_bisect/bisect.cfg as it was supposed to.

This change makes so that the files listed in the CONFIG_FILES list here will be checked (including run-perf-test.cfg, even though it's outside of the auto_bisect directory).

BUG=

Review URL: https://codereview.chromium.org/669543002

Cr-Commit-Position: refs/heads/master@{#300598}

This brings in:
767aebb Update openjpeg to r2908
bff247d More fixes in sycc422_to_rgb and sycc420_to_rgb when image width is odd
f71c2d0 Add missing parenthesis in FXARGB_GETDIB macro
fe45372 Make DEPS not add an extra pdfium directory.
175998f Fix standalone build on Linux and Mac.

Review URL: https://codereview.chromium.org/638883004

Cr-Commit-Position: refs/heads/master@{#300597}

Reverting instrumentations.

The bug is practically fixed, and profiler instrumentations are not necessary anymore.
BUG=417106
TBR=zelidrag@chromium.org, xians@chromium.org, hans@chromium.org, plundblad@chromium.org, komatsu@chromium.org, mfoltz@chromium.org, dcheng@chromium.org, tommycli@chromium.org, erikwright@chromium.org, rpaquay@chromium.org, mkwst@chromium.org, hongbo.min@intel.com, dvh@chromium.org, tbarzic@chromium.org, vitalybuka@chromium.org, jyasskin@chromium.org

Review URL: https://codereview.chromium.org/671783002

Cr-Commit-Position: refs/heads/master@{#300596}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=tommycli@chromium.org

Review URL: https://codereview.chromium.org/660343006

Cr-Commit-Position: refs/heads/master@{#300595}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/631653002

Cr-Commit-Position: refs/heads/master@{#300594}

This is necessary to roll in a new NaCl revision after I committed a
NaCl-side change which cleans up the service_runtime/include/ headers.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3909
TEST= build

Review URL: https://codereview.chromium.org/651643007

Cr-Commit-Position: refs/heads/master@{#300593}

This pulls in the following Native Client changes:

r13948: (mseaborn) Clean up sys/errno.h's #include guard to match the file's name
r13949: (glider) Filter -fsanitize=undefined from cflags when nacl_bootstrap_lib.
r13950: (jvoung) Build gold.nexe with a segment gap, and supply -B, to later support IRT use.
r13952: (jvoung) Add irt_load_optional flag to chrome_main args. Helps w/ making pnacl ld.nexe use IRT.
r13953: (nfullagar) Prep for sdk inclusion - make source more relocatable, so

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/666493004

Cr-Commit-Position: refs/heads/master@{#300592}

 * Fixes app_shell_browsertests on windows.

BUG=399363

Review URL: https://codereview.chromium.org/663203006

Cr-Commit-Position: refs/heads/master@{#300591}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/659563005

Cr-Commit-Position: refs/heads/master@{#300590}

There is a race where the IO thread got error after the UI thread
launched a process. This CL rejects such a case.
This is OK as the error is eventually notified to the UI thread.

TEST=chromeos browser_tests with ChannelMojo being on.
R=viettrungluu@chromium.org
BUG=377980

Review URL: https://codereview.chromium.org/671513011

Cr-Commit-Position: refs/heads/master@{#300589}

Intermingling enums with integer types leads to warnings on some compilers. Explicitly coercing an enum to an integer before returing it clears up the problem.

Broader changes (using constants instead of the enum, returning an enum instead of an integer type) were considered but deemed too sweeping.

BUG=424334
TEST=ui_unittests, events_unittests
R=sky@chromium.org,sadrul@chromium.org

Review URL: https://codereview.chromium.org/666673005

Cr-Commit-Position: refs/heads/master@{#300588}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jln@chromium.org

Review URL: https://codereview.chromium.org/666193002

Cr-Commit-Position: refs/heads/master@{#300587}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/657373004

Cr-Commit-Position: refs/heads/master@{#300586}

BUG=424706
TBR=bolian@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/669993002

Cr-Commit-Position: refs/heads/master@{#300585}

The fix for bug 337746 prevented unescaping of BiDi control
characters in URLs. This breaks the loading of data: URLs
because BiDi control chars appear escaped in the loaded HTML.
This patch adds a special case for the parsing of BiDi control
chars. This shouldn't change the way URLs are shown in the omnibox
or any other UI. URLs with BiDi control characters are always
displayed as escaped in the omnibox. This behavior is also
consistent with Firefox.

BUG=423901

Review URL: https://codereview.chromium.org/643963004

Cr-Commit-Position: refs/heads/master@{#300584}

(Depends on: https://codereview.chromium.org/606703003/)

BUG=251382

Review URL: https://codereview.chromium.org/602133002

Cr-Commit-Position: refs/heads/master@{#300583}

namespace like other GuestViews.

This is a cleanup only CL.

Also, this CL removes one extraneous "extensions::" namespace resolution
from ChromeExtensionOptionsGuestDelegate.

BUG=None
Test=Internal cleanup only, no visible change.

Review URL: https://codereview.chromium.org/668053002

Cr-Commit-Position: refs/heads/master@{#300582}

This broke when adding functionality to fill a single number across multiple fields.

BUG=425256

Review URL: https://codereview.chromium.org/654223004

Cr-Commit-Position: refs/heads/master@{#300581}

BUG=421710
TEST=conformance/glsl/misc/shaders-with-invariance.html
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/660123002

Cr-Commit-Position: refs/heads/master@{#300580}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/665323004

Cr-Commit-Position: refs/heads/master@{#300579}

It is possible that cameraInfo returns NULL.
However, the NULL case is not well handled and it will cause crashes.
This change also removed the unncessary JNI call to convert an int to string

BUG=424775

Review URL: https://codereview.chromium.org/667433003

Cr-Commit-Position: refs/heads/master@{#300578}

BUG=

Review URL: https://codereview.chromium.org/656583005

Cr-Commit-Position: refs/heads/master@{#300577}

craigdh, frankf, and ilevy are no longer working on chrome.

BUG=

Review URL: https://codereview.chromium.org/670783002

Cr-Commit-Position: refs/heads/master@{#300576}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/666123002

Cr-Commit-Position: refs/heads/master@{#300575}

This is similar to the DelegatedFrameResourceCollection logic and avoids returning resources created by one output surface to a different one.

Review URL: https://codereview.chromium.org/650533004

Cr-Commit-Position: refs/heads/master@{#300574}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/668073002

Cr-Commit-Position: refs/heads/master@{#300573}

The optimizations had minimal impact on library size, and should be kept
permanently.

BUG=419051

Review URL: https://codereview.chromium.org/643253002

Cr-Commit-Position: refs/heads/master@{#300572}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/638123004

Cr-Commit-Position: refs/heads/master@{#300571}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/668093002

Cr-Commit-Position: refs/heads/master@{#300570}

Check for EGL_KHR_wait_sync extension before calling eglWaitSyncKHR. If
extension not present, fallback to EGL_KHR_fence_sync and
eglClientWaitSyncKHR.

BUG=

Review URL: https://codereview.chromium.org/670843002

Cr-Commit-Position: refs/heads/master@{#300569}

From [1]:
"Filename globs follow the simple UNIX shell conventions
("*" and "?" are supported), and relative and absolute
paths are not allowed (globs may only refer to the files
in the current directory)."

So I'm pushing my name to the appropriate new
OWNERS file.

[1] http://www.chromium.org/developers/owners-files

Review URL: https://codereview.chromium.org/667483005

Cr-Commit-Position: refs/heads/master@{#300568}

telemetry downloads gsutil sometimes there when its running tests. This isn't shipped to users.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/672513002

Cr-Commit-Position: refs/heads/master@{#300567}

* If CommitFrame is skipped to to stall, ensure we invalidate.
* Make sure force_invalidate does not get cancelled by a
  pending fallback tick.
* Allow hardware initialization even when visible rect is
  empty, so fallback tick is always in the right mode.
* Fix visible rect empty checks.

BUG=425372

Review URL: https://codereview.chromium.org/654403006

Cr-Commit-Position: refs/heads/master@{#300566}