GitLab

BUG=732060

Review-Url: https://codereview.chromium.org/2933893002
Cr-Commit-Position: refs/heads/master@{#478806}

On most platforms, right-clicking a misspelled word only selects it and shows
suggestions in the context menu if you right-clik in the interior of the word.
In https://codereview.chromium.org/2925363002, I modified some of the spellcheck
code (specifically, the method that replaces the misspelled word) to support the
case where we have a caret selection immediately before or after a word, since
tapping at a word boundary should open the spellcheck menu on Android (this
feature is still in progress, but this is the behavior for a native EditText
widget, so we're trying to match it.)

This CL adds a test case to verify we don't accidentally change the behavior for
other platforms.

BUG=715365

Review-Url: https://codereview.chromium.org/2932123002
Cr-Commit-Position: refs/heads/master@{#478805}

This behavior is no longer supported.

BUG=731922

Review-Url: https://codereview.chromium.org/2934663002
Cr-Commit-Position: refs/heads/master@{#478804}

BUG=672489

Review-Url: https://codereview.chromium.org/2931323002
Cr-Commit-Position: refs/heads/master@{#478803}

Currently only being used on FontCache, to be used on other Font-related
classes.

Bug: 730692
Change-Id: I58f66d6cf59dca83be5133fc273136ce408e5b2e
Reviewed-on: https://chromium-review.googlesource.com/531753
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478802}

BUG=729197
TBR=groby@chromium.org

Review-Url: https://codereview.chromium.org/2927193002
Cr-Commit-Position: refs/heads/master@{#478801}

BUG=661774

Review-Url: https://codereview.chromium.org/2936433002
Cr-Commit-Position: refs/heads/master@{#478800}

BUG=none

Change-Id: Ic4359354e152c4af266554252a3728af1efd0e02
Reviewed-on: https://chromium-review.googlesource.com/529584
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478799}

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests

Review-Url: https://codereview.chromium.org/2932193002
Cr-Commit-Position: refs/heads/master@{#478798}

Screenshot of the change in the bug.

Since the entry response time is given as an internal UTC format, I added wrapper methods to Time.h to convert it to standard UTC format.

BUG=727922

Review-Url: https://codereview.chromium.org/2928833002
Cr-Commit-Position: refs/heads/master@{#478797}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7ba431f75da5..e663166b9cf3

$ git log 7ba431f75..e663166b9 --date=short --no-merges --format='%ad %ae %s'
2017-06-12 benjhayden Fix histogram-span for Histograms with a single sample with diagnostics.
2017-06-12 charliea Move myself to tracing/ OWNERS emeriti
2017-06-12 phsilva Remove left-over file from story runner unittests
2017-06-12 xunjieli Add initial web-page-replay-go code
2017-06-12 benjhayden Replace some single quotes in value/ui/ with double-quotes for consistency.
2017-06-12 benjhayden Add instantiation tests for date-range-span.
2017-06-12 charliea Stops the BattOr shell after receiving an invalid git hash
2017-06-12 kraynov Android systrace: Graphics memory reporting in atrace_helper.
2017-06-12 simonhatch Telemetry - Generate TagMap diagnostic in benchmark and attach to results.
2017-06-12 benjhayden Fix polymer_postload in tracing/ui.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I38b0071240ac342bf1da9d5cf5d6f2855f9cbb3b
Reviewed-on: https://chromium-review.googlesource.com/531784
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478796}

If the bottom_sheet_snackbar_container is the last view in the
coordinator layout, the margin property is not respected. This change
moves the empty_container_stub to be the last item since order for
this item is not particularly important.

BUG=732222

Change-Id: I5eb506cf0da38a252f579b4d2d11d82794b6b71d
Reviewed-on: https://chromium-review.googlesource.com/531803Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478795}

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926763002
Cr-Commit-Position: refs/heads/master@{#478794}

Adds an OfflineEventLogger to PrefetchDispatcher. GCM message handler now
notifies the dispatcher when a message arrives.

Bug: 701939
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I02de62ca3fd4eb7ca9fa98aff8431a37861cb361
Reviewed-on: https://chromium-review.googlesource.com/523163
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478793}

It subclasses ProfileIOData, which always makes and sets a CTVerifier
for the MainURLRequestContext, but the OffTheRecordProfileIOData was
replacing the pointer with on to the system context's CTVerifier. Both
verifiers are created with the same arguments, so this doesn't seem to
server any useful purpose.

The CTVerifier created by ProfileIOData contains no reference to
outside data, other than CTLogs and as an STH Observers, so it should
be fine to use for Incognito mode (Also note that it is not shared
between Incognito and non-Incognito).

BUG=732537

Review-Url: https://codereview.chromium.org/2936643004
Cr-Commit-Position: refs/heads/master@{#478792}

Implements two new public C API calls: MojoCreateMessage and
MojoGetMessageContext. This constitutes the bulk of what's needed to
support basic lazy message serialization as described in the proposal[1].

Follow-up CLs will introduce additional API surface - namely
MojoSerializeMessage and MojoGetSerializedMessageContents -- and
rename or rework existing APIs to match the details of the proposal.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/4CA0Ip56lgA

BUG=725321

Change-Id: Ifdd0ee9ed69ab49c6324ea3f02e1efab74ea5175
Reviewed-on: https://chromium-review.googlesource.com/527556
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478791}

Simply reuses the existing command buffer fuzzer, but with a SwiftShader backend.

Bug: swiftshader:51
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I40f595c830f82c791033383d68f4b2802a35b8b2
Reviewed-on: https://chromium-review.googlesource.com/514246Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478790}

This allows other callers to use it without including iat_patch_function.h.
Principally, this will be used for the upcoming CoCreateInstance DCHECK.

BUG=708303
TBR=gab@chromium.org
Refactor. No impact to running code.

Change-Id: Ibd25de76a2e9bf858619c6fccc18a46704237067
Reviewed-on: https://chromium-review.googlesource.com/531668
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478789}

This CL adds a template for building CRD iOS target so that we can easily
implement the production target by adding new sources or deps.

Eventually logic for authentication and settings menu will be moved out of the
template.

BUG=731851

Review-Url: https://codereview.chromium.org/2934593002
Cr-Commit-Position: refs/heads/master@{#478788}

It's possible for us to get a null icon from getInstantAppLaunchData, so
perform a null check before using the icon in InfoBarLayout.

BUG=731801

Review-Url: https://codereview.chromium.org/2936703002
Cr-Commit-Position: refs/heads/master@{#478787}

Also, on an unrelated note, change BidirectionalStreamTest base class
from TestWithParam<> to Test, since no parameters are used.

Review-Url: https://codereview.chromium.org/2936663002
Cr-Commit-Position: refs/heads/master@{#478786}

API change to pass GURL by reference.

Bug: 646586
Change-Id: I993cd98e3c8f17ac9fb85c632dcc0d253fcf358a
Reviewed-on: https://chromium-review.googlesource.com/531739Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478785}

Now that we have no DisplayItems and DisplayItemList is holding a
PaintOpBuffer, there are no consumers of cc::ContiguousContainer. The
PaintOpBuffer does a similar job for PaintOps. So we can remove this
class from the codebase.

R=weiliangc@chromium.org

Bug: 671433
Change-Id: Id11741b42bb0a75ab4a6c6db11779773741df2fd
Reviewed-on: https://chromium-review.googlesource.com/531669Reviewed-by: Weiliang Chen <weiliangc@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478784}

This reverts commit 1c7e3e09.

Breaks PhoneSimulator and TabletSimulator bots:

Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed failure reason

[0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed: _isShutdown. -shutdown must be called before dealloc.

TBR=sdefresne@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2930363003
Cr-Commit-Position: refs/heads/master@{#478783}

Today we pass in both |requires_secure_codec| and
|require_software_codec| which may cotradict with each other given
secure codecs are all hardware codecs. Add an enum to avoid this issue.

Also fixes a bug where if both |requires_secure_codec| and
|require_software_codec| are true, we would still create a secure (and
hence hardware) codec which may hang the GPU process. In this case, we
should just fail to create the codec.

BUG=459414

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icd8a403fe5a63b68cfe4045da7057be64ea9de66
Reviewed-on: https://chromium-review.googlesource.com/530098Reviewed-by: Chris Watkins <watk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478782}

Revert of Move ObjectContentType entirely to HTMLPlugInElement (patchset #2 id:20001 of https://codereview.chromium.org/2927703003/ )

Reason for revert:
Looks like schenney's unavailable at the moment; speculatively reverting for layout test virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html failures (e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/57955)

Original issue's description:
> Move ObjectContentType entirely to HTMLPlugInElement
>
> There's no need to go to LocalFrameClientImpl to determine how to load
> a plugin element, that was a purely pre-blink necessity.
>
> Simplify a bunch of logic around HTMLPlugInElement to assume that url_
> and service_type_ are always set and correct by the time the
> ObjectContentType is being determined.
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2927703003
> Cr-Commit-Position: refs/heads/master@{#478683}
> Committed: https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a7304764642f05c76bb81

TBR=schenney@chromium.org,japhet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2933213002
Cr-Commit-Position: refs/heads/master@{#478781}

In ScriptContext::OnResponseReceived(), instead of immediately executing
JS, request execution. This means we don't receive a result from the
execution. According to comments,

// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.

This appears to have been true at some point [1], but some time in the
last seven years, has been updated to no longer be the case. As such,
just remove any reference to the result value.

[1] https://chromium.googlesource.com/chromium/src/+/5c21a2eeaa92326a6a771e27c70b11b1ea52441a/chrome/renderer/resources/extension_process_bindings.js#114

BUG=629431

Review-Url: https://codereview.chromium.org/2932913004
Cr-Commit-Position: refs/heads/master@{#478780}

A Lazy(Sequenced|SingleThread|COMSTA)TaskRunner lazily creates a TaskRunner.

A Lazy(Sequenced|SingleThread|COMSTA)TaskRunner is meant to be instantiated in
an anonymous namespace and used to post tasks to the same sequence/thread
from pieces of code that don't have a better way of sharing a TaskRunner.
Adding a Lazy(Sequenced|SingleThread|COMSTA)TaskRunner to an anonymous
namespace doesn't generate a static initializer.

Bug: 730170
Change-Id: Idb35cfe9a5ca5501b7057d7b90b9df3f702faff1
Reviewed-on: https://chromium-review.googlesource.com/524141
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478779}

Right now, NotificationsNativeHandler::GetNotificationImageSizes()
builds a DictionaryValue and then passes that to V8ValueConverter to
convert it to a v8::Object. Instead, we can use gin::DataObjectBuilder,
which should be faster (since it's much more lightweight, and doesn't
require setting up a DictionaryValue we won't use - not to mention
fewer heap allocations).

BUG=None

Review-Url: https://codereview.chromium.org/2937543002
Cr-Commit-Position: refs/heads/master@{#478778}

This patch prevent hover state change for touch event on mobile.

We have 2 checks for this:
1. Event is from touch.
2. Viewport enabled (on mobile).
3. Page with viewport meta.

TESTS:
Review-Url: https://codereview.chromium.org/2931433002
Cr-Commit-Position: refs/heads/master@{#478777}

Calling start() or stop() with negative time values should throw
RangeError, not InvalidAccessError.  This also includes the offset and
duration parameters for AudioBufferSourceNode.start().

constant-source-basic.html,
oscillator-basic.html

Bug: 731242
Test: audiobuffersource-basic.html,
Change-Id: Ide02d22a66712ba46aa1f0007c71ae24e78b88fe
Reviewed-on: https://chromium-review.googlesource.com/528479Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478776}

After crrev.com/478051 It2Me host expects to get IceConfig from
the webapp. The config is used to connect to TURN servers when using
WebRTC. This CL updates the webapp to fetch IceConfig from the server
and pass it to the host.

Change-Id: I194f3602fad9bdd3445d843860a585a739187de2
Reviewed-on: https://chromium-review.googlesource.com/530446
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478775}

This patch introduces a separate code path for browser side navigation. Instead of
using pending and current, we keep track of a single RenderFrameHostImpl instance via
standard WebContentsObserver notifications.

While any navigations are active (determined by the navigation_handles_ set), we put messages
to suspended_messages_ instead of sending them to the renderer, resuming once navigations
commit to a specific RenderFrameHostImpl instance.

While navigation is not active, we send messages to renderer and put them to
waiting_for_response_messages_, which are exactly the messages received after last
state cookie update (see DevToolsMessageChunkProcessor).

BUG=727517
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927983004
Cr-Commit-Position: refs/heads/master@{#478774}

This is required otherwise the second include in any component will
trigger multiply defined symbol errors.

BUG=708303

Change-Id: I857cb001f3310a4c35e24768e0fbbd25d6ec22a3
Reviewed-on: https://chromium-review.googlesource.com/531802Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478773}

The V4UsageStatus is a desktop-specific check, because Android is already
shipped with V4.

Additionally, this exposed an issue with our implementation when there
is a remote db: synchronous failure (e.g. when visiting chrome:// urls)
cause our db client to cancel a non-existent request in its destructor.

This is easily fixed by marking request_complete_ in that code path.

Another small (but important!) fix is that the Android check for the
subresource filter also includes the phishing list.

Bug: 609747
Change-Id: I477361117380fcb7e14b30a677b24c5d41027e1c
Reviewed-on: https://chromium-review.googlesource.com/528393Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478772}

marked as broken, mark the session as going away.

BUG=731303

Review-Url: https://codereview.chromium.org/2933773002
Cr-Commit-Position: refs/heads/master@{#478771}

BUG=chromium:720002

Review-Url: https://codereview.chromium.org/2933173002
Cr-Commit-Position: refs/heads/master@{#478770}

RTCVideoEncoder.SupportsNativeHandle() means it can handle frames of
type kNative, which in Chromium represents wrapped media::VideoFrames.

Also, before accessing I420 data, i.e. DataY/U/V or StrideY/U/V, the
function ToI420 should be called on webrtc::VideoFrameBuffer (these
I420 functions will be removed from webrtc::VideoFrameBuffer soon).

BUG=732345,732418

Review-Url: https://codereview.chromium.org/2939493002
Cr-Commit-Position: refs/heads/master@{#478769}

This fully removes trust in WoSign and StartCom, as announced at https://security.googleblog.com/2016/10/distrusting-wosign-and-startcom.html

BUG=731838

Review-Url: https://codereview.chromium.org/2927383002
Cr-Commit-Position: refs/heads/master@{#478768}

Adds the Night Light automatic schedule settings.

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c15

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2915753003
Cr-Commit-Position: refs/heads/master@{#478767}