GitLab

When the Ctrl+Enter are pressed, the click is simulated.
The test checks if the new tab is opened on the background.

BUG=450069
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/877513002

Cr-Commit-Position: refs/heads/master@{#314313}

When announcing the availability of the robot account token to its
observers, DeviceOAuth2TokenService needs to know both the token and
the robot account ID. During enrollment, the token becomes available
before the account ID. Thus, DeviceOAuth2TokenService needs to wait
for the account ID to be available before announcing the token.

BUG=453828
TEST=New unit test

Review URL: https://codereview.chromium.org/892633003

Cr-Commit-Position: refs/heads/master@{#314312}

For the login screen, if there is some web content displayed, and the user clicks a link that is specified to open in a new window, a new browser window indeed opens, which is highly undesirable at the login screen.
To avoid this, a new delegate method was introduced, which should decide if we want to allow displaying any additional contents.

BUG=443096
TEST=manual

Review URL: https://codereview.chromium.org/812763003

Cr-Commit-Position: refs/heads/master@{#314311}

 - fix missing files check for the case when the script runs outside of
   the repository root;

 - exclude not shipped dirs that present on the bot from the checks.

BUG=450048

Review URL: https://codereview.chromium.org/877583003

Cr-Commit-Position: refs/heads/master@{#314310}

Rather than lazily creatng the schedueler (which could happen on any
thread), create it in the constructor if there is a message loop.
Frustratingly the problem this solves only shows up if you
run all the webkit_tests, not just one of them.

BUG=391005

Review URL: https://codereview.chromium.org/890333003

Cr-Commit-Position: refs/heads/master@{#314309}

Revert of Add build targets for Opus tests. (patchset #2 id:20001 of https://codereview.chromium.org/894473002/)

Reason for revert:
This CL breaks WebRTC in Chrome and must be reverted. Contact tlegrand@ for more details.

Original issue's description:
> Add build targets for Opus tests.
>
> test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding
> can be run directly, with no command-line options, and they print out
> "OK" during the test and an overall status message such as
> "All API tests passed." or "Tests completed successfully." at the end.
>
> The celt component has several unit tests. I didn't add build targets
> for them because some of them don't print any output, so you'd need a
> test harness script to examine their exit status.
>
> R=henrika@chromium.org,sergeyu@chromium.org
> BUG=452984
>
> Committed: https://crrev.com/8b76b75f78ffdb9760ee7eea4f149c5d2b64bc89
> Cr-Commit-Position: refs/heads/master@{#314235}

TBR=sergeyu@chromium.org,brettw@chromium.org,wtc@chromium.org, tlegrand@chromium.org
BUG=452984

Review URL: https://codereview.chromium.org/884483005

Cr-Commit-Position: refs/heads/master@{#314308}

Some printing related //android_webview were copied over from
//chrome. Now that the ones in //chrome can move to a component,
webview should also use these files.

Depends on https://codereview.chromium.org/811563008/

BUG=444883, 311308

Review URL: https://codereview.chromium.org/822133003

Cr-Commit-Position: refs/heads/master@{#314307}

BUG=452828

Review URL: https://codereview.chromium.org/880223002

Cr-Commit-Position: refs/heads/master@{#314306}

Make android webview shell behaviour to be like chrome shell: enable
zoom and fit we page contents into viewport.

BUG=n/a

Review URL: https://codereview.chromium.org/872363005

Cr-Commit-Position: refs/heads/master@{#314305}

This is the provider by using FileEntry#getMetadata.

TEST=FileManagerJsTest.FileSystemMetadataProvider
BUG=410766

Review URL: https://codereview.chromium.org/894313002

Cr-Commit-Position: refs/heads/master@{#314304}

Implementation of the NetworkingConfigService and boiler plate code for the
networking.config API.

Reviewers:
Please see
1) https://docs.google.com/document/d/1V8YGouKC477iC11L4PL8H_HU1Ru3R5kMhXppuoIVNeo for the design document.
2) https://docs.google.com/drawings/d/12Hai1LdaPzwtkrQUdCjSpt1s7InRNNBDeWiW5ujfIRg for a flow diagram.

Review URL: https://codereview.chromium.org/880073002

Cr-Commit-Position: refs/heads/master@{#314303}

This reverts commit c511691c.

CL added SetUpgradeAndCheckCredentials test.
This test failed on Mac 10.6 build bot.

TBR=mlerman@chromium.org,
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/875983008

Cr-Commit-Position: refs/heads/master@{#314302}

Revert of Move the call to CRYPTO_set_NEON_capable up. (patchset #1 id:1 of https://codereview.chromium.org/899463002/)

Reason for revert:
Suspect this change upset the webkit ChromeOS Test 1, Mac 10.8, encrypted
media tests. Reverting to see if these builders turn green.

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/9563

Original issue's description:
> Move the call to CRYPTO_set_NEON_capable up.
>
> BoringSSL needs to probe for NEON support via SIGILL in cases where
> getauxval isn't provided and the application doesn't do explicit
> initialisation.
>
> However, Chromium might have gone multithreaded by the time that we
> initialise BoringSSL and, although it doesn't look like we'll race the
> disposition of SIGILL with anything, it's best not to test that hope.
>
> So this change causes CRYPTO_set_NEON_capable to always be called, and
> to be called before SSL_library_init. BoringSSL will take that as a
> signal that probing for NEON support isn't needed.
>
> BUG=none
>
> Committed: https://crrev.com/fa9063829e638aeb72ede79e5d0396a81a0211d1
> Cr-Commit-Position: refs/heads/master@{#314201}

TBR=davidben@chromium.org,agl@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/895013002

Cr-Commit-Position: refs/heads/master@{#314301}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b12ea41..fef4c32

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/884033003

Cr-Commit-Position: refs/heads/master@{#314300}

BUG=none
TBR=kenrb@chromium.org

Review URL: https://codereview.chromium.org/896753002

Cr-Commit-Position: refs/heads/master@{#314299}

The test was disabled because it was flaky.  This CL tries to address that
and reenables the test.

This relands the previous attempt which was still flaky on slow enough environments (such as the memory bots).

BUG=346797
R=dtseng@chromium.org

Committed: https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7
Cr-Commit-Position: refs/heads/master@{#313467}

Review URL: https://codereview.chromium.org/866713002

Cr-Commit-Position: refs/heads/master@{#314298}

The CL adds:
 * Assertion for property names passed to NewMetadataProvider.
 * Existance check for results obtained from getImpl.

BUG=410766
TEST=FileManagerJsTest.NewMetadataProvider

Review URL: https://codereview.chromium.org/899603002

Cr-Commit-Position: refs/heads/master@{#314297}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/891183004

Cr-Commit-Position: refs/heads/master@{#314296}

ListThumbnailLoader is a thumbnail loader for list style ui.
For the images in the viewport, either thumbnailLoaded event is dispatched or getThumbnailFromCache will return from cache.

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/885323002

Cr-Commit-Position: refs/heads/master@{#314295}

BUG=387037

Review URL: https://codereview.chromium.org/885423003

Cr-Commit-Position: refs/heads/master@{#314294}

The main toolbar of the Material Design PDF Viewer (at the top containing page selection functionality) is set to use the 'core-narrow' class, setting it to the same height as the toolbar in Inbox by Google.

BUG=110020

Review URL: https://codereview.chromium.org/891563004

Cr-Commit-Position: refs/heads/master@{#314293}

Previously ProtectedMediaIdentifierPermissionContext is only used on Android.

In this CL:
- ChromeOS is using the stanand infobar/bubble permission UI.
- ChromeOS is using the same strings as Android. This should be fixed or
  reevaluated. See below.

Follow up work:
1. Make sure the infobar/bubble UI (including strings) is good for ChromeOS.
2. Fix the icon for the infobar/bubble on ChromeOS.
3. If we cannot get (1) and (2) done, use the current ChromeOS UI (see
   PlatformVerificationDialog) for ProtectedMediaIdentifierPermissionContext.

TBR=cpu@chromium.org
BUG=446263
TEST=Tested on ChromeOS build.

Review URL: https://codereview.chromium.org/863263007

Cr-Commit-Position: refs/heads/master@{#314292}

Previously, typing Ctrl-G would pop up the "find-text" box, appearing to be an alias for Ctrl-F.
Doing so will now highlight the page number in the viewer-page-selector, allowing for a quick and easy method to go to another page.
Changed viewer-page-selector to use a combination of paper-input-decorator and input instead of a sole paper-input. This affords us greater flexibility and should ease maintenance.

BUG=55920

Review URL: https://codereview.chromium.org/888343003

Cr-Commit-Position: refs/heads/master@{#314291}

ScriptPreprocessor is being deprecated and will be removed soon. This CL prepares page_handler for removing scriptPreprocessor parameter from Page.reload command.

BUG=394230, 438626

Review URL: https://codereview.chromium.org/898433002

Cr-Commit-Position: refs/heads/master@{#314290}

Cr-Commit-Position: refs/heads/master@{#314289}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e67164d..b12ea41

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/890233003

Cr-Commit-Position: refs/heads/master@{#314288}

TBR=vabr@chromium.org
BUG=346297

Review URL: https://codereview.chromium.org/896723003

Cr-Commit-Position: refs/heads/master@{#314287}

BUG=422869

Review URL: https://codereview.chromium.org/898443004

Cr-Commit-Position: refs/heads/master@{#314286}

In FindPreviousFocusableViewImpl, in the recursive call to visit the
sibling node, preserves can_go_up, rather than forcing it to true.

Added FocusTraversalNonFocusableTest (test the pathological case
outlined in the bug report).

Also fixed existing comment in test file describing the view hierarchy
to match reality.

BUG=453699
BUG=438425
BUG=451140

Review URL: https://codereview.chromium.org/886033002

Cr-Commit-Position: refs/heads/master@{#314285}

BUG=312380

Review URL: https://codereview.chromium.org/881733002

Cr-Commit-Position: refs/heads/master@{#314284}

In nacl_helper_nonsfi, getpid() is prohibited to be called by seccomp-bpf
(will be implemented somehow soon). So, base::GetCurrentProcID() used in IPC
library, which uses getpid(), would cause a SIGSYS crashing.
As, in nacl_helper_nonsfi, PID is actually not used, so this CL replaces it
with -1 (dummy PID).

Note that the more generic CL crrev.com/695353005, which replaces PID with
dummy also on Linux platforms, was landed once, but reverted due to it was
still in use (crbug.com/441312). This CL extracts only Non-SFI related
part to avoid breakage.

TEST=Ran bots.
BUG=358465, 441312
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm

Review URL: https://codereview.chromium.org/879303004

Cr-Commit-Position: refs/heads/master@{#314283}

The visible viewport is the area of the window that is visible. For example,
when the on-screen keyboard obscures part of the window we shrink the visible
viewport to allow the page to "overscroll" the obscured area into view.
When we resize the window, the visible viewport should be resized along
with it.

Also renamed ResizeSynchronously since it sets the rect, not just the size.
Same for initial_pos_.

This was breaking the
css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html
layout test upon turning on virtual-viewport.

BUG=444952

Review URL: https://codereview.chromium.org/894193003

Cr-Commit-Position: refs/heads/master@{#314282}

Adds support for automatic on-line reconfiguration of the VP8 software
encoder whenever the video frame size changes.  libvpx supports
shrinking frame sizes without tearing down the encoder, but growing
frames sizes still requires a full tear-down and re-creation.

Most of this change involves adding extensive unit testing to confirm
media/cast is now capable of handling variable frames sizes end-to-end.
In addition, the cast_sender_app and cast_receiver_app diagnostic tools
have been updated.

An upcoming change will eliminate the width and height properties from
media::cast::VideoSenderConfig, which are both being ignored now.

BUG=451277
TBR=hubbe@chromium.org

Review URL: https://codereview.chromium.org/892383002

Cr-Commit-Position: refs/heads/master@{#314281}

See bug for details. This patch makes it so that we fire
the events  IA2_EVENT_TEXT_INSERTED and IA2_EVENT_TEXT_REMOVED
when the children referenced by the embedded object characters
changed, not just when the text changed.

This patch also avoids incorrectly firing these same two
events on a newly-created node.

BUG=425861

Review URL: https://codereview.chromium.org/859133003

Cr-Commit-Position: refs/heads/master@{#314280}

The class will be used as the base class of all metadata provider.  The class has abstrct
getImpl method and sub-class of the class should inherit the function. The class
also contains MetadataProviderCache that is a sub-class of MetadataCacheSet, and
caches the result of getImpl method.

BUG=410766
TEST=FileManagerJsTest.NewMetadataProvider

Review URL: https://codereview.chromium.org/894283002

Cr-Commit-Position: refs/heads/master@{#314279}

Currently most objects in the Chromoting Webapp doesn't unhook events until
the page is unloaded.  This introduces unintentional coupling between an object's
lifetime and the app's lifetime.

This CL implements a lightweight utility class to make unhooking listeners easier.

BUG=454552

Review URL: https://codereview.chromium.org/863863003

Cr-Commit-Position: refs/heads/master@{#314278}

BUG=454335

Review URL: https://codereview.chromium.org/863863005

Cr-Commit-Position: refs/heads/master@{#314277}

BUG=452608
TEST=existing unit tests

Review URL: https://codereview.chromium.org/890293002

Cr-Commit-Position: refs/heads/master@{#314276}

A previous change to skip displaying zoom levels for host and scheme
zoom changes caused host-only zoom changes to be skipped due to surprise
case fallthrough. This adds a break so the correct zoom settings are
displayed.

BUG=454254

Review URL: https://codereview.chromium.org/879333003

Cr-Commit-Position: refs/heads/master@{#314275}

Revert of offset namespace ids (patchset #7 id:120001 of https://codereview.chromium.org/881253004/)

Reason for revert:
Tests now only work if they ran in the "right" order. DOMStorageContextImplTest.Basic fails if the tests are shuffled:

content_unittests --gtest_filter=DOMStorageContextImplTest.*:DOMStorageAreaTest.* --gtest_shuffle

Original issue's description:
> [DOMStorage] Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another.
>
> Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e
> Cr-Commit-Position: refs/heads/master@{#314256}

TBR=jsbell@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/896733002

Cr-Commit-Position: refs/heads/master@{#314274}