GitLab

BUG=123896

Review URL: https://codereview.chromium.org/561673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds internalAbort() call to handleDidCancel(). This is
not harmful. It's rather good that we clear resources.

R=yhirano,sof,kouhei
BUG=406229

Review URL: https://codereview.chromium.org/490083002

git-svn-id: svn://svn.chromium.org/blink/trunk@181791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SYlD0YVUnQk

Remove all *Sync interfaces and implementations, and WorkerGlobalScope::
openDatabase.
CLs to simplify code follow.

BUG=397429,323858,310866,357427

Review URL: https://codereview.chromium.org/561093003

git-svn-id: svn://svn.chromium.org/blink/trunk@181790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The only functional difference is that we no longer repeat the
step name on every line. Otherwise, it's all CSS tweaks.

NOTRY=true
R=michaelpg@chromium.org

Review URL: https://codereview.chromium.org/553343002

git-svn-id: svn://svn.chromium.org/blink/trunk@181789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderFlexibleBox has several methods that take pointers to RenderBox instances but
those methods assumes that the objects will never be NULL. We should replace them by
references. This makes the caller code safer.

Review URL: https://codereview.chromium.org/555213002

git-svn-id: svn://svn.chromium.org/blink/trunk@181787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This has been an alias for innerNode with a "remove this" FIXME for some
time.  The cleanup is pretty easy.

BUG=

Review URL: https://codereview.chromium.org/476303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLTextAreaElement::value() is a costly operation, and we can avoid it
if a <textarea> has neither 'required' attribute nor 'maxlength' attribute.

This CL improves PerformanceTests/DOM/textarea-dom.html and
textarea-edit.html by a few percent.

BUG=

Review URL: https://codereview.chromium.org/543403003

git-svn-id: svn://svn.chromium.org/blink/trunk@181785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step towards implementing getRegistration method of
ServiceWorkerContainer. This patch adds definition of the method and
its callback type to WebServiceWorkerProvider.

[2/3] https://codereview.chromium.org/535753002/
[3/3] https://codereview.chromium.org/540823003/

BUG=404951
TEST=compile (tests will be added by subsequent patches)

Review URL: https://codereview.chromium.org/553983010

git-svn-id: svn://svn.chromium.org/blink/trunk@181784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (3/3)

1. [Blink] https://codereview.chromium.org/549093002/
2. [Chromium] https://codereview.chromium.org/554573002/
3. [Blink] this patch

BUG=390894
TEST=run_webkit_tests.py http/tests/serviceworker/unregister.html

Review URL: https://codereview.chromium.org/550093002

git-svn-id: svn://svn.chromium.org/blink/trunk@181783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This looks like a no-op, but forthcoming changes to
IDBPendingTransactionMonitor require this and it makes those patches
much easier to understand.

BUG=390704,411532

Review URL: https://codereview.chromium.org/555633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used <button> for cells, and we had unexpected focus behaviors. This CL
changes <button> to <div>.
This is a preparation to support accessibility in the month popup.

BUG=123896

Review URL: https://codereview.chromium.org/556323003

git-svn-id: svn://svn.chromium.org/blink/trunk@181781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bug 401177 added more explicit tracking of the source of synthetic mouse
events.  This CL updates the remianing places that generate mouse event
from touch input to explicitly mark them as so.  To do this I've removed
an ASSERT I added that attempted to lock-in hit-test reduction
improvements.  We have a dedicated test for this (hit-test-counts.html)
and so the ASSERT wasn't adding much.  It's not worth the effort at this
point to refactor the touch drag and drop code (a little used feature)
to remove a couple of hit tests (but I've left the comments in place
saying that ideally we'd do so in the future).

BUG=408660

Review URL: https://codereview.chromium.org/558753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The comment is outdated since the css values have been
implemented and the referenced bug is closed.

NOTRY=true

Review URL: https://codereview.chromium.org/562743003

git-svn-id: svn://svn.chromium.org/blink/trunk@181778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use reference instead of pointer in BMPImageDecoder::processFileHeader

Review URL: https://codereview.chromium.org/556913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/558363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove this field as it is no longer used by Chromium. Also prepare the
way for removing |WebTouchEvent.changedTouches| by populating
|WebTouchEvent.touches| with *all* touch points, even those that are
released or cancelled, in WebTouchEventBuilder. The plugin consumer
downstream can resynthesize the changed touches on-demand.

This is part 2 of a 4-sided patch simplifying WebTouchEvent:
1) https://codereview.chromium.org/557863002/
2) This change
3) https://codereview.chromium.org/559693003/
4) https://codereview.chromium.org/560493003/

BUG=358132

Review URL: https://codereview.chromium.org/558773002

git-svn-id: svn://svn.chromium.org/blink/trunk@181775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a Blink side patch for visualizing paint
invalidation for newly created RenderObject.
Demo @ https://www.youtube.com/watch?v=L-zo91nL2nE&list=UUGC5ommqy7KyPzZ-eGlL_Dg

After this CL, GraphicsLayerDebugInfo holds a vector of
invalidation rects along with their source / reason.
The rects can be queried from the embedder using the method
|GraphicsLayerDebugInfo::getAnnotatedInvalidationRects|.

This CL also adds a flag |RenderObject::hadPaintInvalidation|
to track if the RenderObject had ever been painted.
The flag is then used to annotate invalidation rects
for first paint of the RenderObject.

After this CL, WebLayer implementator can query this info to
visualize the layer invalidation including the first paint,
which is useful for telling if the repaint storm is due to
the page itself, or is a performance bug in Blink rendering
stack.

BUG=402033

Review URL: https://codereview.chromium.org/498193003

git-svn-id: svn://svn.chromium.org/blink/trunk@181774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/560613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to CL 459633002, this fixes a compile error with some
older toolchains.

BUG=401254

Review URL: https://codereview.chromium.org/558283003

git-svn-id: svn://svn.chromium.org/blink/trunk@181772 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to find the missing setNeedsAnimate.

BUG=393331

Review URL: https://codereview.chromium.org/556723004

git-svn-id: svn://svn.chromium.org/blink/trunk@181770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This class was only used for rendering <select> elements.  PopupListBox now
inherits ScrollView directly.  (With future refactorings of the scrolling code
it may not even do that.)

PopupContainer now inherits Widget.  There is no need for it to be a ScrollView
since it never actually scrolls.

Review URL: https://codereview.chromium.org/562513004

git-svn-id: svn://svn.chromium.org/blink/trunk@181769 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/460043002

git-svn-id: svn://svn.chromium.org/blink/trunk@181768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In addition to changing the default for the chromium coding style to
use single-quoted string literals instead of double, this reworks the
structure of the program to be a bit clearer, and adds command line
args to toggle on and off the autopep8 reformatting and the string literal
reformatting.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/555283006

git-svn-id: svn://svn.chromium.org/blink/trunk@181767 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The latest EME spec has MediaKeys.createSession() return the session
object, and adds MediaKeySession.generateRequest() to actually call
the CDM with the necessary |initData| for the session.

This change also updates the layout tests to match the new way of
creating sessions.

BUG=358271
TEST=updated layout tests pass

Review URL: https://codereview.chromium.org/543173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181765 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357747

Review URL: https://codereview.chromium.org/544443002

git-svn-id: svn://svn.chromium.org/blink/trunk@181764 bbb929c8-8fbe-4397-9dbb-9b2b20218538

String is much more useful, it can be used as key for StringMap.

BUG=

Review URL: https://codereview.chromium.org/556363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412027

Review URL: https://codereview.chromium.org/558793002

git-svn-id: svn://svn.chromium.org/blink/trunk@181762 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This path required a connection to the WindowServer, which should be avoided
(see the two bugs for details). Instead this data can be retrieved via the
ColorProfile class, which can access a value that has been cached during
pre-sandbox warmup.

BUG=397642,306348
R=noel@chromium.org

Review URL: https://codereview.chromium.org/554033002

git-svn-id: svn://svn.chromium.org/blink/trunk@181761 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I found that InvalidationLocationChange is a very frequent invalidation
reason for some repaint storms. The invalidation is because the
location (from the paint invalidation container) of the render object
changed since the last invalidation. It will be helpful to know how
the location changes when debugging repaint storms.

Review URL: https://codereview.chromium.org/561443002

git-svn-id: svn://svn.chromium.org/blink/trunk@181759 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As LocalDOMWindow controls the registration lifetime of its
DOMWindowProperties, there's no need to offer a separate unregistration
mechanism. Remove it, simplify notification code + retire now unused
LocalDOMWindow back reference on DOMWindowProperty.

R=haraken,ager
BUG=

Review URL: https://codereview.chromium.org/558213002

git-svn-id: svn://svn.chromium.org/blink/trunk@181758 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The LCD bit is captured in run paints at blob build time, so any
adjustments should be performed at that point. Also, text encoding is
handled similarly, and we don't need to set it on draw paints.

R=jbroman@chromium.org,reed@chromium.org,eae@chromium.org
BUG=412445

Review URL: https://codereview.chromium.org/551183005

git-svn-id: svn://svn.chromium.org/blink/trunk@181757 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Support for CSSPropertyWebkitCursorVisibility has been removed:
https://chromiumcodereview.appspot.com/14612004

Review URL: https://codereview.chromium.org/563553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181756 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383125

Review URL: https://codereview.chromium.org/464073002

git-svn-id: svn://svn.chromium.org/blink/trunk@181755 bbb929c8-8fbe-4397-9dbb-9b2b20218538

From WebKit legacy we have two redundant copies of this file.
In order for switching shapers on mac, we need to fuse these files again. 
This is part two of the merge,
after the headers were merged in r181655 / ad011a9df.

BUG=334269

R=eae

Review URL: https://codereview.chromium.org/550083005

git-svn-id: svn://svn.chromium.org/blink/trunk@181754 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to https://codereview.chromium.org/403393002, an SVG image which had
no intrinsic size specified, would (somewhat accidentally) get the
<image>'s bounds set as their container size. After said CL, the container
size would never be set, and hence remain as 300x150. This will result in
incorrect scale factors being used when painting, and hence an incorrectly
scaled result.
Revert to setting the <image>'s bounds when the SVG image does not have an
intrinsic size.

BUG=411906

Review URL: https://codereview.chromium.org/551043006

git-svn-id: svn://svn.chromium.org/blink/trunk@181752 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412027

Review URL: https://codereview.chromium.org/556563002

git-svn-id: svn://svn.chromium.org/blink/trunk@181751 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since jpeg_read_raw_data reads blocks of memory, we have to make sure
that the memory allocated is a multiple of the DCT block size. For
example, if DCTSIZE is 8, which is generally the case, we have to make
sure that the allocated memory to read the raw JPEG data has a width
rounded up to the next multiple of 8 (if it's not already a multiple
of 8) to avoid writing data out of the bounds of the memory. If this
isn't done properly, the end of some decode image lines can overwrite
the beginning of the following lines.

BUG=411189

Review URL: https://codereview.chromium.org/544323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181749 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=408075
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/558243003

git-svn-id: svn://svn.chromium.org/blink/trunk@181748 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dglazkov@chromium.org
BUG=395425

Review URL: https://codereview.chromium.org/558253002

git-svn-id: svn://svn.chromium.org/blink/trunk@181747 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Noticed that it was (in content_shell x64 for Linux) 421 and 425 bytes
which seemed excessive. Just rewrote it a bit to do less work for the
same result.

gcc (not even going to guess why createQualifiedName changed):
---------------------------------------------------------------------------------------------------------------------
 -635 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp - (gained 8, lost 643)
---------------------------------------------------------------------------------------------------------------------
  Grown symbols:
         +8: WebCore::Document::didChangeVisibilityState() type=t, (was 299 bytes, now 307 bytes)
  Shrunk symbols:
        -64: WebCore::createQualifiedName(WTF::AtomicString const&, WTF::AtomicString const&, WebCore::ExceptionState&) type=t, (was 1112 bytes, now 1048 bytes)
       -579: WebCore::Document::updateTitle(WTF::String const&) type=t, (was 1541 bytes, now 962 bytes)

clang:
  Shrunk symbols:
       -241: WebCore::Document::updateTitle(WTF::String const&) type=t, (was 1124 bytes, now 883 bytes)

Review URL: https://codereview.chromium.org/390003003

git-svn-id: svn://svn.chromium.org/blink/trunk@181746 bbb929c8-8fbe-4397-9dbb-9b2b20218538