GitLab

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338283002
Cr-Commit-Position: refs/heads/master@{#419142}

Currently, we instantiate the service in BrowsingDataRemover even when
it does not exist, yet. This means that we instantiate it on non-android
platforms, in unit-tests, etc.

This CL changes the logic so that the service is accessed only if it has
been created previously. This way, the BrowsingDataRemover respects the
start-up logic that decides whether to create the service or not.

BUG=647222

Review-Url: https://codereview.chromium.org/2342673004
Cr-Commit-Position: refs/heads/master@{#419141}

To start the servicification of //content's time zone monitoring code,
this CL Mojoifies the ViewMsg_TimezoneChange message sent from the browser
to the renderer. To do so, we introduce the TimeZoneMonitor Mojo interface
(living in //device, where the implementation will move to), and change
content::TimeZoneMonitor to implement the interface. Rather than notifying
all RenderProcessHosts on a time zone change, content::TimeZoneMonitor
maintains connections to the clients (RenderThreadImpl in this case)
and notifies them directly on a time zone change. This CL uses the
polling pattern described here:
https://groups.google.com/a/chromium.org/forum/#!topic/mojo-dev/pSNDDN3gpFo
for consistency with the way that the geolocation and battery monitor
interfaces work (in practice, it's unlikely that time zone change updates
would flood the client, of course).

Followup will decouple content::TimeZoneMonitor from //content and move it to //
device.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Review-Url: https://codereview.chromium.org/2304073003
Cr-Commit-Position: refs/heads/master@{#419140}

Added support for script protobuf compiler plugins.
Removed |json_converter| option workaround.

BUG=637292

Review-Url: https://codereview.chromium.org/2343833002
Cr-Commit-Position: refs/heads/master@{#419139}

Because the compositor shares a context with the video resource updater,
the copy target doesn't require a sync token.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2341743004
Cr-Commit-Position: refs/heads/master@{#419138}

- Add the tab strip height factor into the transition equation to make sure the
transition is anchored to the top of the tab.
- Override ntp_search_box_transition_length to make the transition take longer
on tablets.

BUG=625145

Review-Url: https://codereview.chromium.org/2345673002
Cr-Commit-Position: refs/heads/master@{#419137}

Linux and Windows were already reporting audio output device changes as
DEVTYPE_AUDIO_CAPTURE.

This CL basically renames DEVTYPE_AUDIO_CAPTURE to DEVTYPE_AUDIO and
makes the CrOS device monitor to report audio-output device changes in
addition to audio-capture devices.

The only platform that needs further work is Mac, which currently does
not report device changes for output-only devices such as USB
speakers.

BUG=587396

Review-Url: https://codereview.chromium.org/2326623003
Cr-Commit-Position: refs/heads/master@{#419136}

BUG=647219

Review-Url: https://codereview.chromium.org/2345693005
Cr-Commit-Position: refs/heads/master@{#419135}

Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper (patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ )

Reason for revert:
Speculative revert from WebRTC-in-Chrome sheriff since it seems like
this CL breaks content_browser tests on Windows 7.

See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29582/steps/content_browsertests/logs/stdio
for more details.

Original issue's description:
> Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
>
> BUG=509735
>
> Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e
> Cr-Commit-Position: refs/heads/master@{#419008}

TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,lunalu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509735

Review-Url: https://codereview.chromium.org/2347473004
Cr-Commit-Position: refs/heads/master@{#419134}

SVG Image's width and height attributes will use intrinsic size,
if css style size is 'auto'

Spec:
https://svgwg.org/svg2-draft/embedded.html#Placement
https://svgwg.org/svg2-draft/geometry.html#Sizing

BUG=493681

Review-Url: https://codereview.chromium.org/2230963002
Cr-Commit-Position: refs/heads/master@{#419133}

Enable HW encoding on Android. This code has been in the code base for a very long time but it was never enabled. This CL fixes a small bug in it and enables it.

BUG=445320, 638664
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2288103003
Cr-Commit-Position: refs/heads/master@{#419132}

This patch converts "editing/pasteboard/displaced-{,generic-}placeholder.html"
to use w3c test harness to simplify test script, and consolidates into
"editing/inserting/insert_and_placeholder.html" since these test scripts
verifies "insertHTML" command with similar test sample, for improving code
health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2341953005
Cr-Commit-Position: refs/heads/master@{#419131}

To make clear that the SharedBuffer() returned by resourceBuffer() is not
modified outside Resource class.

BUG=

Review-Url: https://codereview.chromium.org/2220543002
Cr-Commit-Position: refs/heads/master@{#419130}

The new API is implemented in this CL: https://codereview.webrtc.org/2337883003/

BUG=webrtc:6329

Review-Url: https://codereview.chromium.org/2337913002
Cr-Commit-Position: refs/heads/master@{#419129}

Existing code will not build when building chromeos_unittests target following the simple chrome build instruction
http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromium-browser
with BOARD=x86-generic, for example.

TEST=chromeos_unittest built successfully following the instruction above, and the test passed.

Review-Url: https://codereview.chromium.org/2344893002
Cr-Commit-Position: refs/heads/master@{#419128}

Tries to make the code a little more readable to help debugging the
associated bug.

For the OK result, BoundNetLog::EndEventWithNetErrorCode() was called
after BoundNetLog::EndEvent() in
WebSocketTransportClientSocketPool::RequestSocket(). Fixed this to call
only EndEvent().

Removed pre-condition checks before ActivateStalledRequest() which are
already performed by its while loop.

Added DCHECK_NE(error, OK) to FlushWithError() to make sure OK is never
received from that path.

Reordered some lines.

R=yhirano@chromium.org,mmenke@chromium.org
BUG=642363

Review-Url: https://codereview.chromium.org/2328453002
Cr-Commit-Position: refs/heads/master@{#419127}

Revert of Roll recipe dependencies (nontrivial). (patchset #1 id:1 of https://codereview.chromium.org/2343013004/ )

Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.

Original issue's description:
> Roll recipe dependencies (nontrivial).
>
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
>
> Please review the expectation changes, and LGTM as normal. The recipe roller
> will *NOT* CQ the change itself, so you must CQ the change manually.
>
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
> (or complain)
>
> build:
>   https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
> depot_tools:
>   https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)
>
> R=tandrii@chromium.org,recipe-roller@chromium.org
> BUG=635641,647446
> NOTRY=True
>
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Committed: https://crrev.com/fd83e754f046fe29f120103423b19bd33717e36d
> Cr-Commit-Position: refs/heads/master@{#419122}

TBR=recipe-roller@chromium.org,recipe-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446

Review-Url: https://codereview.chromium.org/2348863002
Cr-Commit-Position: refs/heads/master@{#419126}

net::WebSocketExtensionParser would accept top-bit-set characters in
tokens. Change it to use net::HttpUtil::IsTokenChar() so it accepts the same
characters as everything else.

Add some tests for top-bit-set characters and a regression test for issue
647156.

Also various minor changes to make the code more Chromey.

BUG=647156

Review-Url: https://codereview.chromium.org/2344873002
Cr-Commit-Position: refs/heads/master@{#419125}

The base::AlignedAlloc expects a alignement multiple of sizeof(void*) :

DCHECK_EQ(alignment % sizeof(void*), 0U);

This fixes this error :

[0826/162544:FATAL:aligned_memory.cc(19)] Check failed: alignment % sizeof(void*) == 0U (1 vs. 0)

BUG=647570
TEST=run video_encode_accelerator_unittest on a non ARM platform

Review-Url: https://codereview.chromium.org/2281043002
Cr-Commit-Position: refs/heads/master@{#419124}

To investigate how frequently unclean shutdown is performed.

Start recording a new UMA Shutdown.ShutdownType.
Update prefs::kShutdownType when Chrome is performing unclean shutdown with SessionEnding().

BUG=644649

Review-Url: https://codereview.chromium.org/2318373003
Cr-Commit-Position: refs/heads/master@{#419123}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)

R=tandrii@chromium.org,recipe-roller@chromium.org
BUG=635641,647446
NOTRY=True

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2343013004
Cr-Commit-Position: refs/heads/master@{#419122}

Now using CacheHitMetrics instead of local enum. Fixup for
https://crrev.com/2289303004.

Review-Url: https://codereview.chromium.org/2347113002
Cr-Commit-Position: refs/heads/master@{#419121}

In preparation for moving metricsPrivate to //extensions, re-generate the
externs file and fix outdated types.

BUG=647397
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346683004
Cr-Commit-Position: refs/heads/master@{#419120}

Authors: Alexander Shalamov, Mikhail Pozdnyakov

This patch introduces implementation of generic sensor interfaces
for Android platform. Support for following sensors is added:
ambient light, gyroscope, accelerometer, linear acceleration and magnetometer.

BUG=606766

Review-Url: https://codereview.chromium.org/2284613002
Cr-Commit-Position: refs/heads/master@{#419119}

xib changes:
ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message.

BUG=646742

Review-Url: https://codereview.chromium.org/2334283004
Cr-Commit-Position: refs/heads/master@{#419118}

This patch converts "editing/pasteboard/5065605.html" to use w3c test harness to
simplify test script, and renames to "copy_and_paste_with_colored_text.html" to
provide a hint what this test script verifies, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2342673003
Cr-Commit-Position: refs/heads/master@{#419117}

This patch converts "editing/pasteboard/3976872.html" to use w3c test harness to
simplify test script, and renames to "paste_plain_text_to_newlines.html" to
provide a hint what this test script verifies, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2344563004
Cr-Commit-Position: refs/heads/master@{#419116}

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)

Review-Url: https://codereview.chromium.org/2345893002
Cr-Commit-Position: refs/heads/master@{#419115}

Tracking how many pages query for VR hardware, how many actually pesent anything to that hardware, and how many use a deprecated function call.

BUG=389343

Review-Url: https://codereview.chromium.org/2345783002
Cr-Commit-Position: refs/heads/master@{#419114}

Review-Url: https://codereview.chromium.org/2327793002
Cr-Commit-Position: refs/heads/master@{#419113}

Update yandex suggest urls. Also add {language} param to suggest url.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2333113003
Cr-Commit-Position: refs/heads/master@{#419112}

Should have no visible effect (since the banner wasn't visible on CrOS).

This reverts commit 192a6f00.
This reverts commit c00f1d07.

BUG=576531

Review-Url: https://codereview.chromium.org/2341113003
Cr-Commit-Position: refs/heads/master@{#419111}

Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size
(which is especially helpful on Android).

R=agrieve@chromium.org,smaier@chromium.org
BUG=619091

[1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkGoY545Q/edit

Review-Url: https://codereview.chromium.org/2152143002
Cr-Commit-Position: refs/heads/master@{#419110}

BUG=590369

Review-Url: https://codereview.chromium.org/2338233003
Cr-Commit-Position: refs/heads/master@{#419109}

https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx
content < 360p.  Unfortunately, it did not have an exception for
encrypted content.

This CL adds an addition "encrypted only" profile that covers all
supported sizes.

BUG=647259, 642948

Review-Url: https://codereview.chromium.org/2348653002
Cr-Commit-Position: refs/heads/master@{#419108}

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG=645699

Review-Url: https://codereview.chromium.org/2337193004
Cr-Commit-Position: refs/heads/master@{#419107}

unittests

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2334563002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#419106}

This icon was incorrectly appearing on the right side of the page,
when it should appear on the left.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342243002
Cr-Commit-Position: refs/heads/master@{#419105}

BUG=643729
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2311473002
Cr-Commit-Position: refs/heads/master@{#419104}

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639

Review-Url: https://codereview.chromium.org/2344473002
Cr-Commit-Position: refs/heads/master@{#419103}